)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8f296e98ec47f45c52eaacb437f21c94130806a8","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Stop using DHCP for o-hm0 interface in devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We know the IP address allocated to the o-hm0 interface by neutron, so"},{"line_number":10,"context_line":"there is no need to use DHCP on this interface. Some distrobutions are"},{"line_number":11,"context_line":"changing DHCP clients and the current code fails on those new releases."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2072593"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e359135d_3d8df609","line":10,"range":{"start_line":10,"start_character":53,"end_line":10,"end_character":66},"updated":"2024-07-10 19:24:14.000000000","message":"I really like this typo :)","commit_id":"952944c1f46bfe1094a1040d179aec6f552e9973"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3d3092c4bcef3dbb07a8801260a72b90cfec1985","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Stop using DHCP for o-hm0 interface in devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We know the IP address allocated to the o-hm0 interface by neutron, so"},{"line_number":10,"context_line":"there is no need to use DHCP on this interface. Some distrobutions are"},{"line_number":11,"context_line":"changing DHCP clients and the current code fails on those new releases."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2072593"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4608c3a1_71a8c81f","line":10,"range":{"start_line":10,"start_character":53,"end_line":10,"end_character":66},"in_reply_to":"e359135d_3d8df609","updated":"2024-07-11 18:23:35.000000000","message":"Done","commit_id":"952944c1f46bfe1094a1040d179aec6f552e9973"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8f296e98ec47f45c52eaacb437f21c94130806a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bd4b9110_1d50732e","updated":"2024-07-10 19:24:14.000000000","message":"I think this is a good idea, I\u0027ve been meaning to do the same downstream for some time","commit_id":"952944c1f46bfe1094a1040d179aec6f552e9973"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"159cacab09719987960aee46c1b28f0db16f4f34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"492d4bb5_a7747f07","updated":"2024-07-12 12:13:18.000000000","message":"LGTM\n\nbut maybe we can also delete those lines: https://opendev.org/openstack/octavia/src/branch/master/devstack/settings#L12-L15","commit_id":"cb118a790671bd41eae79dd3a2764371445834bc"}],"devstack/plugin.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8f296e98ec47f45c52eaacb437f21c94130806a8","unresolved":true,"context_lines":[{"line_number":624,"context_line":""},{"line_number":625,"context_line":"function octavia_start {"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    if  ! ps aux | grep -q [o]-hm0 \u0026\u0026 [ $OCTAVIA_NODE !\u003d \u0027api\u0027 ] ; then"},{"line_number":628,"context_line":"        # This is probably out of scope here? Load it from config"},{"line_number":629,"context_line":"        MGMT_PORT_IP\u003d$(iniget $OCTAVIA_CONF health_manager bind_ip)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7569a184_10fe1389","line":627,"range":{"start_line":627,"start_character":8,"end_line":627,"end_character":34},"updated":"2024-07-10 19:24:14.000000000","message":"this check doesn\u0027t make sense either if you no longer run dhclient?","commit_id":"952944c1f46bfe1094a1040d179aec6f552e9973"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3d3092c4bcef3dbb07a8801260a72b90cfec1985","unresolved":false,"context_lines":[{"line_number":624,"context_line":""},{"line_number":625,"context_line":"function octavia_start {"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    if  ! ps aux | grep -q [o]-hm0 \u0026\u0026 [ $OCTAVIA_NODE !\u003d \u0027api\u0027 ] ; then"},{"line_number":628,"context_line":"        # This is probably out of scope here? Load it from config"},{"line_number":629,"context_line":"        MGMT_PORT_IP\u003d$(iniget $OCTAVIA_CONF health_manager bind_ip)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"f13c8d54_3e2c4384","line":627,"range":{"start_line":627,"start_character":8,"end_line":627,"end_character":34},"in_reply_to":"7569a184_10fe1389","updated":"2024-07-11 18:23:35.000000000","message":"Done","commit_id":"952944c1f46bfe1094a1040d179aec6f552e9973"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8f296e98ec47f45c52eaacb437f21c94130806a8","unresolved":true,"context_lines":[{"line_number":633,"context_line":"            MGMT_SUBNET_MASK\u003d${MGMT_SUBNET_ARRAY[1]}"},{"line_number":634,"context_line":"        else"},{"line_number":635,"context_line":"            MGMT_SUBNET_ARRAY\u003d(${OCTAVIA_MGMT_SUBNET//// })"},{"line_number":636,"context_line":"            MGMT_SUBNET_MASK\u003d${MGMT_SUBNET_ARRAY[1]}"},{"line_number":637,"context_line":"        fi"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        sudo ip addr add $MGMT_PORT_IP/$MGMT_SUBNET_MASK dev o-hm0"}],"source_content_type":"text/x-sh","patch_set":3,"id":"941fe350_f7c7ed2d","line":636,"updated":"2024-07-10 19:24:14.000000000","message":"nit: this line is duplicated and could go after the `fi`","commit_id":"952944c1f46bfe1094a1040d179aec6f552e9973"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3d3092c4bcef3dbb07a8801260a72b90cfec1985","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            MGMT_SUBNET_MASK\u003d${MGMT_SUBNET_ARRAY[1]}"},{"line_number":634,"context_line":"        else"},{"line_number":635,"context_line":"            MGMT_SUBNET_ARRAY\u003d(${OCTAVIA_MGMT_SUBNET//// })"},{"line_number":636,"context_line":"            MGMT_SUBNET_MASK\u003d${MGMT_SUBNET_ARRAY[1]}"},{"line_number":637,"context_line":"        fi"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        sudo ip addr add $MGMT_PORT_IP/$MGMT_SUBNET_MASK dev o-hm0"}],"source_content_type":"text/x-sh","patch_set":3,"id":"25c4a257_7bac0cd7","line":636,"in_reply_to":"941fe350_f7c7ed2d","updated":"2024-07-11 18:23:35.000000000","message":"Done","commit_id":"952944c1f46bfe1094a1040d179aec6f552e9973"}]}