)]}'
{"octavia/api/drivers/amphora_driver/flavor_schema.py":[{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"85ff23522e6fb292bb693e2520ff1691d562c10a","unresolved":true,"context_lines":[{"line_number":57,"context_line":"            \"type\": \"array\","},{"line_number":58,"context_line":"            \"description\": \"Nova compute zones list\""},{"line_number":59,"context_line":"        },"},{"line_number":60,"context_line":"        consts.AVAILABILITY_ZONES: {"},{"line_number":61,"context_line":"            \"type\": \"array\","},{"line_number":62,"context_line":"            \"description\": \"Availability zones list to use for creating\""},{"line_number":63,"context_line":"                           \"distributed Amphorae instances on\""},{"line_number":64,"context_line":"        }"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"92217bd9_e8332cd8","line":64,"range":{"start_line":60,"start_character":8,"end_line":64,"end_character":9},"updated":"2024-07-15 08:23:40.000000000","message":"If this field is used, it seems to me that we should check that the Octavia\u0027s availability zone exists, since we have access to the Octavia database and can do this. Otherwise, the creation of a loadbalancer ends in an ERROR without details.","commit_id":"91f8d33e275678ac3ac5793fe3ef0abfb849c64e"}],"octavia/common/config.py":[{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"85ff23522e6fb292bb693e2520ff1691d562c10a","unresolved":true,"context_lines":[{"line_number":724,"context_line":"                      \u0027provided for each amphora, in the format \"a[A-Z0-9]*\". \u0027"},{"line_number":725,"context_line":"                      \u0027Otherwise, the default name format will be used: \u0027"},{"line_number":726,"context_line":"                      \u0027\"amphora-{UUID}\".\u0027)),"},{"line_number":727,"context_line":"    cfg.StrOpt(\u0027availability_zone\u0027, default\u003dNone,"},{"line_number":728,"context_line":"               help\u003d_(\u0027Availability zone to use for creating Amphorae\u0027)),"},{"line_number":729,"context_line":"    cfg.ListOpt(\u0027availability_zones\u0027, default\u003dNone,"},{"line_number":730,"context_line":"                help\u003d_(\u0027Availability zones list to use for creating\u0027"},{"line_number":731,"context_line":"                       \u0027distributed Amphorae instances on\u0027)),"},{"line_number":732,"context_line":"]"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"cinder_opts \u003d ["},{"line_number":735,"context_line":"    cfg.StrOpt(\u0027service_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a84b8c83_fb4ac2e2","line":732,"range":{"start_line":727,"start_character":0,"end_line":732,"end_character":1},"updated":"2024-07-15 08:23:40.000000000","message":"Why do we need separate fields for 1 and for many AZs instead of using one option with list type and check how many elements inside?","commit_id":"91f8d33e275678ac3ac5793fe3ef0abfb849c64e"}],"octavia/controller/worker/v2/tasks/compute_tasks.py":[{"author":{"_account_id":27256,"name":"Vadim Ponomarev","email":"velizarx@gmail.com","username":"velizarx"},"change_message_id":"85ff23522e6fb292bb693e2520ff1691d562c10a","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        :param zones: list of strings. Octavia availability zone names"},{"line_number":241,"context_line":"        \"\"\""},{"line_number":242,"context_line":"        config \u003d {"},{"line_number":243,"context_line":"            zone: self.az_repo.get_availability_zone_metadata_dict("},{"line_number":244,"context_line":"                db_apis.get_session(), zone)"},{"line_number":245,"context_line":"            for zone in zones}"},{"line_number":246,"context_line":"        return config"}],"source_content_type":"text/x-python","patch_set":1,"id":"52360a5d_6b362133","line":243,"range":{"start_line":243,"start_character":12,"end_line":243,"end_character":67},"updated":"2024-07-15 08:23:40.000000000","message":"This line raises an exception if Octavia\u0027s availability zone does not exist. My suggestion: handle this exception here and wrap it to proper ERROR in the logs.","commit_id":"91f8d33e275678ac3ac5793fe3ef0abfb849c64e"}]}