)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a5c7785988f8951e1006c1f57a5183cd467c9d30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4b39b141_1fae3df3","updated":"2025-02-18 16:20:49.000000000","message":"LGTM","commit_id":"22929f654e6dd4ffb74f44e15514701449c4a664"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"843ecc48705ad00c59b56333ca718a3918041d79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7590558b_0f400fe2","updated":"2025-03-19 08:16:24.000000000","message":"Thanks for this change! 😊","commit_id":"22929f654e6dd4ffb74f44e15514701449c4a664"}],"etc/policy/octavia-advanced-rbac-policy.yaml":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"932435cd6d82b0933c1d4944dca3c6cdb1a005aa","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\"load-balancer:global_observer\": \"role:load-balancer_global_observer\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"\"load-balancer:member_and_owner\": \"role:load-balancer_member and"},{"line_number":48,"context_line":"                                   rule:load-balancer:owner\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# API access methods"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"43728200_c93cf605","line":48,"range":{"start_line":47,"start_character":35,"end_line":48,"end_character":59},"updated":"2025-01-17 09:30:41.000000000","message":"in the old code, member_and_owner was:\n- role:load-balancer_member\n- AND role:member\n- AND project_id:%(project_id)\n\nhttps://github.com/openstack/octavia/blob/master/octavia/policies/base.py#L104-L109\n\n\"role:load-balancer_member and rule:load-balancer:owner\" seems to be the deprecated rule, is it ok?","commit_id":"22929f654e6dd4ffb74f44e15514701449c4a664"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"68426d385217c2c6bcf69e9e280d2da50817c334","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\"load-balancer:global_observer\": \"role:load-balancer_global_observer\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"\"load-balancer:member_and_owner\": \"role:load-balancer_member and"},{"line_number":48,"context_line":"                                   rule:load-balancer:owner\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# API access methods"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"709e02a7_46fd7c3e","line":48,"range":{"start_line":47,"start_character":35,"end_line":48,"end_character":59},"in_reply_to":"43728200_c93cf605","updated":"2025-01-23 01:10:03.000000000","message":"This is the \"Advanced RBAC\" policy override file that reverts the Octavia RBAC back to what it was before SRBAC. That means the role \"load-balancer_member\" was still in use and the rule \"load-balancer:owner\" is defined in this file above on line 32. The role of \"member\" is an SRBAC role, so does not apply here.\nSo I\u0027m not 100% sure what your concern is.","commit_id":"22929f654e6dd4ffb74f44e15514701449c4a664"}],"octavia/policies/advanced_rbac.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"932435cd6d82b0933c1d4944dca3c6cdb1a005aa","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"deprecated_member_and_owner \u003d policy.DeprecatedRule("},{"line_number":64,"context_line":"    name\u003d\u0027load-balancer:member_and_owner\u0027,"},{"line_number":65,"context_line":"    check_str\u003d\u0027role:load-balancer_member and \u0027"},{"line_number":66,"context_line":"              \u0027rule:load-balancer:owner\u0027,"},{"line_number":67,"context_line":"    deprecated_reason\u003dconstants.RBAC_ROLES_DEPRECATED_REASON,"},{"line_number":68,"context_line":"    deprecated_since\u003dversionutils.deprecated.WALLABY,"}],"source_content_type":"text/x-python","patch_set":5,"id":"eee71ab1_15173c8f","line":65,"updated":"2025-01-17 09:30:41.000000000","message":"same remark/question here","commit_id":"22929f654e6dd4ffb74f44e15514701449c4a664"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"68426d385217c2c6bcf69e9e280d2da50817c334","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"deprecated_member_and_owner \u003d policy.DeprecatedRule("},{"line_number":64,"context_line":"    name\u003d\u0027load-balancer:member_and_owner\u0027,"},{"line_number":65,"context_line":"    check_str\u003d\u0027role:load-balancer_member and \u0027"},{"line_number":66,"context_line":"              \u0027rule:load-balancer:owner\u0027,"},{"line_number":67,"context_line":"    deprecated_reason\u003dconstants.RBAC_ROLES_DEPRECATED_REASON,"},{"line_number":68,"context_line":"    deprecated_since\u003dversionutils.deprecated.WALLABY,"}],"source_content_type":"text/x-python","patch_set":5,"id":"01e88b6a_4fec47d5","line":65,"in_reply_to":"eee71ab1_15173c8f","updated":"2025-01-23 01:10:03.000000000","message":"Same here, this is for backward compatibility on upgrade. Here, the Role is deprecated and the rule \"load-balancer:owner\" is defined below on line 88.\n\nBasically, this is deprecated and will be removed at some point. The override file is there to allow Advanced RBAC to function at deployments that want to keep it longer term.","commit_id":"22929f654e6dd4ffb74f44e15514701449c4a664"}]}