)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"1918325139e8bac330f74b00e9d3c869a4b8ce5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4ec82c8_f5fa389d","updated":"2024-10-21 08:26:40.000000000","message":"need to bump taskflow to support this","commit_id":"edb8d14255b8c63d42df0a05fe9dc11f41217530"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3bc80d95202bf3469b43a94c849b171e09f0761f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cbb5ca44_f5d28046","updated":"2025-07-10 10:05:31.000000000","message":"I just tested it.\nIt look like the mask_inputs_keys and mask_outputs_keys params only allow to mask top level attributes in the data structures.\nHowever, in the launchpad, the Tasks that are mentioned (ListenersToErrorOnRevertTask for instance) have no private information at top level, but only in children dict. So the secrets are not hidden:\n\nDo you have any examples where this patch improves/hides private information?\n\n```\noctavia-worker[2483539]:   |__Atom \u0027octavia.controller.worker.v2.tasks.lifecycle_tasks.ListenersToErrorOnRevertTask\u0027 {\u0027intention\u0027: \u0027EXECUTE\u0027, \u0027state\u0027: \u0027SUCCESS\u0027, \u0027requires\u0027: {\u0027listeners\u0027: [{\u0027admin_state_up\u0027: True, \u0027connection_limit\u0027: -1, \u0027default_pool\u0027: None, \u0027default_pool_id\u0027: None, \u0027default_tls_container_data\u0027: {\u0027id\u0027: \u00274d2b07587d62ae182ac38f5471f5a3c447bd76f0\u0027, \u0027primary_cn\u0027: \u0027localhost\u0027, \u0027certificate\u0027: \u0027-----BEGIN CERTIFICATE-----\\nMIIFAjCCAuoCFFHqQsdaElFa50Gnz+4AxsegRoplMA0GCSqGSIb3DQEBCwUAMDox\\nCzAJBgNVBAYTAkZSMQ4wDAYDVQQHDAVQYXJpczEOMAwGA1UECgwFbXlvcmcxCzAJ\\nBgNVBAMMAkNBMB4XDTI1MDYxODExNTYwMloXDTI2MDYxODExNTYwMlowQTELMAkG\\nA1UEBhMCRlIxDjAMBgNVBAcMBVBhcmlzMQ4wDAYDVQQKDAVteW9yZzESMBAGA1UE\\nAwwJbG9jYWxob3N0MIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEAnYyT\\n6NS7S5wRntrSw9eA1ReMSgwqUpw90bMqfhY+ov/hc0f8sgKZXw1p6EW0xsm+v5Es\\nVxU7poJywsQOMNluuZizEbP5+zKa6JN3MobdpwER7RaoWPxmFrFA+JjIf55fbLvD\\nAW4FNlVRtp/1q5PzzA37aIvupUcu2smc0zTUSLLtmMJcavZ31N7PncrnfTF8kMFo\\nQgdQe/6hdflgi6CYfBJ0TMsvhFZLsG59ChDLFUNMMi9YCK3DTBxIMeFcfuppTpcn\\n7mC2YNNK127kuCn2d1sFBnuBv0reBOk55x2ttrXrFxNLK9HHQq+FoCU1K5y4EniM\\n/J7q2on9rUHFfVx+wW9Y5SOoTYD454xaZnZNVQTUWgCgkRY61m08ZQJvLBCFF8zm\\nelU9e2tfgC6oTDJnpNYBxBz6QFFT7vXVhH7dGrl09t4U7Xohr0VwWtuH02dyPgE+\\n8fHjbl7K03vFy6x2fKxwkoGFY80J+Co96PdgrXlRGAaJJndZVWxmplaudAgtQB0/\\nW9dDYVUsJpLk70St2VqjF2XvWv5jK9BxofhC4IxMz7QuWtiNh0+NC/sHUJ356WU3\\nqfwUj04748QMp/FKdbEh5i9l1C+NNVs+pne1S5gpDIjgOEIFQ5s9ssdH1MR6NRol\\n2wf+LidIYqsdKz38P/10/+NUrcjLUv4BJycPjB8CAwEAATANBgkqhkiG9w0BAQsF\\nAAOCAgEAXPsuYL2fgwzwmgGel9zOkMde0n54OegAwrUJ+wraoyp6kkApbIIQ7Xls\\npH9d3zuMY3xWgS4r5KBFbOit0AK2wcCK6tSCfQgnyIQDxvteY33AmALQYrvd6GZ2\\ny2Zd5gGypPTHj8LKvZbEJYTFmYxIpuArpI52Rp/7eelIG2lJMg2TsY+ofHfoDP43\\nxMFckLifSxsONF/Bo0VwJAjq2cYDYC6VflDLwfteuKn3QPLPXtCxQ6L6Sgo2adOJ\\nkbc6lwAGeLeq2t+h3C4O+om+Rt8WLePdD0DoeuYd/iew4p2c6aaZLb16O0ysyQt/\\ntRoE+2FqogGjek3a3ui5yGOl9H0TKvF0DiDFz0PCGjXyeW0ITORDLyuZko+szVT7\\nK1sGJpawe4csofn/4LhjJWRjYKGIKmzmNNE+XxkcjifkWSI8vu1QjVe84C3+TKcb\\n3w++hWD6hnCXdhEwqv/Obm2c47rg35nWWckppWj9RDLajl65baIiYsNT/tLlTPx1\\nI50sAApnQ1qpl5JKTwEYIIdieIOovaqsZHBzAN3J5f02DgkQeodisfzHcQn4nP2T\\ngnc60mJAPw+g93v4B0bSUcZeMKZDcvrkjLKiBNF0glHPzgg6iifVoAkQlYA+jty+\\nUP2WDbB7s7IX2FiwPmHnP1eYhfTnfTQ8ONPVGq7A+dbv5zGjnjM\u003d\\n-----END CERTIFICATE-----\u0027, \u0027private_key\u0027: \u0027-----BEGIN RSA PRIVATE KEY-----\\nMIIJJwIBAAKCAgEAnYyT6NS7S5wRntrSw9eA1ReMSgwqUpw90bMqfhY+ov/hc0f8\\nsgKZXw1p6EW0xsm+v5EsVxU7poJywsQOMNluuZizEbP5+zKa6JN3MobdpwER7Rao\\nWPxmFrFA+JjIf55fbLvDAW4FNlVRtp/1q5PzzA37aIvupUcu2smc0zTUSLLtmMJc\\navZ31N7PncrnfTF8kMFoQgdQe/6hdflgi6CYfBJ0TMsvhFZLsG59ChDLFUNMMi9Y\\nCK3DTBxIMeFcfuppTpcn7mC2YNNK127kuCn2d1sFBnuBv0reBOk55x2ttrXrFxNL\\nK9HHQq+FoCU1K5y4EniM/J7q2on9rUHFfVx+wW9Y5SOoTYD454xaZnZNVQTUWgCg\\nkRY61m08ZQJvLBCFF8zmelU9e2tfgC6oTDJnpNYBxBz6QFFT7vXVhH7dGrl09t4U\\n7Xohr0VwWtuH02dyPgE+8fHjbl7K03vFy6x2fKxwkoGFY80J+Co96PdgrXlRGAaJ\\nJndZVWxmplaudAgtQB0/W9dDYVUsJpLk70St2VqjF2XvWv5jK9BxofhC4IxMz7Qu\\nWtiNh0+NC/sHUJ356WU3qfwUj04748QMp/FKdbEh5i9l1C+NNVs+pne1S5gpDIjg\\nOEIFQ5s9ssdH1MR6NRol2wf+LidIYqsdKz38P/10/+NUrcjLUv4BJycPjB8CAwEA\\nAQKCAgAsFdKro59XPHA3zc6NS4e62RCCBd5v6FVqEOLyjkHvtX8+FWYx34VQMj4w\\n5xR7TaepDjPkmEXtRXJcaqT36VfQ6lgtO3nXXyU2sFD53AA5A5UjDSSFZfchIW9n\\nQMVV5JiaIf4ir8kYl446do81eDyPnFf9vK5GJGGJikHuXcmLIDpY9QYMTjRg5god\\ngtH817SeAuisFUThtXIzw1jPKVyR104g0PhWZRlf4MLvZpyVMhQntNTC9PCBoyZW\\ngtOxleFqwuRDEV/nPyihmN+6Ys+bPWZuFnBLeWUf5a00rTrXNhd3CQiPVe+Wiuvu\\n0IqMzhk53e7Bn6xjA5ru+MkM162F/bdmKM5LnAoiOeOTjz5DbGHndItGTpBSCy0P\\nQMtnIX5G32XQhzyHb6d2jTDV5ImsfAMwVRmRRmvk04nCYFefu+oNQQTZUdov+grD\\niHOAjipm6u9HN5LN71E7ChjGuIDm7vblgtWLE1fAyF6Wk2sRqiUCTGGAp/tEtT7v\\nfKRdDuIa1lvjzqRNAnLMY54YwDtMv8i6KyPuUsXIIiIrEVsH5OJMiFtGyIVd6y26\\n58komzQbf8XoL219KzTkn1xVFNCFHhRVQkI+/QnBJmRO5h75R6OKTnhHi6t5Dtvv\\nvQkBrFUcaWSVcXnnMmhUhvENF7Y1l5xg8Bq1jlBHfWO/LbNCaQKCAQEAzdGhEwyD\\nCaaShTd6iFF5Ct8B0WXzYnXM0PpkmrkQDTrZUf2OoxHH40Y+SHpbSzm4h5S/d8Ob\\n1fLGABMMywz63IKMZNgPFb/w8vREAsXpuGrDBb9L7F/8lUVfgZZEr2q2qugrJaPV\\nDy+KAiEHol0FEzsfzcVdiZXvy/QFOky3ezoWJ+pYY4XRCmWh5n746BH4TXPqEXH+\\n8MUodDbei0XOBdWvO9sTM1xb0LdQUCv3Blho5B3WmzxMzApXHHPnuL1VvpyRJ6oT\\nXIorLi/I4RQdaFFLAQ3Lnc6THd0T+Jm1kp9IhyaY7xmM26m7bhbU4C9o4cqXWclw\\nm5/wokhED5P7NwKCAQEAw/YmR2wFn2WCUd9X6RKOMN8LzgDfsSaEQqfxe/b3nUfh\\nOEqh9cprsw3XrXhBHDt4fLFfvgrL/PGzyIBHYu4zF49K7j8eVOvc9eaPEI3NGU/f\\nzwNnsYuo3tep6brQEhFNaPSlylt/MS0+lljvg9qi1TWosBhYYsgSIjG4b7rzP4xK\\nsb//kiSpMVYqdcRmzXVbiiw9PSzzw69ogaiEy5I23tsAsEdJWefBtUvtv2QCjjSA\\ndQUjU+wxYl8dxOtvW3aLwbmyfwFKPyBaPWYDDqZhvQ3/RjBxWLntqdwu67S4zXXD\\nAI2LdGMaQHrBvnqdPj1y7cQ9dwDcdptWN8z0BMN6WQKCAQAjKtR46sRhG8MhXA9l\\nx3YFM4GeA+uIQVSTyJT0Evb5K7sCVW7P0jPzU4dE3xNGUUCEehgVIKk571eBn7+p\\n2jfrAat3d6tsLfW/rZkJWEPNLQDRtJQGeYgxAT+GZuSpjHRV04G71riK9baBEp+5\\nUGeTl6Chij2nSqVElhdmlMEtHwm2HEaqCq1jN2Zoef2RubBRm6K9BFtpTGbTJKT1\\n6yF+wbpFYfNv7TILAaeJa1m0DdsuTyLiN3Vvz7x+shc/66oA/cOXoWnZgApMxAFw\\n4/z6XBmSvoayGh/tFF9bNPhfazP7U88B273DssbB0sjg3XjwS6t8vfyturBlKi/m\\n8YQVAoIBAGRzut2j3yH9jBdiERN2IpOk0s1QH1sVLnlo095DFF14qlgL0ghIMns/\\n3k6bNW0+gx4QYs7tg/HvCMUAFRf+mQw7tSJ6EpdfrQ4UmUPYHMob6tOYoEAgInnR\\nPdWFoQGSAweJWa9oxcO0uL+jaWxC2HPJJObYI/7HJpyGtk/4Gpd52BRUIrOMvXp/\\n/BYQjs5FmZ4z3VSNxYuLUFwewawFEMGerDSw5kYDCoZgHMiegLza5vqVnq13hz0x\\nGvaF5biSBURSZ9C5HZFMiVWuBGUvHy0ljrUxQflEnjMTnq3PH2ibNFIFPPZ1ktB4\\n3PZCrnZoU5DUptlpBJp8OG80TeZfOkkCggEAWsIVMCw+V6DHvRLgmfftyBujM1lf\\n8AWUaOH6qwSfLDwDUgusM6tIslt66xjoyzeBH0Tv8GKmc3Skx7HvoGTNz/Vp9VXg\\n9Q13ao0waop8/vlOo22rbHLTjk2lmLYD9df36ItLxAEcYFPrmO2gr6AZ1a9VChvc\\nfOhdXShCPMmcZ1ZPL21Xg2k1Xu9Fnk6r9JUWBJ3qgZEbUm6zcnMB3nQ4oXWUvbaw\\nySxusSnYrix47UWl5riQdJh3d/a8cIFJSHnz3a9HlaOaNBMZ8j7Tm5P4wK0Q4lCP\\nJBBSIk0d9UenVpKpyC8KpZPy55wMhwowA7oenj/AvmJcAQMsR8n3QZILPQ\u003d\u003d\\n-----END\n```","commit_id":"e9ff900dcc476410b36e041d77c0e5088bb5b54b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"7b06fb2804a81d662f5a5360e1bdcb596b5ed9af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"27c441bc_0072eb11","in_reply_to":"cbb5ca44_f5d28046","updated":"2025-08-29 07:52:02.000000000","message":"Thanks Gregory! I will revisit this and look into it again when I have some time","commit_id":"e9ff900dcc476410b36e041d77c0e5088bb5b54b"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"860f5c5f2095fcadfdb21c57068ebd8b20c9df7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f3813cf7_08741aa9","updated":"2025-09-18 07:58:34.000000000","message":"@tobias.urdin@binero.com is it still WIP?","commit_id":"99d9ce7ef6a4157a38853e249c73ceb5b15d2766"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"c7f3eb2e2aece4419fc190901a976ea6e9dab90e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8a31da7f_28d08791","updated":"2025-09-08 21:35:52.000000000","message":"updated commit message to new dependency patch in taskflow that works on the issues mentioned by Gregory","commit_id":"99d9ce7ef6a4157a38853e249c73ceb5b15d2766"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d08142ed5071ff42a838ea3473fbc9dd5aa95068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e28e98bc_6d82f36e","in_reply_to":"f3813cf7_08741aa9","updated":"2025-09-18 09:16:24.000000000","message":"No but will have a long standing dependency on the taskflow patch, and until that change (if merged) is released","commit_id":"99d9ce7ef6a4157a38853e249c73ceb5b15d2766"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"204b9ab7e4afbe7baac73d8f33630bd7c466eeb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"703b911b_7016b37e","updated":"2026-06-30 07:25:37.000000000","message":"After testing it, I still see private data when taskflow displays the tree of Atoms\n\n```\noctavia-worker[250334]: WARNING octavia.common.base_taskflow [-] Task \u0027octavia.controller.worker.v2.tasks.amphora_driver_tasks.ListenersUpdate\u0027 (25e2d350-6866-4031-a69c-d9ca82a7a184) transitioned into state \u0027FAILURE\u0027 from state \u0027RUNNING\u0027\noctavia-worker[250334]: 2 predecessors (most recent first):\noctavia-worker[250334]:   Atom \u0027octavia.controller.worker.v2.tasks.lifecycle_tasks.ListenersToErrorOnRevertTask\u0027 {\u0027intention\u0027: \u0027EXECUTE\u0027, \u0027state\u0027: \u0027SUCCESS\u0027, \u0027requires\u0027: {\u0027listeners\u0027: [{\u0027admin_state_up\u0027: True, \u0027connection_limit\u0027: -1, \u0027default_pool\u0027: N\none, \u0027default_pool_id\u0027: None, \u0027default_tls_container_data\u0027: {\u0027id\u0027: \u00275eb2070ac864f6f714259f01182263051c3476b2\u0027, \u0027primary_cn\u0027: \u0027localhost\u0027, \u0027certificate\u0027: \u0027-----BEGIN CERTIFICATE-----\\nMIIESzCCAjOgAwIBAgIUWjbEzTkBDPYreQkqNsrIFJm38rMwDQYJKoZIhvcNAQEL\\nBQAwOjELMAkGA1UEBhMCRlI\nxDjAMBgNVBAcMBVBhcmlzMQ4wDAYDVQQKDAVteW9y\\nZzELMAkGA1UEAwwCQ0EwHhcNMjYwMzA0MTA1MzUwWhcNMjcwMzA0MTA1MzUwWjBB\\nMQswCQYDVQQGEwJGUjEOMAwGA1UEBwwFUGFyaXMxDjAMBgNVBAoMBW15b3JnMRIw\\nEAYDVQQDDAlsb2NhbGhvc3QwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIB\\nAQCYNGIcx28XcKMKt/uSm/JorQx9WK8\nAk1YnRaclINmDwdhCCYhSPahI/WWiIlr1\\n019Z6RGioYjZrZMgPLvGFz5lMlxbuYUbd/aGYmmQWBabSkANxJf0tg2kxl7AzaKO\\nGWBPe+inBeJAOmxlGOEMeOpKmveIPTIn2QVpD4hT+vi43DmWV/BfsauELXbtHaH4\\n5gEOil6quTzrKKV5SLPxh88TubB7Yhk/TPvCp59WRUAv05I93cWOH+PCAuH5mrr/\\nNc36R01m6YfUyYNgQt2aa/gfGBMDqy9twYIvdj+zF5RMaVjWTNNJxOSaGC0EWhn6\\npUZ9T8XS8nBF0cSntp1zlheHAgMBAAGjQjBAMB0GA1UdDgQWBBQIi6+EKcbwdTYi\\nCg4uiziOwGF4vjAfBgNVHSMEGDAWgBRr7kMpUKHgZGkuMA2EBM7P8nJE0jANBgkq\\nhkiG9w0BAQsFAAOCAgEAel+ZnWLcW1qQnqAFGavcVK+mbBZlZpTB21UbftFsrDfV\\nqRBf1mXdhSV5WUlaAKV7omHf4/W1E8NWlJ/iePSNsnyEcoQ\nb0YWhywVB5s8GxmyN\\nocwTX1SK3AG9h3iXnFQ3+XYdsbJRwSbeZcAxqXNR6sJOO/0uCoxZKElmANUEPNL/\\n3CIGR8Zki2h4RHzwIOFR5uW9GA1Fxt0f7sKBUkE2qGRF3Qtrprl27Hrem67ggnQJ\\nZWCQ/qxlSCvz3TWhsyKqmJuqT4qX7aguWYMn06wsqcm0h9ACgV/o+ZENerwXqJq/\\nY1WAzehlNUmYGHSwbqjOyQy1y75QZB7jaD11E2veIaW0P+LHGuJwLC3\nfwNPzam0J\\nF7dz7KBObMxNcrGWtgrt0GJxTacFbSyYLS2o9FSBLnWcIHzfJHQzHn2/5U+w62qt\\n3YuclVlqRMES2TDvg3ljMTFPAyiWImSVaN79M9lrjgF8TdmarnODon3D99x2CLzU\\ng6BsWRc1JIsBhxZeuCfhaOODMyIfKHDlF1Y9aYjXGiOuchcAqRLwuLQ8cBmOdJjP\\n9puu4tJwCXZWCqHDHZjp81paMmzUu8L8pOf7g12nOUDONf/NBCl4KZcF0Yn8sfD7\\ntqnmlenMYGdaQ+SIlVKoEHgqOSvSDvlui64g0FnSzOR+F+TM0z+LDgk/0d75vm0\u003d\\n-----END CERTIFICATE-----\u0027, \u0027private_key\u0027: \u0027-----BEGIN RSA PRIVATE KEY-----\\nMIIEogIBAAKCAQEAmDRiHMdvF3CjCrf7kpvyaK0MfVivAJNWJ0WnJSDZg8HYQgmI\\nUj2oSP1loiJa9dNfWekRoqGI2a2TIDy7xhc+ZTJcW7mFG3f2hmJpkFgWm0pA...\n```\n\nHowever the private attributes are hidden in some other log lines\n\n```\nWARNING taskflow.conductors.backends.impl_executor [-] Job execution failed (consumption proceeding): RedisJob: get_create_listener_flow-7ddfbc84-5c6b-4bb7-9c21-71ed53aa0461 (priority\u003dJobPriority.NORMAL, uuid\u003df482a20e-460b-4531-ba98-e3e7ae2542df, details\u003d{\u0027store\u0027: {\u0027listeners\u0027: [{\u0027admin_state_up\u0027: True, \u0027connection_limit\u0027: -1, \u0027default_pool\u0027: None, \u0027default_pool_id\u0027: None, \u0027default_tls_container_data\u0027: {\u0027id\u0027: \u00275eb2070ac864f6f714259f01182263051c3476b2\u0027, \u0027primary_cn\u0027: \u0027localhost\u0027, \u0027certificate\u0027: \u0027***\u0027, \u0027private_key\u0027: \u0027***\u0027, \u0027passphrase\u0027: None, \u0027intermediates\u0027: [\u0027***\u0027]}, \u0027default_tls_container_ref\u0027: \u0027http://192.168.1.24/key-manager/v1/secrets/fb3c9138-9ab4-491f-aea6-ad406e2ca898\u0027, \u0027description\u0027: None, \u0027insert_headers\u0027: {}, \u0027l7policies\u0027: [], \u0027listener_id\u0027: \u0027bed4412e-ad46-4f49-9b18-cdf93b25b38b\u0027, \u0027loadbalancer_id\u0027: \u0027eb525052-b282-4643-8e4c-9084f2d93423\u0027\n```","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"24abfe724f199f01e9620ee53e67f8872e867488","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8b8d053f_50ebbd63","updated":"2026-06-30 13:54:26.000000000","message":"can you please also include a releasenote?","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"62074d079547e1b6623cf02e580da5f545f86665","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"acc88426_a923f6d4","in_reply_to":"703b911b_7016b37e","updated":"2026-06-30 08:31:36.000000000","message":"I don\u0027t have any good idea here, can you verify that you have taskflow \u003e\u003d6.2.0 that the code from dependency is present? Real pain trying to get this solved it seems","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d73e27b1d2106da2838b5b28c7deee2499427523","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ba7a4dd4_49439094","in_reply_to":"acc88426_a923f6d4","updated":"2026-06-30 08:54:41.000000000","message":"I think I use taskflow master in my env, but I\u0027ll take another look","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ad674d9f25ced9af9976d8a57c029c3b9bc05ee8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"247695af_76039510","updated":"2026-07-01 06:10:12.000000000","message":"LGTM","commit_id":"e84556244afa374a0dec04ea7d00ee719783155e"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b25fe9a5cb80a7649c40836d2d38f9d513e4d4c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1eaab4e1_e0d89fb8","updated":"2026-06-30 14:01:13.000000000","message":"Thanks Gregory! I\u0027ve updated accordingly.","commit_id":"e84556244afa374a0dec04ea7d00ee719783155e"}],"octavia/common/base_taskflow.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9a6146d573060c840c409f6aa9f9db4584c5bced","unresolved":true,"context_lines":[{"line_number":52,"context_line":"LOG.logger.addFilter(retryMaskFilter)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def _details_filter_keys():"},{"line_number":56,"context_line":"    return (\u0027certificate\u0027, \u0027private_key\u0027, \u0027passphrase\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bd023204_f136c411","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":24},"updated":"2024-10-23 11:10:35.000000000","message":"This is used by a different module, so this should not be a private function.\n\nProbably we can just define a constant like\n\n```\nFILTER_KEYS \u003d (\u0027certificate\u0027, \u0027private_key\u0027, \u0027passphrase\u0027)\n```","commit_id":"edb8d14255b8c63d42df0a05fe9dc11f41217530"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ed82c33e5e54f25e095d79c926e1779a00d2e303","unresolved":false,"context_lines":[{"line_number":52,"context_line":"LOG.logger.addFilter(retryMaskFilter)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def _details_filter_keys():"},{"line_number":56,"context_line":"    return (\u0027certificate\u0027, \u0027private_key\u0027, \u0027passphrase\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4f6d34b8_ba0a7696","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":24},"in_reply_to":"bd023204_f136c411","updated":"2024-10-24 07:40:16.000000000","message":"I agree, thanks!","commit_id":"edb8d14255b8c63d42df0a05fe9dc11f41217530"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"33f95e6fbb86b7f6578208742c1e6678d16ed395","unresolved":true,"context_lines":[{"line_number":52,"context_line":"LOG.logger.addFilter(retryMaskFilter)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"FILTER_KEYS \u003d (\u0027certificate\u0027, \u0027private_key\u0027, \u0027passphrase\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _details_filter(obj):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf63fe63_883b5db1","line":55,"updated":"2025-03-03 12:20:31.000000000","message":"Hello, I also met in logs information about \"server_pem\", could you also include this key to filter as well?","commit_id":"03243f95b8a9cfe73ba715a253a33475bf08b5dd"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a47cce86f045559f6bf2e3fd992d4530ca34ec1b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"LOG.logger.addFilter(retryMaskFilter)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"FILTER_KEYS \u003d (\u0027certificate\u0027, \u0027private_key\u0027, \u0027passphrase\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _details_filter(obj):"}],"source_content_type":"text/x-python","patch_set":4,"id":"18117756_8c667313","line":55,"in_reply_to":"3181ce68_d70f4650","updated":"2025-05-22 07:54:09.000000000","message":"Done","commit_id":"03243f95b8a9cfe73ba715a253a33475bf08b5dd"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9ea0f8b591a29e49fc80e2495d099af66ca9cf12","unresolved":true,"context_lines":[{"line_number":52,"context_line":"LOG.logger.addFilter(retryMaskFilter)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"FILTER_KEYS \u003d (\u0027certificate\u0027, \u0027private_key\u0027, \u0027passphrase\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _details_filter(obj):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3181ce68_d70f4650","line":55,"in_reply_to":"bf63fe63_883b5db1","updated":"2025-04-04 09:14:44.000000000","message":"I will make sure to `server_pem` in the future before this is merged, thanks!","commit_id":"03243f95b8a9cfe73ba715a253a33475bf08b5dd"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6fefdbd7b2750eeefc6200c25b45ae934e269e96","unresolved":true,"context_lines":[{"line_number":52,"context_line":"LOG.logger.addFilter(retryMaskFilter)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"FILTER_KEYS \u003d (\u0027certificate\u0027, \u0027private_key\u0027, \u0027passphrase\u0027, \u0027server_pem\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _details_filter(obj):"}],"source_content_type":"text/x-python","patch_set":7,"id":"c44421eb_ec8a41c1","line":55,"updated":"2026-06-30 13:48:41.000000000","message":"in my env, \u0027intermediates\u0027 also include some certificate-related data, do you think we should add it there?","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b25fe9a5cb80a7649c40836d2d38f9d513e4d4c3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"LOG.logger.addFilter(retryMaskFilter)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"FILTER_KEYS \u003d (\u0027certificate\u0027, \u0027private_key\u0027, \u0027passphrase\u0027, \u0027server_pem\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _details_filter(obj):"}],"source_content_type":"text/x-python","patch_set":7,"id":"99a168c6_0a865712","line":55,"in_reply_to":"c44421eb_ec8a41c1","updated":"2026-06-30 14:01:13.000000000","message":"Done","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6fefdbd7b2750eeefc6200c25b45ae934e269e96","unresolved":true,"context_lines":[{"line_number":140,"context_line":"    def _listeners_from_job(self, job, engine):"},{"line_number":141,"context_line":"        listeners \u003d super()._listeners_from_job("},{"line_number":142,"context_line":"            job, engine)"},{"line_number":143,"context_line":"        listeners.append(logging.DynamicLoggingListener(engine, log\u003dLOG))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        return listeners"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"314592a9_22e7ff2c","line":143,"range":{"start_line":143,"start_character":33,"end_line":143,"end_character":55},"updated":"2026-06-30 13:48:41.000000000","message":"I found the issue, I use jobboard and the mask_*_keys parameters need to be passed to this DynamicLoggingListener.\n\nCan you add them?","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b25fe9a5cb80a7649c40836d2d38f9d513e4d4c3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def _listeners_from_job(self, job, engine):"},{"line_number":141,"context_line":"        listeners \u003d super()._listeners_from_job("},{"line_number":142,"context_line":"            job, engine)"},{"line_number":143,"context_line":"        listeners.append(logging.DynamicLoggingListener(engine, log\u003dLOG))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        return listeners"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fd1abc96_5beb90f5","line":143,"range":{"start_line":143,"start_character":33,"end_line":143,"end_character":55},"in_reply_to":"314592a9_22e7ff2c","updated":"2026-06-30 14:01:13.000000000","message":"Done","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"}],"requirements.txt":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"da334295f00a94092bbe27cef8daab8bd463f3fd","unresolved":true,"context_lines":[{"line_number":37,"context_line":"python-cinderclient\u003e\u003d3.3.0 # Apache-2.0"},{"line_number":38,"context_line":"WSME\u003e\u003d0.8.0 # MIT"},{"line_number":39,"context_line":"Jinja2\u003e\u003d2.10 # BSD License (3 clause)"},{"line_number":40,"context_line":"taskflow!\u003d6.0.0,\u003e\u003d6.2.0 # Apache-2.0"},{"line_number":41,"context_line":"castellan\u003e\u003d0.16.0 # Apache-2.0"},{"line_number":42,"context_line":"tenacity\u003e\u003d5.0.4  # Apache-2.0"},{"line_number":43,"context_line":"distro\u003e\u003d1.2.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":7,"id":"1ed68e1c_f4b6dc48","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":23},"updated":"2026-06-30 07:09:14.000000000","message":"\"taskflow\u003e\u003d6.2.0\" should be enough, right?","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b25fe9a5cb80a7649c40836d2d38f9d513e4d4c3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"python-cinderclient\u003e\u003d3.3.0 # Apache-2.0"},{"line_number":38,"context_line":"WSME\u003e\u003d0.8.0 # MIT"},{"line_number":39,"context_line":"Jinja2\u003e\u003d2.10 # BSD License (3 clause)"},{"line_number":40,"context_line":"taskflow!\u003d6.0.0,\u003e\u003d6.2.0 # Apache-2.0"},{"line_number":41,"context_line":"castellan\u003e\u003d0.16.0 # Apache-2.0"},{"line_number":42,"context_line":"tenacity\u003e\u003d5.0.4  # Apache-2.0"},{"line_number":43,"context_line":"distro\u003e\u003d1.2.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":7,"id":"fb7fe57d_99802bfd","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":23},"in_reply_to":"1ed68e1c_f4b6dc48","updated":"2026-06-30 14:01:13.000000000","message":"Done","commit_id":"26374ee6602ffc8875f994a8aee6c591aef9851c"}]}