)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"d21b65947d52f80fbb661d9fc6e67030541bea4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1adb2477_22d85e9a","updated":"2024-10-28 16:48:13.000000000","message":"I added release note","commit_id":"72fd38e90ea461c5c9cd1b1b82cc729c3f25697e"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"1348ca6c0341f6ede825dc15da9302a92f07f385","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8ae3a31e_77eb647b","updated":"2024-11-02 07:46:45.000000000","message":"recheck","commit_id":"7c08b63a37e7ef990909d656683d098971228731"}],"octavia/controller/worker/v2/tasks/network_tasks.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"62af1442fa4b6e2d34719df7e34f1d9f79f0f85a","unresolved":true,"context_lines":[{"line_number":559,"context_line":"            if db_lb:"},{"line_number":560,"context_line":"                LOG.error("},{"line_number":561,"context_line":"                    \u0027Failed to unplug AAP port. Resources may still be in \u0027"},{"line_number":562,"context_line":"                    \u0027use for VIP: %s due to error: %s\u0027, db_lb.vip, str(e)"},{"line_number":563,"context_line":"                )"},{"line_number":564,"context_line":"            else:"},{"line_number":565,"context_line":"                LOG.error("}],"source_content_type":"text/x-python","patch_set":1,"id":"15a86e28_62bf3aef","line":562,"range":{"start_line":562,"start_character":67,"end_line":562,"end_character":73},"updated":"2024-10-28 10:12:56.000000000","message":"nit, strictly speaking this `str()` is redundant, because `%s` will do the same.","commit_id":"f0e296f611dfa12da0b72be07fe19d92813a36eb"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"0659295c479e35dd205dfc600a3e6d42f4011256","unresolved":true,"context_lines":[{"line_number":559,"context_line":"            if db_lb:"},{"line_number":560,"context_line":"                LOG.error("},{"line_number":561,"context_line":"                    \u0027Failed to unplug AAP port. Resources may still be in \u0027"},{"line_number":562,"context_line":"                    \u0027use for VIP: %s due to error: %s\u0027, db_lb.vip, str(e)"},{"line_number":563,"context_line":"                )"},{"line_number":564,"context_line":"            else:"},{"line_number":565,"context_line":"                LOG.error("}],"source_content_type":"text/x-python","patch_set":1,"id":"b4a6c628_a623cc3d","line":562,"range":{"start_line":562,"start_character":67,"end_line":562,"end_character":73},"in_reply_to":"15a86e28_62bf3aef","updated":"2024-10-28 16:37:35.000000000","message":"ok, I just decided to leave it without changes from old log message.\nAlso it\u0027s similar with other logs messages in the file.\nIf it\u0027s strong requirement, please let me know and I will change it.","commit_id":"f0e296f611dfa12da0b72be07fe19d92813a36eb"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ba320cb63a56dd97c34f45e4b85e0b93d3a07d56","unresolved":true,"context_lines":[{"line_number":559,"context_line":"            if db_lb:"},{"line_number":560,"context_line":"                LOG.error("},{"line_number":561,"context_line":"                    \u0027Failed to unplug AAP port. Resources may still be in \u0027"},{"line_number":562,"context_line":"                    \u0027use for VIP: %s due to error: %s\u0027, db_lb.vip, str(e)"},{"line_number":563,"context_line":"                )"},{"line_number":564,"context_line":"            else:"},{"line_number":565,"context_line":"                LOG.error("}],"source_content_type":"text/x-python","patch_set":2,"id":"5c3e31fd_1dce45f6","line":562,"range":{"start_line":562,"start_character":56,"end_line":562,"end_character":65},"updated":"2024-10-29 07:10:38.000000000","message":"I\u0027m wondering what it prints when an error occurs, vip is a db object, do we really want to display it?","commit_id":"72fd38e90ea461c5c9cd1b1b82cc729c3f25697e"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"358a8ce0112bc273800b4555a4b3d87e4fefd8c6","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            if db_lb:"},{"line_number":560,"context_line":"                LOG.error("},{"line_number":561,"context_line":"                    \u0027Failed to unplug AAP port. Resources may still be in \u0027"},{"line_number":562,"context_line":"                    \u0027use for VIP: %s due to error: %s\u0027, db_lb.vip, str(e)"},{"line_number":563,"context_line":"                )"},{"line_number":564,"context_line":"            else:"},{"line_number":565,"context_line":"                LOG.error("}],"source_content_type":"text/x-python","patch_set":2,"id":"0162bc87_6e883088","line":562,"range":{"start_line":562,"start_character":56,"end_line":562,"end_character":65},"in_reply_to":"5c3e31fd_1dce45f6","updated":"2024-10-29 08:12:45.000000000","message":"discussed in chat and updated","commit_id":"72fd38e90ea461c5c9cd1b1b82cc729c3f25697e"}],"releasenotes/notes/handle_empty_db_lb_on_plug_vip_revert-5c24af124498b246.yaml":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"077540dcd4f7f2e130d7afffbc65df27e4bede85","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix error on revert PlugVIPAmphora task, when db_lb is not defined"},{"line_number":5,"context_line":"    and get_subnet raises NotFound error. It could happen when Amphora"},{"line_number":6,"context_line":"    creation failed by timeout and before it VIP network was removed."},{"line_number":7,"context_line":"    As result revert failed with exception."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"57a99c0e_66dd19ae","line":5,"range":{"start_line":4,"start_character":45,"end_line":5,"end_character":40},"updated":"2024-11-05 07:57:41.000000000","message":"IMHO release notes are intended for the end users/admins, we don\u0027t need to go into too much details. but it\u0027s fine","commit_id":"7c08b63a37e7ef990909d656683d098971228731"}]}
