)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"752cd038c6fe973372ba0a45e036f551b15926c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c003189_68f2d9a2","updated":"2025-01-15 03:43:43.000000000","message":"I don\u0027t think we need the extra deprecation warning setting. Can you explain why it is needed?","commit_id":"d88a26f8f459d35f0e138cd5139fb90acb795490"},{"author":{"_account_id":38360,"name":"Zachary Mark Raines","display_name":"Zachary Raines","email":"zachary.raines@canonical.com","username":"raineszm","status":"Sustaining Engineer @ Canonical"},"change_message_id":"876f748782c7e1a15301ecef8de294d269c2cbce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9bba55c5_10718894","updated":"2025-12-04 16:51:58.000000000","message":"Tested functional tests locally and everything works as expected.","commit_id":"36418a80354d1d24bf65ce73cf922d373026a675"},{"author":{"_account_id":38360,"name":"Zachary Mark Raines","display_name":"Zachary Raines","email":"zachary.raines@canonical.com","username":"raineszm","status":"Sustaining Engineer @ Canonical"},"change_message_id":"9f8771fe27986843bc0415242383e5bf4587b953","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c41542e0_9c9a15a9","updated":"2026-02-23 16:52:57.000000000","message":"Nit on commit message but otherwise looks good.","commit_id":"386a35dae8a7275be48907a89c07b6adb2a37742"},{"author":{"_account_id":38360,"name":"Zachary Mark Raines","display_name":"Zachary Raines","email":"zachary.raines@canonical.com","username":"raineszm","status":"Sustaining Engineer @ Canonical"},"change_message_id":"887e6a0e84d49c5482194397e91a2115d66dd15d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"190ef416_cb6d5b76","updated":"2026-02-23 21:32:43.000000000","message":"Looks good and reads well to me.","commit_id":"03303a91fd983b01b36b11f32f0ccfd4c1f1db09"}],"tox.ini":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"752cd038c6fe973372ba0a45e036f551b15926c8","unresolved":true,"context_lines":[{"line_number":34,"context_line":"setenv \u003d"},{"line_number":35,"context_line":"    {[testenv]setenv}"},{"line_number":36,"context_line":"    PYTHON\u003dcoverage run --source octavia --parallel-mode"},{"line_number":37,"context_line":"    PYTHONWARNINGS\u003dalways::DeprecationWarning"},{"line_number":38,"context_line":"commands \u003d"},{"line_number":39,"context_line":"    coverage erase"},{"line_number":40,"context_line":"    sh -c \u0027OS_TEST_PATH\u003d{toxinidir}/octavia/tests/unit stestr run {posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":1,"id":"4e80f026_bd48b5f0","line":37,"updated":"2025-01-15 03:43:43.000000000","message":"I am not sure this is needed here. It\u0027s defined above on line 9.","commit_id":"d88a26f8f459d35f0e138cd5139fb90acb795490"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bf45ab74585c91bffa232c4f954f94bd603c05b6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"setenv \u003d"},{"line_number":35,"context_line":"    {[testenv]setenv}"},{"line_number":36,"context_line":"    PYTHON\u003dcoverage run --source octavia --parallel-mode"},{"line_number":37,"context_line":"    PYTHONWARNINGS\u003dalways::DeprecationWarning"},{"line_number":38,"context_line":"commands \u003d"},{"line_number":39,"context_line":"    coverage erase"},{"line_number":40,"context_line":"    sh -c \u0027OS_TEST_PATH\u003d{toxinidir}/octavia/tests/unit stestr run {posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":1,"id":"29ba0f66_629ec518","line":37,"in_reply_to":"4e80f026_bd48b5f0","updated":"2025-01-15 07:16:35.000000000","message":"I\u0027m afraid I was looking at the wrong section... Dropped it.","commit_id":"d88a26f8f459d35f0e138cd5139fb90acb795490"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4a99ff227ff4a91dd9a043e68abf5eca6c14ee55","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[testenv:py3]"},{"line_number":49,"context_line":"setenv \u003d OS_TEST_PATH\u003d{toxinidir}/octavia/tests/unit"},{"line_number":50,"context_line":"         PYTHONWARNINGS\u003dalways::DeprecationWarning"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[testenv:functional]"},{"line_number":53,"context_line":"# This will use whatever \u0027basepython\u0027 is set to, so the name is ambiguous."}],"source_content_type":"text/x-properties","patch_set":5,"id":"a6ef9d13_6653fc88","side":"PARENT","line":50,"updated":"2026-02-12 20:41:05.000000000","message":"I am wondering if the commit message meant to say \"PYTHONWARNINGS\" is already the default under python3 or if this variable should be carried forward.","commit_id":"7221e6f682c94302ab58d95645bccb956c23daf1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"49dcde99e143ba905b05a31abe74ae0c1a119a88","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[testenv:py3]"},{"line_number":49,"context_line":"setenv \u003d OS_TEST_PATH\u003d{toxinidir}/octavia/tests/unit"},{"line_number":50,"context_line":"         PYTHONWARNINGS\u003dalways::DeprecationWarning"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[testenv:functional]"},{"line_number":53,"context_line":"# This will use whatever \u0027basepython\u0027 is set to, so the name is ambiguous."}],"source_content_type":"text/x-properties","patch_set":5,"id":"f4f5555a_f4a14bb4","side":"PARENT","line":50,"in_reply_to":"a6ef9d13_6653fc88","updated":"2026-02-13 06:38:56.000000000","message":"No what I meant is that OS_TEST_PATH doesn\u0027t have to be set explciitly in py3 env because this is the default value baked in .stestr.conf .\nIf we remove this redundant/unnecessary override we need only PYTHONWARNINGS which is already set in the base testenv, so we don\u0027t need explicit setenv and can omit it (which means py3 env uses the setenv defined in [testenv] section.)","commit_id":"7221e6f682c94302ab58d95645bccb956c23daf1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"545cb57db49724a90d89ba74b3dae712f11db990","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[testenv:py3]"},{"line_number":49,"context_line":"setenv \u003d OS_TEST_PATH\u003d{toxinidir}/octavia/tests/unit"},{"line_number":50,"context_line":"         PYTHONWARNINGS\u003dalways::DeprecationWarning"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[testenv:functional]"},{"line_number":53,"context_line":"# This will use whatever \u0027basepython\u0027 is set to, so the name is ambiguous."}],"source_content_type":"text/x-properties","patch_set":5,"id":"b73620ed_a586cfe9","side":"PARENT","line":50,"in_reply_to":"d5e09a6d_c207f1e3","updated":"2026-02-23 16:59:02.000000000","message":"Done","commit_id":"7221e6f682c94302ab58d95645bccb956c23daf1"},{"author":{"_account_id":38360,"name":"Zachary Mark Raines","display_name":"Zachary Raines","email":"zachary.raines@canonical.com","username":"raineszm","status":"Sustaining Engineer @ Canonical"},"change_message_id":"9f8771fe27986843bc0415242383e5bf4587b953","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[testenv:py3]"},{"line_number":49,"context_line":"setenv \u003d OS_TEST_PATH\u003d{toxinidir}/octavia/tests/unit"},{"line_number":50,"context_line":"         PYTHONWARNINGS\u003dalways::DeprecationWarning"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[testenv:functional]"},{"line_number":53,"context_line":"# This will use whatever \u0027basepython\u0027 is set to, so the name is ambiguous."}],"source_content_type":"text/x-properties","patch_set":5,"id":"d5e09a6d_c207f1e3","side":"PARENT","line":50,"in_reply_to":"f4f5555a_f4a14bb4","updated":"2026-02-23 16:52:57.000000000","message":"It\u0027s probably good then to also mention briefly why setenv can be dropped completely from the py3 testenv (it\u0027s redundant with the settings in the base testenv).","commit_id":"7221e6f682c94302ab58d95645bccb956c23daf1"}]}