)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bc89c436dcb2020dfadc2a0ba6619afe2461355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8cba6553_685dc48c","updated":"2025-05-10 03:15:16.000000000","message":"LGTM\nGlad to get rid of mod_wsgi, it is a bad path","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"}],"devstack/plugin.sh":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac226c70d5305ea3062180f1cf805301f9e4beff","unresolved":true,"context_lines":[{"line_number":138,"context_line":"    upload_image file://${OCTAVIA_AMP_IMAGE_FILE} $TOKEN"},{"line_number":139,"context_line":"}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"function _configure_octavia_apache_uwsgi {"},{"line_number":142,"context_line":"    write_uwsgi_config \"$OCTAVIA_UWSGI_CONF\" \"$OCTAVIA_UWSGI_APP\" \"/$OCTAVIA_SERVICE_TYPE\" \"\" \"octavia-wsgi\""},{"line_number":143,"context_line":"}"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"41f06355_c2736a21","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":40},"updated":"2025-06-03 15:42:55.000000000","message":"(This can be done separately) but maybe we can replace apache_(u)wsgi by uwsgi because apache is not explicitly involved.","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"885540080499f8f0311d4c58a49b5cdc3f3a1fbc","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    upload_image file://${OCTAVIA_AMP_IMAGE_FILE} $TOKEN"},{"line_number":139,"context_line":"}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"function _configure_octavia_apache_uwsgi {"},{"line_number":142,"context_line":"    write_uwsgi_config \"$OCTAVIA_UWSGI_CONF\" \"$OCTAVIA_UWSGI_APP\" \"/$OCTAVIA_SERVICE_TYPE\" \"\" \"octavia-wsgi\""},{"line_number":143,"context_line":"}"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"661809bb_bd25f318","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":40},"in_reply_to":"41f06355_c2736a21","updated":"2025-08-22 06:39:53.000000000","message":"will be addressed by https://review.opendev.org/c/openstack/octavia/+/951732","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac226c70d5305ea3062180f1cf805301f9e4beff","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"function _cleanup_octavia_apache_wsgi {"},{"line_number":146,"context_line":"    remove_uwsgi_config \"$OCTAVIA_UWSGI_CONF\" \"$OCTAVIA_UWSGI_APP\""},{"line_number":147,"context_line":"    restart_apache_server"},{"line_number":148,"context_line":"}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"function _start_octavia_apache_wsgi {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"6948ed9c_be54036f","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":25},"updated":"2025-06-03 15:42:55.000000000","message":"I know that this is not a new issue but remove_uwsgi_config does restart apache when needed so this is redundant.","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"885540080499f8f0311d4c58a49b5cdc3f3a1fbc","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"function _cleanup_octavia_apache_wsgi {"},{"line_number":146,"context_line":"    remove_uwsgi_config \"$OCTAVIA_UWSGI_CONF\" \"$OCTAVIA_UWSGI_APP\""},{"line_number":147,"context_line":"    restart_apache_server"},{"line_number":148,"context_line":"}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"function _start_octavia_apache_wsgi {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"c824dd91_3c0e73c8","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":25},"in_reply_to":"68cce432_fb156343","updated":"2025-08-22 06:39:53.000000000","message":"I\u0027ve proposed a follow-up https://review.opendev.org/c/openstack/octavia/+/951732 to address this.","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"49462024c81032e564b8faa3174c2502d9f49416","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"function _cleanup_octavia_apache_wsgi {"},{"line_number":146,"context_line":"    remove_uwsgi_config \"$OCTAVIA_UWSGI_CONF\" \"$OCTAVIA_UWSGI_APP\""},{"line_number":147,"context_line":"    restart_apache_server"},{"line_number":148,"context_line":"}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"function _start_octavia_apache_wsgi {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"68cce432_fb156343","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":25},"in_reply_to":"6948ed9c_be54036f","updated":"2025-08-22 05:53:36.000000000","message":"Yeah, seems a followup would be fine.","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac226c70d5305ea3062180f1cf805301f9e4beff","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"function _start_octavia_apache_wsgi {"},{"line_number":151,"context_line":"    run_process o-api \"$(which uwsgi) --ini $OCTAVIA_UWSGI_CONF\""},{"line_number":152,"context_line":"    enable_apache_site octavia-wsgi"},{"line_number":153,"context_line":"    restart_apache_server"},{"line_number":154,"context_line":"}"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"function _stop_octavia_apache_wsgi {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5bb688a7_da19b553","line":153,"range":{"start_line":152,"start_character":4,"end_line":153,"end_character":25},"updated":"2025-06-03 15:42:55.000000000","message":"I wonder if we really have to manipulate vhost during start/stop. Maybe we can drop these ?","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"49462024c81032e564b8faa3174c2502d9f49416","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"function _start_octavia_apache_wsgi {"},{"line_number":151,"context_line":"    run_process o-api \"$(which uwsgi) --ini $OCTAVIA_UWSGI_CONF\""},{"line_number":152,"context_line":"    enable_apache_site octavia-wsgi"},{"line_number":153,"context_line":"    restart_apache_server"},{"line_number":154,"context_line":"}"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"function _stop_octavia_apache_wsgi {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"b10a4c94_72b8dcbd","line":153,"range":{"start_line":152,"start_character":4,"end_line":153,"end_character":25},"in_reply_to":"5bb688a7_da19b553","updated":"2025-08-22 05:53:36.000000000","message":"Also probably followup material.","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"885540080499f8f0311d4c58a49b5cdc3f3a1fbc","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"function _start_octavia_apache_wsgi {"},{"line_number":151,"context_line":"    run_process o-api \"$(which uwsgi) --ini $OCTAVIA_UWSGI_CONF\""},{"line_number":152,"context_line":"    enable_apache_site octavia-wsgi"},{"line_number":153,"context_line":"    restart_apache_server"},{"line_number":154,"context_line":"}"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"function _stop_octavia_apache_wsgi {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7b55b224_b3351a01","line":153,"range":{"start_line":152,"start_character":4,"end_line":153,"end_character":25},"in_reply_to":"b10a4c94_72b8dcbd","updated":"2025-08-22 06:39:53.000000000","message":"ditto","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3bc89c436dcb2020dfadc2a0ba6619afe2461355","unresolved":true,"context_lines":[{"line_number":380,"context_line":"        iniset $OCTAVIA_CONF oslo_policy policy_file $OCTAVIA_CONF_DIR/policy.yaml"},{"line_number":381,"context_line":"    fi"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    if [[ \"$OCTAVIA_USE_MOD_WSGI\" \u003d\u003d \"True\" ]]; then"},{"line_number":384,"context_line":"        _configure_octavia_apache_uwsgi"},{"line_number":385,"context_line":"    fi"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"05692987_bdfab373","line":383,"updated":"2025-05-10 03:15:16.000000000","message":"This concerned me initially, but I see it is removed in the followup patch.","commit_id":"6911bbf5a2127a69c6e89a7db443cbe402f7fd85"}]}