)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"1ff59daad8b5dc4412228d85a29760b074e39b70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb59ae50_1ec00641","updated":"2025-06-18 20:37:36.000000000","message":"recheck","commit_id":"c9f50acb6afc62cd5031222863377d1920f9f1d2"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"91cc1d9ca4ce4aa1b5acbf455825ee764e9ed06a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ebdd704a_c7a8b3e2","updated":"2026-06-11 09:12:51.000000000","message":"recheck","commit_id":"4f6b50f2ff45dcefcc9a70f926b2f1751ea4be16"},{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"b7ffa540be07bb73c97375b94a5a7f3a2932b02c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d0c9d810_2fac5da8","updated":"2026-08-31 09:27:42.000000000","message":"Looks good, just one general question below","commit_id":"dd1a2d1dcd252c58f4b6f0c11c5bb189e800b2fe"}],"octavia/api/v2/controllers/load_balancer.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6b49d9bb7f4a16226a4b6c82f56e474336f99fb2","unresolved":true,"context_lines":[{"line_number":509,"context_line":"            # If no availability_zone specified, check Nova config default"},{"line_number":510,"context_line":"            if (\u0027availability_zone\u0027 not in lb_dict or"},{"line_number":511,"context_line":"                    lb_dict[\u0027availability_zone\u0027] is None):"},{"line_number":512,"context_line":"                default_az \u003d CONF.nova.availability_zone"},{"line_number":513,"context_line":"                if default_az:"},{"line_number":514,"context_line":"                    # Check if the default zone exists in Octavia\u0027s AZ table"},{"line_number":515,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"73894814_06337bd7","line":512,"range":{"start_line":512,"start_character":16,"end_line":512,"end_character":56},"updated":"2025-06-19 18:17:40.000000000","message":"something is weird here,\nCONF.nova.availability_zone is a compute AZ which is passed to Nova when creating an amphora VM.\nbut line 516 you use the compute AZ name to get the Octavia AZ object. Despite having the same name (AZ) those objects are not related. There\u0027s a consistency issue there.\n\nIMHO if you really want to do it, we should add a new availability_zone setting in another section of the config which is not \u0027nova\u0027.","commit_id":"c9f50acb6afc62cd5031222863377d1920f9f1d2"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"0e77d03102502a1c1b04f6953c0e3bfd6c4c7540","unresolved":false,"context_lines":[{"line_number":509,"context_line":"            # If no availability_zone specified, check Nova config default"},{"line_number":510,"context_line":"            if (\u0027availability_zone\u0027 not in lb_dict or"},{"line_number":511,"context_line":"                    lb_dict[\u0027availability_zone\u0027] is None):"},{"line_number":512,"context_line":"                default_az \u003d CONF.nova.availability_zone"},{"line_number":513,"context_line":"                if default_az:"},{"line_number":514,"context_line":"                    # Check if the default zone exists in Octavia\u0027s AZ table"},{"line_number":515,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e29a84d_655b42d3","line":512,"range":{"start_line":512,"start_character":16,"end_line":512,"end_character":56},"in_reply_to":"73894814_06337bd7","updated":"2026-07-07 22:14:34.000000000","message":"Done","commit_id":"c9f50acb6afc62cd5031222863377d1920f9f1d2"},{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"b7ffa540be07bb73c97375b94a5a7f3a2932b02c","unresolved":true,"context_lines":[{"line_number":545,"context_line":"                        if az_obj and az_obj.enabled:"},{"line_number":546,"context_line":"                            lb_dict[\u0027availability_zone\u0027] \u003d default_az"},{"line_number":547,"context_line":"                    except sa_exception.NoResultFound:"},{"line_number":548,"context_line":"                        pass"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"            az_dict \u003d self._validate_and_return_az_dict(lock_session, driver,"},{"line_number":551,"context_line":"                                                        lb_dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a9cb961d_e440f449","line":548,"updated":"2026-08-31 09:27:42.000000000","message":"Just to confirm my understanding, setting the default AZ to an AZ that doesn\u0027t exist will result in the AZ still being None? This is probably fine, but I just want to be sure. Will there be a nice visible exception in the logs to show the operator that something has gone wrong?","commit_id":"dd1a2d1dcd252c58f4b6f0c11c5bb189e800b2fe"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"649868efd458d1b670e8f1dc58fa7fb9df75c517","unresolved":true,"context_lines":[{"line_number":545,"context_line":"                        if az_obj and az_obj.enabled:"},{"line_number":546,"context_line":"                            lb_dict[\u0027availability_zone\u0027] \u003d default_az"},{"line_number":547,"context_line":"                    except sa_exception.NoResultFound:"},{"line_number":548,"context_line":"                        pass"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"            az_dict \u003d self._validate_and_return_az_dict(lock_session, driver,"},{"line_number":551,"context_line":"                                                        lb_dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"079de724_8a115a65","line":548,"in_reply_to":"a9cb961d_e440f449","updated":"2026-09-01 15:04:17.000000000","message":"Correct, if the configured default AZ doesn\u0027t exist (or exists but is disabled), the availability_zone field stays None. Currently there\u0027s no log message, so the misconfiguration is silent. I\u0027ll add a LOG.warning() for both the missing and disabled cases so operators get a visible signal.","commit_id":"dd1a2d1dcd252c58f4b6f0c11c5bb189e800b2fe"}]}