)]}'
{"octavia/controller/worker/v2/tasks/database_tasks.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"078f8c1633ad73340849bc332cc25dbe02b17c28","unresolved":true,"context_lines":[{"line_number":1100,"context_line":"                session, id\u003dloadbalancer[constants.LOADBALANCER_ID])"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"            # Check if any amphora is in ERROR state"},{"line_number":1103,"context_line":"            for amphora in db_lb.amphorae:"},{"line_number":1104,"context_line":"                if (amphora.status \u003d\u003d constants.ERROR and"},{"line_number":1105,"context_line":"                        amphora.status !\u003d constants.DELETED):"},{"line_number":1106,"context_line":"                    LOG.warning(\"Not marking load balancer %s ACTIVE because \""}],"source_content_type":"text/x-python","patch_set":1,"id":"b80c4a86_578e6106","line":1103,"range":{"start_line":1103,"start_character":12,"end_line":1103,"end_character":42},"updated":"2025-08-27 13:56:45.000000000","message":"moving the LB to ERROR should be done after marking subobject (or it the children resources are PENDING_*)","commit_id":"569c60136926a3a7c35926e5f6af91392917f158"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"916b212170e8a627622fddcfdd359d770a60fced","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"                session, id\u003dloadbalancer[constants.LOADBALANCER_ID])"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"            # Check if any amphora is in ERROR state"},{"line_number":1103,"context_line":"            for amphora in db_lb.amphorae:"},{"line_number":1104,"context_line":"                if (amphora.status \u003d\u003d constants.ERROR and"},{"line_number":1105,"context_line":"                        amphora.status !\u003d constants.DELETED):"},{"line_number":1106,"context_line":"                    LOG.warning(\"Not marking load balancer %s ACTIVE because \""}],"source_content_type":"text/x-python","patch_set":1,"id":"05283a9f_29933123","line":1103,"range":{"start_line":1103,"start_character":12,"end_line":1103,"end_character":42},"in_reply_to":"b80c4a86_578e6106","updated":"2025-08-27 15:04:33.000000000","message":"Done","commit_id":"569c60136926a3a7c35926e5f6af91392917f158"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"078f8c1633ad73340849bc332cc25dbe02b17c28","unresolved":true,"context_lines":[{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"            # Check if any amphora is in ERROR state"},{"line_number":1103,"context_line":"            for amphora in db_lb.amphorae:"},{"line_number":1104,"context_line":"                if (amphora.status \u003d\u003d constants.ERROR and"},{"line_number":1105,"context_line":"                        amphora.status !\u003d constants.DELETED):"},{"line_number":1106,"context_line":"                    LOG.warning(\"Not marking load balancer %s ACTIVE because \""},{"line_number":1107,"context_line":"                                \"amphora %s is in ERROR state\","},{"line_number":1108,"context_line":"                                loadbalancer[constants.LOADBALANCER_ID],"}],"source_content_type":"text/x-python","patch_set":1,"id":"141d05e7_e7af35fa","line":1105,"range":{"start_line":1104,"start_character":20,"end_line":1105,"end_character":59},"updated":"2025-08-27 13:56:45.000000000","message":"could be simplified","commit_id":"569c60136926a3a7c35926e5f6af91392917f158"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"916b212170e8a627622fddcfdd359d770a60fced","unresolved":false,"context_lines":[{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"            # Check if any amphora is in ERROR state"},{"line_number":1103,"context_line":"            for amphora in db_lb.amphorae:"},{"line_number":1104,"context_line":"                if (amphora.status \u003d\u003d constants.ERROR and"},{"line_number":1105,"context_line":"                        amphora.status !\u003d constants.DELETED):"},{"line_number":1106,"context_line":"                    LOG.warning(\"Not marking load balancer %s ACTIVE because \""},{"line_number":1107,"context_line":"                                \"amphora %s is in ERROR state\","},{"line_number":1108,"context_line":"                                loadbalancer[constants.LOADBALANCER_ID],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3baedb16_9807037c","line":1105,"range":{"start_line":1104,"start_character":20,"end_line":1105,"end_character":59},"in_reply_to":"141d05e7_e7af35fa","updated":"2025-08-27 15:04:33.000000000","message":"Done","commit_id":"569c60136926a3a7c35926e5f6af91392917f158"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ef3aaced36db35463c8604ac1ec04742b779741b","unresolved":true,"context_lines":[{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"            # Check if any amphora is in ERROR state"},{"line_number":1103,"context_line":"            has_error_amphora \u003d False"},{"line_number":1104,"context_line":"            for amphora in db_lb.amphorae:"},{"line_number":1105,"context_line":"                if amphora.status \u003d\u003d constants.ERROR:"},{"line_number":1106,"context_line":"                    LOG.warning(\"Not marking load balancer %s ACTIVE because \""},{"line_number":1107,"context_line":"                                \"amphora %s is in ERROR state\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9bb585c5_15a3e16d","line":1104,"updated":"2025-09-04 17:09:46.000000000","message":"I am not sure I agree with this.\nWhy would we tie the load balancer object provisioning status to the amphora?\nWouldn\u0027t a load balancer be provisioning status ACTIVE if at least one amphora is healthy?","commit_id":"f70d5b343a924ef91d4260c0cba2c797e1b27356"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a6fcde965dcb672e3d72274dde895500b0914f2e","unresolved":true,"context_lines":[{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"            # Check if any amphora is in ERROR state"},{"line_number":1103,"context_line":"            has_error_amphora \u003d False"},{"line_number":1104,"context_line":"            for amphora in db_lb.amphorae:"},{"line_number":1105,"context_line":"                if amphora.status \u003d\u003d constants.ERROR:"},{"line_number":1106,"context_line":"                    LOG.warning(\"Not marking load balancer %s ACTIVE because \""},{"line_number":1107,"context_line":"                                \"amphora %s is in ERROR state\","}],"source_content_type":"text/x-python","patch_set":2,"id":"bc28502a_e3ba1343","line":1104,"in_reply_to":"9bb585c5_15a3e16d","updated":"2025-09-08 06:50:20.000000000","message":"I think that making it ACTIVE gives a false impression that the LB is healthy, especially since the status of the amphorae is not visible from the user.\n\nin case of an ACTIVE LB with an amphora in ERROR:\n- VRRP may not work\n- the next API call may trigger a new error (for instance \"Updating a listening\" will attempt to update an unreachable amphora)\n\nIMHO in this situation the only action that should be accepted is a failover or the deletion of the LB.","commit_id":"f70d5b343a924ef91d4260c0cba2c797e1b27356"}]}