)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"01400590e19a3a8a727784d82478c77f02b77af7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e01c01c6_e6013e49","updated":"2025-09-18 06:29:46.000000000","message":"FYI I already +2ed a similar patch https://review.opendev.org/c/openstack/octavia/+/949630","commit_id":"dba56982ee6b995aa21785b0acc3bd61445586e3"}],"octavia/amphorae/backends/agent/api_server/templates/amphora-netns.systemd.j2":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"01400590e19a3a8a727784d82478c77f02b77af7","unresolved":true,"context_lines":[{"line_number":27,"context_line":"ExecStart\u003d-/sbin/ip netns exec {{ amphora_nsname }} sysctl -w net.ipv4.vs.expire_nodest_conn\u003d1"},{"line_number":28,"context_line":"ExecStart\u003d-/sbin/ip netns exec {{ amphora_nsname }} sysctl -w net.ipv4.vs.expire_quiescent_template\u003d1"},{"line_number":29,"context_line":"# Assign the interfaces into the namespace with the appropriate name"},{"line_number":30,"context_line":"ExecStart\u003d-/bin/sh -c \u0027while read -r hw_address desired_name; do current_name\u003d$(awk -v a\u003d\"$hw_address\" \\\u0027{if (a\u003d\u003d$1) {f\u003dFILENAME; gsub(\"(.*/net/|/address)\", \"\", f); print f}}\\\u0027 /sys/class/net/*/address); /sbin/ip link set \"$current_name\" netns {{ amphora_nsname }} name \"$desired_name\"; done \u003c {{ amphora_plugged_interfaces }}\u0027"},{"line_number":31,"context_line":"# Bring up all of the namespace interfaces"},{"line_number":32,"context_line":"ExecStart\u003d-/sbin/ip netns exec {{ amphora_nsname }} amphora-interface up all"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0c2c309c_95f14ab0","line":30,"updated":"2025-09-18 06:29:46.000000000","message":"maybe it needs to be discussed with the wider team, but this line has puzzled me for a long time.\nthe \"before\" and \"after\" are not really readable.\n\nwhat about creating a good old file instead of using a one liner? could be python or bash. IMHO it\u0027s not maintainable in its current state.","commit_id":"dba56982ee6b995aa21785b0acc3bd61445586e3"}]}