)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"330fc24940e89d4d7282ae75a40c54ef07848540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9abc4b94_21045b10","updated":"2026-04-01 12:47:33.000000000","message":"LGTM, tested in Ubuntu 24.04 with assistance from Claude Code (https://www.anthropic.com)","commit_id":"ef4a8df69abf10f7242059d872746182187c2736"}],"octavia/common/jinja/templates/user_data_config_drive.template":[{"author":{"_account_id":38360,"name":"Zachary Mark Raines","display_name":"Zachary Raines","email":"zachary.raines@canonical.com","username":"raineszm","status":"Sustaining Engineer @ Canonical"},"change_message_id":"9173a9c34be1ff7c3ab8b571169f22fc37239599","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{# restart agent now that configurations are in place #}"},{"line_number":35,"context_line":"runcmd:"},{"line_number":36,"context_line":"-   systemctl reload rsyslog"},{"line_number":37,"context_line":"{% if user_data -%}"},{"line_number":38,"context_line":"-   service amphora-agent restart"},{"line_number":39,"context_line":"{%- endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"91d99078_edd03217","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"updated":"2026-03-30 19:50:34.000000000","message":"In my testing on Ubuntu noble and resolute this fails with `Failed to reload rsyslog.service: Job type reload is not applicable for unit rsyslog.service.`\n\nIf there are cases where reload is supported we could try `reload-or-restart`?","commit_id":"26daa26e094427984995a56dd9dae5fe86d52108"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"28d3f2b5f15cfb2e1bba811dfa23cd2f40b3e3b9","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{# restart agent now that configurations are in place #}"},{"line_number":35,"context_line":"runcmd:"},{"line_number":36,"context_line":"-   systemctl reload rsyslog"},{"line_number":37,"context_line":"{% if user_data -%}"},{"line_number":38,"context_line":"-   service amphora-agent restart"},{"line_number":39,"context_line":"{%- endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"b58c10d0_366ed61b","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"91d99078_edd03217","updated":"2026-03-31 07:41:49.000000000","message":"good catch\nI\u0027ve never seen the issue (the launchpad bug) on ubuntu, so it\u0027s probably fine to use reload-or-restart here","commit_id":"26daa26e094427984995a56dd9dae5fe86d52108"},{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"04220d6caab1d933daeb7df88581890d43208caf","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{# restart agent now that configurations are in place #}"},{"line_number":35,"context_line":"runcmd:"},{"line_number":36,"context_line":"-   systemctl reload rsyslog"},{"line_number":37,"context_line":"{% if user_data -%}"},{"line_number":38,"context_line":"-   service amphora-agent restart"},{"line_number":39,"context_line":"{%- endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"b79a6cf0_bbeb406e","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"9fe427c9_804fde30","updated":"2026-04-08 08:33:50.000000000","message":"This is perhaps a dumb question, but would it not make more sense to move syslog.service from Wants to Requires in the systemd template for the amphora agent? Doing so would cause the agent to restart when syslog restarts and thus prevent a race condition if syslog restarts?","commit_id":"26daa26e094427984995a56dd9dae5fe86d52108"},{"author":{"_account_id":38360,"name":"Zachary Mark Raines","display_name":"Zachary Raines","email":"zachary.raines@canonical.com","username":"raineszm","status":"Sustaining Engineer @ Canonical"},"change_message_id":"f8da17e7b468a2742c29d988dfe4910558c60a6d","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{# restart agent now that configurations are in place #}"},{"line_number":35,"context_line":"runcmd:"},{"line_number":36,"context_line":"-   systemctl reload rsyslog"},{"line_number":37,"context_line":"{% if user_data -%}"},{"line_number":38,"context_line":"-   service amphora-agent restart"},{"line_number":39,"context_line":"{%- endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bac79098_4038181e","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"b58c10d0_366ed61b","updated":"2026-04-07 20:59:29.000000000","message":"Is there a situation where rsyslog actually supports reload? I checked upstream and it looks like ExecReload was in the upstream service file, but later removed (in 2011) when the behavior of rsyslog on SIGHUP was changed https://github.com/rsyslog/rsyslog/commit/fd26a42bdc04eaf497cafd9ef806a54f3de1a7e9.","commit_id":"26daa26e094427984995a56dd9dae5fe86d52108"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ee2108d8b057a0e02d2044b8437bb741069fef43","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{# restart agent now that configurations are in place #}"},{"line_number":35,"context_line":"runcmd:"},{"line_number":36,"context_line":"-   systemctl reload rsyslog"},{"line_number":37,"context_line":"{% if user_data -%}"},{"line_number":38,"context_line":"-   service amphora-agent restart"},{"line_number":39,"context_line":"{%- endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"e9a0a413_517424f4","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"b79a6cf0_bbeb406e","updated":"2026-04-08 08:39:39.000000000","message":"IMHO to prevent race conditions, we need to:\n- (re)start rsyslog after cloud-init uploads the new rsyslog config files\n- start amphora-agent after rsyslog restarts (amphora-agent should not be automatically started by systemd)","commit_id":"26daa26e094427984995a56dd9dae5fe86d52108"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"923cc29ea51734ae3f21673b10c3140918b260d1","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{# restart agent now that configurations are in place #}"},{"line_number":35,"context_line":"runcmd:"},{"line_number":36,"context_line":"-   systemctl reload rsyslog"},{"line_number":37,"context_line":"{% if user_data -%}"},{"line_number":38,"context_line":"-   service amphora-agent restart"},{"line_number":39,"context_line":"{%- endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9fe427c9_804fde30","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"bac79098_4038181e","updated":"2026-04-08 06:21:18.000000000","message":"looks like ExecReload is present in the systemd files in RPM-based distros\nbut it looks like it doesn\u0027t reload the config files, it only rotates the log files.","commit_id":"26daa26e094427984995a56dd9dae5fe86d52108"}]}