)]}'
{"id":"openstack%2Foctavia~988052","triplet_id":"openstack%2Foctavia~master~I6ac099aa38695fd837d74ffa619d131700c239a2","project":"openstack/octavia","branch":"master","attention_set":{"38562":{"account":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"last_update":"2026-08-17 14:52:17.000000000","reason":"\u003cGERRIT_ACCOUNT_29244\u003e replied on the change","reason_account":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}}},"removed_from_attention_set":{"29244":{"account":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"last_update":"2026-08-17 14:52:17.000000000","reason":"\u003cGERRIT_ACCOUNT_29244\u003e replied on the change","reason_account":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}}},"hashtags":[],"change_id":"I6ac099aa38695fd837d74ffa619d131700c239a2","subject":"Fix duplicate NICs and KeyError in CalculateAmphoraDelta","status":"NEW","created":"2026-05-11 08:38:45.000000000","updated":"2026-08-17 17:03:53.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"3633754a629360f3b9a513cb0b918b98f0d82686","_number":988052,"virtual_id_number":988052,"owner":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-08-17 17:03:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"all":[{"value":-1,"date":"2026-08-17 15:30:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-11 11:20:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-05-13 08:05:31.000000000","updated_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"reviewer":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"state":"REVIEWER"}],"messages":[{"id":"c73964bd6daa9d0b08865b1c48f24a8088334e8e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-11 08:38:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9a6f7a00e35f3e16f0ea17ceea2723e9a68b8c93","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-11 08:41:06.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d081142d0c71ccd612c66563cf52fb9e2df7dbff","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-11 08:44:00.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"166c033963f173dd2ff7f8dd2a98b9df0454ca1e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-11 11:20:54.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1b5ac4fa3cf24954a261c809a19808ce\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4de3e10c70814e67a9c53af10a88fe10 : SUCCESS in 6m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c0b37412bd254a12a8cdb3c813bc58b6 : SUCCESS in 2m 49s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/39d2c5af65174117a2d019077d97e65c : SUCCESS in 4m 36s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/fb83c270505d4e64a425b0e3ff8594b2 : SUCCESS in 5m 06s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/37bea1c74d4e41208660a0356fac9e89 : SUCCESS in 9m 17s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d02b77f11b074a31b67a6b69e2407278 : SUCCESS in 13m 48s\n- octavia-tox-py313-tips https://zuul.opendev.org/t/openstack/build/cd78de93b15f4444b6c48a5b49f9ad7d : SUCCESS in 4m 36s\n- octavia-tox-functional-py313-tips https://zuul.opendev.org/t/openstack/build/bb4aa259530447ebbc52a8cb2edeb5e1 : SUCCESS in 5m 59s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/b18f8c1d3b5c41c6b73c5a4327f600aa : SUCCESS in 4m 53s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/69848353b1f6415797d56356b5fba6b4 : SUCCESS in 5m 59s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/a12e38dafd874cc58ab2ac3b25263f58 : SUCCESS in 3m 42s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/a1a9ab2fc01847cfb2df9285d87e9179 : SUCCESS in 28m 28s\n- octavia-v2-dsvm-scenario-traffic-ops https://zuul.opendev.org/t/openstack/build/f541a0bc2b9f4383975e919ff59ab350 : SUCCESS in 1h 29m 53s\n- octavia-v2-dsvm-scenario-non-traffic-ops https://zuul.opendev.org/t/openstack/build/f59b059f08294c9997e982dd607091ea : SUCCESS in 1h 04m 02s\n- octavia-v2-dsvm-scenario-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/b9f348df5c2a410f9a89b68d669da3df : SUCCESS in 1h 36m 31s\n- octavia-v2-dsvm-scenario-non-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/499b0ed4b61f42c98f63933e9b49882e : SUCCESS in 1h 04m 52s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/7a0f511173004f499f248377b8546b23 : SUCCESS in 35m 23s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/b632cd19515745188219f187ebfdc83c : SUCCESS in 46m 09s\n- octavia-grenade-skip-level https://zuul.opendev.org/t/openstack/build/dff481b368a549ffbb927bf9b23c838f : SUCCESS in 43m 59s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/65aab84c074749a38f0122cd1498e22d : SUCCESS in 34m 29s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/bc183ee942b24d1eb7e0e0fe058e127b : SUCCESS in 34m 22s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/2262849cfcca41a8b44ef4232673877e : FAILURE in 2h 35m 28s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/11d61f82ab534273b38938ce545e119d : SUCCESS in 1h 43m 39s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-traffic-ops https://zuul.opendev.org/t/openstack/build/7b924378256c463bbf7e30f2ccc5bf8b : SUCCESS in 1h 40m 02s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-non-traffic-ops https://zuul.opendev.org/t/openstack/build/52f2232ac7204412adb220c7e89c7c14 : SUCCESS in 1h 16m 20s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"a2915fa231b82ae631d0bc451c14fad6c22a87d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-12 11:18:55.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":4},{"id":"cbc4c7aeba63fbdf1abedbb00c1aff23b87381f5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-12 13:37:01.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/07b24f5de4ca4db0be2dfbe3ac56d0a1\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0b78d7d16dd044ec8ec1d43163e5cfce : SUCCESS in 8m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/aa25536c20b0445a8e02b123791b1f67 : SUCCESS in 4m 37s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/f2d42b9c3b264ed19617625275fff012 : SUCCESS in 2m 57s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/6974bbc0cf0a470282bd2ab7c6bfd5e6 : SUCCESS in 4m 39s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/a60b7771f3904bb69eca86cb74d9ab00 : SUCCESS in 7m 17s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/66a2b760efca406990f2eec1b83c7c40 : SUCCESS in 12m 25s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3ec77abccfc7481182874d49d1344482 : SUCCESS in 5m 17s\n- octavia-tox-py313-tips https://zuul.opendev.org/t/openstack/build/09522c573fa74b6cb545aeb34953c286 : SUCCESS in 5m 00s\n- octavia-tox-functional-py313-tips https://zuul.opendev.org/t/openstack/build/748dbcb49c6e4e76b3b26ec8462253f6 : SUCCESS in 6m 49s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/9fc79203c5b9440e90c618403bc8a81d : SUCCESS in 3m 15s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/ca0d6f6586264cccab09aa034f318f9f : SUCCESS in 5m 28s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/8e0b38212b364e2d8ccc6194930e6dcc : SUCCESS in 4m 51s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/803820088d654022a3d9ad0802a2a137 : SUCCESS in 35m 23s\n- octavia-v2-dsvm-scenario-traffic-ops https://zuul.opendev.org/t/openstack/build/330d69ea516145eb9152d463420df7ff : SUCCESS in 1h 30m 12s\n- octavia-v2-dsvm-scenario-non-traffic-ops https://zuul.opendev.org/t/openstack/build/ffb23c22729d4a91a07a0d638a2aeffe : SUCCESS in 1h 03m 22s\n- octavia-v2-dsvm-scenario-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/00d579c5d4354104b83b6383e2468a35 : SUCCESS in 1h 36m 36s\n- octavia-v2-dsvm-scenario-non-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/fc53e5b31674420b95c7a813bf34eb7c : SUCCESS in 1h 09m 16s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/803bc65d23104980aff2c8f03c5197e9 : SUCCESS in 34m 18s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/5e7badb85265408db368c32ced4c450b : SUCCESS in 51m 22s\n- octavia-grenade-skip-level https://zuul.opendev.org/t/openstack/build/03640cfca58241509552122056f2b958 : SUCCESS in 43m 00s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/b4ce52338b454b3ea3fab85920f9f360 : SUCCESS in 31m 31s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/c28db0fd3aa74fbdb59d8e7979c8ea2f : SUCCESS in 40m 50s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/5f81610ee7c047438fc4528bdd944e8d : SUCCESS in 2h 12m 20s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/b269408b18094da2a3af2f39068789bd : SUCCESS in 1h 33m 55s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-traffic-ops https://zuul.opendev.org/t/openstack/build/d95cd15a07c8468483bb8156152b38bc : SUCCESS in 1h 25m 03s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-non-traffic-ops https://zuul.opendev.org/t/openstack/build/f716306561fe44ae84c3107c9007c8c9 : SUCCESS in 1h 14m 47s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"89395b384fd6a172635471063396f25dbbc13836","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2026-05-13 08:05:31.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"52c527b9d96337726e1451296eaba6401f069b10","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-14 14:28:25.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":5},{"id":"cb5eb3a5d79c2e9166619d37d02396867e861551","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-14 14:29:16.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"c6b71418f88e62cf40b200b2a317d6b1430c51c9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-14 17:30:40.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/fa5e6d9ba7c74bb4b48fb4e949c8647a\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a3bf523156fb48df80e5aad98d99698a : SUCCESS in 10m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/07369983a9f64658b3de5a8ec0073d13 : SUCCESS in 4m 42s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/009baa819fe24316b655cd5e28dee48a : SUCCESS in 7m 00s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/42e7db3128824e0d8d4c1cb9083667ff : SUCCESS in 6m 15s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/04467853f67a4ebab8d7de93a5edf31a : SUCCESS in 6m 42s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3774677bccf842d881c480b145563254 : SUCCESS in 14m 05s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5b87dbbe8ef04ef4b22de3b52bc6bf61 : SUCCESS in 8m 32s\n- octavia-tox-py313-tips https://zuul.opendev.org/t/openstack/build/b328ba10be6e4e1e9760cac9cf7c03a3 : SUCCESS in 5m 15s\n- octavia-tox-functional-py313-tips https://zuul.opendev.org/t/openstack/build/5c059a2a1b4045b9b86d912f3606078a : SUCCESS in 6m 53s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/c12a2bab20d94f67912f5b4277193091 : SUCCESS in 4m 52s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/cf994d0bc4514183a3ad4a39710e61eb : FAILURE in 3m 18s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/3d690d95bed44927aa8af69de1f03ee9 : SUCCESS in 5m 47s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/ccecd537ad9f46e394a586c0b2046c1f : SUCCESS in 1h 08m 46s\n- octavia-v2-dsvm-scenario-traffic-ops https://zuul.opendev.org/t/openstack/build/aa56b2cd723c4a98af0109e4bdc13890 : SUCCESS in 1h 34m 17s\n- octavia-v2-dsvm-scenario-non-traffic-ops https://zuul.opendev.org/t/openstack/build/17e9a45ca65c4a7788a44480c7c4ef5d : SUCCESS in 1h 30m 01s\n- octavia-v2-dsvm-scenario-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/0b0783de3c984d2fa8a34b055fc317d7 : SUCCESS in 2h 19m 23s\n- octavia-v2-dsvm-scenario-non-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/a3082f90ff5f401d87458a2e756d0bd7 : SUCCESS in 1h 13m 41s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/9a248bb4614048ee94347ea681f7758d : SUCCESS in 47m 39s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/e979408abfc94d718bb73907573d04ad : SUCCESS in 1h 07m 33s\n- octavia-grenade-skip-level https://zuul.opendev.org/t/openstack/build/7255d9fcac82496e869843185ed8e0da : SUCCESS in 1h 15m 26s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/10ec519be84a441eb9d7a2b62ce89954 : SUCCESS in 55m 39s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/4a70560defe44f47810a83dd71d256a1 : SUCCESS in 49m 59s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/997fb595cc6f40cc93e15437aa70b70f : SUCCESS in 2h 37m 32s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/51c49050a22f430687066526cc692620 : SUCCESS in 1h 45m 55s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-traffic-ops https://zuul.opendev.org/t/openstack/build/deab007600184c328c13c48c5c9ccc79 : SUCCESS in 1h 55m 06s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-non-traffic-ops https://zuul.opendev.org/t/openstack/build/9378e84bdf5c48f7a784164fb7b0cd76 : SUCCESS in 1h 16m 25s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"2a381692e52440247929f1a8980c3fbbec17d8ab","tag":"autogenerated:claude-review","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-15 09:06:39.000000000","message":"Patch Set 5:\n\n*Reviewed by claude-sonnet-4-6*\n\nThe review has been completed and saved. Here\u0027s a summary of the findings:\n\n## Code Review Summary: openstack/octavia Change #988052 PS5\n\n**Output file**: `~/octavia-gdrive/code-reviews/review_openstack_octavia_988052_ps5_20260514_160524.md`\n\n### What This Change Does\nPS5 extends the PS4 `KeyError` fix with a second related fix: it prevents duplicate NIC accumulation when the VIP network and the amphora management network are the same — a common scenario in Kolla Ansible all-in-one deployments.\n\n**Two production code changes in `network_tasks.py`:**\n1. **Line 125–126**: Subtracts `set(management_nets)` from `add_ids`, mirroring an existing exclusion already applied to `network_to_nic_map` — prevents the management/VIP network from being re-plugged as a duplicate NIC.\n2. **Line 134–135**: Retains `net_vnic_type_map.get(add_net_id, constants.VNIC_TYPE_NORMAL)` as defence-in-depth for VIP networks on distinct subnets.\n\n### Test Results\n| Test Suite | Result |\n|---|---|\n| Unit Tests (`tox -e py3`) | ✅ 1593/1593 pass (includes 2 new regression tests) |\n| Functional Tests (`tox -e functional`) | ✅ 1419/1419 pass (3 pre-existing skips) |\n| PEP8/pycodestyle | ✅ Clean on modified files (pre-existing tox env issue unrelated to this change) |\n\n### Verdict: ✅ Approve\nThe fix is correct, minimal, and well-tested. One non-blocking suggestion: expand the release note to describe **both** the `KeyError` fix and the duplicate NIC fix (currently only the `KeyError` is mentioned).\n\n### Backport Recommendation\n**High urgency** backport to `stable/2025.1` and `stable/2024.2` — the bug blocks member creation in common deployment configurations.\n\n---\n*This review was generated by an AI and may contain errors.*","accounts_in_message":[],"_revision_number":5},{"id":"b2816d08ddc36872e18db38bd8c8c4496ab91215","tag":"autogenerated:claude-review","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-15 09:30:56.000000000","message":"Patch Set 5:\n\ntest","accounts_in_message":[],"_revision_number":5},{"id":"6465da4059b93cff5848850ac63bc200e22235a7","tag":"autogenerated:claude-review","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-15 09:32:25.000000000","message":"Patch Set 5:\n\n*CI analysis by claude-sonnet-4-6*\n\n## Overall Recommendation\n\n**Action Required:** RE-RUN ONLY\n\nThe single failing job, `openstack-tox-functional-py310`, never executed any functional tests. It failed during the `pip install` dependency setup phase because `sphinx 9.0.4` — pinned in the global `upper-constraints.txt` — was not available on the Rackspace internal PyPI mirror at build time. This is a transient infrastructure issue (mirror sync lag) with no connection to the code changes in this patchset. A simple recheck should be sufficient to resolve it.\n\n### Jobs Requiring Code Fix\n\nNone.\n\n### Jobs That Can Be Re-Run\n\n- **openstack-tox-functional-py310** — Mirror sync lag caused `sphinx\u003d\u003d\u003d9.0.4` to be unavailable; re-run after mirror refreshes.\n\n## Failing Jobs\n\n| Field | Value |\n|-------|-------|\n| Gerrit Change | [openstack/octavia #988052](https://review.opendev.org/c/openstack/octavia/+/988052) |\n| Patchset | 5 |\n| Pipeline | check |\n| Total Failing Jobs | 1 |\n| Analysis Date | 2026-05-14 15:00:27 UTC |\n\n---\n*This analysis was generated by an AI and may contain errors.*","accounts_in_message":[],"_revision_number":5},{"id":"65660410cd247f17e449c80720364541e79eca18","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-15 09:34:45.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"398eaf02de8727b8bc5ba7c420e6fcddadb7232f","tag":"autogenerated:claude-review","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-15 13:49:36.000000000","message":"Patch Set 5:\n\n*DevStack integration tests by claude-sonnet-4-6*\n\n## Tests Run\n\n| Test | Result |\n|------|--------|\n| Service Restart After Checkout | ✅ PASS |\n| OpenStack Credential Verification | ✅ PASS |\n| Load Balancer Creation | ✅ PASS |\n| Load Balancer Reaches ACTIVE Status | ✅ PASS |\n| Listener Creation | ✅ PASS |\n| Pool Creation | ✅ PASS |\n| Amphora Status Verification | ✅ PASS |\n| Service Log Analysis | ✅ PASS |\n| Full Load Balancer Detail Verification | ✅ PASS |\n\n## Test Results Summary\n\n**Overall Status:** ✅ PASS\n\n**Tests Passed:** 9/9\n**Tests Failed:** 0\n\n**Key Findings:**\n- The patched code applies cleanly to the `master` branch with no conflicts.\n- All three Octavia services restart successfully with the new code.\n- The full LB → Listener → Pool provisioning lifecycle completes without errors.\n- `CalculateAmphoraDelta` was exercised during amphora creation; no `KeyError` was raised and no duplicate NICs were plugged.\n- MASTER + BACKUP amphorae provisioned correctly with proper NIC configuration.\n- Service logs are clean — no errors or warnings attributable to this patch.\n- The pre-existing SQLAlchemy `SAWarning` (cartesian product) is unrelated to this change and exists on `master` as well.\n\n**Issues Found:**\n- None related to this patch.\n\n**Recommendations:**\n- ✅ The fix correctly addresses the duplicate NIC / `KeyError` regression in `CalculateAmphoraDelta` as described in LP #2150752.\n- ✅ The `.get()` defensive lookup for `net_vnic_type_map` is a good defensive programming practice, even for environments where the VIP network is distinct from management.\n- ✅ New unit tests adequately cover both regressions.\n- Consider adding a functional test that exercises the all-in-one VIP-on-management-network topology for CI coverage of this edge case.\n- The change is suitable for merge.\n\n---\n\n---\n*This report was generated by an AI and may contain errors.*","accounts_in_message":[],"_revision_number":5},{"id":"45e30b9291312e8fe87caa515af7106982ad3b89","tag":"autogenerated:claude-review","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-15 16:40:47.000000000","message":"Patch Set 5:\n\n*DevStack integration tests by claude-sonnet-4-6*\n\n**Tested:** change #988052 PS4\n\n## Tests Run\n\n| Test | Result |\n|------|--------|\n| Service Restart and Health Check | ✅ PASS |\n| OpenStack Connectivity | ✅ PASS |\n| Load Balancer Creation (Core Regression Test) | ✅ PASS |\n| Listener and Pool Creation (Extended Workflow) | ✅ PASS |\n| Amphora Health Check | ✅ PASS |\n| Service Log Inspection | ✅ PASS |\n| New Regression Unit Test | ✅ PASS |\n| Full Unit Test Suite for Modified Module | ✅ PASS |\n\n## Test Results Summary\n\n**Overall Status:** ✅ PASS\n\n**Tests Passed:** 8/8\n**Tests Failed:** 0\n\n**Key Findings:**\n\n- The one-line fix (`dict.get()` with `VNIC_TYPE_NORMAL` default) correctly\n  resolves the `KeyError` in `CalculateAmphoraDelta` when the VIP network\n  appears in `add_ids` but is absent from `net_vnic_type_map`.\n- End-to-end load balancer creation, listener and pool provisioning all succeed\n  with no errors in any service log.\n- The patch includes a targeted regression test (`test_calculate_amphora_delta_vip_not_plugged`)\n  that directly reproduces the bug scenario — this test passes.\n- All 32 existing unit tests in the modified module continue to pass.\n- HA amphora pair (MASTER + BACKUP) provisions and remains healthy throughout.\n- The default `VNIC_TYPE_NORMAL` applied by `.get()` is semantically correct\n  for VIP ports and consistent with how VIP ports are created elsewhere in\n  Octavia.\n\n**Issues Found:**\n- None. The fix is minimal, targeted, and correct.\n\n**Recommendations:**\n- ✅ Change is ready to merge. The fix is a one-line, low-risk change with\n  comprehensive test coverage.\n- The release note correctly references Launchpad bug #2150752 and describes\n  the impact accurately.\n- Consider backporting to stable branches if the `KeyError` is reproducible on\n  those branches (likely yes, since the code path is unchanged there).\n\n---\n\n*Generated by DevStack Test Agent*\n*Test executed in isolated environment with unique resource prefix `test-test-407778-1778862650-`*\n*Services restored to `master` branch after testing*\n\n---\n*This report was generated by an AI and may contain errors.*","accounts_in_message":[],"_revision_number":5},{"id":"3822e22f2185b85821099a250039a47fc4e078d4","tag":"autogenerated:claude-review","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-26 15:49:28.000000000","message":"Patch Set 5:\n\n*DevStack integration tests by claude-sonnet-4-6*\n\n**Tested:** change #988052 PS5\n\n## Tests Run\n\n| Test | Result |\n|------|--------|\n| Load Balancer Creation | ✅ PASS |\n| Listener and Pool Creation | ✅ PASS |\n| First Member Add — KeyError Regression Test (Primary Fix Verification) | ✅ PASS |\n| Second Member Add — Duplicate NIC Regression Test | ✅ PASS |\n| Member Update — Repeated CalculateAmphoraDelta Stability | ✅ PASS |\n| API Log Review | ✅ PASS |\n\n## Test Results Summary\n\n**Overall Status:** ✅ PASS\n\n**Tests Passed:** 6/6\n**Tests Failed:** 0\n\n**Key Findings:**\n- The fix correctly subtracts `set(management_nets)` from `add_ids` in `CalculateAmphoraDelta`, preventing management NICs from appearing in the list of networks to plug.\n- The `.get()` fallback on `net_vnic_type_map` provides safe defence-in-depth for any network absent from the map.\n- All three `CalculateAmphoraDelta` invocations (member create ×2, member update ×1) completed without `KeyError` and without spurious NIC plug attempts.\n- All provisioned resources reached `provisioning_status: ACTIVE`.\n- The standard load balancer / listener / pool / member lifecycle is fully preserved — no regressions observed.\n\n**Issues Found:**\n- None.\n\n**Recommendations:**\n- This change is ready to merge. The fix is minimal and surgical (two-line change to `network_tasks.py`) with a clear regression test added.\n- The `devstack/plugin.sh` change should be reviewed separately for any devstack-specific configuration implications, though it did not affect the integration test behaviour.\n- Future testing in a Kolla Ansible all-in-one environment (where VIP network \u003d\u003d management network) would provide the most direct reproduction of Bug #2150752, which could not be exactly replicated in this standard DevStack topology (VIP and mgmt networks are distinct). However, the fix was exercised through the same code path (management net excluded from `add_ids`) and behaved correctly.\n\n---\n\n---\n*This report was generated by an AI and may contain errors.*","accounts_in_message":[],"_revision_number":5},{"id":"cfe21ce4302f8d3742831df6b34aaaee05a937f1","tag":"autogenerated:claude-review","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-05-27 19:40:48.000000000","message":"Patch Set 5:\n\n*DevStack integration tests by claude-sonnet-4-6*\n\n**Tested:** change #988052 PS5\n\n## Tests Run\n\n| Test | Result |\n|------|--------|\n| Service Restart and Verification | ✅ PASS |\n| Load Balancer Creation | ✅ PASS |\n| Listener Creation | ✅ PASS |\n| Pool Creation | ✅ PASS |\n| Member Add — First Member (CalculateAmphoraDelta Exercise) | ✅ PASS |\n| Member Add — Second Member (Repeated CalculateAmphoraDelta) | ✅ PASS |\n| Service Log Error Check | ✅ PASS |\n| Resource Cleanup | ✅ PASS |\n| Service Restore and Final Status | ✅ PASS |\n\n## Test Results Summary\n\n**Overall Status:** ✅ PASS\n**Tests Passed:** 9/9\n**Tests Failed:** 0\n\n**Key Findings:**\n- The patched `CalculateAmphoraDelta` in `network_tasks.py` correctly subtracts management network IDs from `add_ids`, preventing the `KeyError` on `net_vnic_type_map` lookup and eliminating spurious duplicate NIC plug operations.\n- Both the first and second member-add operations returned `\u0027add_nics\u0027: []` for all amphora instances, confirming the fix is correct and idempotent.\n- The change includes 111 lines of new unit tests in `test_network_tasks.py` and a release note, demonstrating good test coverage for the bug fix.\n- All Octavia services remained stable throughout testing with no new errors or regressions introduced.\n- The DevStack test environment uses separate management and VIP networks, so the exact VIP-on-management-network scenario described in the bug report was not directly reproducible; however, the fixed code path was exercised end-to-end on every member operation with clean results.\n\n**Issues Found:**\n- None. The change applies cleanly, all operations succeed, and no errors or regressions were observed.\n\n**Recommendations:**\n- None. The change is well-structured with a clear bug fix, appropriate unit tests, and a release note. It is ready to merge.\n\n---\n*This report was generated by an AI and may contain errors.*","accounts_in_message":[],"_revision_number":5},{"id":"0531f262a2f61f7edc09f2ebeb97fce2691da6a6","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2026-08-17 14:52:17.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"ff791659f17624010b8164a95d72f92c46b3ae85","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2026-08-17 15:30:52.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"3633754a629360f3b9a513cb0b918b98f0d82686","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-17 17:03:53.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/120e63eb9b6648c892a21a511f216210\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d6e0f591512c46e187914aa7721f126d : SUCCESS in 11m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/05c41a0d83e74766a8422c025abe5fe1 : SUCCESS in 2m 42s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/5e2947e06a0a4fba8f28fedbbef91858 : SUCCESS in 2m 52s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/68687a6adbdc411e85194383e87ce3ae : SUCCESS in 4m 42s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/2ef0208a963a4ce3ac2b5952650d203f : SUCCESS in 6m 43s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/649c9f6719164b248128b6cab5b96375 : SUCCESS in 12m 00s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e0ff1b6631f045598a2ec465c783a8ae : SUCCESS in 9m 58s\n- octavia-tox-py313-tips https://zuul.opendev.org/t/openstack/build/9bcd9dae2495449c88e25b1949030bcc : SUCCESS in 3m 18s\n- octavia-tox-functional-py313-tips https://zuul.opendev.org/t/openstack/build/7a6ddc83840b4d41a0ba5bc49e243889 : SUCCESS in 5m 33s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/377e6e4dec3a4fa68c06e556396bdda0 : SUCCESS in 2m 16s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/252fc266bc2845cb9ccb5ba6ac555b21 : SUCCESS in 6m 07s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/7390590bad774b6f938692d475901406 : SUCCESS in 52m 54s\n- octavia-v2-dsvm-scenario-traffic-ops https://zuul.opendev.org/t/openstack/build/e2c5430070e242f2941dfa4c0207eb73 : SUCCESS in 1h 24m 41s\n- octavia-v2-dsvm-scenario-non-traffic-ops https://zuul.opendev.org/t/openstack/build/00b8c408361c4c44b1bcfd925648ce62 : SUCCESS in 1h 09m 54s\n- octavia-v2-dsvm-scenario-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/d1b6f6cfd2344863a5f4872bca5bfd71 : SUCCESS in 1h 25m 10s\n- octavia-v2-dsvm-scenario-non-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/db359e67564e494782c647e1d6194c96 : SUCCESS in 1h 01m 00s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/4719482b7e8549c3866491609736d482 : SUCCESS in 34m 04s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/8afbbe35ae274296815bccaaa5978037 : SUCCESS in 42m 08s\n- octavia-grenade-skip-level https://zuul.opendev.org/t/openstack/build/e54e3d7ed4114257a5e694cda97da58e : SUCCESS in 41m 52s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/1b5ff8beed3f4127a421c914442a4975 : SUCCESS in 33m 51s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/4f9578d82f1a441eb9e252dfbeb83af6 : SUCCESS in 32m 40s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/217216452b064c129656d4a29700e1c0 : SUCCESS in 2h 09m 50s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/5c257fcf407a440290c1ed1e5f3ac5a0 : SUCCESS in 1h 22m 34s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-traffic-ops https://zuul.opendev.org/t/openstack/build/aed588d3323d446a9e51217d2d705a77 : SUCCESS in 1h 12m 49s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-non-traffic-ops https://zuul.opendev.org/t/openstack/build/83584813439b4db3b0a4482adba97814 : SUCCESS in 59m 53s (non-voting)","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"84a0e81cb75020bcec65b423d49a14206b2a8486","revisions":{"573ddd0cf28187cdef2fc75eec2d678625651b1c":{"kind":"REWORK","_number":1,"created":"2026-05-11 08:38:45.000000000","uploader":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"ref":"refs/changes/52/988052/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/52/988052/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/52/988052/1"}}},"commit":{"parents":[{"commit":"d16fa5e723701c95cf97a3e9ea57b3856e09aaa7","subject":"Merge \"Add check for Octavia Healthmonitor network before deleting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/d16fa5e723701c95cf97a3e9ea57b3856e09aaa7"}]}],"author":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-11 08:30:49.000000000","tz":60},"committer":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-11 08:38:14.000000000","tz":60},"subject":"Fix Key Error when getching VNIC types","message":"Fix Key Error when getching VNIC types\n\n- The SR-IOV feature added a new dictionary called net_vnic_type_map\n- This is only populagted for Member networks and not VIP networks\n- This can result in an unhandled Key Error if the function looks up a UUID for VIP network\n- Although this isn\u0027t a valid use case, the resulting trace in the logs isn\u0027t ideal\n- The fix is to use the more stable dict.get method with a normal VNIC as default response\n- An additional unit test case has been added as well\n\nFixes-bug:2150752\n\nGenerated-by: Claude Sonnet 4.6 \u003csupport@anthropic.com\u003e\nChange-Id: I6ac099aa38695fd837d74ffa619d131700c239a2\nSigned-off-by: Richard Cruise \u003crcruise@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/573ddd0cf28187cdef2fc75eec2d678625651b1c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/573ddd0cf28187cdef2fc75eec2d678625651b1c"}]},"branch":"refs/heads/master"},"b2dcd3a3ed3a526d0f61aff5b34cd6a54fec63a8":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-05-11 08:41:06.000000000","uploader":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"ref":"refs/changes/52/988052/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/52/988052/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/52/988052/2"}}},"commit":{"parents":[{"commit":"d16fa5e723701c95cf97a3e9ea57b3856e09aaa7","subject":"Merge \"Add check for Octavia Healthmonitor network before deleting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/d16fa5e723701c95cf97a3e9ea57b3856e09aaa7"}]}],"author":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-11 08:30:49.000000000","tz":60},"committer":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-11 08:41:06.000000000","tz":0},"subject":"Fix Key Error when getching VNIC types","message":"Fix Key Error when getching VNIC types\n\n- The SR-IOV feature added a new dictionary called net_vnic_type_map\n- This is only populagted for Member networks and not VIP networks\n- This can result in an unhandled Key Error if the function looks up a UUID for VIP network\n- Although this isn\u0027t a valid use case, the resulting trace in the logs isn\u0027t ideal\n- The fix is to use the more stable dict.get method with a normal VNIC as default response\n- An additional unit test case has been added as well\n\nFixes-bug: #2150752\n\nGenerated-by: Claude Sonnet 4.6 \u003csupport@anthropic.com\u003e\nChange-Id: I6ac099aa38695fd837d74ffa619d131700c239a2\nSigned-off-by: Richard Cruise \u003crcruise@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/b2dcd3a3ed3a526d0f61aff5b34cd6a54fec63a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/b2dcd3a3ed3a526d0f61aff5b34cd6a54fec63a8"}]},"branch":"refs/heads/master","description":"Edit commit message"},"ecec082d18521ee6812cb00889726bfdb09a849f":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-05-11 08:44:00.000000000","uploader":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"ref":"refs/changes/52/988052/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/52/988052/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/52/988052/3"}}},"commit":{"parents":[{"commit":"d16fa5e723701c95cf97a3e9ea57b3856e09aaa7","subject":"Merge \"Add check for Octavia Healthmonitor network before deleting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/d16fa5e723701c95cf97a3e9ea57b3856e09aaa7"}]}],"author":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-11 08:30:49.000000000","tz":60},"committer":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-11 08:44:00.000000000","tz":0},"subject":"Fix Key Error when getching VNIC types","message":"Fix Key Error when getching VNIC types\n\n- The SR-IOV feature added a new dictionary called net_vnic_type_map\n- This is only populated for Member networks and not VIP networks\n- This can result in an unhandled Key Error if the function looks up a UUID for VIP network\n- Although this isn\u0027t a valid use case, the resulting trace in the logs isn\u0027t ideal\n- The fix is to use the more stable dict.get method with a normal VNIC as default response\n- An additional unit test case has been added as well\n\nFixes-bug: #2150752\n\nGenerated-by: Claude Sonnet 4.6 \u003csupport@anthropic.com\u003e\nChange-Id: I6ac099aa38695fd837d74ffa619d131700c239a2\nSigned-off-by: Richard Cruise \u003crcruise@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/ecec082d18521ee6812cb00889726bfdb09a849f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/ecec082d18521ee6812cb00889726bfdb09a849f"}]},"branch":"refs/heads/master","description":"Edit commit message"},"334ca2bfc73ed94fd16533c84056d0de45e4fcf4":{"kind":"REWORK","_number":4,"created":"2026-05-12 11:18:55.000000000","uploader":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"ref":"refs/changes/52/988052/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/52/988052/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/52/988052/4"}}},"commit":{"parents":[{"commit":"d16fa5e723701c95cf97a3e9ea57b3856e09aaa7","subject":"Merge \"Add check for Octavia Healthmonitor network before deleting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/d16fa5e723701c95cf97a3e9ea57b3856e09aaa7"}]}],"author":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-11 08:30:49.000000000","tz":60},"committer":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-12 11:17:28.000000000","tz":60},"subject":"Fix KeyError when fetching VNIC types in CalculateAmphoraDelta","message":"Fix KeyError when fetching VNIC types in CalculateAmphoraDelta\n\nThe net_vnic_type_map dict is built by iterating over pool members\nand recording each member\u0027s network → vnic_type mapping.  However,\nthe VIP network is always seeded into desired_subnet_to_net_map\n(and therefore always appears in desired_network_ids), but it is\nnever added to net_vnic_type_map because it is not a member network.\n\nWhen the VIP network has not yet been plugged into the amphora it\nappears in add_ids, and the list comprehension that builds add_nics\nperforms a bare dict lookup net_vnic_type_map[add_net_id].  This can\nresult in an unhandled KeyError when a load balancer has no SR-IOV\nmembers (e.g. no members at all, or during initial amphora boot).\n\nReplace the bare lookup with dict.get() using VNIC_TYPE_NORMAL as the\ndefault.  VIP ports are always normal (non-SR-IOV), so this is\nsemantically correct and does not affect SR-IOV member functionality.\n\nCloses-Bug: #2150752\n\nGenerated-by: Claude Sonnet 4.6 \u003csupport@anthropic.com\u003e\nChange-Id: I6ac099aa38695fd837d74ffa619d131700c239a2\nSigned-off-by: Richard Cruise \u003crcruise@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/334ca2bfc73ed94fd16533c84056d0de45e4fcf4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/334ca2bfc73ed94fd16533c84056d0de45e4fcf4"}]},"branch":"refs/heads/master"},"84a0e81cb75020bcec65b423d49a14206b2a8486":{"kind":"REWORK","_number":5,"created":"2026-05-14 14:28:25.000000000","uploader":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"ref":"refs/changes/52/988052/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/52/988052/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/52/988052/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/52/988052/5"}}},"commit":{"parents":[{"commit":"d16fa5e723701c95cf97a3e9ea57b3856e09aaa7","subject":"Merge \"Add check for Octavia Healthmonitor network before deleting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/d16fa5e723701c95cf97a3e9ea57b3856e09aaa7"}]}],"author":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-11 08:30:49.000000000","tz":60},"committer":{"name":"Richard Cruise","email":"rcruise@redhat.com","date":"2026-05-14 14:28:03.000000000","tz":60},"subject":"Fix duplicate NICs and KeyError in CalculateAmphoraDelta","message":"Fix duplicate NICs and KeyError in CalculateAmphoraDelta\n\nWhen the VIP network is the same as the management network (e.g. a\nKolla Ansible all-in-one deployment where the LB is created on\nlb-mgmt-net), the management NIC is intentionally excluded from\nnetwork_to_nic_map and therefore absent from plugged_network_ids.\nHowever, the VIP network still appears in desired_network_ids, so it\nlanded in add_ids on every recalculation.  This had two consequences:\n\n1. The bare lookup net_vnic_type_map[add_net_id] raised KeyError\n   because net_vnic_type_map only contains member networks, not the\n   management/VIP network.\n\n2. Even after silencing the KeyError with .get(), Octavia tried to\n   plug an additional NIC onto the management network on each member\n   add/update, accumulating duplicate interfaces (eth2, eth3, ...).\n\nFix both issues:\n\n* Subtract set(management_nets) from add_ids, mirroring the exclusion\n  already applied to network_to_nic_map one step earlier.  Management\n  NICs are already present on the amphora and must never be re-plugged.\n\n* Retain the dict.get() fallback on net_vnic_type_map as defence-in-\n  depth for any non-management network absent from the map (e.g. the\n  VIP network on a distinct, not-yet-plugged subnet).\n\nAdd a unit test (test_calculate_amphora_delta_vip_on_mgmt_net) that\nexercises the exact failure scenario: VIP network \u003d\u003d management network,\none member on a separate network, management NIC already plugged.\n\nCloses-Bug: #2150752\n\nGenerated-by: Claude Sonnet 4.6 \u003csupport@anthropic.com\u003e\nChange-Id: I6ac099aa38695fd837d74ffa619d131700c239a2\nSigned-off-by: Richard Cruise \u003crcruise@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/84a0e81cb75020bcec65b423d49a14206b2a8486"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/84a0e81cb75020bcec65b423d49a14206b2a8486"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}