)]}'
{"id":"openstack%2Foctavia~990822","triplet_id":"openstack%2Foctavia~master~Ibe52f67f275a0ba90dc43d667f502f0c937e3291","project":"openstack/octavia","branch":"master","attention_set":{},"removed_from_attention_set":{"38562":{"account":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"last_update":"2026-06-02 09:01:46.000000000","reason":"removed on reply"},"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2026-07-30 07:39:10.000000000","reason":"Change was submitted"},"29244":{"account":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"last_update":"2026-07-30 06:11:48.000000000","reason":"\u003cGERRIT_ACCOUNT_29244\u003e replied on the change","reason_account":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}}},"hashtags":[],"change_id":"Ibe52f67f275a0ba90dc43d667f502f0c937e3291","subject":"Remove unused [DEFAULT] octavia_plugins","status":"MERGED","created":"2026-05-31 13:38:37.000000000","updated":"2026-07-30 07:41:03.000000000","submitted":"2026-07-30 07:39:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"990822","meta_rev_id":"99c2df4e17c2a1f9d30403128a729e49c4b14612","_number":990822,"virtual_id_number":990822,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-07-30 07:39:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"recommended":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"all":[{"value":1,"date":"2026-06-02 09:18:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},{"value":2,"date":"2026-07-30 06:11:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-05-31 19:05:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"all":[{"value":0,"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},{"value":1,"date":"2026-07-30 06:11:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-31 16:14:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-05-31 19:05:35.000000000","updated_by":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"reviewer":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"state":"REVIEWER"},{"updated":"2026-05-31 19:05:35.000000000","updated_by":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"reviewer":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"state":"REVIEWER"},{"updated":"2026-05-31 19:05:35.000000000","updated_by":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"reviewer":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"state":"REVIEWER"}],"messages":[{"id":"88f8bfb57894cecda57c8a000375c2bbf11f889a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2026-05-31 13:38:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b68be2fe6f05fdcf1998d6fbe0f7a27ea31cc53f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2026-05-31 13:40:32.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a0aa100a3844c3dcde90efea612ba5dca7615837","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-31 16:14:56.000000000","message":"Patch Set 2: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/70f409e06c11458c844d04054ee1d1bd\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/194584dafae14ac18d719459218861b4 : SUCCESS in 2m 32s\n- requirements-check https://zuul.opendev.org/t/openstack/build/135ac08b8a3740e5a3c6ddd9ef7a6427 : SUCCESS in 2m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b374d50f539d400e9de142eadffac091 : SUCCESS in 9m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/daec9debd87845a189bce6dde9116590 : FAILURE in 2m 41s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/4b5fd341903443a8b406ebfe5834b635 : SUCCESS in 4m 07s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/fba26d2aebb647c6812ef0bebd6f34eb : SUCCESS in 4m 31s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/18c099575583424f847277b30632daf5 : SUCCESS in 6m 57s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f3a4fbaa035a4f72bb31b258b17ff917 : SUCCESS in 13m 28s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/06eace1eb3ec4f59826f95c8182a6fd2 : SUCCESS in 6m 08s\n- octavia-tox-py313-tips https://zuul.opendev.org/t/openstack/build/917b4f4b0b6a4c5a994ab8c12df6049c : SUCCESS in 4m 14s\n- octavia-tox-functional-py313-tips https://zuul.opendev.org/t/openstack/build/f95fcaeb9737401baea6dd4d1bab6858 : SUCCESS in 4m 25s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/a084e07aeba5491fb6b1284492180e0f : SUCCESS in 3m 37s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/73a6e946c023442b9dc955f3fa831ecb : SUCCESS in 5m 17s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/cdc8f603386e4c34b39f04b719b4d1e9 : SUCCESS in 1h 04m 44s\n- octavia-v2-dsvm-scenario-traffic-ops https://zuul.opendev.org/t/openstack/build/700aa1825e674e25ba88331909140d1b : TIMED_OUT in 2h 32m 07s\n- octavia-v2-dsvm-scenario-non-traffic-ops https://zuul.opendev.org/t/openstack/build/b391115ecbd44e0d927f2cbd3764edf4 : SUCCESS in 55m 41s\n- octavia-v2-dsvm-scenario-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/ff93b597a5c94edabe73dcc6d5303d14 : SUCCESS in 1h 35m 33s\n- octavia-v2-dsvm-scenario-non-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/6ff292997f02443e94ba019231f6767a : SUCCESS in 1h 00m 06s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/ad288df334134789b38c10f892e33191 : SUCCESS in 34m 29s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/787f1dd33b524dbd85bcb30484553185 : SUCCESS in 50m 26s\n- octavia-grenade-skip-level https://zuul.opendev.org/t/openstack/build/85dbdd6843c546609cd6cefee8eeb678 : SUCCESS in 47m 28s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/28bbc74a31b54ae18868c3b254f6a3f4 : SUCCESS in 35m 40s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/89e149a5bd1741e4b56c2f4bb9ea385a : SUCCESS in 36m 38s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/f0e83675be1a4cf7be9d7008a3892454 : SUCCESS in 2h 33m 02s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/aa10a18b590a4801a2c6981670743a06 : SUCCESS in 1h 27m 24s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-traffic-ops https://zuul.opendev.org/t/openstack/build/d4c744fd97e14f8e9e7b0ee651c3271f : SUCCESS in 1h 21m 40s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-non-traffic-ops https://zuul.opendev.org/t/openstack/build/3c5ecbad5453409ab9ab219184942d9d : SUCCESS in 1h 01m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"bdfff82a0808ff66f07b7da437aae88388f58800","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2026-05-31 16:29:29.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":3},{"id":"7d22de628e48ac85af07b1faa2eeb699929f6559","author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"date":"2026-05-31 19:05:35.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"49859e39a1de923ab3f9021258f4355b1664e20d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-31 19:15:00.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a5825f983e4146f1bbdbb28041d0d5da\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/a6ebd5dbab274e36b745634a24308946 : SUCCESS in 2m 16s\n- requirements-check https://zuul.opendev.org/t/openstack/build/40fb5093ce87410097d5ae57fbc09ac2 : SUCCESS in 1m 56s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1abf3088dc90468392be0a36507850d7 : SUCCESS in 9m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d6b1ca310579443c8193a5b81315454b : SUCCESS in 3m 13s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/c3407d538f794511ac6de781961a4fc0 : SUCCESS in 4m 15s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/b0ab09c737bc45a881cbb111ad63a628 : SUCCESS in 6m 56s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/e8e41c778e3d43cc877b3af0a97bcb54 : SUCCESS in 5m 04s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/87474067bf6a4a3d879a66a2373cb524 : SUCCESS in 12m 43s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8b6ca55057a84acb9525b44903aafe37 : SUCCESS in 4m 12s\n- octavia-tox-py313-tips https://zuul.opendev.org/t/openstack/build/209bbfad8f1d48539cb2875bc4f947ff : SUCCESS in 7m 07s\n- octavia-tox-functional-py313-tips https://zuul.opendev.org/t/openstack/build/af564e17fba4466696d59ef8350ca907 : SUCCESS in 3m 11s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/62588a4db0f14a2f8b6e403320305a47 : SUCCESS in 3m 20s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/4c6a12ccd01a4d3aba23e65f8fe27949 : SUCCESS in 5m 50s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/778caba7a4ad498a84ed34b05bfe2811 : SUCCESS in 1h 11m 29s\n- octavia-v2-dsvm-scenario-traffic-ops https://zuul.opendev.org/t/openstack/build/b64326d24db145d39fd646d270278a0d : SUCCESS in 1h 35m 25s\n- octavia-v2-dsvm-scenario-non-traffic-ops https://zuul.opendev.org/t/openstack/build/5f6ab3d1adec4f4685b4739cef500e06 : SUCCESS in 1h 05m 16s\n- octavia-v2-dsvm-scenario-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/620ce65b46c54ab98ad677b67eeaeb8b : SUCCESS in 1h 38m 16s\n- octavia-v2-dsvm-scenario-non-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/4848ffaf1ea5437aa458363a1932e6ea : SUCCESS in 1h 07m 57s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/8047ef4643354a6ba455fe64568b6979 : SUCCESS in 39m 28s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/d5345c2a96ab43f7a2afdea518fe10f5 : SUCCESS in 49m 24s\n- octavia-grenade-skip-level https://zuul.opendev.org/t/openstack/build/9c6dc2ee4afe481bb45e65886e41703e : SUCCESS in 46m 01s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/b48d2aa3755949f4a55411c16e4354ec : SUCCESS in 36m 20s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/cf75ed6a401b453681a2164491b8166c : SUCCESS in 33m 36s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/de56f499159b4d5981194589bd65f854 : SUCCESS in 2h 44m 17s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/3b86f2a4a99b47deb3c6f2f045a668cc : SUCCESS in 1h 33m 26s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-traffic-ops https://zuul.opendev.org/t/openstack/build/0b44177cbe0c41eab6ca72591632a9b4 : SUCCESS in 1h 20m 13s (non-voting)\n- octavia-v2-dsvm-scenario-centos-10-stream-non-traffic-ops https://zuul.opendev.org/t/openstack/build/5306a3861ddb4ae38eea6cc238b51d57 : SUCCESS in 1h 02m 52s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"bfbc1a93a64c07b8b37bbd3d7a5ead8bd5bdca28","tag":"autogenerated:claude-review","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-06-02 09:01:46.000000000","message":"Patch Set 3:\n\n(3 comments)\n\n*Reviewed by claude-sonnet-4-6*\n\n# Code Review: openstack/octavia - Change #990822\n\n**Gerrit URL**: https://review.opendev.org/c/openstack/octavia/+/990822\n**Patchset**: 3\n**Reviewed**: 2026-06-02 10:00:25\n**Reviewer**: claude-sonnet-4-6\n**First Review**\n\n---\n\n## Change Summary\n\nThis change removes the `[DEFAULT] octavia_plugins` configuration option and its associated entry point, which have been dead code since the removal of amphora v1 driver support (commit `6c0515c9880b5310dd0647a5881233f07898d812`). The change also cleans up the test setup that was unnecessarily configuring this defunct option.\n\n**Files Modified**: 4\n**Lines Added**: +5\n**Lines Removed**: -10\n\n### Commit Message\n```\nRemove unused [DEFAULT] octavia_plugins\n\nThis option has been unused since amphora v1 was removed [1].\n\n[1] 6c0515c9880b5310dd0647a5881233f07898d812\n\nChange-Id: Ibe52f67f275a0ba90dc43d667f502f0c937e3291\nSigned-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e\n\nChange-Id: Ibe52f67f275a0ba90dc43d667f502f0c937e3291\n```\n\n### Purpose\nThe `octavia_plugins` config option was used by the now-removed amphora v1 plugin loading mechanism. Since that mechanism was removed, the option has served no purpose. This change removes the dead code and the associated `octavia.plugins` stevedore entry point to keep the codebase clean.\n\n### Scope\n- `octavia/common/config.py`: Removes the `octavia_plugins` `StrOpt` from `core_opts`\n- `octavia/tests/unit/controller/queue/v2/test_endpoints.py`: Removes unnecessary test fixture setup that configured the now-deleted option\n- `pyproject.toml`: Removes the `[project.entry-points.\"octavia.plugins\"]` section\n- `releasenotes/notes/remove-octavia_plugins-5ce6b0692c8e29bf.yaml`: Documents the removal for operators\n\n---\n\n## Test Results\n\n_No test commands configured._\n\n---\n\n## Code Analysis\n\n### Overall Assessment\nThis is a clean, minimal dead-code removal with no functional risk. All references to `octavia_plugins` have been fully excised from the codebase (confirmed via grep), the test cleanup is correct, and the change is well-scoped. The release note adequately informs operators of the breaking configuration change.\n\n### Strengths\n- Complete removal: a grep of the repository confirms zero remaining references to `octavia_plugins` outside of the new release note, indicating thorough cleanup.\n- Test hygiene: the test setUp cleanup correctly removes the now-meaningless oslo_config fixture setup, removing two unnecessary imports along with it.\n- Entry point removed: the `pyproject.toml` entry point for `octavia.plugins` is correctly removed alongside the config option, preventing stale stevedore namespace registration.\n- Release note included: operators who may have `octavia_plugins` set in existing config files are informed it has been removed.\n\n### Issues Found\n\n#### Critical Issues 🔴\n*None identified.*\n\n#### Major Issues 🟡\n*None identified.*\n\n#### Minor Issues / Suggestions 🔵\n\n- **Duplicate `Change-Id` in commit message**: The commit message contains two identical `Change-Id:` lines. While this does not affect functionality and Gerrit only uses the first occurrence, it is untidy and diverges from standard OpenStack commit message format. The author may wish to squash/amend to remove the duplicate before merge.\n\n- **Release note could be more informative**: The release note states the option \"has been unused\" but does not give operators any context about when it became unused or why. Operators who have `octavia_plugins` explicitly set in their configuration files (e.g., via automation or config management) would benefit from a brief pointer to when amphora v1 was removed. A suggested improvement:\n\n  ```yaml\n  ---\n  upgrade:\n    - |\n      The ``[DEFAULT] octavia_plugins`` configuration option has been removed.\n      This option was used by the amphora v1 plugin mechanism, which was\n      removed in a prior release. Deployments that have this option explicitly\n      set in their configuration files should remove it to avoid warnings from\n      oslo.config about unknown configuration options.\n  ```\n\n#### Nits 🟢\n- The commit message references the amphora v1 removal commit hash (`6c0515c9880b5310dd0647a5881233f07898d812`) which is good practice for traceability.\n\n---\n\n## Detailed Review Comments\n\n### File: `octavia/common/config.py`\n\n**Lines 41–44** (post-patch) — Severity: None (informational)\nAfter the removal, `core_opts` contains only the single `host` option. This is fine — no action needed, just confirming the list is still syntactically valid with a single element.\n\n### File: `octavia/tests/unit/controller/queue/v2/test_endpoints.py`\n\n**Lines 14–16** (post-patch) — Severity: None (informational)\nThe removal of `from oslo_config import cfg` and `from oslo_config import fixture as oslo_fixture` imports is correct and complete. The remaining imports (`oslo_utils`, `constants`, `endpoints`, `base`) are all still used by the test class.\n\n### File: `releasenotes/notes/remove-octavia_plugins-5ce6b0692c8e29bf.yaml`\n\n**Lines 1–5** — Severity: Minor\nAs noted above, the release note is functional but sparse. Operators who have set this option in config management tooling (Puppet, Ansible, etc.) may not immediately understand why they should remove it. A brief explanation of what the option was for would improve operator experience.\n\n---\n\n## Security Analysis\n\n*No security concerns identified.* This change removes dead configuration, reducing the attack surface by eliminating an unused stevedore entry point namespace (`octavia.plugins`). No credentials, secrets, or security-sensitive code paths are involved.\n\n---\n\n## Documentation Review\n\n- **Docstrings**: ✅ Good — No new functions introduced; existing docstrings unaffected.\n- **Code Comments**: ✅ Good — The removal is self-explanatory; no additional comments needed.\n- **Commit Message**: ⚠️ Needs Improvement — The message is clear and references the introducing commit correctly, but contains a duplicate `Change-Id` line that should be removed.\n- **Release Notes**: ✅ Included — A release note is present in the correct `upgrade` category, though it could be more descriptive (see Minor Issues above).\n\n---\n\n## Final Verdict\n\n**Overall Assessment**: This is a well-executed dead-code removal that cleanly eliminates an unused configuration option, its entry point, and associated test scaffolding. The change is low-risk, complete, and appropriately documented.\n\n**Recommendation**:\n✅ **Approve** (Code is ready to merge)\n\n**Confidence Level**: High\nThe change is straightforward and purely subtractive. A codebase-wide grep confirms no remaining references to `octavia_plugins` exist, and the referenced commit (`6c0515c9880b5310dd0647a5881233f07898d812`) confirms the historical context. The only identified issues are cosmetic (duplicate Change-Id, sparse release note) and do not warrant blocking the merge.\n\n---\n\n## Backport Recommendation\n\n**Recommendation:** ❌ No backport needed\n\n**Rationale:** This is a cleanup/dead-code removal of a feature already absent since amphora v1 was removed. No backport branches are configured for this project, and this type of housekeeping change is not typically appropriate for stable branch backports. The option being removed has been a no-op for multiple releases.\n\n---\n\n## Next Steps\n\n---\n*This review was generated by an AI and may contain errors.*","accounts_in_message":[],"_revision_number":3},{"id":"8467793e3f58d1478bc997faf0bb01e266c57231","author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"date":"2026-06-02 09:18:57.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"de739181094c35fd3a96054ca257289b894dc91e","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2026-07-30 06:11:48.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"95bcaeeb62c53d5bd82f2a419d560d37c2e1e265","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-30 06:12:42.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"0eac96d50faeee13deeb38ad3b2269792055d337","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-30 07:39:10.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dcdf2d46c1d64d6e8315cdfc66dd296f\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/22ccc628dbdf48bc9d5ad83d732b4e2e : SUCCESS in 2m 20s\n- requirements-check https://zuul.opendev.org/t/openstack/build/807a1ea445024dee8d4e1779d4cde4ec : SUCCESS in 2m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/023d9ad7edbc4396b104ab30550c6da9 : SUCCESS in 4m 31s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/c89cac1366704f69a2508b5b444f7796 : SUCCESS in 6m 14s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/5e947b85b48f40aa876990309f0845e2 : SUCCESS in 6m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8704d6d0724242faa07aa431d7a53e69 : SUCCESS in 15m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/42af470009034c2780140786fe2a6b74 : SUCCESS in 10m 42s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/6dc997f4a6cf4d6aa28b664a2e1f64c5 : SUCCESS in 3m 47s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/f64afb935461437297d482c002379ee4 : SUCCESS in 7m 42s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/08440ea423144e7cad7aea6ad336ce0c : SUCCESS in 1h 01m 42s\n- octavia-v2-dsvm-scenario-traffic-ops https://zuul.opendev.org/t/openstack/build/9490f0908a7f4c01945123d5c49afa1c : SUCCESS in 1h 19m 34s\n- octavia-v2-dsvm-scenario-non-traffic-ops https://zuul.opendev.org/t/openstack/build/450e8dede3964e0db624173355306291 : SUCCESS in 1h 01m 34s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/0b3565acca5842b1a6dea03da48d542a : SUCCESS in 36m 15s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/a6d9302315a54318baea0e052253d82c : SUCCESS in 44m 08s\n- octavia-grenade-skip-level https://zuul.opendev.org/t/openstack/build/5525f1e2b79e4af699c862ccd975bd4b : SUCCESS in 41m 00s","accounts_in_message":[],"_revision_number":3},{"id":"c7ac6736c172814b38fa81b90fd561faeef5e792","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-30 07:39:10.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3},{"id":"99c2df4e17c2a1f9d30403128a729e49c4b14612","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-30 07:41:03.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8cfa535a6df0447eb7ff355ad8856e44\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e2eb96a39d8142bfb6194b72e5648f30 : SUCCESS in 48s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2a76dbc96edd4630af6e7a0cb8286c8d : SUCCESS in 43s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d3c5b615cfe02e72577a0b22d05641c26b2110a4","revisions":{"92d9eae439d86916700e023a3be64406115ba085":{"kind":"REWORK","_number":1,"created":"2026-05-31 13:38:37.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/22/990822/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/22/990822/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/22/990822/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/22/990822/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/22/990822/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/22/990822/1"}}},"commit":{"parents":[{"commit":"9ff4683c8212e4c043af69f1b5ebadc21651dc58","subject":"Merge \"Drop Python 3.10\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/9ff4683c8212e4c043af69f1b5ebadc21651dc58"}]}],"author":{"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","date":"2026-05-31 13:37:59.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","date":"2026-05-31 13:38:29.000000000","tz":540},"subject":"Remove unused [DEFAULT] octavia_plugins","message":"Remove unused [DEFAULT] octavia_plugins\n\nThis option has been unused since v1 API was removed.\n\nChange-Id: Ibe52f67f275a0ba90dc43d667f502f0c937e3291\nSigned-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/92d9eae439d86916700e023a3be64406115ba085"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/92d9eae439d86916700e023a3be64406115ba085"}]},"branch":"refs/heads/master"},"c144637e3d95d8cdf59d8164bb1acebcb0aaf956":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-05-31 13:40:32.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/22/990822/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/22/990822/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/22/990822/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/22/990822/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/22/990822/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/22/990822/2"}}},"commit":{"parents":[{"commit":"9ff4683c8212e4c043af69f1b5ebadc21651dc58","subject":"Merge \"Drop Python 3.10\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/9ff4683c8212e4c043af69f1b5ebadc21651dc58"}]}],"author":{"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","date":"2026-05-31 13:37:59.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","date":"2026-05-31 13:40:12.000000000","tz":540},"subject":"Remove unused [DEFAULT] octavia_plugins","message":"Remove unused [DEFAULT] octavia_plugins\n\nThis option has been unused since amphora v1 was removed [1].\n\n[1] 6c0515c9880b5310dd0647a5881233f07898d812\n\nChange-Id: Ibe52f67f275a0ba90dc43d667f502f0c937e3291\nSigned-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/c144637e3d95d8cdf59d8164bb1acebcb0aaf956"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/c144637e3d95d8cdf59d8164bb1acebcb0aaf956"}]},"branch":"refs/heads/master"},"d3c5b615cfe02e72577a0b22d05641c26b2110a4":{"kind":"REWORK","_number":3,"created":"2026-05-31 16:29:29.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/22/990822/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/22/990822/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/22/990822/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/22/990822/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/22/990822/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/22/990822/3"}}},"commit":{"parents":[{"commit":"9ff4683c8212e4c043af69f1b5ebadc21651dc58","subject":"Merge \"Drop Python 3.10\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/9ff4683c8212e4c043af69f1b5ebadc21651dc58"}]}],"author":{"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","date":"2026-05-31 13:37:59.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","date":"2026-05-31 16:28:59.000000000","tz":540},"subject":"Remove unused [DEFAULT] octavia_plugins","message":"Remove unused [DEFAULT] octavia_plugins\n\nThis option has been unused since amphora v1 was removed [1].\n\n[1] 6c0515c9880b5310dd0647a5881233f07898d812\n\nChange-Id: Ibe52f67f275a0ba90dc43d667f502f0c937e3291\nSigned-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/d3c5b615cfe02e72577a0b22d05641c26b2110a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/d3c5b615cfe02e72577a0b22d05641c26b2110a4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
