)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"2785ed757bb794c23c2da170bb7dd1a279abc32e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The change adds a new task file that checks if the installed version of the"},{"line_number":13,"context_line":"galera cluster matches that of the specified major version. The role will"},{"line_number":14,"context_line":"hard stop if there is a version missmatch and the option \"galera_upgrade\u003dtrue\""},{"line_number":15,"context_line":"is not passed."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I26560668325d45f670c8b946c978c48559f58419"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_cf8003c3","line":14,"updated":"2016-01-22 16:44:59.000000000","message":"mismatch","commit_id":"107dd50ea39f90cbd843f7a97d4d94ac3c2bfd7d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6ecb92524374b40f80727e986eb9cb8ee3a7b54e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"galera cluster matches that of the specified major version. The role will"},{"line_number":14,"context_line":"hard stop if there is a version missmatch and the option \"galera_upgrade\u003dtrue\""},{"line_number":15,"context_line":"is not passed."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I26560668325d45f670c8b946c978c48559f58419"},{"line_number":18,"context_line":"Signed-off-by: Kevin Carter \u003ckevin.carter@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_32b2644d","line":16,"updated":"2016-01-22 16:51:02.000000000","message":"I think that we should perhaps add a test to validate that this works too - maybe add one container with the old version first, then do an upgrade or something like that? Alternatively we can have a special job in -infra that does the upgrade.","commit_id":"107dd50ea39f90cbd843f7a97d4d94ac3c2bfd7d"}],"tasks/galera_running_check.yml":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"57ca138d735019425b4b7be6bc36db8a28588d3f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2015, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a5ae5dd_5361a6d2","line":2,"updated":"2016-02-09 03:59:18.000000000","message":"s/2015/2016/","commit_id":"6ef91bd8828d45cae6e7da4c4a521fb4ad3766c3"}],"tasks/galera_upgrade_check.yml":[{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"2785ed757bb794c23c2da170bb7dd1a279abc32e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2015, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a68dd71_2f575f59","line":2,"updated":"2016-01-22 16:44:59.000000000","message":"2016","commit_id":"107dd50ea39f90cbd843f7a97d4d94ac3c2bfd7d"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"033d15f511dff82b917496cce101f0732310247e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  service:"},{"line_number":53,"context_line":"    name: mysql"},{"line_number":54,"context_line":"    state: stopped"},{"line_number":55,"context_line":"  until: galera_restart_fall_back | success"},{"line_number":56,"context_line":"  retries: 3"},{"line_number":57,"context_line":"  delay: 5"},{"line_number":58,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a68dd71_72245c5f","line":55,"updated":"2016-01-22 16:55:48.000000000","message":"Ansible complains that a `register` is needed here, I think.\n\nroot@nolan-aio2:/opt/openstack-ansible/playbooks# openstack-ansible -vvv galera-install.yml\nVariable files: \"-e @/etc/openstack_deploy/user_secrets.yml -e @/etc/openstack_deploy/user_variables.yml \"\nERROR: register keyword is mandatory when using do until feature","commit_id":"107dd50ea39f90cbd843f7a97d4d94ac3c2bfd7d"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"b1e4d3da13d64716bfad8a51c69234dd8fd9104b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  service:"},{"line_number":53,"context_line":"    name: mysql"},{"line_number":54,"context_line":"    state: stopped"},{"line_number":55,"context_line":"  until: galera_restart_fall_back | success"},{"line_number":56,"context_line":"  retries: 3"},{"line_number":57,"context_line":"  delay: 5"},{"line_number":58,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a68dd71_d20bc88c","line":55,"in_reply_to":"9a68dd71_72245c5f","updated":"2016-01-22 16:59:22.000000000","message":"Yep, registering `galera_restart_fall_back` at least allows the task to execute instead of raising an error.","commit_id":"107dd50ea39f90cbd843f7a97d4d94ac3c2bfd7d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4cdc4c7341fda0a8ef43c0ba64ff986676973e2b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - galera_upgrade | bool"},{"line_number":69,"context_line":"  tags:"},{"line_number":70,"context_line":"    - galera-upgrade"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a68dd71_d22d0896","line":71,"updated":"2016-01-22 16:48:17.000000000","message":"We\u0027ll also have to remove any v5.5 apt sources.","commit_id":"107dd50ea39f90cbd843f7a97d4d94ac3c2bfd7d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a8d6e5fe0ee006527a857530d09684c7ce20532f","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: Find old sources"},{"line_number":65,"context_line":"  shell: |"},{"line_number":66,"context_line":"    grep -rnil maria /etc/apt/sources.list*"},{"line_number":67,"context_line":"  register: old_sources"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - galera-upgrade"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a68dd71_154aa555","line":66,"updated":"2016-01-22 18:46:49.000000000","message":"If this finds a mariadb entry in /etc/apt/sources.list then the task below will delete that file. I don\u0027t think that\u0027s a good idea. Shouldn\u0027t this just search /etc/apt/sources.list.d/* ?","commit_id":"95611d3ca364d7d1e76f6d954457f210a413014f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bdd2609b5aa087cbee190c6d2fd39c289909c0e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2015, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_880afc77","line":2,"updated":"2016-01-22 19:32:22.000000000","message":"Somehow the year here has reverted. It should be 2016.","commit_id":"e71ff838af2bf2a9f28b315eba1acaf78118e2a6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bdd2609b5aa087cbee190c6d2fd39c289909c0e0","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: Find old sources"},{"line_number":65,"context_line":"  shell: |"},{"line_number":66,"context_line":"    grep -rnil maria /etc/apt/sources.list*"},{"line_number":67,"context_line":"  register: old_sources"},{"line_number":68,"context_line":"  when:"},{"line_number":69,"context_line":"    - galera_upgrade | bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_081fecb7","line":66,"updated":"2016-01-22 19:32:22.000000000","message":"See my comment in PS2.","commit_id":"e71ff838af2bf2a9f28b315eba1acaf78118e2a6"}],"tasks/galera_upgrade_post.yml":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"4aa43e43cc22879be108dbf35d1c66201c30332e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# This is starting MySQL as it may be required to restart the service more than"},{"line_number":17,"context_line":"#  once to get it to clean up old service files from the previous version."},{"line_number":18,"context_line":"#  If the service fails to start after 3 attempts the shell command will be failed."},{"line_number":19,"context_line":"- name: Start MySQL"},{"line_number":20,"context_line":"  shell: |"},{"line_number":21,"context_line":"    for i in {1..3}; do"},{"line_number":22,"context_line":"      /etc/init.d/mysql start || true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a68dd71_498fb8cc","line":19,"updated":"2016-01-26 11:16:12.000000000","message":"This task assumes that there is an existing/active cluster for this node to join.\n\nWhy not use the existing service handler?","commit_id":"5577402dde96baf59bc09f266a431393dfb36f9e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7cb6bedd1820f722806f7093e8a37865a56e6052","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# This is starting MySQL as it may be required to restart the service more than"},{"line_number":17,"context_line":"#  once to get it to clean up old service files from the previous version."},{"line_number":18,"context_line":"#  If the service fails to start after 3 attempts the shell command will be failed."},{"line_number":19,"context_line":"- name: Start MySQL"},{"line_number":20,"context_line":"  shell: |"},{"line_number":21,"context_line":"    for i in {1..3}; do"},{"line_number":22,"context_line":"      /etc/init.d/mysql start || true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a68dd71_056d17cc","line":19,"in_reply_to":"9a68dd71_498fb8cc","updated":"2016-01-26 14:59:25.000000000","message":"This does assume the a cluster is available to join. I could however add in the additional option in our service handler to this shell command which would attempt to bootstrap a cluster should the cluster be dead. \n\nThe reason that the existing service handlers were not used was because in testing any given node, depending on the state of the node when it was taken down may require more than 1 restart of the service to actually start. I also found that the init script will always return 0 on the completion of the start function within it (even if the node failed to actually start). For this reason the base service handlers were not used for this case as mentioned in the comment above.","commit_id":"5577402dde96baf59bc09f266a431393dfb36f9e"}],"tasks/galera_upgrade_pre.yml":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"4aa43e43cc22879be108dbf35d1c66201c30332e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9a68dd71_e4aed397","updated":"2016-01-26 11:16:12.000000000","message":"The tasks in this file don\u0027t appear to be appropriately tagged. Specifically the use of the tag \u0027galera-apt-packages\u0027 with upgrades has the potential to cause issues as currently used.","commit_id":"5577402dde96baf59bc09f266a431393dfb36f9e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7cb6bedd1820f722806f7093e8a37865a56e6052","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9a68dd71_e578032e","in_reply_to":"9a68dd71_e4aed397","updated":"2016-01-26 14:59:25.000000000","message":"Done","commit_id":"5577402dde96baf59bc09f266a431393dfb36f9e"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"4aa43e43cc22879be108dbf35d1c66201c30332e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Set fact to ignore cluster state"},{"line_number":17,"context_line":"  set_fact:"},{"line_number":18,"context_line":"    galera_ignore_cluster_state: true"},{"line_number":19,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a68dd71_0986a065","line":16,"updated":"2016-01-26 11:16:12.000000000","message":"Why ignore the state? Isn\u0027t the purpose of that to make sure the cluster is healthy before making changes?","commit_id":"5577402dde96baf59bc09f266a431393dfb36f9e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7cb6bedd1820f722806f7093e8a37865a56e6052","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Set fact to ignore cluster state"},{"line_number":17,"context_line":"  set_fact:"},{"line_number":18,"context_line":"    galera_ignore_cluster_state: true"},{"line_number":19,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a68dd71_85e4a7ac","line":16,"in_reply_to":"9a68dd71_0986a065","updated":"2016-01-26 14:59:25.000000000","message":"Yes however the cluster will be in an unhealthy state as the upgrade rolls through the various nodes installing both the updated MariaDB client and a new version of XtraBackup. These packages will cause cluster instability on a per node basis as our plays serially iterate through the nodes in our cluster. While the cluster will remain online nodes will be taken down one at a time to perform the upgrade which would require us to set `galera_ignore_cluster_state\u003dtrue`.","commit_id":"5577402dde96baf59bc09f266a431393dfb36f9e"}]}
