)]}'
{"tasks/galera_cluster_state.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3949aeb7ca39625e01270ce4ea8344ee7bfe4ca1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  tags:"},{"line_number":32,"context_line":"    - galera-cluster-state-check"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Gather mysql facts"},{"line_number":35,"context_line":"  mysql_status_facts:"},{"line_number":36,"context_line":"  failed_when: false"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - galera-cluster-state-check"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Check for cluster state failure"},{"line_number":41,"context_line":"  fail:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_d766dab9","line":38,"range":{"start_line":34,"start_character":0,"end_line":38,"end_character":32},"updated":"2016-10-16 12:07:12.000000000","message":"The output is a lot nicer. With this patch we get:\n\nok: [container3] \u003d\u003e {\"changed\": false, \"failed\": false, \"failed_when_result\": false, \"invocation\": {\"module_args\": {}, \"module_name\": \"mysql_status_facts\"}, \"msg\": \"Mysql fact collection failed: \\\"ERROR 2003 (HY000): Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 (111 \\\"Connection refused\\\")\\\".\"}\n\nWithout this patch we have:\n\nfatal: [container1]: FAILED! \u003d\u003e {\"changed\": false, \"failed\": true, \"invocation\": {\"module_args\": {}, \"module_name\": \"mysql_status_facts\"}, \"msg\": \"Mysql fact collection failed: \\\"ERROR 2003 (HY000): Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 (111 \\\"Connection refused\\\")\\\".\"}\n...ignoring","commit_id":"fd2cf1eb08aa5d8d44b5c405fd0442552d37a1a6"}],"tasks/galera_install_apt.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3949aeb7ca39625e01270ce4ea8344ee7bfe4ca1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  retries: 5"},{"line_number":70,"context_line":"  delay: 2"},{"line_number":71,"context_line":"  with_items: \"{{ galera_gpg_keys }}\""},{"line_number":72,"context_line":"  when: add_keys|failed and (item.fallback_keyserver is defined or item.fallback_url is defined)"},{"line_number":73,"context_line":"  tags:"},{"line_number":74,"context_line":"    - galera-apt-keys"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_97f702d2","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":23},"updated":"2016-10-16 12:07:12.000000000","message":"I\u0027d like to verify that this works before giving this my vote.","commit_id":"fd2cf1eb08aa5d8d44b5c405fd0442552d37a1a6"}],"tasks/galera_install_yum.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d9e6508e35552212d44dfc821bc2178ab0dd5c81","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    key: \"{{ item.fallback_keyserver }}/{{ item.key_name }}\""},{"line_number":48,"context_line":"  register: add_keys"},{"line_number":49,"context_line":"  until: add_keys|success"},{"line_number":50,"context_line":"  failed_when: false"},{"line_number":51,"context_line":"  retries: 5"},{"line_number":52,"context_line":"  delay: 2"},{"line_number":53,"context_line":"  with_items: \"{{ galera_client_gpg_keys }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_375716cb","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":20},"updated":"2016-10-16 12:03:31.000000000","message":"I think we have a bug here - this task should cause a failure if it fails, not ignore the error.","commit_id":"fd2cf1eb08aa5d8d44b5c405fd0442552d37a1a6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2201ce8e9455538b16886d664dd419bdc59d7273","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    key: \"{{ item.fallback_keyserver }}/{{ item.key_name }}\""},{"line_number":48,"context_line":"  register: add_keys"},{"line_number":49,"context_line":"  until: add_keys|success"},{"line_number":50,"context_line":"  failed_when: false"},{"line_number":51,"context_line":"  retries: 5"},{"line_number":52,"context_line":"  delay: 2"},{"line_number":53,"context_line":"  with_items: \"{{ galera_client_gpg_keys }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_b7fb2646","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":20},"in_reply_to":"fa6399be_375716cb","updated":"2016-10-16 13:35:01.000000000","message":"Fixed in https://review.openstack.org/387037","commit_id":"fd2cf1eb08aa5d8d44b5c405fd0442552d37a1a6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ddc1bb545c5366bd3c59884f395a3218468ef084","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    key: \"{{ item.fallback_keyserver }}/{{ item.key_name }}\""},{"line_number":48,"context_line":"  register: add_keys"},{"line_number":49,"context_line":"  until: add_keys|success"},{"line_number":50,"context_line":"  ignore_errors: True"},{"line_number":51,"context_line":"  retries: 5"},{"line_number":52,"context_line":"  delay: 2"},{"line_number":53,"context_line":"  with_items: \"{{ galera_client_gpg_keys }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa6399be_42aa0686","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":21},"updated":"2016-10-16 14:46:40.000000000","message":"This is intentionally left behind as it shouldn\u0027t be here. This is removed in https://review.openstack.org/387037","commit_id":"5038acc3907c75d6a5ff1af6382e5abec4ea1650"}]}
