)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e0e64d8c1ad26ef7a48faeedc63b7699ad12b6b3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"galera_server_distro_package_pins: []"},{"line_number":43,"context_line":"galera_debconf_items: []"},{"line_number":44,"context_line":"galera_server_percona_distro_packages: []"},{"line_number":45,"context_line":"galera_mariadb_yum_server_package: \"{{ _galera_mariadb_yum_server_package }}\""},{"line_number":46,"context_line":"galera_yum_repo_url: \"{{ _galera_yum_repo_url }}\""},{"line_number":47,"context_line":"galera_mariadb_apt_server_package: \"{{ _galera_mariadb_apt_server_package }}\""},{"line_number":48,"context_line":"galera_apt_repo_url: \"{{ _galera_apt_repo_url }}\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"galera_existing_cluster: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a74a57a_2ba35b01","line":48,"range":{"start_line":45,"start_character":0,"end_line":48,"end_character":49},"updated":"2016-11-28 11:14:52.000000000","message":"Instead of doing this, perhaps we can take the approach we used in the RabbitMQ upgrade tests? See https://github.com/openstack/openstack-ansible-rabbitmq_server/blob/master/tests/test-vars.yml","commit_id":"21fad4b097c0f259dd2e1555c66ba5a0d7d39dee"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"a3d538c0a446189cd46ed84873446f821735113a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"galera_server_distro_package_pins: []"},{"line_number":43,"context_line":"galera_debconf_items: []"},{"line_number":44,"context_line":"galera_server_percona_distro_packages: []"},{"line_number":45,"context_line":"galera_mariadb_yum_server_package: \"{{ _galera_mariadb_yum_server_package }}\""},{"line_number":46,"context_line":"galera_yum_repo_url: \"{{ _galera_yum_repo_url }}\""},{"line_number":47,"context_line":"galera_mariadb_apt_server_package: \"{{ _galera_mariadb_apt_server_package }}\""},{"line_number":48,"context_line":"galera_apt_repo_url: \"{{ _galera_apt_repo_url }}\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"galera_existing_cluster: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a74a57a_d6851dcf","line":48,"range":{"start_line":45,"start_character":0,"end_line":48,"end_character":49},"in_reply_to":"5a74a57a_2ba35b01","updated":"2016-11-28 16:37:41.000000000","message":"I think we\u0027ll still need something like this to avoid problems with variable precedence with the task that includes OS specific vars.\nIt\u0027s still happening in the rabbit role too.\nhttps://github.com/openstack/openstack-ansible-rabbitmq_server/blob/master/defaults/main.yml#L36-L40\n\nI\u0027ve renamed the galera_apt/galera_yum repos so that there\u0027s not a difference in variable names themselves between OS\u0027s and the test vars are more similar to the rabbit role, but that rename needs to go back to the client role as well.","commit_id":"21fad4b097c0f259dd2e1555c66ba5a0d7d39dee"}],"tasks/galera_bootstrap.yml":[{"author":{"_account_id":21685,"name":"Andrew Garner","email":"andrew.garner@rackspace.com","username":"andrew.garner"},"change_message_id":"e268bead9bed4ec8342d9185483acbb5d3b0664a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  command: \"/etc/init.d/mysql bootstrap\""},{"line_number":34,"context_line":"  when:"},{"line_number":35,"context_line":"    - ansible_service_mgr \u003d\u003d \u0027systemd\u0027"},{"line_number":36,"context_line":"    - start_cluster | failed"},{"line_number":37,"context_line":"    - inventory_hostname \u003d\u003d galera_server_bootstrap_node"},{"line_number":38,"context_line":"    - mysql_running.rc !\u003d 0"},{"line_number":39,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a74a57a_f742d367","line":36,"updated":"2016-11-29 19:42:52.000000000","message":"Is there a good reason to fallback here?  This will start mysqld outside of the control of systemd - so a future galera_new_cluster / service/systemctl start action that runs through the systemd toolchain could start a second mysqld instance.   \n\nMariaDB 10.1 has a real systemd service rather than just wrapping the initscript as in earlier releases, so I\u0027ve seen mixing these paths more commonly be troublesome in practice in those environment.","commit_id":"f6ccd0dad0fa291536aa4eb28d3f04e38a73e906"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"4075e8ef2088b84ce0ada12553ea4ea9824e320b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  command: \"/etc/init.d/mysql bootstrap\""},{"line_number":34,"context_line":"  when:"},{"line_number":35,"context_line":"    - ansible_service_mgr \u003d\u003d \u0027systemd\u0027"},{"line_number":36,"context_line":"    - start_cluster | failed"},{"line_number":37,"context_line":"    - inventory_hostname \u003d\u003d galera_server_bootstrap_node"},{"line_number":38,"context_line":"    - mysql_running.rc !\u003d 0"},{"line_number":39,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a74a57a_f20821dc","line":36,"in_reply_to":"5a74a57a_f742d367","updated":"2016-11-30 02:59:50.000000000","message":"It\u0027s only to accommodate upgrade testing from 10.0 and should be removed once the project moves to 10.2.","commit_id":"f6ccd0dad0fa291536aa4eb28d3f04e38a73e906"}],"tasks/galera_install_yum.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e0e64d8c1ad26ef7a48faeedc63b7699ad12b6b3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - galera-gpg-keys"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"#TODO(cloudnull) Remove this task once we move to Ansible 2.1"},{"line_number":58,"context_line":"# where we can leverage the `yum_repository` module:"},{"line_number":59,"context_line":"# https://docs.ansible.com/ansible/yum_repository_module.html"},{"line_number":60,"context_line":"- name: Add galera repo"},{"line_number":61,"context_line":"  yum_repository:"},{"line_number":62,"context_line":"    name: \"{{ item.name }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a74a57a_2b07db18","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":61},"updated":"2016-11-28 11:14:52.000000000","message":"This comment should be removed seeing as the action is complete with this patch.","commit_id":"21fad4b097c0f259dd2e1555c66ba5a0d7d39dee"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"a3d538c0a446189cd46ed84873446f821735113a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - galera-gpg-keys"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"#TODO(cloudnull) Remove this task once we move to Ansible 2.1"},{"line_number":58,"context_line":"# where we can leverage the `yum_repository` module:"},{"line_number":59,"context_line":"# https://docs.ansible.com/ansible/yum_repository_module.html"},{"line_number":60,"context_line":"- name: Add galera repo"},{"line_number":61,"context_line":"  yum_repository:"},{"line_number":62,"context_line":"    name: \"{{ item.name }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a74a57a_36ad7188","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":61},"in_reply_to":"5a74a57a_2b07db18","updated":"2016-11-28 16:37:41.000000000","message":"Done","commit_id":"21fad4b097c0f259dd2e1555c66ba5a0d7d39dee"}],"tasks/galera_post_install.yml":[{"author":{"_account_id":21685,"name":"Andrew Garner","email":"andrew.garner@rackspace.com","username":"andrew.garner"},"change_message_id":"e268bead9bed4ec8342d9185483acbb5d3b0664a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    dest: /etc/init.d/mysql"},{"line_number":64,"context_line":"    state: present"},{"line_number":65,"context_line":"    insertafter: \u0027^export HOME\u003d/etc/mysql/\u0027"},{"line_number":66,"context_line":"    line: \u0027[ -r /etc/default/mariadb ] \u0026\u0026 . /etc/default/mariadb\u0027"},{"line_number":67,"context_line":"    backup: yes"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - galera-config"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a74a57a_b2b5c932","line":66,"updated":"2016-11-29 19:42:52.000000000","message":"Worth noting here that mariadb 10.1+systemd won\u0027t honor these timeouts anymore.  I think some systemd path is probably needed around here to set the systemd Timeout(Start|Stop)?Sec directive for the service.   The start/stop timeouts default to 5min for the MGC 10.0 systemd+sysv path (and the initscript in turn was using the timeouts defined here), but I believe this defaults to 90s for normal systemd services.","commit_id":"f6ccd0dad0fa291536aa4eb28d3f04e38a73e906"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"4075e8ef2088b84ce0ada12553ea4ea9824e320b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    dest: /etc/init.d/mysql"},{"line_number":64,"context_line":"    state: present"},{"line_number":65,"context_line":"    insertafter: \u0027^export HOME\u003d/etc/mysql/\u0027"},{"line_number":66,"context_line":"    line: \u0027[ -r /etc/default/mariadb ] \u0026\u0026 . /etc/default/mariadb\u0027"},{"line_number":67,"context_line":"    backup: yes"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - galera-config"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a74a57a_0dfd7c6e","line":66,"in_reply_to":"5a74a57a_b2b5c932","updated":"2016-11-30 02:59:50.000000000","message":"Good catch, I\u0027ll look into this.","commit_id":"f6ccd0dad0fa291536aa4eb28d3f04e38a73e906"}],"tests/test.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8b854b586430f69dccfa132044585fce86e50761","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  vars:"},{"line_number":25,"context_line":"    galera_mariadb_server_package: \"{{ galera_server_old_package[ansible_os_family | lower][\u0027galera_mariadb_server_package\u0027] }}\""},{"line_number":26,"context_line":"    galera_repo_url: \"{{ galera_server_old_package[ansible_os_family | lower][\u0027galera_repo_url\u0027] }}\""},{"line_number":27,"context_line":"    galera_client_yum_repo_url: \"http://yum.mariadb.org/10.0/centos/7/x86_64\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Run functional tests"},{"line_number":30,"context_line":"- include: test-galera-server-functional.yml"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5a74a57a_c8146da1","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":77},"updated":"2016-11-29 12:28:39.000000000","message":"Perhaps the client should be adjusted to use the same var name across platforms so that this is not necessary.","commit_id":"3e03cc77c74396aca790cb189a4ab7bb50c89f79"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"1e5a5d1ecaa13c9eb5ee419c6047e522912cc765","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  vars:"},{"line_number":25,"context_line":"    galera_mariadb_server_package: \"{{ galera_server_old_package[ansible_os_family | lower][\u0027galera_mariadb_server_package\u0027] }}\""},{"line_number":26,"context_line":"    galera_repo_url: \"{{ galera_server_old_package[ansible_os_family | lower][\u0027galera_repo_url\u0027] }}\""},{"line_number":27,"context_line":"    galera_client_yum_repo_url: \"http://yum.mariadb.org/10.0/centos/7/x86_64\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Run functional tests"},{"line_number":30,"context_line":"- include: test-galera-server-functional.yml"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5a74a57a_cd5552fa","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":77},"in_reply_to":"5a74a57a_c8146da1","updated":"2016-11-29 15:40:51.000000000","message":"This was just a test, it didn\u0027t work and shouldn\u0027t be needed.","commit_id":"3e03cc77c74396aca790cb189a4ab7bb50c89f79"}]}