)]}'
{"defaults/main.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"c33a9150c22d27e2616492db0e77864f949f3032","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# Galera Server SSL functionality. SSL options should be configured if galera_server_ssl is True"},{"line_number":124,"context_line":"galera_server_ssl: False"},{"line_number":125,"context_line":"#galera_server_ssl_ca_cert: \"/etc/mysql/ssl/galera-ca.crt\""},{"line_number":126,"context_line":"#galera_server_ssl_cert: \"/etc/mysql/ssl/galera.crt\""},{"line_number":127,"context_line":"#galera_server_ssl_key: \"/etc/mysql/ssl/galera.key\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_0bbb40e6","line":125,"updated":"2017-01-27 20:04:31.000000000","message":"If these 3 vars represent the cert that should be distributed to the galera containers, then please follow the naming convention used here: https://github.com/openstack/openstack-ansible-os_keystone/blob/master/defaults/main.yml#L233 and the construct of \u003cpath to cert on ansible deployment host\u003e for doc purposes.\n\nFurther, it would be good to see some role level documentation in the docs/ dir for this change.","commit_id":"de89931ad48ed3ff40bd0cafbc6f06c8fcee948b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8cfb5ab5c0e55589fb82dc0515ff04a6a87bbbe5","unresolved":false,"context_lines":[{"line_number":121,"context_line":"qpress_package_path: \"/opt/{{ qpress_package_url | basename }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# Galera Server SSL functionality. SSL options should be configured if galera_server_ssl is True"},{"line_number":124,"context_line":"galera_server_ssl: False"},{"line_number":125,"context_line":"#galera_user_ssl_ca_cert: \u003cpath to CA cert on ansible deployment host\u003e"},{"line_number":126,"context_line":"#galera_user_ssl_cert: \u003cpath to the cert on ansible deployment host\u003e"},{"line_number":127,"context_line":"#galera_user_ssl_key: \u003cpath to the key on ansible deployment host\u003e"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a461143_9d0668cc","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":24},"updated":"2017-01-30 14:24:32.000000000","message":"I\u0027m thinking that SSL enabled should be true by default and folks can disbale it when if they don\u0027t want it.","commit_id":"0744da4577307b06af8f4cb3cafeac41f6c616e6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"54e76c4c3c4d3a92752cf5fe7b73072ae472588e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"galera_ssl_ca_key: /etc/mysql/ssl/galera-ca.key"},{"line_number":132,"context_line":"galera_ssl_req: /etc/mysql/ssl/galera-req.pem"},{"line_number":133,"context_line":"# This option is used for creating the CA and overriding the Galera address on the clients side"},{"line_number":134,"context_line":"galera_ssl_address: \"{{ internal_lb_vip_address }}\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# Set galera_ssl_self_signed_regen to true if you want to generate a new"},{"line_number":137,"context_line":"# SSL certificate for Galera when this playbook runs.  You can also change"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a1ced50_d15545fa","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":47},"updated":"2017-03-21 15:49:17.000000000","message":"For the role this should just be the node\u0027s address. In the integrated build you should apply this value in group_vars as an override to the role default.","commit_id":"dad482ca9a8e3ab014ebcbb34768a78502280ee6"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"f268e6a6a8e7996c6f53229ebae82a621c5e3824","unresolved":false,"context_lines":[{"line_number":131,"context_line":"galera_ssl_ca_key: /etc/mysql/ssl/galera-ca.key"},{"line_number":132,"context_line":"galera_ssl_req: /etc/mysql/ssl/galera-req.pem"},{"line_number":133,"context_line":"# This option is used for creating the CA and overriding the Galera address on the clients side"},{"line_number":134,"context_line":"galera_ssl_address: \"{{ internal_lb_vip_address }}\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# Set galera_ssl_self_signed_regen to true if you want to generate a new"},{"line_number":137,"context_line":"# SSL certificate for Galera when this playbook runs.  You can also change"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a1ced50_e7a8c3dd","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":47},"in_reply_to":"1a1ced50_d15545fa","updated":"2017-03-21 16:07:56.000000000","message":"Done","commit_id":"dad482ca9a8e3ab014ebcbb34768a78502280ee6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"54e76c4c3c4d3a92752cf5fe7b73072ae472588e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"# Set galera_ssl_self_signed_regen to true if you want to generate a new"},{"line_number":137,"context_line":"# SSL certificate for Galera when this playbook runs.  You can also change"},{"line_number":138,"context_line":"# the subject of the self-signed certificate here if you prefer."},{"line_number":139,"context_line":"galera_self_signed_dir: /tmp/galera-self-signed-certs"},{"line_number":140,"context_line":"galera_ssl_self_signed_regen: false"},{"line_number":141,"context_line":"galera_ssl_self_signed_subject: \"/C\u003dUS/ST\u003dTexas/L\u003dSan Antonio/O\u003dIT/CN\u003d{{ galera_ssl_address }}\""},{"line_number":142,"context_line":"galera_ssl_ca_self_signed_subject: \"/C\u003dUS/ST\u003dTexas/L\u003dSan Antonio/O\u003dIT\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a1ced50_512eb5a5","line":139,"range":{"start_line":139,"start_character":24,"end_line":139,"end_character":53},"updated":"2017-03-21 15:49:17.000000000","message":"Is there a reason why you wouldn\u0027t want to use a more permanent storage space for this? eg: /etc/openstack_deploy/files/galera","commit_id":"dad482ca9a8e3ab014ebcbb34768a78502280ee6"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"f268e6a6a8e7996c6f53229ebae82a621c5e3824","unresolved":false,"context_lines":[{"line_number":136,"context_line":"# Set galera_ssl_self_signed_regen to true if you want to generate a new"},{"line_number":137,"context_line":"# SSL certificate for Galera when this playbook runs.  You can also change"},{"line_number":138,"context_line":"# the subject of the self-signed certificate here if you prefer."},{"line_number":139,"context_line":"galera_self_signed_dir: /tmp/galera-self-signed-certs"},{"line_number":140,"context_line":"galera_ssl_self_signed_regen: false"},{"line_number":141,"context_line":"galera_ssl_self_signed_subject: \"/C\u003dUS/ST\u003dTexas/L\u003dSan Antonio/O\u003dIT/CN\u003d{{ galera_ssl_address }}\""},{"line_number":142,"context_line":"galera_ssl_ca_self_signed_subject: \"/C\u003dUS/ST\u003dTexas/L\u003dSan Antonio/O\u003dIT\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a1ced50_44e6f544","line":139,"range":{"start_line":139,"start_character":24,"end_line":139,"end_character":53},"in_reply_to":"1a1ced50_512eb5a5","updated":"2017-03-21 16:07:56.000000000","message":"This is exactly the issue I was struggling with. It doesn\u0027t work on the gates because Ubuntu user cannot write into /etc.\nI suggest to change it in the group_vars or just exclude the self-signed cert generation in the role completely.","commit_id":"dad482ca9a8e3ab014ebcbb34768a78502280ee6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f18d860de4d645eec8009c3a2a416d10f8fcd678","unresolved":false,"context_lines":[{"line_number":133,"context_line":"# This option is used for creating the CA and overriding the Galera address on the clients side"},{"line_number":134,"context_line":"# Should be set to either public VIP of VIP FQDN, depending on what is currently used in the env."},{"line_number":135,"context_line":"galera_ssl_address: \"{{ ansible_host }}\""},{"line_number":136,"context_line":"# The folder for storing self-signed certificates and keys on the deployment host."},{"line_number":137,"context_line":"galera_self_signed_dir: /etc/openstack_deploy/files/self-signed-certs"},{"line_number":138,"context_line":"# Set galera_ssl_self_signed_regen to true if you want to generate a new"},{"line_number":139,"context_line":"# SSL certificate for Galera when this playbook runs.  You can also change"},{"line_number":140,"context_line":"# the subject of the self-signed certificate here if you prefer."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_a5bba80c","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":69},"updated":"2017-03-23 20:15:26.000000000","message":"This should not be necessary - we\u0027re requiring an extra var and extra folder. Ideally just the galera_user_* vars should be needed and should always be defaulted.","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"5975e33ab2a5e27b108d9756b0c13376677cf3ae","unresolved":false,"context_lines":[{"line_number":133,"context_line":"# This option is used for creating the CA and overriding the Galera address on the clients side"},{"line_number":134,"context_line":"# Should be set to either public VIP of VIP FQDN, depending on what is currently used in the env."},{"line_number":135,"context_line":"galera_ssl_address: \"{{ ansible_host }}\""},{"line_number":136,"context_line":"# The folder for storing self-signed certificates and keys on the deployment host."},{"line_number":137,"context_line":"galera_self_signed_dir: /etc/openstack_deploy/files/self-signed-certs"},{"line_number":138,"context_line":"# Set galera_ssl_self_signed_regen to true if you want to generate a new"},{"line_number":139,"context_line":"# SSL certificate for Galera when this playbook runs.  You can also change"},{"line_number":140,"context_line":"# the subject of the self-signed certificate here if you prefer."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_282c0f46","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":69},"in_reply_to":"ffe62b97_a5bba80c","updated":"2017-03-23 20:40:12.000000000","message":"This is, again, for allowing the users to Not store the certs to default location (which in some cases may not be available for writing)","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c2e379cd78f165e4fa42f3090791c64bdf4d0de9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"galera_user_ssl_cert: /etc/openstack_deploy/self_signed_certs/galera.pem"},{"line_number":133,"context_line":"galera_user_ssl_key: /etc/openstack_deploy/self_signed_certs/galera.key"},{"line_number":134,"context_line":"galera_user_ssl_ca_cert: /etc/openstack_deploy/self_signed_certs/galera-ca.pem"},{"line_number":135,"context_line":"# This option is used for creating the CA and overriding the Galera address on the clients side"},{"line_number":136,"context_line":"# Should be set to either public VIP of VIP FQDN, depending on what is currently used in the env."},{"line_number":137,"context_line":"galera_ssl_address: \"{{ ansible_host }}\""},{"line_number":138,"context_line":"# The folder for storing self-signed certificates and keys on the deployment host."},{"line_number":139,"context_line":"#galera_self_signed_dir: /etc/openstack_deploy/files/self-signed-certs"},{"line_number":140,"context_line":"# Set galera_ssl_self_signed_regen to true if you want to generate a new"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"ffe62b97_33511464","line":137,"range":{"start_line":135,"start_character":0,"end_line":137,"end_character":40},"updated":"2017-03-30 14:39:22.000000000","message":"nit: This is perhaps best moved down to the rest of the vars related to self signed certs.","commit_id":"32013506e5cc7d28f1b117401350702f6df961d5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c2e379cd78f165e4fa42f3090791c64bdf4d0de9","unresolved":false,"context_lines":[{"line_number":136,"context_line":"# Should be set to either public VIP of VIP FQDN, depending on what is currently used in the env."},{"line_number":137,"context_line":"galera_ssl_address: \"{{ ansible_host }}\""},{"line_number":138,"context_line":"# The folder for storing self-signed certificates and keys on the deployment host."},{"line_number":139,"context_line":"#galera_self_signed_dir: /etc/openstack_deploy/files/self-signed-certs"},{"line_number":140,"context_line":"# Set galera_ssl_self_signed_regen to true if you want to generate a new"},{"line_number":141,"context_line":"# SSL certificate for Galera when this playbook runs.  You can also change"},{"line_number":142,"context_line":"# the subject of the self-signed certificate here if you prefer."}],"source_content_type":"text/x-yaml","patch_set":32,"id":"ffe62b97_33d6b4c5","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":70},"updated":"2017-03-30 14:39:22.000000000","message":"nit: This is unused, remove it.","commit_id":"32013506e5cc7d28f1b117401350702f6df961d5"}],"galera_s.patch":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3a461143_c81fe2b5","updated":"2017-02-01 23:18:07.000000000","message":"patch file should be deleted.","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"}],"root@192.168.122.23":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3a461143_c848c2cf","updated":"2017-02-01 23:18:07.000000000","message":"patch file should be deleted.","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"}],"tasks/galera_post_install.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3a461143_c8fb6246","updated":"2017-02-01 23:18:07.000000000","message":"creating a conditional list should ensure all required data is provided resulting in the expected execution path.","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- include: galera_ssl_self_signed.yml"},{"line_number":33,"context_line":"  when: \u003e"},{"line_number":34,"context_line":"        galera_user_ssl_cert is not defined or"},{"line_number":35,"context_line":"        galera_user_ssl_key is not defined"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- include: galera_ssl_user_provided.yml"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a461143_c8e442ae","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":42},"updated":"2017-02-01 23:18:07.000000000","message":"we can probably lump these together like so:\n\n  when:\n    - galera_ssl | bool\n    - galera_user_ssl_cert is not defined\n    - galera_user_ssl_key is not defined","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        galera_user_ssl_cert is not defined or"},{"line_number":35,"context_line":"        galera_user_ssl_key is not defined"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- include: galera_ssl_user_provided.yml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Drop mariadb config(s)"},{"line_number":40,"context_line":"  config_template:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a461143_48d052ca","line":37,"updated":"2017-02-01 23:18:07.000000000","message":"this should have a when clause on it limited its execute. something like:\n\n    when:\n      - galera_ssl | bool\n      - galera_user_ssl_cert is defined \n      - galera_user_ssl_key is defined","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3e43abb6342373e8aa8c7158aaa8633904cefdf4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"- include: galera_ssl_self_signed.yml"},{"line_number":33,"context_line":"  when: \u003e"},{"line_number":34,"context_line":"        galera_user_ssl_cert is not defined or"},{"line_number":35,"context_line":"        galera_user_ssl_key is not defined"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- include: galera_ssl_user_provided.yml"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a1ff146_c5aa5119","line":35,"updated":"2017-03-15 10:58:48.000000000","message":"could you add\ntags:\n  - galera_server-config","commit_id":"96f1f757c451d5064b2e65397540f571da36d82a"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3e43abb6342373e8aa8c7158aaa8633904cefdf4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        galera_user_ssl_cert is not defined or"},{"line_number":35,"context_line":"        galera_user_ssl_key is not defined"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- include: galera_ssl_user_provided.yml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Drop mariadb config(s)"},{"line_number":40,"context_line":"  config_template:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a1ff146_0563891b","line":37,"updated":"2017-03-15 10:58:48.000000000","message":"tags:\n  - galera_server-config","commit_id":"96f1f757c451d5064b2e65397540f571da36d82a"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"95a4749c9e08b4ea49293cce4aab6a866e59bf14","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- include: galera_ssl_self_signed.yml"},{"line_number":33,"context_line":"  when: \u003e"},{"line_number":34,"context_line":"        ( galera_use_ssl | bool ) and"},{"line_number":35,"context_line":"        ( galera_user_ssl_cert is not defined or"},{"line_number":36,"context_line":"        galera_user_ssl_key is not defined )"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - galera-config"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_8289ba27","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":44},"updated":"2017-03-23 20:13:30.000000000","message":"could you please use the list format?","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cf66872a9b1b55ac3d3e6e681d75c7c5e4ee4ac1","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- include: galera_ssl_self_signed.yml"},{"line_number":33,"context_line":"  when: \u003e"},{"line_number":34,"context_line":"        ( galera_use_ssl | bool ) and"},{"line_number":35,"context_line":"        ( galera_user_ssl_cert is not defined or"},{"line_number":36,"context_line":"        galera_user_ssl_key is not defined )"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - galera-config"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_e8d86780","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":44},"in_reply_to":"ffe62b97_6566c054","updated":"2017-03-23 20:36:13.000000000","message":"when:\n    - galera_use_ssl | bool\n    - galera_user_ssl_cert is not defined or galera_user_ssl_key is not defined","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"bc1b257bef2f05a90b24b18ea36d091077720136","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- include: galera_ssl_self_signed.yml"},{"line_number":33,"context_line":"  when: \u003e"},{"line_number":34,"context_line":"        ( galera_use_ssl | bool ) and"},{"line_number":35,"context_line":"        ( galera_user_ssl_cert is not defined or"},{"line_number":36,"context_line":"        galera_user_ssl_key is not defined )"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - galera-config"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_6566c054","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":44},"in_reply_to":"ffe62b97_8289ba27","updated":"2017-03-23 20:33:43.000000000","message":"I can\u0027t because I need \"and\" and \"or\"","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f18d860de4d645eec8009c3a2a416d10f8fcd678","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  tags:"},{"line_number":30,"context_line":"    - galera-config"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- include: galera_ssl_self_signed.yml"},{"line_number":33,"context_line":"  when: \u003e"},{"line_number":34,"context_line":"        ( galera_use_ssl | bool ) and"},{"line_number":35,"context_line":"        ( galera_user_ssl_cert is not defined or"},{"line_number":36,"context_line":"        galera_user_ssl_key is not defined )"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - galera-config"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- include: galera_ssl_user_provided.yml"},{"line_number":41,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_c5010cb2","line":38,"range":{"start_line":32,"start_character":0,"end_line":38,"end_character":19},"updated":"2017-03-23 20:15:26.000000000","message":"Ideally there should be a check for the user provided files. If they don\u0027t exist then this should execute, but execute on the deployment host. The deployment host has better entropy than the containers, so the key/cert pair is more secure.\n\nThe files created should match the user-provided var values.","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"bc1b257bef2f05a90b24b18ea36d091077720136","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  tags:"},{"line_number":30,"context_line":"    - galera-config"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- include: galera_ssl_self_signed.yml"},{"line_number":33,"context_line":"  when: \u003e"},{"line_number":34,"context_line":"        ( galera_use_ssl | bool ) and"},{"line_number":35,"context_line":"        ( galera_user_ssl_cert is not defined or"},{"line_number":36,"context_line":"        galera_user_ssl_key is not defined )"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - galera-config"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- include: galera_ssl_user_provided.yml"},{"line_number":41,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_88755b9b","line":38,"range":{"start_line":32,"start_character":0,"end_line":38,"end_character":19},"in_reply_to":"ffe62b97_c5010cb2","updated":"2017-03-23 20:33:43.000000000","message":"it checks for both \"galera_user_ssl_cert\" and \"galera_user_ssl_key\"... :/","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f18d860de4d645eec8009c3a2a416d10f8fcd678","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    - galera-config"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- include: galera_ssl_user_provided.yml"},{"line_number":41,"context_line":"  when:"},{"line_number":42,"context_line":"        galera_use_ssl | bool"},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - galera-config"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_656480ba","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":29},"updated":"2017-03-23 20:15:26.000000000","message":"This should actually be:\n\n  when:\n    - galera_use_ssl | bool","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"95a4749c9e08b4ea49293cce4aab6a866e59bf14","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- include: galera_ssl_user_provided.yml"},{"line_number":41,"context_line":"  when:"},{"line_number":42,"context_line":"        galera_use_ssl | bool"},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - galera-config"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_628eb62f","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":29},"updated":"2017-03-23 20:13:30.000000000","message":"could you please indent the usual way?","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- include: galera_ssl.yml"},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - ( galera_use_ssl | bool )"},{"line_number":35,"context_line":"  tags:"},{"line_number":36,"context_line":"    - galera-config"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_c2a710bd","line":34,"range":{"start_line":34,"start_character":6,"end_line":34,"end_character":7},"updated":"2017-03-28 18:05:30.000000000","message":"nit: ( not really necessary.","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - ( galera_use_ssl | bool )"},{"line_number":35,"context_line":"  tags:"},{"line_number":36,"context_line":"    - galera-config"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Drop mariadb config(s)"},{"line_number":39,"context_line":"  config_template:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_2546c6c1","line":36,"updated":"2017-03-28 18:05:30.000000000","message":"add \ngalera-ssl tag here to avoid duplication, but keep galera-config! :)","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"}],"tasks/galera_ssl.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d56e35c30af75b532b5c66f884f97de1fa77c936","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Check if SSL bundle exists"},{"line_number":17,"context_line":"  connection: local"},{"line_number":18,"context_line":"  stat:"},{"line_number":19,"context_line":"    path: \"{{ item.path }}\""},{"line_number":20,"context_line":"  register: \"{{ item.res }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ffe62b97_48432f14","line":17,"updated":"2017-03-28 14:02:50.000000000","message":"Move to local_action instead please.","commit_id":"e22125aae17c52ce7b07a59a0c07edb68cbe08f7"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"298155d59c5769e5689aa971e59ca52a4ab368c9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Check if SSL bundle exists"},{"line_number":17,"context_line":"  connection: local"},{"line_number":18,"context_line":"  stat:"},{"line_number":19,"context_line":"    path: \"{{ item.path }}\""},{"line_number":20,"context_line":"  register: \"{{ item.res }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ffe62b97_49b56e7d","line":17,"in_reply_to":"ffe62b97_48432f14","updated":"2017-03-28 15:52:55.000000000","message":"seems local_action is made for commands. Turned to delegate_to","commit_id":"e22125aae17c52ce7b07a59a0c07edb68cbe08f7"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d56e35c30af75b532b5c66f884f97de1fa77c936","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - not _galera_ssl_ca_cert.stat.exists"},{"line_number":29,"context_line":"    - not _galera_ssl_cert.stat.exists"},{"line_number":30,"context_line":"    - not _galera_ssl_key.stat.exists"},{"line_number":31,"context_line":"    - inventory_hostname \u003d\u003d galera_cluster_members[0]"},{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - galera-ssl"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ffe62b97_485c4fec","line":31,"updated":"2017-03-28 14:02:50.000000000","message":"please use ansible_play_hosts[0] or run_once.","commit_id":"e22125aae17c52ce7b07a59a0c07edb68cbe08f7"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"298155d59c5769e5689aa971e59ca52a4ab368c9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - not _galera_ssl_ca_cert.stat.exists"},{"line_number":29,"context_line":"    - not _galera_ssl_cert.stat.exists"},{"line_number":30,"context_line":"    - not _galera_ssl_key.stat.exists"},{"line_number":31,"context_line":"    - inventory_hostname \u003d\u003d galera_cluster_members[0]"},{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - galera-ssl"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ffe62b97_88c497f6","line":31,"in_reply_to":"ffe62b97_485c4fec","updated":"2017-03-28 15:52:55.000000000","message":"removed","commit_id":"e22125aae17c52ce7b07a59a0c07edb68cbe08f7"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d56e35c30af75b532b5c66f884f97de1fa77c936","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    - { src: \"{{ galera_user_ssl_ca_cert }}\", dest: \"{{ galera_ssl_ca_cert }}\" }"},{"line_number":54,"context_line":"    - { src: \"{{ galera_user_ssl_cert }}\", dest: \"{{ galera_ssl_cert }}\" }"},{"line_number":55,"context_line":"    - { src: \"{{ galera_user_ssl_key }}\", dest: \"{{ galera_ssl_key }}\", mode: \"0600\" }"},{"line_number":56,"context_line":"  when:"},{"line_number":57,"context_line":"    - galera_user_ssl_ca_cert is defined"},{"line_number":58,"context_line":"    - galera_user_ssl_cert is defined"},{"line_number":59,"context_line":"    - galera_user_ssl_key is defined"},{"line_number":60,"context_line":"  tags:"},{"line_number":61,"context_line":"    - galera-ssl"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ffe62b97_88349794","line":59,"range":{"start_line":56,"start_character":0,"end_line":59,"end_character":36},"updated":"2017-03-28 14:02:50.000000000","message":"Shouldn\u0027t we copy in all cases?","commit_id":"e22125aae17c52ce7b07a59a0c07edb68cbe08f7"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"298155d59c5769e5689aa971e59ca52a4ab368c9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    - { src: \"{{ galera_user_ssl_ca_cert }}\", dest: \"{{ galera_ssl_ca_cert }}\" }"},{"line_number":54,"context_line":"    - { src: \"{{ galera_user_ssl_cert }}\", dest: \"{{ galera_ssl_cert }}\" }"},{"line_number":55,"context_line":"    - { src: \"{{ galera_user_ssl_key }}\", dest: \"{{ galera_ssl_key }}\", mode: \"0600\" }"},{"line_number":56,"context_line":"  when:"},{"line_number":57,"context_line":"    - galera_user_ssl_ca_cert is defined"},{"line_number":58,"context_line":"    - galera_user_ssl_cert is defined"},{"line_number":59,"context_line":"    - galera_user_ssl_key is defined"},{"line_number":60,"context_line":"  tags:"},{"line_number":61,"context_line":"    - galera-ssl"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ffe62b97_288a2bbe","line":59,"range":{"start_line":56,"start_character":0,"end_line":59,"end_character":36},"in_reply_to":"ffe62b97_88349794","updated":"2017-03-28 15:52:55.000000000","message":"yeah, sorry, copied form the initial file. Changing","commit_id":"e22125aae17c52ce7b07a59a0c07edb68cbe08f7"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  delegate_to: localhost"},{"line_number":20,"context_line":"  register: \"{{ item.res }}\""},{"line_number":21,"context_line":"  with_items:"},{"line_number":22,"context_line":"    - { path: \"{{ galera_user_ssl_ca_cert }}\", res: \"_galera_ssl_ca_cert\" }"},{"line_number":23,"context_line":"    - { path: \"{{ galera_user_ssl_cert }}\", res: \"_galera_ssl_cert\" }"},{"line_number":24,"context_line":"    - { path: \"{{ galera_user_ssl_key }}\", res: \"_galera_ssl_key\" }"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_e290d445","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":7},"updated":"2017-03-28 18:05:30.000000000","message":"could you adopt a cleaner yaml notation?\n- path: \u003cNEWLINE\u003e\n  res:","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  copy:"},{"line_number":46,"context_line":"    src: \"{{ item.src }}\""},{"line_number":47,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":48,"context_line":"    owner: \"mysql\""},{"line_number":49,"context_line":"    group: \"mysql\""},{"line_number":50,"context_line":"    mode: \"{{ item.mode|default(\u00270640\u0027) }}\""},{"line_number":51,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_82b468d2","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":17},"updated":"2017-03-28 18:05:30.000000000","message":"shouldn\u0027t this be a var depending on the os?\nOr do all the oses have the same user name?","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"b4beae71ee15dad35b4cbb8b1ae268255725df5a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  copy:"},{"line_number":46,"context_line":"    src: \"{{ item.src }}\""},{"line_number":47,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":48,"context_line":"    owner: \"mysql\""},{"line_number":49,"context_line":"    group: \"mysql\""},{"line_number":50,"context_line":"    mode: \"{{ item.mode|default(\u00270640\u0027) }}\""},{"line_number":51,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_f6b2d648","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":17},"in_reply_to":"ffe62b97_82b468d2","updated":"2017-03-28 19:13:36.000000000","message":"verified - centos and ubuntu has same user names for mysql.","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    owner: \"mysql\""},{"line_number":49,"context_line":"    group: \"mysql\""},{"line_number":50,"context_line":"    mode: \"{{ item.mode|default(\u00270640\u0027) }}\""},{"line_number":51,"context_line":"  with_items:"},{"line_number":52,"context_line":"    - { src: \"{{ galera_user_ssl_ca_cert }}\", dest: \"{{ galera_ssl_ca_cert }}\" }"},{"line_number":53,"context_line":"    - { src: \"{{ galera_user_ssl_cert }}\", dest: \"{{ galera_ssl_cert }}\" }"},{"line_number":54,"context_line":"    - { src: \"{{ galera_user_ssl_key }}\", dest: \"{{ galera_ssl_key }}\", mode: \"0600\" }"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_22aa3c70","line":51,"updated":"2017-03-28 18:05:30.000000000","message":"same here","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"}],"tasks/galera_ssl_key_create.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2015, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a461143_6810aea9","line":2,"updated":"2017-02-01 23:18:07.000000000","message":"boiler plate should reflect the company or owner of the patch","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3e43abb6342373e8aa8c7158aaa8633904cefdf4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    mode: \"{{ item.mode|default(\u00270640\u0027) }}\""},{"line_number":75,"context_line":"  with_items:"},{"line_number":76,"context_line":"    - { path: \"{{ galera_ssl_ca_cert }}\" }"},{"line_number":77,"context_line":"    - { path: \"{{ galera_ssl_key }}\" }"},{"line_number":78,"context_line":"    - { path: \"{{ galera_ssl_cert }}\", mode: \"0600\" }"},{"line_number":79,"context_line":"  tags:"},{"line_number":80,"context_line":"    - galera-ssl"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a1ff146_e52cadad","line":77,"updated":"2017-03-15 10:58:48.000000000","message":"Why has the key higher permissions than the cert? shouldn\u0027t it also be \"0600\" ?","commit_id":"96f1f757c451d5064b2e65397540f571da36d82a"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"95a4749c9e08b4ea49293cce4aab6a866e59bf14","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \"{{ galera_ssl_ca_self_signed_subject }}\""},{"line_number":38,"context_line":"    -keyout {{ galera_ssl_ca_key }}"},{"line_number":39,"context_line":"    -out {{ galera_ssl_ca_cert }}"},{"line_number":40,"context_line":"    creates\u003d{{ galera_ssl_ca_cert }}"},{"line_number":41,"context_line":"  tags:"},{"line_number":42,"context_line":"    - galera-ssl"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_e593f0a2","line":40,"updated":"2017-03-23 20:13:30.000000000","message":"args:\n  creates:","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"5975e33ab2a5e27b108d9756b0c13376677cf3ae","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \"{{ galera_ssl_ca_self_signed_subject }}\""},{"line_number":38,"context_line":"    -keyout {{ galera_ssl_ca_key }}"},{"line_number":39,"context_line":"    -out {{ galera_ssl_ca_cert }}"},{"line_number":40,"context_line":"    creates\u003d{{ galera_ssl_ca_cert }}"},{"line_number":41,"context_line":"  tags:"},{"line_number":42,"context_line":"    - galera-ssl"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_08f82bc2","line":40,"in_reply_to":"ffe62b97_e593f0a2","updated":"2017-03-23 20:40:12.000000000","message":"just re-used\nhttps://github.com/openstack/openstack-ansible-rabbitmq_server/blob/master/tasks/rabbitmq_ssl_key_create.yml#L35","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d56e35c30af75b532b5c66f884f97de1fa77c936","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create ssl directory"},{"line_number":17,"context_line":"  connection: local"},{"line_number":18,"context_line":"  file:"},{"line_number":19,"context_line":"    path: \"{{ galera_user_ssl_ca_cert | dirname }}\""},{"line_number":20,"context_line":"    state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ffe62b97_482a0f2c","line":17,"updated":"2017-03-28 14:02:50.000000000","message":"please use local_action","commit_id":"e22125aae17c52ce7b07a59a0c07edb68cbe08f7"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"298155d59c5769e5689aa971e59ca52a4ab368c9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create ssl directory"},{"line_number":17,"context_line":"  connection: local"},{"line_number":18,"context_line":"  file:"},{"line_number":19,"context_line":"    path: \"{{ galera_user_ssl_ca_cert | dirname }}\""},{"line_number":20,"context_line":"    state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"ffe62b97_2948ea84","line":17,"in_reply_to":"ffe62b97_482a0f2c","updated":"2017-03-28 15:52:55.000000000","message":"used delegate_to","commit_id":"e22125aae17c52ce7b07a59a0c07edb68cbe08f7"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    path: \"{{ galera_user_ssl_ca_cert | dirname }}\""},{"line_number":19,"context_line":"    state: \"directory\""},{"line_number":20,"context_line":"  delegate_to: localhost"},{"line_number":21,"context_line":"  tags:"},{"line_number":22,"context_line":"    - galera-ssl"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Remove self signed cert for regen"},{"line_number":25,"context_line":"  connection: local"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_05ee22b3","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":16},"updated":"2017-03-28 18:05:30.000000000","message":"You can remove the\ntags:\nand put it on the higher level to avoid repetition","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - galera-ssl"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Remove self signed cert for regen"},{"line_number":25,"context_line":"  connection: local"},{"line_number":26,"context_line":"  file:"},{"line_number":27,"context_line":"    dest: \"{{ item.path }}\""},{"line_number":28,"context_line":"    state: \"absent\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_e261f4aa","line":25,"updated":"2017-03-28 18:05:30.000000000","message":"please use delegate_to: here too","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - { path: \"{{ galera_user_ssl_ca_cert | dirname }}/galera-ca.key \" }"},{"line_number":34,"context_line":"    - { path: \"{{ galera_user_ssl_ca_cert | dirname }}/galera-req.pem \" }"},{"line_number":35,"context_line":"  when: galera_ssl_self_signed_regen | bool"},{"line_number":36,"context_line":"  tags:"},{"line_number":37,"context_line":"    - galera-ssl"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Create galera CA cert"},{"line_number":40,"context_line":"  connection: local"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_8537d24d","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":16},"updated":"2017-03-28 18:05:30.000000000","message":"same here and everywhere below","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    - galera-ssl"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Create galera CA cert"},{"line_number":40,"context_line":"  connection: local"},{"line_number":41,"context_line":"  command: \u003e"},{"line_number":42,"context_line":"    openssl req -new -nodes -x509 -subj"},{"line_number":43,"context_line":"    \"{{ galera_ssl_ca_self_signed_subject }}\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_c266f0c1","line":40,"updated":"2017-03-28 18:05:30.000000000","message":"please use delegate_to: here too","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    - galera-ssl"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Create galera ssl request"},{"line_number":51,"context_line":"  connection: local"},{"line_number":52,"context_line":"  command: \u003e"},{"line_number":53,"context_line":"    openssl req -new -nodes -sha256 -subj"},{"line_number":54,"context_line":"    \"{{ galera_ssl_self_signed_subject }}\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_02685884","line":51,"updated":"2017-03-28 18:05:30.000000000","message":"please use delegate_to: here too","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    - galera-ssl"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- name: Create galera ssl cert"},{"line_number":64,"context_line":"  connection: local"},{"line_number":65,"context_line":"  command: \u003e"},{"line_number":66,"context_line":"    openssl x509 -req"},{"line_number":67,"context_line":"    -days 3650"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_4220a048","line":64,"updated":"2017-03-28 18:05:30.000000000","message":"please use delegate_to: here too","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a8897f3fa25a95a84d89e8f0d511ba08016e153a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    -days 3650"},{"line_number":68,"context_line":"    -in {{ galera_user_ssl_ca_cert | dirname }}/galera-req.pem"},{"line_number":69,"context_line":"    -CA {{ galera_user_ssl_ca_cert }}"},{"line_number":70,"context_line":"    -CAkey {{ galera_user_ssl_ca_cert | dirname }}/galera-ca,key"},{"line_number":71,"context_line":"    -out {{ galera_user_ssl_cert }}"},{"line_number":72,"context_line":"    -set_serial 01"},{"line_number":73,"context_line":"    creates\u003d{{ galera_user_ssl_cert }}"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ffe62b97_02fdf8af","line":70,"range":{"start_line":70,"start_character":60,"end_line":70,"end_character":61},"updated":"2017-03-28 18:05:30.000000000","message":".","commit_id":"7c09a81381a7c93a732ca4c1e8717ff4b48f8a80"}],"tasks/galera_ssl_key_distribute.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2015, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a461143_08780af8","line":2,"updated":"2017-02-01 23:18:07.000000000","message":"boiler plate should reflect the company or owner of the patch","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - galera-ssl"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# This is here because there was a different way of configuring SSL/TLS"},{"line_number":58,"context_line":"# for RabbitMQ that used a mode of 0750 for the RabbitMQ directory.  That has"},{"line_number":59,"context_line":"# since been updated but we need to ensure that old environments get this"},{"line_number":60,"context_line":"# critical update during upgrades."},{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"# See bug 1513668 in Launchpad for more details."},{"line_number":63,"context_line":"#- name: Ensure /etc/rabbitmq is set to the default mode of 0755"},{"line_number":64,"context_line":"#  file:"},{"line_number":65,"context_line":"#    path: /etc/rabbitmq"},{"line_number":66,"context_line":"#    mode: 0755"},{"line_number":67,"context_line":"#  tags:"},{"line_number":68,"context_line":"#    - rabbitmq-ssl"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a461143_28c066e0","line":68,"range":{"start_line":57,"start_character":0,"end_line":68,"end_character":19},"updated":"2017-02-01 23:18:07.000000000","message":"i think this can be removed.","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"dcf2f4bb2e40e385cac5f60835f6ef43a9a13cd0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - galera-ssl"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# This is here because there was a different way of configuring SSL/TLS"},{"line_number":58,"context_line":"# for RabbitMQ that used a mode of 0750 for the RabbitMQ directory.  That has"},{"line_number":59,"context_line":"# since been updated but we need to ensure that old environments get this"},{"line_number":60,"context_line":"# critical update during upgrades."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a461143_aed51aba","line":57,"updated":"2017-02-02 19:16:34.000000000","message":"Let\u0027s delete this, looks like a copy and paste from another role","commit_id":"f6451cf0164e47d7fdfc234e78dc2af759c75b79"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3e43abb6342373e8aa8c7158aaa8633904cefdf4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    mode: \"{{ item.mode|default(\u00270640\u0027) }}\""},{"line_number":62,"context_line":"  with_items:"},{"line_number":63,"context_line":"    - { path: \"{{ galera_ssl_ca_cert }}\" }"},{"line_number":64,"context_line":"    - { path: \"{{ galera_ssl_key }}\" }"},{"line_number":65,"context_line":"    - { path: \"{{ galera_ssl_cert }}\", mode: \"0600\" }"},{"line_number":66,"context_line":"  tags:"},{"line_number":67,"context_line":"    - galera-ssl"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a1ff146_2804dc13","line":64,"updated":"2017-03-15 10:58:48.000000000","message":"same comment","commit_id":"96f1f757c451d5064b2e65397540f571da36d82a"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"95a4749c9e08b4ea49293cce4aab6a866e59bf14","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     group: mysql"},{"line_number":32,"context_line":"     mode: \"{{ item.mode|default(\u00270640\u0027) }}\""},{"line_number":33,"context_line":"  with_items:"},{"line_number":34,"context_line":"     - { name: \"{{ galera_ssl_ca_cert }}\", path: \u0027galera-self-ca-cert.crt\u0027}"},{"line_number":35,"context_line":"     - { name: \"{{ galera_ssl_cert }}\", path: \u0027galera-self-cert.crt\u0027 }"},{"line_number":36,"context_line":"     - { name: \"{{ galera_ssl_key }}\", mode: \u00270600\u0027, path: \u0027galera-self-key.crt\u0027 }"},{"line_number":37,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_c5534ce2","line":34,"updated":"2017-03-23 20:13:30.000000000","message":"could you write this in a simpler notation like:\n - name: \"{{ galera_ssl_ca_cert }}\"\n    path: ...","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"5975e33ab2a5e27b108d9756b0c13376677cf3ae","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     group: mysql"},{"line_number":32,"context_line":"     mode: \"{{ item.mode|default(\u00270640\u0027) }}\""},{"line_number":33,"context_line":"  with_items:"},{"line_number":34,"context_line":"     - { name: \"{{ galera_ssl_ca_cert }}\", path: \u0027galera-self-ca-cert.crt\u0027}"},{"line_number":35,"context_line":"     - { name: \"{{ galera_ssl_cert }}\", path: \u0027galera-self-cert.crt\u0027 }"},{"line_number":36,"context_line":"     - { name: \"{{ galera_ssl_key }}\", mode: \u00270600\u0027, path: \u0027galera-self-key.crt\u0027 }"},{"line_number":37,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_28d08f50","line":34,"in_reply_to":"ffe62b97_c5534ce2","updated":"2017-03-23 20:40:12.000000000","message":"is it the new requirement?\nthis way of \"items\" exists across all the roles...","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"}],"tasks/galera_ssl_key_store.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2015, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a461143_287dc6e7","line":2,"updated":"2017-02-01 23:18:07.000000000","message":"boiler plate should reflect the company or owner of the patch","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"54e76c4c3c4d3a92752cf5fe7b73072ae472588e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Read galera ssl CA cert"},{"line_number":17,"context_line":"  slurp:"},{"line_number":18,"context_line":"    src: \"{{ galera_ssl_ca_cert }}\""},{"line_number":19,"context_line":"  register: _galera_ssl_ca_cert"},{"line_number":20,"context_line":"  changed_when: false"},{"line_number":21,"context_line":"  tags:"},{"line_number":22,"context_line":"    - galera-ssl"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Read galera ssl cert"},{"line_number":25,"context_line":"  slurp:"},{"line_number":26,"context_line":"    src: \"{{ galera_ssl_cert }}\""},{"line_number":27,"context_line":"  register: _galera_ssl_cert"},{"line_number":28,"context_line":"  changed_when: false"},{"line_number":29,"context_line":"  tags:"},{"line_number":30,"context_line":"    - galera-ssl"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Read galera ssl key"},{"line_number":33,"context_line":"  slurp:"},{"line_number":34,"context_line":"    src: \"{{ galera_ssl_key }}\""},{"line_number":35,"context_line":"  register: _galera_ssl_key"},{"line_number":36,"context_line":"  changed_when: false"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - galera-ssl"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Register a fact for galera cert and key"},{"line_number":41,"context_line":"  set_fact:"},{"line_number":42,"context_line":"     galera_ssl_ca_cert_fact: \"{{ _galera_ssl_ca_cert.content }}\""},{"line_number":43,"context_line":"     galera_ssl_cert_fact: \"{{ _galera_ssl_cert.content }}\""},{"line_number":44,"context_line":"     galera_ssl_key_fact: \"{{ _galera_ssl_key.content }}\""},{"line_number":45,"context_line":"  tags:"},{"line_number":46,"context_line":"    - galera-ssl"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Create a folder for self-signed certs on the deployment host"},{"line_number":49,"context_line":"  delegate_to: localhost"},{"line_number":50,"context_line":"  file:"},{"line_number":51,"context_line":"    path: \"{{ galera_self_signed_dir }}\""},{"line_number":52,"context_line":"    state: \"directory\""},{"line_number":53,"context_line":"    mode: \"0755\""},{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - galera-ssl"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Store self-signed certs on the deployment host"},{"line_number":58,"context_line":"  delegate_to: localhost"},{"line_number":59,"context_line":"  copy:"},{"line_number":60,"context_line":"     content: \"{{ hostvars[galera_cluster_members[0]][item.name] | b64decode }}\""},{"line_number":61,"context_line":"     dest: \"{{ galera_self_signed_dir }}/{{ item.path }}\""},{"line_number":62,"context_line":"     mode: \"{{ item.mode|default(\u00270644\u0027) }}\""},{"line_number":63,"context_line":"  with_items:"},{"line_number":64,"context_line":"     - { name: \u0027galera_ssl_ca_cert_fact\u0027, path: \u0027galera-self-ca-cert.crt\u0027}"},{"line_number":65,"context_line":"     - { name: \u0027galera_ssl_cert_fact\u0027, path: \u0027galera-self-cert.crt\u0027 }"},{"line_number":66,"context_line":"     - { name: \u0027galera_ssl_key_fact\u0027, path: \u0027galera-self-key.crt\u0027 }"},{"line_number":67,"context_line":"  tags:"},{"line_number":68,"context_line":"    - galera-ssl"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a1ced50_11051d45","line":68,"range":{"start_line":16,"start_character":0,"end_line":68,"end_character":16},"updated":"2017-03-21 15:49:17.000000000","message":"Instead of all this, why not just use the synchronize module\u0027s pull mode?","commit_id":"dad482ca9a8e3ab014ebcbb34768a78502280ee6"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"f268e6a6a8e7996c6f53229ebae82a621c5e3824","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Read galera ssl CA cert"},{"line_number":17,"context_line":"  slurp:"},{"line_number":18,"context_line":"    src: \"{{ galera_ssl_ca_cert }}\""},{"line_number":19,"context_line":"  register: _galera_ssl_ca_cert"},{"line_number":20,"context_line":"  changed_when: false"},{"line_number":21,"context_line":"  tags:"},{"line_number":22,"context_line":"    - galera-ssl"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Read galera ssl cert"},{"line_number":25,"context_line":"  slurp:"},{"line_number":26,"context_line":"    src: \"{{ galera_ssl_cert }}\""},{"line_number":27,"context_line":"  register: _galera_ssl_cert"},{"line_number":28,"context_line":"  changed_when: false"},{"line_number":29,"context_line":"  tags:"},{"line_number":30,"context_line":"    - galera-ssl"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Read galera ssl key"},{"line_number":33,"context_line":"  slurp:"},{"line_number":34,"context_line":"    src: \"{{ galera_ssl_key }}\""},{"line_number":35,"context_line":"  register: _galera_ssl_key"},{"line_number":36,"context_line":"  changed_when: false"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    - galera-ssl"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Register a fact for galera cert and key"},{"line_number":41,"context_line":"  set_fact:"},{"line_number":42,"context_line":"     galera_ssl_ca_cert_fact: \"{{ _galera_ssl_ca_cert.content }}\""},{"line_number":43,"context_line":"     galera_ssl_cert_fact: \"{{ _galera_ssl_cert.content }}\""},{"line_number":44,"context_line":"     galera_ssl_key_fact: \"{{ _galera_ssl_key.content }}\""},{"line_number":45,"context_line":"  tags:"},{"line_number":46,"context_line":"    - galera-ssl"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Create a folder for self-signed certs on the deployment host"},{"line_number":49,"context_line":"  delegate_to: localhost"},{"line_number":50,"context_line":"  file:"},{"line_number":51,"context_line":"    path: \"{{ galera_self_signed_dir }}\""},{"line_number":52,"context_line":"    state: \"directory\""},{"line_number":53,"context_line":"    mode: \"0755\""},{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - galera-ssl"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Store self-signed certs on the deployment host"},{"line_number":58,"context_line":"  delegate_to: localhost"},{"line_number":59,"context_line":"  copy:"},{"line_number":60,"context_line":"     content: \"{{ hostvars[galera_cluster_members[0]][item.name] | b64decode }}\""},{"line_number":61,"context_line":"     dest: \"{{ galera_self_signed_dir }}/{{ item.path }}\""},{"line_number":62,"context_line":"     mode: \"{{ item.mode|default(\u00270644\u0027) }}\""},{"line_number":63,"context_line":"  with_items:"},{"line_number":64,"context_line":"     - { name: \u0027galera_ssl_ca_cert_fact\u0027, path: \u0027galera-self-ca-cert.crt\u0027}"},{"line_number":65,"context_line":"     - { name: \u0027galera_ssl_cert_fact\u0027, path: \u0027galera-self-cert.crt\u0027 }"},{"line_number":66,"context_line":"     - { name: \u0027galera_ssl_key_fact\u0027, path: \u0027galera-self-key.crt\u0027 }"},{"line_number":67,"context_line":"  tags:"},{"line_number":68,"context_line":"    - galera-ssl"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1a1ced50_c458258d","line":68,"range":{"start_line":16,"start_character":0,"end_line":68,"end_character":16},"in_reply_to":"1a1ced50_11051d45","updated":"2017-03-21 16:07:56.000000000","message":"I was just not aware of that telling the truth...\nIf there is a preference - I can definitely refacter.","commit_id":"dad482ca9a8e3ab014ebcbb34768a78502280ee6"}],"tasks/galera_ssl_self_signed.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a461143_488212ca","line":2,"updated":"2017-02-01 23:18:07.000000000","message":"boiler plate should reflect the company or owner of the patch","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"}],"tasks/galera_ssl_user_provided.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"a5bbd4c5c94d1bacdb05258d15071d2a9afb94c5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    group: \"{{ item.group|default(\u0027root\u0027) }}\""},{"line_number":22,"context_line":"    mode: \"{{ item.mode|default(\u00270755\u0027) }}\""},{"line_number":23,"context_line":"    recurse: \"{{ item.recurse|default(\u0027false\u0027) }}\""},{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - { path: \"/etc/mysql/ssl\", owner: \"mysql\", group: \"mysql\", mode: \"0750\" }"},{"line_number":26,"context_line":"  tags:"},{"line_number":27,"context_line":"    - galera-ssl"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_15327d10","line":24,"updated":"2017-01-27 19:18:14.000000000","message":"Since this is just one directory, this would be more clear/maintainable to remove the with_items usage and all the item.* refs above","commit_id":"de89931ad48ed3ff40bd0cafbc6f06c8fcee948b"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"a5bbd4c5c94d1bacdb05258d15071d2a9afb94c5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  tags:"},{"line_number":27,"context_line":"    - galera-ssl"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Copy CA cert and key "},{"line_number":30,"context_line":"  copy:"},{"line_number":31,"context_line":"    src: \"{{ item.src }}\""},{"line_number":32,"context_line":"    dest: \"{{ item.dest }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_5545e56d","line":29,"range":{"start_line":29,"start_character":28,"end_line":29,"end_character":29},"updated":"2017-01-27 19:18:14.000000000","message":"nit, remove the trailing whitespace","commit_id":"de89931ad48ed3ff40bd0cafbc6f06c8fcee948b"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"7fdc6165a73e069f22af7f3399a1282a32368e06","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    mode: \"{{ item.mode|default(\u00270755\u0027) }}\""},{"line_number":23,"context_line":"    recurse: \"{{ item.recurse|default(\u0027false\u0027) }}\""},{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - { path: \"/etc/mysql/ssl\", owner: \"mysql\", group: \"mysql\", mode: \"0750\" }"},{"line_number":26,"context_line":"  tags:"},{"line_number":27,"context_line":"    - galera-ssl"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a461143_56cec42e","line":25,"updated":"2017-01-28 01:29:58.000000000","message":"Since there\u0027s a single preset item, its properties could be given directly to the file module instead of looping with_items.","commit_id":"0744da4577307b06af8f4cb3cafeac41f6c616e6"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8cfb5ab5c0e55589fb82dc0515ff04a6a87bbbe5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    mode: \"{{ item.mode|default(\u00270755\u0027) }}\""},{"line_number":23,"context_line":"    recurse: \"{{ item.recurse|default(\u0027false\u0027) }}\""},{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - { path: \"/etc/mysql/ssl\", owner: \"mysql\", group: \"mysql\", mode: \"0750\" }"},{"line_number":26,"context_line":"  tags:"},{"line_number":27,"context_line":"    - galera-ssl"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a461143_3dc3b48a","line":25,"in_reply_to":"3a461143_56cec42e","updated":"2017-01-30 14:24:32.000000000","message":"+1 this should just a single task.","commit_id":"0744da4577307b06af8f4cb3cafeac41f6c616e6"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a461143_886cfa37","line":2,"updated":"2017-02-01 23:18:07.000000000","message":"boiler plate should reflect the company or owner of the patch","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dfef4441ce5c06d5ccff43e70a0f9ee9349b077a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    - { src: \"{{ galera_user_ssl_ca_cert }}\", dest: \"{{ galera_ssl_ca_cert }}\" }"},{"line_number":35,"context_line":"    - { src: \"{{ galera_user_ssl_cert }}\", dest: \"{{ galera_ssl_cert \" }"},{"line_number":36,"context_line":"    - { src: \"{{ galera_user_ssl_key }}\", dest: \"{{ galera_ssl_key }}\", mode: \"0600\" }"},{"line_number":37,"context_line":"  when: \u003e"},{"line_number":38,"context_line":"    galera_user_ssl_ca_cert is defined and"},{"line_number":39,"context_line":"    galera_user_ssl_cert is defined and"},{"line_number":40,"context_line":"    galera_user_ssl_key is defined"},{"line_number":41,"context_line":"  tags:"},{"line_number":42,"context_line":"    - galera-ssl"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a461143_a88536ae","line":40,"range":{"start_line":37,"start_character":0,"end_line":40,"end_character":34},"updated":"2017-02-01 23:18:07.000000000","message":"While functionally the same, i\u0027d make this a list.\n\n  when:\n    - galera_user_ssl_ca_cert is defined\n    - galera_user_ssl_cert is defined\n    - galera_user_ssl_key is defined","commit_id":"e81b5fb067212d6f2e2742ca718acd37523e4a32"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"dcf2f4bb2e40e385cac5f60835f6ef43a9a13cd0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  with_items:"},{"line_number":34,"context_line":"    - { src: \"{{ galera_user_ssl_ca_cert }}\", dest: \"{{ galera_ssl_ca_cert }}\" }"},{"line_number":35,"context_line":"    - { src: \"{{ galera_user_ssl_cert }}\", dest: \"{{ galera_ssl_cert \" }"},{"line_number":36,"context_line":"    - { src: \"{{ galera_user_ssl_key }}\", dest: \"{{ galera_ssl_key }}\", mode: \"0600\" }"},{"line_number":37,"context_line":"  when: \u003e"},{"line_number":38,"context_line":"    galera_user_ssl_ca_cert is defined and"},{"line_number":39,"context_line":"    galera_user_ssl_cert is defined and"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a461143_2e55aa1c","line":36,"updated":"2017-02-02 19:16:34.000000000","message":"Why is the key mode 0600 here, but 0640 when we a self-signed cert is used? Either is probably fine, but they should be consistent.","commit_id":"f6451cf0164e47d7fdfc234e78dc2af759c75b79"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"95a4749c9e08b4ea49293cce4aab6a866e59bf14","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    group: \"mysql\""},{"line_number":32,"context_line":"    mode: \"{{ item.mode|default(\u00270640\u0027) }}\""},{"line_number":33,"context_line":"  with_items:"},{"line_number":34,"context_line":"    - { src: \"{{ galera_user_ssl_ca_cert }}\", dest: \"{{ galera_ssl_ca_cert }}\" }"},{"line_number":35,"context_line":"    - { src: \"{{ galera_user_ssl_cert }}\", dest: \"{{ galera_ssl_cert }}\" }"},{"line_number":36,"context_line":"    - { src: \"{{ galera_user_ssl_key }}\", dest: \"{{ galera_ssl_key }}\", mode: \"0600\" }"},{"line_number":37,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ffe62b97_255e78e6","line":34,"updated":"2017-03-23 20:13:30.000000000","message":"same here","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"}],"templates/my.cnf.j2":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"a5bbd4c5c94d1bacdb05258d15071d2a9afb94c5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"server-id \u003d {{ galera_server_id }}"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":"{% if galera_server_ssl is True %}"},{"line_number":37,"context_line":"ssl-ca \u003d /etc/mysql/ssl/galera-ca.crt"},{"line_number":38,"context_line":"ssl-cert \u003d /etc/mysql/ssl/galera.crt"},{"line_number":39,"context_line":"ssl-key \u003d /etc/mysql/ssl/galera.key"},{"line_number":40,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a461143_55132566","line":37,"updated":"2017-01-27 19:18:14.000000000","message":"Looks like the other vars introduced in defaults/main.yml should be referenced here.","commit_id":"de89931ad48ed3ff40bd0cafbc6f06c8fcee948b"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"7128065e39e94478b37ceb383c64c28981afff60","unresolved":false,"context_lines":[{"line_number":34,"context_line":"server-id \u003d {{ galera_server_id }}"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":"{% if galera_server_ssl is True %}"},{"line_number":37,"context_line":"ssl-ca \u003d /etc/mysql/ssl/galera-ca.crt"},{"line_number":38,"context_line":"ssl-cert \u003d /etc/mysql/ssl/galera.crt"},{"line_number":39,"context_line":"ssl-key \u003d /etc/mysql/ssl/galera.key"},{"line_number":40,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a461143_cb5698d1","line":37,"in_reply_to":"3a461143_55132566","updated":"2017-01-27 20:00:10.000000000","message":"Nope, it is the same as the approach in\nhttps://github.com/openstack/openstack-ansible-os_keystone/blob/master/defaults/main.yml#L233","commit_id":"de89931ad48ed3ff40bd0cafbc6f06c8fcee948b"}],"tox.ini":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"56be2785dfaeb0435b94726ca7e9136ca54a164a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    {[testenv:tests_clone]commands}"},{"line_number":109,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-functional.sh\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"[testenv:functional_ssl]"},{"line_number":112,"context_line":"deps \u003d"},{"line_number":113,"context_line":"    {[testenv:ansible]deps}"},{"line_number":114,"context_line":"setenv \u003d"}],"source_content_type":"text/x-properties","patch_set":28,"id":"1a1ced50_36d3b461","line":111,"range":{"start_line":111,"start_character":9,"end_line":111,"end_character":23},"updated":"2017-03-22 17:55:39.000000000","message":"I\u0027m not sure if this will be too long, but it\u0027s worth a try.","commit_id":"ce01f64cd500fa3db5cb7b47eb2ed4ec46f5bb06"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"95a4749c9e08b4ea49293cce4aab6a866e59bf14","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    {[testenv:ansible]deps}"},{"line_number":114,"context_line":"setenv \u003d"},{"line_number":115,"context_line":"    {[testenv]setenv}"},{"line_number":116,"context_line":"    ANSIBLE_PARAMETERS\u003d-vvv -e galera_use_ssl\u003dTrue -e galera_self_signed_dir\u003d\"/tmp/self-signed-certs\""},{"line_number":117,"context_line":"commands \u003d"},{"line_number":118,"context_line":"    {[testenv:tests_clone]commands}"},{"line_number":119,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-functional.sh\""}],"source_content_type":"text/x-properties","patch_set":29,"id":"ffe62b97_e5f410d2","line":116,"range":{"start_line":116,"start_character":51,"end_line":116,"end_character":100},"updated":"2017-03-23 20:13:30.000000000","message":"I\u0027d rather use another location, this is supposed to be ephemeral.","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"},{"author":{"_account_id":11782,"name":"Andrey Grebennikov","email":"agrebennikov1983@gmail.com","username":"agrebennikov"},"change_message_id":"5975e33ab2a5e27b108d9756b0c13376677cf3ae","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    {[testenv:ansible]deps}"},{"line_number":114,"context_line":"setenv \u003d"},{"line_number":115,"context_line":"    {[testenv]setenv}"},{"line_number":116,"context_line":"    ANSIBLE_PARAMETERS\u003d-vvv -e galera_use_ssl\u003dTrue -e galera_self_signed_dir\u003d\"/tmp/self-signed-certs\""},{"line_number":117,"context_line":"commands \u003d"},{"line_number":118,"context_line":"    {[testenv:tests_clone]commands}"},{"line_number":119,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-functional.sh\""}],"source_content_type":"text/x-properties","patch_set":29,"id":"ffe62b97_e8462722","line":116,"range":{"start_line":116,"start_character":51,"end_line":116,"end_character":100},"in_reply_to":"ffe62b97_e5f410d2","updated":"2017-03-23 20:40:12.000000000","message":"this is exactly why I used /tmp here - it is only used for tests because ubuntu user cannot write into the default folder (/etc/)","commit_id":"064fb80a8791d68f03d0f75f309dad1036f4b8f4"}]}
