)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c7b0d88a654512089f9cbdb7e893e6d6ded1fd49","unresolved":false,"context_lines":[{"line_number":13,"context_line":"declaration into a \u0027set_fact\u0027 task. This also allows distributions to"},{"line_number":14,"context_line":"override the default package list with an empty list if they do not plan"},{"line_number":15,"context_line":"to use local percona packages."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Icb65f6c8c1654e24f73e1e5310516cd9b3568aad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f231b9d_001c0a76","line":16,"updated":"2017-06-14 16:27:53.000000000","message":"I\u0027m not sure what this does any different to what was done before? Perhaps I\u0027m just tired. :/","commit_id":"22a87ddf74099780a3ed457de1be01947cf93978"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"68e2c4b8add05f69736bce28738b2c94fe8677ef","unresolved":false,"context_lines":[{"line_number":13,"context_line":"declaration into a \u0027set_fact\u0027 task. This also allows distributions to"},{"line_number":14,"context_line":"override the default package list with an empty list if they do not plan"},{"line_number":15,"context_line":"to use local percona packages."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Icb65f6c8c1654e24f73e1e5310516cd9b3568aad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f231b9d_2fd9207e","line":16,"in_reply_to":"7f231b9d_001c0a76","updated":"2017-06-15 08:19:21.000000000","message":"Previously, in vars/main.yml, a single variable galera_packages_list was used including all the packages. However, the values for the percona packages depend on variables being defined in defaults/main.yml which in turn depend on values being defined in the various vars/* files.\n\nFor example, take this item which is unconditionally included in the galera_packages_list\n\n  - packages: \"{{ [percona_package_path] }}\"\n    enabled: \"{{ not use_percona_upstream }}\"\n    local_pkg: yes\n\npercona_package_path is defined as\n\npercona_package_path: \"/opt/{{ percona_package_url | basename }}\"\n\nand percona_package_url as\n\npercona_package_url: \"{{ percona_arch_url.get( galera_package_arch | lower ) }}\"\n\nbut, percona_arch_url is not defined in defaults/main. It\u0027s defined in the vars/$distro files.\n\nSo the way it is right now, it is required to defined the various percona_package_* variable in the distro files even though you are never going to use them.\n\nDoes it make sense now?","commit_id":"22a87ddf74099780a3ed457de1be01947cf93978"}],"tasks/galera_install.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"801c34d82f130071bdf9a2040e9059207204533f","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Add percona external packages to the galera packages list"},{"line_number":17,"context_line":"  set_fact:"},{"line_number":18,"context_line":"    galera_install_packages_list: \"{{ galera_packages_list }} + {{ percona_packages_list }}\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- include: \"galera_install_{{ ansible_pkg_mgr }}.yml\""},{"line_number":21,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf091321_3e133169","line":18,"updated":"2017-06-07 20:47:42.000000000","message":"I think this should use the union filter.\n\n    galera_install_packages_list: \"{{ galera_packages_list | union(percona_packages_list) }}\"","commit_id":"3c9b72cb2d8e3303fa8622ca768246ad6538ca04"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"42a9b7c7c6d6bcfdb267c6c6a99411d31a7b2aa8","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Add percona external packages to the galera packages list"},{"line_number":17,"context_line":"  set_fact:"},{"line_number":18,"context_line":"    galera_install_packages_list: \"{{ galera_packages_list }} + {{ percona_packages_list }}\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- include: \"galera_install_{{ ansible_pkg_mgr }}.yml\""},{"line_number":21,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf091321_4ddcf945","line":18,"in_reply_to":"bf091321_3e133169","updated":"2017-06-07 22:58:21.000000000","message":"Thank you for the review. Could you tell me why union is preferred over the \u0027+\u0027 operator? The end result should be the same so I am curious about the benefits of the union one.","commit_id":"3c9b72cb2d8e3303fa8622ca768246ad6538ca04"}]}
