)]}'
{"tasks/galera_install_yum.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5971e9cc0da3463e03e5c3a16f19b9e38d2c9d01","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    dest: \"/etc/systemd/system/mariadb.service.d/without-privatedevices.conf\""},{"line_number":120,"context_line":"  when:"},{"line_number":121,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":122,"context_line":"    - ansible_service_mgr \u003d\u003d \u0027systemd\u0027"},{"line_number":123,"context_line":"    - systemd_mysql_service.stat.exists"},{"line_number":124,"context_line":"  notify:"},{"line_number":125,"context_line":"    - Reload the systemd daemon"},{"line_number":126,"context_line":"    - Restart mysql"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f231b9d_357f07e1","line":123,"range":{"start_line":122,"start_character":0,"end_line":123,"end_character":39},"updated":"2017-06-16 12:45:34.000000000","message":"Why both of these?","commit_id":"d8141a7e5df558bf5df9d7257e8db22ddb1b527b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e43bdb337cc2f8b99a658a948569f6ae79d359a0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  tags:"},{"line_number":128,"context_line":"    - galera-config"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"- name: Reload the systemd daemon"},{"line_number":131,"context_line":"  command: \"systemctl daemon-reload\""},{"line_number":132,"context_line":"  when:"},{"line_number":133,"context_line":"    - ansible_service_mgr \u003d\u003d \u0027systemd\u0027"},{"line_number":134,"context_line":"    - systemd_mysql_service.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f231b9d_5565e344","line":131,"range":{"start_line":130,"start_character":0,"end_line":131,"end_character":36},"updated":"2017-06-16 12:46:30.000000000","message":"Use the systemd or module instead.","commit_id":"d8141a7e5df558bf5df9d7257e8db22ddb1b527b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e32f897cfa06145b56c9cd046b6c6d46e2a1c35b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    - galera_server-config"},{"line_number":107,"context_line":"    - galera-enable"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"- name: Check if we are on systemd service"},{"line_number":110,"context_line":"  stat:"},{"line_number":111,"context_line":"    path: \"/etc/systemd/system/mariadb.service.d/\""},{"line_number":112,"context_line":"  register: systemd_mysql_service"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# See comments above \u0027galera_disable_privatedevices\u0027 in defaults/main.yml for"},{"line_number":115,"context_line":"# links to relevant bugs and discussion."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f231b9d_7871f643","line":112,"range":{"start_line":109,"start_character":0,"end_line":112,"end_character":33},"updated":"2017-06-16 13:21:05.000000000","message":"Is there a reason this is being used instead of ansible_service_mgr?","commit_id":"c4ecae1a6cc3ee1098341764f7071a59f7fe9f6f"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"3a98018650211265c8d5377394e97c3f2087a1c9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    - galera_server-config"},{"line_number":107,"context_line":"    - galera-enable"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"- name: Check if we are on systemd service"},{"line_number":110,"context_line":"  stat:"},{"line_number":111,"context_line":"    path: \"/etc/systemd/system/mariadb.service.d/\""},{"line_number":112,"context_line":"  register: systemd_mysql_service"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# See comments above \u0027galera_disable_privatedevices\u0027 in defaults/main.yml for"},{"line_number":115,"context_line":"# links to relevant bugs and discussion."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f231b9d_984e12bf","line":112,"range":{"start_line":109,"start_character":0,"end_line":112,"end_character":33},"in_reply_to":"7f231b9d_7871f643","updated":"2017-06-16 13:30:25.000000000","message":"on centos 7 the service manager is systemd but mariadb 10.0 uses init script. and the folder doens\u0027t exist in that case.","commit_id":"c4ecae1a6cc3ee1098341764f7071a59f7fe9f6f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4c7a1d743214fecf1c826a7fc7394e4117649602","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    - galera_server-config"},{"line_number":107,"context_line":"    - galera-enable"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"- name: Check if we are on systemd service"},{"line_number":110,"context_line":"  stat:"},{"line_number":111,"context_line":"    path: \"/etc/systemd/system/mariadb.service.d/\""},{"line_number":112,"context_line":"  register: systemd_mysql_service"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# See comments above \u0027galera_disable_privatedevices\u0027 in defaults/main.yml for"},{"line_number":115,"context_line":"# links to relevant bugs and discussion."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f231b9d_2b7c4681","line":112,"range":{"start_line":109,"start_character":0,"end_line":112,"end_character":33},"in_reply_to":"7f231b9d_984e12bf","updated":"2017-06-16 13:41:52.000000000","message":"Ah, so this is a compatibility thing for the upgrade?\n\nI think we need to change the upgrade to work similarly to the openstack roles - it should use the previous branch role to deploy the older system. That\u0027s for another patch though.\n\nPlease add a comment to this to explain its purpose so that we can remove it once we improve the upgrade test.","commit_id":"c4ecae1a6cc3ee1098341764f7071a59f7fe9f6f"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"cbc949c7238f08b8f23db9cf714c7fab34532e88","unresolved":false,"context_lines":[{"line_number":139,"context_line":"#  MySQL secure setup which is done automatically in Ubuntu deployments."},{"line_number":140,"context_line":"- name: \"Update root user, connections, and grant options\""},{"line_number":141,"context_line":"  shell: |"},{"line_number":142,"context_line":"    /bin/galera_new_cluster || service mysql start || true"},{"line_number":143,"context_line":"    # Reset the root password, at this time there is no password set"},{"line_number":144,"context_line":"    mysqladmin --no-defaults --port\u003d3306 --socket\u003d/var/run/mysqld/mysqld.sock --host\u003d127.0.0.1 --user\u003droot password \"{{ galera_root_password }}\""},{"line_number":145,"context_line":"    # Setup the root user for MySQL"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f231b9d_cedf2067","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":27},"updated":"2017-06-16 14:19:36.000000000","message":"The reason for this change is not immediately obvious to me. Could you explain the reason for chaining these commands like this either in a comment above them or in the commit message?","commit_id":"82902e0ffdef1fd37d1b6d370baeedc52ded3e22"}]}
