)]}'
{"defaults/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c118e19a326faafd163542f9e1ffde353c89dc8d","unresolved":true,"context_lines":[{"line_number":218,"context_line":"  - \"*-*-* 06:00:00\""},{"line_number":219,"context_line":"  - \"*-*-* 12:00:00\""},{"line_number":220,"context_line":"  - \"*-*-* 18:00:00\""},{"line_number":221,"context_line":"galera_mariadb_backups_user: galera_mariadb_backup"},{"line_number":222,"context_line":"galera_mariadb_backups_suffix: \"{{ inventory_hostname }}\""},{"line_number":223,"context_line":"galera_mariadb_backups_cnf_file: \"/etc/mysql/mariabackup.cnf\""},{"line_number":224,"context_line":"galera_mariadb_backups_nodes: [\"{{ galera_cluster_members[0] }}\"]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d4da9d8a_2f7d9901","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":50},"updated":"2020-11-30 18:20:24.000000000","message":"it\u0027s a bit of a nitpick but this is actually the db user and as we have a bunch of vars talking about unix usernames/groups perhaps this needs at least a comment to say it\u0027s the db user, not the unix user for backups","commit_id":"a343a365ebc8b8d7db396f3e4c04bf529d7e9d39"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"97b3a1ad2bd8f8c9ea835b4e61fbca749bfc2906","unresolved":true,"context_lines":[{"line_number":219,"context_line":"  - \"*-*-* 06:00:00\""},{"line_number":220,"context_line":"  - \"*-*-* 12:00:00\""},{"line_number":221,"context_line":"  - \"*-*-* 18:00:00\""},{"line_number":222,"context_line":"#galera_mariadb_backups_user is the name of the mariadb database user"},{"line_number":223,"context_line":"galera_mariadb_backups_user: galera_mariadb_backup"},{"line_number":224,"context_line":"galera_mariadb_backups_suffix: \"{{ inventory_hostname }}\""},{"line_number":225,"context_line":"galera_mariadb_backups_cnf_file: \"/etc/mysql/mariabackup.cnf\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfaaa79c_56d52ef8","line":222,"range":{"start_line":222,"start_character":1,"end_line":222,"end_character":28},"updated":"2020-12-01 17:08:50.000000000","message":"I don\u0027t see this variable being used. Is it smth leftover?","commit_id":"0b853b1da7802f6fac8da309c88886186f6a15a6"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"a2f9f024c6e59c61a86bfd0bb8476c12a1b40fd3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  - \"*-*-* 06:00:00\""},{"line_number":220,"context_line":"  - \"*-*-* 12:00:00\""},{"line_number":221,"context_line":"  - \"*-*-* 18:00:00\""},{"line_number":222,"context_line":"#galera_mariadb_backups_user is the name of the mariadb database user"},{"line_number":223,"context_line":"galera_mariadb_backups_user: galera_mariadb_backup"},{"line_number":224,"context_line":"galera_mariadb_backups_suffix: \"{{ inventory_hostname }}\""},{"line_number":225,"context_line":"galera_mariadb_backups_cnf_file: \"/etc/mysql/mariabackup.cnf\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"439ef780_974ff8ad","line":222,"range":{"start_line":222,"start_character":1,"end_line":222,"end_character":28},"in_reply_to":"a76c5bd5_2191ef7c","updated":"2020-12-03 09:38:12.000000000","message":"ah confusion! it\u0027s actually a comment about the next variable to make it clear that its the db user rather than a unix user","commit_id":"0b853b1da7802f6fac8da309c88886186f6a15a6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9312ed820858b09d3ecb5c1097dd4d2eabe8e322","unresolved":true,"context_lines":[{"line_number":219,"context_line":"  - \"*-*-* 06:00:00\""},{"line_number":220,"context_line":"  - \"*-*-* 12:00:00\""},{"line_number":221,"context_line":"  - \"*-*-* 18:00:00\""},{"line_number":222,"context_line":"#galera_mariadb_backups_user is the name of the mariadb database user"},{"line_number":223,"context_line":"galera_mariadb_backups_user: galera_mariadb_backup"},{"line_number":224,"context_line":"galera_mariadb_backups_suffix: \"{{ inventory_hostname }}\""},{"line_number":225,"context_line":"galera_mariadb_backups_cnf_file: \"/etc/mysql/mariabackup.cnf\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a76c5bd5_2191ef7c","line":222,"range":{"start_line":222,"start_character":1,"end_line":222,"end_character":28},"in_reply_to":"c6980e17_9069675f","updated":"2020-12-03 09:26:45.000000000","message":"yeah, my bad. But there\u0027s no default there, and value here is commented out, so needs adjustment anyway","commit_id":"0b853b1da7802f6fac8da309c88886186f6a15a6"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"eec0e20d25f5ab7826582b442e6c71504d3279e9","unresolved":true,"context_lines":[{"line_number":219,"context_line":"  - \"*-*-* 06:00:00\""},{"line_number":220,"context_line":"  - \"*-*-* 12:00:00\""},{"line_number":221,"context_line":"  - \"*-*-* 18:00:00\""},{"line_number":222,"context_line":"#galera_mariadb_backups_user is the name of the mariadb database user"},{"line_number":223,"context_line":"galera_mariadb_backups_user: galera_mariadb_backup"},{"line_number":224,"context_line":"galera_mariadb_backups_suffix: \"{{ inventory_hostname }}\""},{"line_number":225,"context_line":"galera_mariadb_backups_cnf_file: \"/etc/mysql/mariabackup.cnf\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c6980e17_9069675f","line":222,"range":{"start_line":222,"start_character":1,"end_line":222,"end_character":28},"in_reply_to":"dfaaa79c_56d52ef8","updated":"2020-12-01 17:55:54.000000000","message":"i think it is used here https://opendev.org/openstack/openstack-ansible-galera_server/src/branch/master/tasks/galera_server_backups.yml#L74","commit_id":"0b853b1da7802f6fac8da309c88886186f6a15a6"}],"tasks/galera_server_backups.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1237704d1a67b385c8803f7d0f59cc34c7bf5d09","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    dest: \"{{ galera_mariadb_backups_cnf_file }}\""},{"line_number":26,"context_line":"    mode: \"0644\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Ensure directory to write pid file exists"},{"line_number":29,"context_line":"  file:"},{"line_number":30,"context_line":"    path: \"/var/run/mariabackup-full\""},{"line_number":31,"context_line":"    state: \"directory\""},{"line_number":32,"context_line":"    owner: \"mysql\""},{"line_number":33,"context_line":"    group: \"backups\""},{"line_number":34,"context_line":"    mode: \"2755\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Create service and timer for full backups"},{"line_number":37,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5e375d31_d24874dc","line":34,"range":{"start_line":28,"start_character":0,"end_line":34,"end_character":16},"updated":"2020-11-28 14:10:54.000000000","message":"I think that this may not persist across reboots and systemd can handle this for us https://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectory\u003d","commit_id":"c0ef99e2cb5a583020768431025213b04b4e35da"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c118e19a326faafd163542f9e1ffde353c89dc8d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure group backups exists"},{"line_number":3,"context_line":"  group:"},{"line_number":4,"context_line":"    name: backups"},{"line_number":5,"context_line":"    state: present"},{"line_number":6,"context_line":"    gid: \"{{ galera_backups_group_gid | default(omit) }}\""},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ea436df5_ddebc976","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":17},"updated":"2020-11-30 18:20:24.000000000","message":"ditto","commit_id":"a343a365ebc8b8d7db396f3e4c04bf529d7e9d39"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c118e19a326faafd163542f9e1ffde353c89dc8d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    path: \"{{ galera_mariadb_backups_path }}\""},{"line_number":11,"context_line":"    state: \"directory\""},{"line_number":12,"context_line":"    owner: \"mysql\""},{"line_number":13,"context_line":"    group: \"backups\""},{"line_number":14,"context_line":"    mode: \"0750\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Template out mariadb backup script"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"255c0e5a_839f97a7","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":19},"updated":"2020-11-30 18:20:24.000000000","message":"this group name is a bit arbitrary and really should be defined in defaults/main.yml. It is quite possible that on a metal host the group responsible for backups already exists and this role should be able to use an existing group name","commit_id":"a343a365ebc8b8d7db396f3e4c04bf529d7e9d39"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c118e19a326faafd163542f9e1ffde353c89dc8d","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    systemd_service_enabled: true"},{"line_number":33,"context_line":"    systemd_service_restart_changed: false"},{"line_number":34,"context_line":"    systemd_user_name: \"mysql\""},{"line_number":35,"context_line":"    systemd_group_name: \"backups\""},{"line_number":36,"context_line":"    systemd_services:"},{"line_number":37,"context_line":"      - service_name: \"mariabackup-full\""},{"line_number":38,"context_line":"        execstarts:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"774cf717_eaa44301","line":35,"range":{"start_line":35,"start_character":25,"end_line":35,"end_character":32},"updated":"2020-11-30 18:20:24.000000000","message":"ditto","commit_id":"a343a365ebc8b8d7db396f3e4c04bf529d7e9d39"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"c118e19a326faafd163542f9e1ffde353c89dc8d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    systemd_service_enabled: true"},{"line_number":59,"context_line":"    systemd_service_restart_changed: false"},{"line_number":60,"context_line":"    systemd_user_name: \"mysql\""},{"line_number":61,"context_line":"    systemd_group_name: \"backups\""},{"line_number":62,"context_line":"    systemd_services:"},{"line_number":63,"context_line":"      - service_name: \"mariabackup-increment\""},{"line_number":64,"context_line":"        execstarts:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"87195a7e_3ed93bc1","line":61,"range":{"start_line":61,"start_character":25,"end_line":61,"end_character":32},"updated":"2020-11-30 18:20:24.000000000","message":"ditto","commit_id":"a343a365ebc8b8d7db396f3e4c04bf529d7e9d39"}],"templates/mariabackup_script.py.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"14d1ad8cb2b7c8f9f47ce9a635a22973a8853d3c","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"def get_lock_file():"},{"line_number":200,"context_line":"    try:"},{"line_number":201,"context_line":"        pid \u003d open(\u0027/var/run/mariabackup-full/db_backup.pid\u0027, \u0027w\u0027)"},{"line_number":202,"context_line":"        pid.write(str(os.getpid()))"},{"line_number":203,"context_line":"        pid.close()"},{"line_number":204,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"0ce04c74_6dcbc40d","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":66},"updated":"2020-11-27 13:20:55.000000000","message":"I don\u0027t see how we create /var/run/mariabackup-full/ directory we\u0027re trying to use. I think we should ensure in script that directory exist before trying to open file","commit_id":"7b743a06f4e3543a928a0f331fbe96f650cc7cf8"},{"author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"change_message_id":"ca1e1f951c483abc54e1e261a6458c4de9e860e4","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"def get_lock_file():"},{"line_number":200,"context_line":"    try:"},{"line_number":201,"context_line":"        pid \u003d open(\u0027/var/run/mariabackup-full/db_backup.pid\u0027, \u0027w\u0027)"},{"line_number":202,"context_line":"        pid.write(str(os.getpid()))"},{"line_number":203,"context_line":"        pid.close()"},{"line_number":204,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"32130daa_e4f98695","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":66},"in_reply_to":"0ce04c74_6dcbc40d","updated":"2020-11-27 18:17:38.000000000","message":"Agreed, that was a bit cheeky of me!","commit_id":"7b743a06f4e3543a928a0f331fbe96f650cc7cf8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"97b3a1ad2bd8f8c9ea835b4e61fbca749bfc2906","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"def get_lock_file():"},{"line_number":200,"context_line":"    try:"},{"line_number":201,"context_line":"        pid \u003d open(\u0027/var/run/mariabackup-galera/db_backup.pid\u0027, \u0027w\u0027)"},{"line_number":202,"context_line":"        pid.write(str(os.getpid()))"},{"line_number":203,"context_line":"        pid.close()"},{"line_number":204,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"6e4ed4c6_a374c22e","line":201,"range":{"start_line":201,"start_character":20,"end_line":201,"end_character":48},"updated":"2020-12-01 17:08:50.000000000","message":"Still don\u0027t see how we get this directory present. I think we should just get OSError because directory does not exist?","commit_id":"0b853b1da7802f6fac8da309c88886186f6a15a6"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"eec0e20d25f5ab7826582b442e6c71504d3279e9","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"def get_lock_file():"},{"line_number":200,"context_line":"    try:"},{"line_number":201,"context_line":"        pid \u003d open(\u0027/var/run/mariabackup-galera/db_backup.pid\u0027, \u0027w\u0027)"},{"line_number":202,"context_line":"        pid.write(str(os.getpid()))"},{"line_number":203,"context_line":"        pid.close()"},{"line_number":204,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"a68107fb_646f88f3","line":201,"range":{"start_line":201,"start_character":20,"end_line":201,"end_character":48},"in_reply_to":"6e4ed4c6_a374c22e","updated":"2020-12-01 17:55:54.000000000","message":"this directory is created with systemd_service using RuntimeDirectory: \u0027mariabackup-galera\u0027. /var/run not persist across a reboot so the dir needs to be created each time the service starts.","commit_id":"0b853b1da7802f6fac8da309c88886186f6a15a6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9312ed820858b09d3ecb5c1097dd4d2eabe8e322","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"def get_lock_file():"},{"line_number":200,"context_line":"    try:"},{"line_number":201,"context_line":"        pid \u003d open(\u0027/var/run/mariabackup-galera/db_backup.pid\u0027, \u0027w\u0027)"},{"line_number":202,"context_line":"        pid.write(str(os.getpid()))"},{"line_number":203,"context_line":"        pid.close()"},{"line_number":204,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"811aa116_8ba98bca","line":201,"range":{"start_line":201,"start_character":20,"end_line":201,"end_character":48},"in_reply_to":"a68107fb_646f88f3","updated":"2020-12-03 09:26:45.000000000","message":"oh, yes, fair enough","commit_id":"0b853b1da7802f6fac8da309c88886186f6a15a6"}]}