)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"500917220d919b536ed0ca7ee9afe7849546782d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76bed78d_360ee5d8","updated":"2021-11-24 16:12:35.000000000","message":"Lets leave this as a reference in the comments for future https://jira.mariadb.org/browse/MDEV-27068","commit_id":"c8575032749dd47f11967c482f122af313f8ee25"}],"tasks/galera_server_setup.yml":[{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"1467015bf0f9cc6aecf55c3b829aaa7a2f5a3f2e","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  until: galera_mysql_upgrade is success"},{"line_number":22,"context_line":"  when: ansible_facts[\u0027os_family\u0027] | lower \u003d\u003d \u0027redhat\u0027"},{"line_number":23,"context_line":"  retries: 3"},{"line_number":24,"context_line":"  delay: 10"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(noonedeadpunk): debian-start runs mariadb-upgrade with systemd unit so we"},{"line_number":27,"context_line":"#                      need to wait for it to finish to avoid race conditions"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9b46428f_136353b6","line":24,"updated":"2021-11-24 13:23:11.000000000","message":"I wonder how long it will take on a older deployment. 30 sec will probably be not quite enough?","commit_id":"c8575032749dd47f11967c482f122af313f8ee25"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"fcd12d72c871c960bcc015fbf9b02ef0f3eee5b7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  until: galera_mysql_upgrade is success"},{"line_number":22,"context_line":"  when: ansible_facts[\u0027os_family\u0027] | lower \u003d\u003d \u0027redhat\u0027"},{"line_number":23,"context_line":"  retries: 3"},{"line_number":24,"context_line":"  delay: 10"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(noonedeadpunk): debian-start runs mariadb-upgrade with systemd unit so we"},{"line_number":27,"context_line":"#                      need to wait for it to finish to avoid race conditions"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9dfafa56_c0b86788","line":24,"in_reply_to":"9b46428f_136353b6","updated":"2021-11-24 13:30:07.000000000","message":"after looking at my past mariadb_upgrade it took less than 3 sec on my production server for older version of maria. so 30 sec should be ok for now.","commit_id":"c8575032749dd47f11967c482f122af313f8ee25"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b078fca65775597fa0805c2e84cef2cdf4b31d30","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  until: galera_mysql_upgrade is success"},{"line_number":22,"context_line":"  when: ansible_facts[\u0027os_family\u0027] | lower \u003d\u003d \u0027redhat\u0027"},{"line_number":23,"context_line":"  retries: 3"},{"line_number":24,"context_line":"  delay: 10"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(noonedeadpunk): debian-start runs mariadb-upgrade with systemd unit so we"},{"line_number":27,"context_line":"#                      need to wait for it to finish to avoid race conditions"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c0fb50c6_30387c6c","line":24,"in_reply_to":"9dfafa56_c0b86788","updated":"2021-11-24 14:30:39.000000000","message":"but it\u0027s for retries? It is applied only when command fails and it re-runs it?\nAnd wait_for timeout default is 300 seconds, which should be enough for sure.","commit_id":"c8575032749dd47f11967c482f122af313f8ee25"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"1467015bf0f9cc6aecf55c3b829aaa7a2f5a3f2e","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(noonedeadpunk): debian-start runs mariadb-upgrade with systemd unit so we"},{"line_number":27,"context_line":"#                      need to wait for it to finish to avoid race conditions"},{"line_number":28,"context_line":"- name: Wait for MySQL Upgrade to finish"},{"line_number":29,"context_line":"  wait_for:"},{"line_number":30,"context_line":"    path: /var/lib/mysql/mysql_upgrade_info"},{"line_number":31,"context_line":"    search_regex: \"^{{ galera_major_version }}.{{ galera_minor_version }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"550a3669_c9cc57a3","line":28,"updated":"2021-11-24 13:23:11.000000000","message":"should we only do that for debian-based since for redhat we wait on the process to end?","commit_id":"c8575032749dd47f11967c482f122af313f8ee25"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b078fca65775597fa0805c2e84cef2cdf4b31d30","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(noonedeadpunk): debian-start runs mariadb-upgrade with systemd unit so we"},{"line_number":27,"context_line":"#                      need to wait for it to finish to avoid race conditions"},{"line_number":28,"context_line":"- name: Wait for MySQL Upgrade to finish"},{"line_number":29,"context_line":"  wait_for:"},{"line_number":30,"context_line":"    path: /var/lib/mysql/mysql_upgrade_info"},{"line_number":31,"context_line":"    search_regex: \"^{{ galera_major_version }}.{{ galera_minor_version }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a29f722_f8a970eb","line":28,"in_reply_to":"550a3669_c9cc57a3","updated":"2021-11-24 14:30:39.000000000","message":"I think it doesn\u0027t hurt for redhat? Better be safe then sorry...","commit_id":"c8575032749dd47f11967c482f122af313f8ee25"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"b10ca45e41e72bfc8f34226de02f38cd71d08b0d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(noonedeadpunk): debian-start runs mariadb-upgrade with systemd unit so we"},{"line_number":27,"context_line":"#                      need to wait for it to finish to avoid race conditions"},{"line_number":28,"context_line":"- name: Wait for MySQL Upgrade to finish"},{"line_number":29,"context_line":"  wait_for:"},{"line_number":30,"context_line":"    path: /var/lib/mysql/mysql_upgrade_info"},{"line_number":31,"context_line":"    search_regex: \"^{{ galera_major_version }}.{{ galera_minor_version }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"73f691a5_70f31066","line":28,"in_reply_to":"9a29f722_f8a970eb","updated":"2021-11-24 14:31:48.000000000","message":"Ack","commit_id":"c8575032749dd47f11967c482f122af313f8ee25"}]}