)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"621031bb240b60f74d0c0e9a1ca83c9d41eb9ef8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"336251cf_076c2d26","updated":"2022-08-26 15:28:10.000000000","message":"This adds support to configure trusted sources for proxy protocol data.\nThere is a related change making actual use of this new option:\n\nhttps://review.opendev.org/c/openstack/openstack-ansible/+/854810","commit_id":"d26e6e809f8ccc68995b1aa6ea75ee6741f5ba8c"}],"templates/my.cnf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c69c44cf56ee27afeca810c048ffffc36a7ce4bb","unresolved":true,"context_lines":[{"line_number":32,"context_line":"ignore_db_dirs \u003d {{ galera_ignore_db_dirs | join(\u0027,\u0027) }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"bind-address \u003d {{ galera_server_bind_address }}"},{"line_number":35,"context_line":"proxy-protocol-networks\u003d{{ galera_server_proxy_protocol_networks }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% if galera_server_id is defined %}"},{"line_number":38,"context_line":"server-id \u003d {{ galera_server_id }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"cb9e5830_25d7e2f8","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":67},"updated":"2022-08-29 09:02:44.000000000","message":"should we check if variable is empty and define proxy-protocol-networks only if it\u0027s not?","commit_id":"d26e6e809f8ccc68995b1aa6ea75ee6741f5ba8c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4f683da5a30d71e68880189eb93960e1c7960b98","unresolved":true,"context_lines":[{"line_number":32,"context_line":"ignore_db_dirs \u003d {{ galera_ignore_db_dirs | join(\u0027,\u0027) }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"bind-address \u003d {{ galera_server_bind_address }}"},{"line_number":35,"context_line":"proxy-protocol-networks\u003d{{ galera_server_proxy_protocol_networks }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% if galera_server_id is defined %}"},{"line_number":38,"context_line":"server-id \u003d {{ galera_server_id }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a10c110f_40cd5dea","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":67},"in_reply_to":"14c58304_5e429b0c","updated":"2022-08-29 10:13:57.000000000","message":"Looking at the generated config [1] it seems that we don\u0027t have any other options without value in there. So for consistency I\u0027d add check not to add option when it\u0027s not needed.\n\n\n[1] https://zuul.opendev.org/t/openstack/build/9ef8032ea71b47d3b044f0a08ab29c1e/log/logs/etc/openstack/aio1_galera_container-14c04743/mysql/mariadb.cnf.txt#28","commit_id":"d26e6e809f8ccc68995b1aa6ea75ee6741f5ba8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"558bbb8e49ebe5bc765b217f18834d43a7c7f1a1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"ignore_db_dirs \u003d {{ galera_ignore_db_dirs | join(\u0027,\u0027) }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"bind-address \u003d {{ galera_server_bind_address }}"},{"line_number":35,"context_line":"proxy-protocol-networks\u003d{{ galera_server_proxy_protocol_networks }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% if galera_server_id is defined %}"},{"line_number":38,"context_line":"server-id \u003d {{ galera_server_id }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b0fbaa74_f4022cee","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":67},"in_reply_to":"a10c110f_40cd5dea","updated":"2022-08-29 10:56:02.000000000","message":"Done","commit_id":"d26e6e809f8ccc68995b1aa6ea75ee6741f5ba8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"bad75a9b3a3d23b6cc821135e4d63a90f8e1d1b3","unresolved":true,"context_lines":[{"line_number":32,"context_line":"ignore_db_dirs \u003d {{ galera_ignore_db_dirs | join(\u0027,\u0027) }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"bind-address \u003d {{ galera_server_bind_address }}"},{"line_number":35,"context_line":"proxy-protocol-networks\u003d{{ galera_server_proxy_protocol_networks }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% if galera_server_id is defined %}"},{"line_number":38,"context_line":"server-id \u003d {{ galera_server_id }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"14c58304_5e429b0c","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":67},"in_reply_to":"cb9e5830_25d7e2f8","updated":"2022-08-29 09:56:35.000000000","message":"I could certainly change it - Your call.\n\nThe default is empty (https://mariadb.com/kb/en/server-system-variables/#proxy_protocol_networks), so the current empty string should also work, but I gladly follow the style you like more.","commit_id":"d26e6e809f8ccc68995b1aa6ea75ee6741f5ba8c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7ecbf4955fc9ae9939d1f21e593d15131f6a140e","unresolved":true,"context_lines":[{"line_number":32,"context_line":"ignore_db_dirs \u003d {{ galera_ignore_db_dirs | join(\u0027,\u0027) }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"bind-address \u003d {{ galera_server_bind_address }}"},{"line_number":35,"context_line":"{% if galera_server_proxy_protocol_networks is defined %}"},{"line_number":36,"context_line":"proxy-protocol-networks \u003d {{ galera_server_proxy_protocol_networks }}"},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"d7d776a2_c2f73902","line":35,"range":{"start_line":35,"start_character":6,"end_line":35,"end_character":54},"updated":"2022-08-29 10:57:48.000000000","message":"It is always defined as it\u0027s in defaults. Can be just\n  {% if galera_server_proxy_protocol_networks %}\nOR\n  {% if galera_server_proxy_protocol_networks is truthy %}","commit_id":"59b16fb96deac7bca256bfafc89d8b97784e4401"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"62ab07f0d5fadd1a76d06a8cee30c37dbcc11fc0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"ignore_db_dirs \u003d {{ galera_ignore_db_dirs | join(\u0027,\u0027) }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"bind-address \u003d {{ galera_server_bind_address }}"},{"line_number":35,"context_line":"{% if galera_server_proxy_protocol_networks is defined %}"},{"line_number":36,"context_line":"proxy-protocol-networks \u003d {{ galera_server_proxy_protocol_networks }}"},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a77bedaf_7a13d368","line":35,"range":{"start_line":35,"start_character":6,"end_line":35,"end_character":54},"in_reply_to":"d7d776a2_c2f73902","updated":"2022-08-29 12:31:24.000000000","message":"Ack, sorry.","commit_id":"59b16fb96deac7bca256bfafc89d8b97784e4401"}]}