)]}'
{"id":"openstack%2Fopenstack-ansible-haproxy_server~587687","triplet_id":"openstack%2Fopenstack-ansible-haproxy_server~master~Ic259abc281619ba5ee8f020ac68373858a06e94d","project":"openstack/openstack-ansible-haproxy_server","branch":"master","topic":"bug/1783886","hashtags":[],"change_id":"Ic259abc281619ba5ee8f020ac68373858a06e94d","subject":"Allow rsyslog to log HAProxy locally","status":"MERGED","created":"2018-08-01 04:58:15.000000000","updated":"2018-11-10 10:00:51.000000000","submitted":"2018-11-10 10:00:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"587687-1541844051159-770aa4df","meta_rev_id":"743cc64aed7bf6a7f0df26687f4be34dde778a0c","_number":587687,"virtual_id_number":587687,"owner":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":2,"date":"2018-11-10 10:00:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-09-23 06:35:15.000000000","_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2018-09-23 20:38:46.000000000","_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":1,"date":"2018-09-25 09:41:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},{"value":2,"date":"2018-11-10 09:48:06.000000000","_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},{"value":1,"date":"2018-11-10 09:48:06.000000000","_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-08-01 14:55:39.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2018-09-23 20:38:46.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2018-09-25 09:41:25.000000000","updated_by":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"reviewer":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"state":"REVIEWER"},{"updated":"2018-11-10 09:48:06.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2018-11-10 10:00:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"29444a0f50b51be6b5dc014449d6b8bf4187993d","author":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"date":"2018-08-01 04:58:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5302702b591cbc4ff50ae3880b237a3f14c2bde6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-01 05:12:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/87/587687/1/check/build-openstack-sphinx-docs/67997e1/html/ : SUCCESS in 2m 57s\n- openstack-ansible-linters http://logs.openstack.org/87/587687/1/check/openstack-ansible-linters/18419da/ : SUCCESS in 5m 26s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/87/587687/1/check/openstack-ansible-functional-centos-7/939268e/ : SUCCESS in 7m 52s\n- openstack-ansible-functional-opensuse-150 http://logs.openstack.org/87/587687/1/check/openstack-ansible-functional-opensuse-150/4993a38/ : FAILURE in 6m 42s (non-voting)\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/87/587687/1/check/openstack-ansible-functional-opensuse-423/609437a/ : SUCCESS in 6m 06s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/87/587687/1/check/openstack-ansible-functional-ubuntu-bionic/be64526/ : SUCCESS in 6m 07s (non-voting)\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/87/587687/1/check/openstack-ansible-functional-ubuntu-xenial/f1d5197/ : SUCCESS in 6m 27s","accounts_in_message":[],"_revision_number":1},{"id":"317d52a9da8da487c36d2b23a7231d6114c5e300","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2018-08-01 10:56:02.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"684180d2752bfb3245103f9efd4f215db98adfbb","author":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"date":"2018-08-01 14:16:03.000000000","message":"Patch Set 1:\n\nReviewers,\n\nAfter \"sleeping on it\" I realize that files/haproxy-logging.cfg is pretty open-ended (ie all local0.info gets written to /var/log/haproxy/haproxy.log and all remaining local0 gets discarded, whether related to haproxy or not), so it might be best to be more specific (eg \"if $programname startswith \u0027haproxy\u0027 then /var/log/haproxy.log\" as appears in Ubuntu\u0027s HAProxy package\u0027s rsyslog config).\n\nNot that we weren\u0027t *implicitly* logging haproxy (and everything else logged to local0 and local1 facilities) to HAProxy logs before, but now that I\u0027m proposing moving HAProxy\u0027s rsyslog config up from \"99\" to \"10\" we are going to discard everything local0 (after logging level info and above to /var/log/haproxy/haproxy.log) whether related to HAProxy or not and potentially before an associated rsyslog config file can save those log messages elsewhere (ie alphanumerically after \"10-haproxy-local-logging.conf\").\n\nI\u0027ll defer to reviewers whether such detail(s) should affect this proposed change.","accounts_in_message":[],"_revision_number":1},{"id":"055202d146f4a7398839582ae6aedda6963a9067","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2018-08-01 14:55:39.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"8c85399569ac8c93300cda4b6728b00dbc15e2cf","author":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"date":"2018-09-23 06:04:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8f4f0c0344c28f25d79a0fb8bc8d6918cd145e8d","author":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"date":"2018-09-23 06:35:15.000000000","message":"Patch Set 2:\n\nrsyslog configuration modified so that it only processes (ie logs and discards) haproxy log messages (ie those with application name starting with \"haproxy\" as part of syslog message tag) with a facility of local0 or local1, which is how we configure haproxy, so we should only be operating on our own haproxy log messages and not other applications\u0027 local0 and local1 log messages, especially now that our rsyslog process occurs so early (ie based on alphabetically sorted name of \"10-haproxy-local-logging.conf\").","accounts_in_message":[],"_revision_number":2},{"id":"a0e59d33dc2664fe9bf74220cb858f74f78ec877","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-23 07:09:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/87/587687/2/check/build-openstack-sphinx-docs/9deb7a9/html/ : SUCCESS in 2m 21s\n- openstack-ansible-linters http://logs.openstack.org/87/587687/2/check/openstack-ansible-linters/7016e39/ : SUCCESS in 5m 10s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/87/587687/2/check/openstack-ansible-functional-centos-7/ade863c/ : SUCCESS in 8m 31s\n- openstack-ansible-functional-opensuse-150 http://logs.openstack.org/87/587687/2/check/openstack-ansible-functional-opensuse-150/bf4a3fc/ : SUCCESS in 8m 03s (non-voting)\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/87/587687/2/check/openstack-ansible-functional-opensuse-423/70445f0/ : SUCCESS in 6m 38s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/87/587687/2/check/openstack-ansible-functional-ubuntu-bionic/622e226/ : SUCCESS in 8m 16s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/87/587687/2/check/openstack-ansible-functional-ubuntu-xenial/e03b0d1/ : SUCCESS in 6m 35s\n- openstack-tox-docs http://logs.openstack.org/87/587687/2/check/openstack-tox-docs/067715a/html/ : SUCCESS in 2m 15s","accounts_in_message":[],"_revision_number":2},{"id":"5029a7e01155cfed71d036f5cf44bd9858e6a0eb","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2018-09-23 20:38:46.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"97dcddeb86922279bc22820cdeae301b230210d7","author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"date":"2018-09-25 09:41:25.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d4fe9fbd5752f4dfeb762f0ea2d7dfe8c3d7efbb","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2018-11-10 09:48:06.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"0e6c5f760fbab1cbad8c054b9e5ca3709ad3b6f2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-10 09:48:17.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"948b9480e5493d1cd51578332d46c9260fb02040","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-10 10:00:50.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/87/587687/2/gate/openstack-ansible-linters/8b40337/ : SUCCESS in 5m 54s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/87/587687/2/gate/openstack-ansible-functional-centos-7/ecad8de/ : SUCCESS in 7m 43s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/87/587687/2/gate/openstack-ansible-functional-opensuse-423/6392fa7/ : SUCCESS in 9m 48s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/87/587687/2/gate/openstack-ansible-functional-ubuntu-bionic/35b3223/ : SUCCESS in 6m 24s\n- openstack-tox-docs http://logs.openstack.org/87/587687/2/gate/openstack-tox-docs/8bab269/html/ : SUCCESS in 2m 30s","accounts_in_message":[],"_revision_number":2},{"id":"12c99f8d9efd9a694bcb45599f70366511608cf5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-10 10:00:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1e0aa6bf473e634d7f7c92561c3fbc3128ae2be3","revisions":{"6691127d25d416ac243184fb53041c0eadcefde3":{"kind":"REWORK","_number":1,"created":"2018-08-01 04:58:15.000000000","uploader":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"ref":"refs/changes/87/587687/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-haproxy_server","ref":"refs/changes/87/587687/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/87/587687/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/87/587687/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/87/587687/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/87/587687/1"}}},"commit":{"parents":[{"commit":"7015fc3dbbe09dc461436ca3549b2bd53398b67f","subject":"Remove the unnecessary space","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/7015fc3dbbe09dc461436ca3549b2bd53398b67f"}]}],"author":{"name":"Corey Wright","email":"corey.wright@rackspace.com","date":"2018-07-31 09:47:01.000000000","tz":-300},"committer":{"name":"Corey Wright","email":"corey.wright@rackspace.com","date":"2018-08-01 04:58:15.000000000","tz":-300},"subject":"Allow rsyslog to log HAProxy locally","message":"Allow rsyslog to log HAProxy locally\n\n* Install haproxy-logging.cfg numerically before Ubuntu\u0027s\n  /etc/rsyslog.d/49-haproxy.conf so its logging directives see HAProxy\n  logs before they are discarded by 49-haproxy.conf.\n* Set owner of /var/log/haproxy to rsyslog\u0027s `syslog` user so rsyslog\n  can write to it on Ubuntu.\n\nChange-Id: Ic259abc281619ba5ee8f020ac68373858a06e94d\nCloses-Bug: #1783886\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/6691127d25d416ac243184fb53041c0eadcefde3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/6691127d25d416ac243184fb53041c0eadcefde3"}]},"branch":"refs/heads/master"},"1e0aa6bf473e634d7f7c92561c3fbc3128ae2be3":{"kind":"REWORK","_number":2,"created":"2018-09-23 06:04:24.000000000","uploader":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"ref":"refs/changes/87/587687/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-haproxy_server","ref":"refs/changes/87/587687/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/87/587687/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/87/587687/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/87/587687/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/87/587687/2"}}},"commit":{"parents":[{"commit":"7015fc3dbbe09dc461436ca3549b2bd53398b67f","subject":"Remove the unnecessary space","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/7015fc3dbbe09dc461436ca3549b2bd53398b67f"}]}],"author":{"name":"Corey Wright","email":"corey.wright@rackspace.com","date":"2018-07-31 09:47:01.000000000","tz":-300},"committer":{"name":"Corey Wright","email":"corey.wright@rackspace.com","date":"2018-09-23 05:58:47.000000000","tz":-300},"subject":"Allow rsyslog to log HAProxy locally","message":"Allow rsyslog to log HAProxy locally\n\n* Install haproxy-logging.cfg numerically before Ubuntu\u0027s\n  /etc/rsyslog.d/49-haproxy.conf so its logging directives see HAProxy\n  logs before they are discarded by 49-haproxy.conf.\n* Set owner of /var/log/haproxy to rsyslog\u0027s `syslog` user so rsyslog\n  can write to it on Ubuntu.\n* Limit HAProxy-related rsyslog processing to HAProxy log messages\n  instead of any/all log messages with the local0 or local1 facility\n  and assuming HAProxy is the only application using those facilities.\n\nChange-Id: Ic259abc281619ba5ee8f020ac68373858a06e94d\nCloses-Bug: #1783886\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/1e0aa6bf473e634d7f7c92561c3fbc3128ae2be3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/1e0aa6bf473e634d7f7c92561c3fbc3128ae2be3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}