)]}'
{"templates/service.j2":[{"author":{"_account_id":2463,"name":"Florian Haas","email":"florian.haas@cleura.com","username":"fghaas"},"change_message_id":"c867b18b2f4ae89d9ad397c34a18347d042278b8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{% endfor %}"},{"line_number":24,"context_line":"{% endif -%}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% for vip_address in extra_lb_tls_vip_addresses %}"},{"line_number":27,"context_line":"  {% set _ \u003d vip_binds.append(vip_address) %}"},{"line_number":28,"context_line":"{% endfor %}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_7133ed13","line":26,"updated":"2020-01-31 15:45:34.000000000","message":"Is there a particular reason why extra_lb_tls_vip_addresses has an empty-list default, and thus doesn\u0027t need to be wrapped in \n\n{%- if extra_lb_tls_vip_addresses is defined %}\n\n... whereas extra_lb_vip_addresses, in contrast, has no default and thus does use an \"is defined\" check?\n\nIn terms of POLA, I\u0027d guess there should either be a default for both, or a default for neither.","commit_id":"b7834dd051cff7d6c26a2f92159099d743256836"},{"author":{"_account_id":23922,"name":"Magnus Bergman","email":"mb@citynetwork.se","username":"magnusbe"},"change_message_id":"96dcf24757a52ccf20cc759b2f741ba6fbfad1aa","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{% endfor %}"},{"line_number":24,"context_line":"{% endif -%}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% for vip_address in extra_lb_tls_vip_addresses %}"},{"line_number":27,"context_line":"  {% set _ \u003d vip_binds.append(vip_address) %}"},{"line_number":28,"context_line":"{% endfor %}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_eb6e09ca","line":26,"in_reply_to":"3fa7e38b_7133ed13","updated":"2020-01-31 20:08:01.000000000","message":"Good catch!\nYeah, the reason is that in the bind line below I check if vip_bind is in extra_lb_tls_vip_addresses to determine if TLS should be enabled for that VIP or not. extr_lb_vip_addresses is not used in that way.\n\nI did however suggest aligning the two variables for clarity to mnaser before submitting this patch and we decided that should go into a separate patch. So it will also be submitted soon. Just didn\u0027t get there today.","commit_id":"b7834dd051cff7d6c26a2f92159099d743256836"}]}