)]}'
{"id":"openstack%2Fopenstack-ansible-haproxy_server~724086","triplet_id":"openstack%2Fopenstack-ansible-haproxy_server~master~Iebc4a293fa8e3566bc910de305e6519a25f2884f","project":"openstack/openstack-ansible-haproxy_server","branch":"master","topic":"certbot-ha","hashtags":[],"change_id":"Iebc4a293fa8e3566bc910de305e6519a25f2884f","subject":"Allow ansible group for self signed certificate distribution to be overidden","status":"MERGED","created":"2020-04-28 16:46:53.000000000","updated":"2020-05-07 18:54:52.000000000","submitted":"2020-05-07 18:54:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"724086-1588877692938-2682b9c6","meta_rev_id":"8afcb03190e4de354abe190a5bfa65c12fa55852","_number":724086,"virtual_id_number":724086,"owner":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-05-07 18:54:52.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":2,"date":"2020-05-07 13:16:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":2,"date":"2020-05-07 13:16:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":1,"date":"2020-05-07 18:36:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-06 16:47:18.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2020-05-07 18:36:50.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2020-05-07 18:54:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fc1b21944f41c9c6dab1994463bce2c177b8df9e","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-04-28 16:46:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f557fb2e7e7501a96b125a387c145687f6dc266b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-28 17:19:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/9b3a7c2d98524c9c9b375ce8787a5892 : SUCCESS in 7m 36s\n- openstack-ansible-functional-debian-buster https://zuul.opendev.org/t/openstack/build/49e629a6dbbd4b56b04c9f24f934a322 : SUCCESS in 9m 10s\n- openstack-ansible-functional-centos-7 https://zuul.opendev.org/t/openstack/build/23b193408eb0473f8cde160cf671f794 : SUCCESS in 10m 17s\n- openstack-ansible-functional-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0919a2e38546485583cc4c0f7770f042 : SUCCESS in 11m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/750cd52bf77844538a03e40f93498c62 : SUCCESS in 9m 42s","accounts_in_message":[],"_revision_number":1},{"id":"5fdf3e5f0928571784b83ccff28b360765fd4441","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-05-05 13:00:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b0ca88c75087c35d43ae10468570172b8a91b0fb","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-05-06 16:47:18.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"df0160c9a953ae31332040b93a40cc422918680d","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-05-07 13:16:18.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"b07cc5fa039e34ddf743d0f7959e5952598d66f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-07 13:42:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/1265032114d54605bc13ce07d81cf52e : SUCCESS in 13m 07s\n- openstack-ansible-functional-debian-buster https://zuul.opendev.org/t/openstack/build/e9393a8c0ad746509796655f5835ea08 : SUCCESS in 13m 36s\n- openstack-ansible-functional-centos-7 https://zuul.opendev.org/t/openstack/build/c8c81edc880a4597832cfd3d2a8affc6 : SUCCESS in 9m 33s\n- openstack-ansible-functional-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/644bd21bb5a64882b398171ce20bfaeb : SUCCESS in 8m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b49efe7af53a4b779498da120b8c6a72 : SUCCESS in 5m 52s","accounts_in_message":[],"_revision_number":2},{"id":"ee8942982957cf80c647b55923bcc0390304a4d7","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-05-07 18:36:50.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"57fb5ad6be355b738cfc6ab463ee224718856c91","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-07 18:37:05.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9aedbcce5e7c5d1d73b831c7cd7549bddddef7f8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-07 18:54:52.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"017ad5c25db06872f0d6039575e746f5b9ba6171","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-07 18:54:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/51652e86245042f1b416a82dbb21ada6 : SUCCESS in 8m 33s\n- openstack-ansible-functional-debian-buster https://zuul.opendev.org/t/openstack/build/8a045a23962e4d9fad8956288f64662f : SUCCESS in 12m 13s\n- openstack-ansible-functional-centos-7 https://zuul.opendev.org/t/openstack/build/1c0487de984140b5b37621fb09e2a131 : SUCCESS in 11m 55s\n- openstack-ansible-functional-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/89812625545b43f49fcbee482421f2d4 : SUCCESS in 10m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cc5d53ee4df5400f970d1041100391a5 : SUCCESS in 6m 29s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"aa737c5c424fa7fab43b2518e1bda25db9a8241f","revisions":{"a970be33e4113a2f58d96c93ae1e8d0add8ef706":{"kind":"REWORK","_number":1,"created":"2020-04-28 16:46:53.000000000","uploader":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"ref":"refs/changes/86/724086/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-haproxy_server","ref":"refs/changes/86/724086/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/86/724086/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/86/724086/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/86/724086/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/86/724086/1"}}},"commit":{"parents":[{"commit":"db713c0a617fd1e9200c2a8916aa3762829dc3ef","subject":"Allow backend healthcheck interval to be overridden per service","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/db713c0a617fd1e9200c2a8916aa3762829dc3ef"}]}],"author":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2020-04-28 16:08:44.000000000","tz":60},"committer":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2020-04-28 16:45:05.000000000","tz":60},"subject":"Allow ansible group for self signed certificate distribution to be overidden","message":"Allow ansible group for self signed certificate distribution to be overidden\n\nIf this role is used outside the context of openstack-ansible then the\nself signed certificate distribution tasks will fail if the haproxy_all\ngroup is not defined, even if self signed certificates are not being used.\n\nChange-Id: Iebc4a293fa8e3566bc910de305e6519a25f2884f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/a970be33e4113a2f58d96c93ae1e8d0add8ef706"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/a970be33e4113a2f58d96c93ae1e8d0add8ef706"}]},"branch":"refs/heads/master"},"aa737c5c424fa7fab43b2518e1bda25db9a8241f":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-05-07 13:16:18.000000000","uploader":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"ref":"refs/changes/86/724086/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-haproxy_server","ref":"refs/changes/86/724086/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/86/724086/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/86/724086/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/86/724086/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/86/724086/2"}}},"commit":{"parents":[{"commit":"dbc8fe1fe2ec675655624ec7ee3996b20ee6e7a4","subject":"Use a certbot pre-hook to ensure haproxy backend is up before renewal","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/dbc8fe1fe2ec675655624ec7ee3996b20ee6e7a4"}]}],"author":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2020-04-28 16:08:44.000000000","tz":60},"committer":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2020-05-07 13:16:18.000000000","tz":0},"subject":"Allow ansible group for self signed certificate distribution to be overidden","message":"Allow ansible group for self signed certificate distribution to be overidden\n\nIf this role is used outside the context of openstack-ansible then the\nself signed certificate distribution tasks will fail if the haproxy_all\ngroup is not defined, even if self signed certificates are not being used.\n\nChange-Id: Iebc4a293fa8e3566bc910de305e6519a25f2884f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/aa737c5c424fa7fab43b2518e1bda25db9a8241f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/aa737c5c424fa7fab43b2518e1bda25db9a8241f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
