)]}'
{"id":"openstack%2Fopenstack-ansible-haproxy_server~801910","triplet_id":"openstack%2Fopenstack-ansible-haproxy_server~master~Ib37445ad852bcbd8d44d9eda9293565a4e52262b","project":"openstack/openstack-ansible-haproxy_server","branch":"master","hashtags":[],"change_id":"Ib37445ad852bcbd8d44d9eda9293565a4e52262b","subject":"Fix service removal condition","status":"MERGED","created":"2021-07-22 16:59:11.000000000","updated":"2021-08-31 11:38:13.000000000","submitted":"2021-08-31 11:36:07.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"801910","meta_rev_id":"80b33416bbba93368e8e66813f8dbfa1d66080da","_number":801910,"virtual_id_number":801910,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-08-31 11:36:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"all":[{"value":2,"date":"2021-08-25 12:05:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-08-31 10:00:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-08-31 10:00:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-22 17:04:19.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"CC"},{"updated":"2021-07-22 19:00:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-24 18:19:51.000000000","updated_by":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"reviewer":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"state":"CC"},{"updated":"2021-08-24 18:52:21.000000000","updated_by":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"reviewer":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"state":"REVIEWER"},{"updated":"2021-08-31 10:00:19.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"}],"messages":[{"id":"52f23aa4df62425bf1926ac727306436cb07ca9c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-07-22 16:59:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"047aef1d3753b5a0e3007d047611bac783d38446","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2021-07-22 17:04:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"585fae0b53f96b13e4860926b0692682d58dc4dd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-22 19:00:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/36a792c067bf42ab8bd4ee9cc564ddf2 : SUCCESS in 19m 40s\n- openstack-ansible-deploy-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/ad774c820e454814a4d2d120142e20bc : SUCCESS in 1h 17m 14s\n- openstack-ansible-deploy-infra_lxc-centos-8-stream https://zuul.opendev.org/t/openstack/build/ba48e0a3e651466489d2a5b7056d516c : SUCCESS in 1h 24m 26s\n- openstack-ansible-deploy-infra_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/47ad81e3a063484381e2b88dfa8b5891 : SUCCESS in 1h 09m 50s\n- openstack-ansible-deploy-infra_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/97447afbf5f6431099272be2acba104a : SUCCESS in 1h 03m 22s (non-voting)\n- openstack-ansible-deploy-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c3ce307b444e4ca6b31dea9531a95a02 : SUCCESS in 1h 12m 59s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/dc44d4814bf345a1a9f9be375d8df353 : SUCCESS in 1h 12m 51s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/9496c0fd04204722819a2b46689c7bf5 : SUCCESS in 1h 08m 17s (non-voting)\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/632c6429a854420fb1b4991694cd8bc1 : SUCCESS in 1h 25m 34s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/3ed9db0d0bb240fa8cb530ebca5503b9 : SUCCESS in 1h 20m 52s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b0f3fe6de6264db09d7acb41b5bcb1be : SUCCESS in 1h 20m 22s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/98e12521c3734a8795bc3bdf777cd4a2 : SUCCESS in 1h 09m 40s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/61a66a3ac0224868b226c9d00a67d323 : SUCCESS in 1h 58m 30s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a284f6a8fd2f42c5b06d0ae549cdfb1e : SUCCESS in 1h 49m 20s\n- openstack-ansible-upgrade-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/3086d681f33a4373aedadcada3fb6af8 : SUCCESS in 1h 31m 13s (non-voting)\n- openstack-ansible-upgrade-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/416f4d575616445b97041199572a1f69 : FAILURE in 1h 20m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e97dbd359759460b90ae1b5490371946 : SUCCESS in 6m 53s","accounts_in_message":[],"_revision_number":1},{"id":"e744cfca30eb2cada8045041558b911845e3238c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-07-23 12:25:29.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"fda307994572df783d33624cbafca1c41e4636cd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-23 13:56:00.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e24fa8ebc4854064a759559c904c7006 : SUCCESS in 21m 01s\n- openstack-ansible-deploy-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/c2d20659bf4f44409cb9b24631f5c420 : SUCCESS in 1h 22m 57s\n- openstack-ansible-deploy-infra_lxc-centos-8-stream https://zuul.opendev.org/t/openstack/build/79bc3cc69f1942f6a9fbae05ddcb5654 : SUCCESS in 1h 24m 00s\n- openstack-ansible-deploy-infra_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/89f4250db9244585acc26f1ae9e5d67a : SUCCESS in 1h 05m 13s\n- openstack-ansible-deploy-infra_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/948b2f1a431543e3a1e4365f43a35aa4 : SUCCESS in 1h 14m 49s (non-voting)\n- openstack-ansible-deploy-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c7e336720dba46af843fa80085f2d176 : SUCCESS in 1h 06m 32s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/031f14ef3bd645c9b3b94b2b389bb501 : SUCCESS in 1h 22m 12s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/68fee8865f84433e92602b6f36dcc774 : SUCCESS in 1h 07m 38s (non-voting)\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/081e98c03fac4c86a34d9af4cc8eaf7a : SUCCESS in 1h 19m 22s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/d105f8db85e0416dad2da38d97b49166 : SUCCESS in 1h 11m 09s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f0b051f96d0046cb9602cff3d0316680 : SUCCESS in 1h 23m 13s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/377a3c15f96a479e8d8a01466bac814c : SUCCESS in 1h 14m 48s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/7971e208edea46f09509095e326629bb : FAILURE in 17m 07s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ca6e85760a7c4bacbb79a67d80f971a2 : FAILURE in 23m 37s\n- openstack-ansible-upgrade-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/581e37f19c7a48b28612aef2be56a2ce : FAILURE in 16m 23s (non-voting)\n- openstack-ansible-upgrade-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5887dc0aef124488942e452dadf8dcb7 : FAILURE in 15m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/301c729073ff499aba8ba0081c80e59a : SUCCESS in 6m 22s","accounts_in_message":[],"_revision_number":2},{"id":"d8cfeebfe43a0724731889629e7259f808a793a8","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-08-23 11:22:22.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"0c18cdcf63ad0738f21e605bd1022f4764861b19","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-23 14:37:00.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5ab158efa1ce409f8f5e36c4b3019ba6 : SUCCESS in 17m 17s\n- openstack-ansible-deploy-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/60b7c6aa32054215ad517a5672cfb13f : SUCCESS in 1h 27m 33s\n- openstack-ansible-deploy-infra_lxc-centos-8-stream https://zuul.opendev.org/t/openstack/build/17d47a97ffda4b2f8bfe4980122a5569 : SUCCESS in 1h 25m 58s\n- openstack-ansible-deploy-infra_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/91e648cd75a44ca1a36c79d27c1023d0 : TIMED_OUT in 3h 12m 05s\n- openstack-ansible-deploy-infra_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/49c1ce37cbda4baa8ebe158faf56b138 : SUCCESS in 1h 09m 52s (non-voting)\n- openstack-ansible-deploy-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ef9f8d21bbb646b4a8a18085b15b9af2 : SUCCESS in 1h 13m 52s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/0327d66a2c574a6bb713b407f2e1ba5a : SUCCESS in 1h 21m 35s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/a1acafb6fe774c03acb2f2f9938ce468 : SUCCESS in 1h 10m 17s (non-voting)\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/afd18116a2a448c2a40389a495ab57c1 : SUCCESS in 1h 26m 44s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/abf90c536d1f462e9c430455d7d08379 : SUCCESS in 1h 27m 13s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e1c2d3c6b6e24899bd025e97c9c47da7 : SUCCESS in 1h 17m 58s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/45b90077d3d94f1e8ec629bc884c2bd2 : SUCCESS in 1h 09m 57s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/c438b864c2984726bb465ba9ffdda290 : SUCCESS in 2h 06m 30s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d828d539e2e54ba9bade924d75ab773f : SUCCESS in 1h 34m 28s\n- openstack-ansible-upgrade-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/ac62acedb4ed43f797074fba8b7b865e : SUCCESS in 1h 38m 39s (non-voting)\n- openstack-ansible-upgrade-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/18b3907aa44d438b854a20a33f0af6e1 : FAILURE in 1h 05m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3c618ed605494629a7f2b6666905a001 : SUCCESS in 6m 13s","accounts_in_message":[],"_revision_number":2},{"id":"0a105339c2817fd9f9172a662ac0c45a1837589b","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-08-24 05:44:37.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"04db93749e4a643ca9b7c2d1255e7d89f513b417","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-24 07:54:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6f7bb0683dda4b19893bc4786e8c7445 : SUCCESS in 13m 11s\n- openstack-ansible-deploy-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/4ebe87c1bfa748c6966bc3089f8a651c : SUCCESS in 1h 22m 48s\n- openstack-ansible-deploy-infra_lxc-centos-8-stream https://zuul.opendev.org/t/openstack/build/47b6cd79313d41988c803a2d71a80ff1 : SUCCESS in 1h 28m 14s\n- openstack-ansible-deploy-infra_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/89a8b7957b184e62bfb851bcf30465e5 : SUCCESS in 1h 10m 12s\n- openstack-ansible-deploy-infra_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/ac8a7a229a9543f88a9d2cd04f7f4882 : SUCCESS in 1h 05m 41s (non-voting)\n- openstack-ansible-deploy-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/10c49c320a0b46818e12307029b7f062 : SUCCESS in 1h 16m 12s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/f433e7ce349547359dc5fca182d52639 : SUCCESS in 1h 17m 08s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/46892c82e37a45e1b14f087aa7fe81b9 : SUCCESS in 1h 14m 19s (non-voting)\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/7fc8be805aef43c7921dd2df66b01898 : SUCCESS in 1h 20m 26s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/2622ba6bc3bf489f881d0c91ae28fefa : SUCCESS in 1h 21m 27s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/73e5dc0714fe42ac93823d45c175ae13 : SUCCESS in 1h 16m 20s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a85a6bf835c64ee7b0fa3e4859b9c9a9 : SUCCESS in 1h 07m 41s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/ba3df23e4dcf4415a2534d25afb4f64b : SUCCESS in 2h 02m 19s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/11a8c11c68864f7aa81b0a925c7ffcb5 : SUCCESS in 1h 40m 01s\n- openstack-ansible-upgrade-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/914ffaedb2074d388406b2c0a884e96f : SUCCESS in 1h 35m 53s (non-voting)\n- openstack-ansible-upgrade-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/65761d28c01e438389ce7ba80c885117 : SUCCESS in 1h 24m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d3ca576aefe94b46b4ca47681179e992 : SUCCESS in 6m 16s","accounts_in_message":[],"_revision_number":2},{"id":"81bad1ada73ad5295bba45dbf964723a419e191c","author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"date":"2021-08-24 18:19:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b4f5ac8ddd1ee4d5ef2869461a09fbe7e5bd77e1","author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"date":"2021-08-24 18:52:21.000000000","message":"Patch Set 2: Code-Review-1","accounts_in_message":[],"_revision_number":2},{"id":"98b7ceb64365cf3560c64022447510403dfc84ce","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2021-08-25 07:59:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fde1da8ceef7a88831378d4ab644e210609e8490","author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"date":"2021-08-25 12:05:04.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5889d6942e3a882756194a82443343f574d01008","author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"date":"2021-08-25 12:05:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8ad315203f0548ec65f115eade000e2ef30f6d21","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2021-08-31 10:00:19.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"28d4179e04ad3805d9f00d79aaa5522e447c48c2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-31 10:02:11.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"51f437e7516d2198bd4d71be8090e6773195fd87","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-31 11:36:07.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/41b7bae9a1bb4c83aa23e3f13f33f962 : SUCCESS in 15m 08s\n- openstack-ansible-deploy-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/cd15f9d1e84c4b149c477f4cad68948f : SUCCESS in 1h 21m 49s\n- openstack-ansible-deploy-infra_lxc-centos-8-stream https://zuul.opendev.org/t/openstack/build/cd04b0e0ee1a4468b2fb735691a8f318 : SUCCESS in 1h 27m 14s\n- openstack-ansible-deploy-infra_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/d7f7ece179184d3788321e3e761fa957 : SUCCESS in 1h 26m 14s\n- openstack-ansible-deploy-infra_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/14be4202bb3d4a3eaea75d7adbd22c50 : SUCCESS in 1h 13m 46s\n- openstack-ansible-deploy-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/351b55d0e0964a16bd9f922edf337a44 : SUCCESS in 1h 08m 41s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/fd0c0e47ec784b85969888ea93d689a2 : SUCCESS in 1h 13m 05s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/cf15fb22e9c14e9293faf245766d04d4 : SUCCESS in 1h 20m 27s\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/d0ba62d222d944a0a3d7b9aa5e6212ef : SUCCESS in 1h 28m 53s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/3730c4f32b50477ba8433723cbee0225 : SUCCESS in 1h 22m 52s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3536ee3879af4252bab02316b4a77af7 : SUCCESS in 1h 17m 09s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8eee0d4a3e63442680dee37404c41fcc : SUCCESS in 1h 12m 28s\n- openstack-ansible-upgrade-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b5126256aa5c40df97f68e637df1d525 : SUCCESS in 1h 27m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bf863bf1f6994860beec34355f5cf64b : SUCCESS in 6m 32s","accounts_in_message":[],"_revision_number":2},{"id":"81da669bc468f6ea73b05532e4891cacb7fdca4f","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-31 11:36:07.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"80b33416bbba93368e8e66813f8dbfa1d66080da","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-31 11:38:13.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/458950810c8648199e916988daf888b5 : SUCCESS in 1m 33s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"691f81a6d958eff896ce12733af30535878ea5a8","revisions":{"f433fba306f74c13f8c196a7af489bce78ba0cf6":{"kind":"REWORK","_number":1,"created":"2021-07-22 16:59:11.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/10/801910/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-haproxy_server","ref":"refs/changes/10/801910/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/10/801910/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/10/801910/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/10/801910/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/10/801910/1"}}},"commit":{"parents":[{"commit":"1dc4fa621c153f1503933f1bb185d9fef2789f79","subject":"Merge \"Generate self-signed SSL per listen IP\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/1dc4fa621c153f1503933f1bb185d9fef2789f79"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@citynetwork.eu","date":"2021-07-22 16:59:02.000000000","tz":180},"committer":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@citynetwork.eu","date":"2021-07-22 16:59:02.000000000","tz":180},"subject":"Fix service removal condition","message":"Fix service removal condition\n\nIn order to remove service currently we need to satisfy one of\nconditions:\n\n- haproxy_backend_nodes and haproxy_backup_nodes are empty and defined\nbut must be defined\n- haproxy_service_enabled is False\n- state is absent\n\nThere\u0027s big issue with logic regarding haproxy_backend_nodes and\nhaproxy_backup_nodes since they both should be defined and empy,\nbut in case haproxy_backup_nodes is not defined but haproxy_backend_nodes\nis empty we should consider this as condition for removal as well.\nBut this will make it too complicated.\n\nThis change suggest consider rely only on haproxy_service_enabled and\nstate keys of haproxy_service_configs, as it\u0027s sufficient to\ndrop service based on these 2 options.\n\nChange-Id: Ib37445ad852bcbd8d44d9eda9293565a4e52262b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/f433fba306f74c13f8c196a7af489bce78ba0cf6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/f433fba306f74c13f8c196a7af489bce78ba0cf6"}]},"branch":"refs/heads/master"},"691f81a6d958eff896ce12733af30535878ea5a8":{"kind":"REWORK","_number":2,"created":"2021-07-23 12:25:29.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/10/801910/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-haproxy_server","ref":"refs/changes/10/801910/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/10/801910/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/10/801910/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/10/801910/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-haproxy_server refs/changes/10/801910/2"}}},"commit":{"parents":[{"commit":"1dc4fa621c153f1503933f1bb185d9fef2789f79","subject":"Merge \"Generate self-signed SSL per listen IP\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/1dc4fa621c153f1503933f1bb185d9fef2789f79"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@citynetwork.eu","date":"2021-07-22 16:59:02.000000000","tz":180},"committer":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@ya.ru","date":"2021-07-23 12:25:20.000000000","tz":0},"subject":"Fix service removal condition","message":"Fix service removal condition\n\nIn order to remove service currently we need to satisfy one of\nconditions:\n\n- haproxy_backend_nodes and haproxy_backup_nodes are empty and defined\nbut must be defined\n- haproxy_service_enabled is False\n- state is absent\n\nThere\u0027s big issue with logic regarding haproxy_backend_nodes and\nhaproxy_backup_nodes since they both should be defined and empy,\nbut in case haproxy_backup_nodes is not defined but haproxy_backend_nodes\nis empty we should consider this as condition for removal as well.\nBut this will make it too complicated.\n\nThis change suggest consider rely only on haproxy_service_enabled and\nstate keys of haproxy_service_configs, as it\u0027s sufficient to\ndrop service based on these 2 options.\n\nChange-Id: Ib37445ad852bcbd8d44d9eda9293565a4e52262b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/691f81a6d958eff896ce12733af30535878ea5a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/691f81a6d958eff896ce12733af30535878ea5a8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
