)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"44e5823b8e00ccaf1d87a1d476231992725985d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6cfa139e_367eec05","updated":"2022-11-28 10:14:59.000000000","message":"Can we do this without gathering facts for all interfaces? If you know the interface name then it can be limited to just that one.","commit_id":"86f0a34f02f7cca97c4e8947fb667b14e4dd38b0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0aaf35429fe0a6ee5a5c19e7d90b37b127b1b904","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5f31b668_fc96ea4c","updated":"2023-05-26 10:37:08.000000000","message":"This patch looks quite fair to me. Unfortunate part is that we\u0027re not testing it... But it\u0027s different topic I guess.","commit_id":"c1be49a95c1ce4ad0122c7d97e48d8c143d10d0e"},{"author":{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"},"change_message_id":"a152cd24eec03b9c04560ff80b870691409e7b86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a95290f_3d5e0b7f","updated":"2023-05-28 05:05:48.000000000","message":"recheck","commit_id":"c1be49a95c1ce4ad0122c7d97e48d8c143d10d0e"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"4b456093fb2d4e2682c7f96113331c6f8288f95e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"079b19eb_0266c44d","updated":"2023-05-26 07:58:54.000000000","message":"recheck - openstack-ansible-upgrade-infra_lxc-rockylinux-9 - tempest failed","commit_id":"c1be49a95c1ce4ad0122c7d97e48d8c143d10d0e"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"869ca92b3b043e6d569aa9df238ef41f08829d52","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c8d4c1b3_e660ca49","in_reply_to":"01052d3e_74246738","updated":"2023-05-26 12:05:11.000000000","message":"that\u0027s true, we don\u0027t test it. I was planning to implement tests when we will switch default protocol for internal VIP to https:// (probably in 2023.2 or 2024.1)\nWhat do you think?","commit_id":"c1be49a95c1ce4ad0122c7d97e48d8c143d10d0e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1add9576ecb63739c6dd22531f81023780223a3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"01052d3e_74246738","in_reply_to":"5f31b668_fc96ea4c","updated":"2023-05-26 10:42:40.000000000","message":"Eventually, we can add some testing to healthcheck-openstack.yml","commit_id":"c1be49a95c1ce4ad0122c7d97e48d8c143d10d0e"}],"tasks/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"44e5823b8e00ccaf1d87a1d476231992725985d1","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# Required to allow smooth transition to TLS when haproxy is configured to bind to specific interface without specified IP address."},{"line_number":18,"context_line":"- name: Gathering network facts"},{"line_number":19,"context_line":"  setup:"},{"line_number":20,"context_line":"    gather_subset: \"!all,network\""},{"line_number":21,"context_line":"  when: haproxy_bind_external_lb_vip_interface | length \u003e 0 or haproxy_bind_internal_lb_vip_interface | length \u003e 0"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Gather variables for each operating system"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"425cbbdc_dac8cc4d","line":20,"range":{"start_line":20,"start_character":25,"end_line":20,"end_character":32},"updated":"2022-11-28 10:14:59.000000000","message":"we make a lot of effort never to do this - on a controller they may be a very large number of interfaces and facts gathering is slow, also creates a large amount of host fact data.","commit_id":"86f0a34f02f7cca97c4e8947fb667b14e4dd38b0"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"467c9c6a0c33818cb2f5fcbe16b92c082a0c0006","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Required to allow smooth transition to TLS when haproxy is configured to bind to specific interface without specified IP address."},{"line_number":18,"context_line":"- name: Gathering network facts"},{"line_number":19,"context_line":"  setup:"},{"line_number":20,"context_line":"    gather_subset: \"!all,network\""},{"line_number":21,"context_line":"  when: haproxy_bind_external_lb_vip_interface | length \u003e 0 or haproxy_bind_internal_lb_vip_interface | length \u003e 0"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Gather variables for each operating system"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b97644c0_fb1d042f","line":20,"range":{"start_line":20,"start_character":25,"end_line":20,"end_character":32},"in_reply_to":"425cbbdc_dac8cc4d","updated":"2023-05-25 16:55:55.000000000","message":"i dropped task responsible for gathering network facts.","commit_id":"86f0a34f02f7cca97c4e8947fb667b14e4dd38b0"}],"templates/service-redirect.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b4604b127b1a7e462bcf576cb416300066dd1510","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# Temporary redirect to adequate backend(HTTP or HTTPS) in order to allow smooth upgrade process."},{"line_number":5,"context_line":"frontend {{ item.service.haproxy_service_name }}-tcp-redirect-front-{{ loop.index }}"},{"line_number":6,"context_line":"    mode tcp"},{"line_number":7,"context_line":"    bind {{ vip_address }}:{{ item.service.haproxy_port }}"},{"line_number":8,"context_line":"    tcp-request inspect-delay 2s"},{"line_number":9,"context_line":"    tcp-request content accept if HTTP"},{"line_number":10,"context_line":"    tcp-request content accept if { req.ssl_hello_type 1 }"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"71ad2ec1_ed1a77a2","line":7,"updated":"2022-11-25 12:22:11.000000000","message":"can we add vip_interface logic here? Ie\n\n{{ (vip_interface is truthy) | ternary(\u0027 interface \u0027 ~ vip_interface, \u0027\u0027) }}","commit_id":"1f894e4793e12b28c495caa005a3baaaece581b7"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a7fc5c5f4ba360d12a9ada2fde1fd7f4a005b6ef","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# Temporary redirect to adequate backend(HTTP or HTTPS) in order to allow smooth upgrade process."},{"line_number":5,"context_line":"frontend {{ item.service.haproxy_service_name }}-tcp-redirect-front-{{ loop.index }}"},{"line_number":6,"context_line":"    mode tcp"},{"line_number":7,"context_line":"    bind {{ vip_address }}:{{ item.service.haproxy_port }}"},{"line_number":8,"context_line":"    tcp-request inspect-delay 2s"},{"line_number":9,"context_line":"    tcp-request content accept if HTTP"},{"line_number":10,"context_line":"    tcp-request content accept if { req.ssl_hello_type 1 }"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3dd56843_878e8002","line":7,"in_reply_to":"067c0fa3_7d99c2ba","updated":"2022-11-28 08:52:46.000000000","message":"Um, I\u0027d say vip_interface is only applicable for _frontend_ not _backend_. As idea about vip_interface on where/how you bind for listening on traffic. I\u0027m not sure it can or should be re-used for backends section. As asusming we\u0027re talking about public vip - why we would try to return internal traffic to backends through public interface?","commit_id":"1f894e4793e12b28c495caa005a3baaaece581b7"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"467c9c6a0c33818cb2f5fcbe16b92c082a0c0006","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# Temporary redirect to adequate backend(HTTP or HTTPS) in order to allow smooth upgrade process."},{"line_number":5,"context_line":"frontend {{ item.service.haproxy_service_name }}-tcp-redirect-front-{{ loop.index }}"},{"line_number":6,"context_line":"    mode tcp"},{"line_number":7,"context_line":"    bind {{ vip_address }}:{{ item.service.haproxy_port }}"},{"line_number":8,"context_line":"    tcp-request inspect-delay 2s"},{"line_number":9,"context_line":"    tcp-request content accept if HTTP"},{"line_number":10,"context_line":"    tcp-request content accept if { req.ssl_hello_type 1 }"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"81e7bc11_9fc08174","line":7,"in_reply_to":"3dd56843_878e8002","updated":"2023-05-25 16:55:55.000000000","message":"tbh I\u0027m not sure what exactly I had in mind when writing previous message :|","commit_id":"1f894e4793e12b28c495caa005a3baaaece581b7"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"58c1b2416e86f962420a7e560626de770fca52b1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# Temporary redirect to adequate backend(HTTP or HTTPS) in order to allow smooth upgrade process."},{"line_number":5,"context_line":"frontend {{ item.service.haproxy_service_name }}-tcp-redirect-front-{{ loop.index }}"},{"line_number":6,"context_line":"    mode tcp"},{"line_number":7,"context_line":"    bind {{ vip_address }}:{{ item.service.haproxy_port }}"},{"line_number":8,"context_line":"    tcp-request inspect-delay 2s"},{"line_number":9,"context_line":"    tcp-request content accept if HTTP"},{"line_number":10,"context_line":"    tcp-request content accept if { req.ssl_hello_type 1 }"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"067c0fa3_7d99c2ba","line":7,"in_reply_to":"71ad2ec1_ed1a77a2","updated":"2022-11-25 17:41:14.000000000","message":"fixed, it was quite tricky because \"redirect\" backends need to point to some IP address. And when this IP address is not defined, the only idea which came to my mind was to gather network facts.","commit_id":"1f894e4793e12b28c495caa005a3baaaece581b7"}]}