)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6955831c73eb6a109f08fa17a135ab42409853bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1cac0e8c_53c930a4","updated":"2023-03-01 17:04:29.000000000","message":"recheck upgrade job","commit_id":"1b8af5464d2f6ce5c72d9d6b3d5ac8b17496b57c"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"249118ece0d448bb8270eee9cd3d9d9eda392403","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cff6136e_d2e9ed3c","updated":"2023-03-21 08:24:29.000000000","message":"i do not think this patch is required any more given other changes we\u0027ve made","commit_id":"781e99c34bf0b5c98e2ec1d54ad2fd0974ebe671"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"4fda3820ee9e4053ec7df21e4e5f59671d773c76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3e359522_741c28f2","updated":"2023-03-22 06:20:53.000000000","message":"recheck - error at cloudsmith `Failed to download metadata for repo \u0027rabbitmq_rabbitmq-server\u0027: Yum repo downloading error: Downloading error(s): repodata/026822a29a596ffd6a81d9bff97e5281-filelists.xml.gz`","commit_id":"6542555a949d395ec6acf6906cc39702305ba4f4"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"382656da09af821bd7003b5dd88d2e4cafb8e3d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"78c9a1d3_07f4d775","updated":"2023-03-28 13:32:45.000000000","message":"recheck centos failure","commit_id":"6542555a949d395ec6acf6906cc39702305ba4f4"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"164b3be0100ffc50369ee50e3b74994980cd1965","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3c4f5707_50fa5329","updated":"2023-04-05 19:28:16.000000000","message":"recheck gpg issue for centos NFV repo is resolved","commit_id":"47515d4b7c84c94df0cb54ca4fc07f36ca06a256"}],"tasks/haproxy_service_config_external.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"0dc86ffcfe828d35b0283989e092431992119bbd","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ lookup(\u0027first_found\u0027, params) }}\""},{"line_number":18,"context_line":"  vars:"},{"line_number":19,"context_line":"    params:"},{"line_number":20,"context_line":"      files:"},{"line_number":21,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":22,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":23,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":24,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":25,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""},{"line_number":26,"context_line":"      paths:"},{"line_number":27,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- include_tasks: haproxy_service_config.yml"},{"line_number":30,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"00df1a80_11f66483","line":27,"range":{"start_line":16,"start_character":0,"end_line":27,"end_character":32},"updated":"2023-03-01 11:32:45.000000000","message":"the only thing we seem to need in the service config template is the location of the system trust store.\n\nif we were to move that from vars/\u003cfoo.yml\u003e to defaults/main.yml with a ternary to select between redhat/debian OS family then the vars include would not be needed, and this whole file disappears.","commit_id":"cbacebbba8e9872ff0b46b6d4765390b9b9905b5"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1d9a58ca70f2927328737811df23db9be154d55d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ lookup(\u0027first_found\u0027, params) }}\""},{"line_number":18,"context_line":"  vars:"},{"line_number":19,"context_line":"    params:"},{"line_number":20,"context_line":"      files:"},{"line_number":21,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":22,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":23,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":24,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":25,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""},{"line_number":26,"context_line":"      paths:"},{"line_number":27,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- include_tasks: haproxy_service_config.yml"},{"line_number":30,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d17f2c3b_56042482","line":27,"range":{"start_line":16,"start_character":0,"end_line":27,"end_character":32},"in_reply_to":"00df1a80_11f66483","updated":"2023-03-01 13:04:05.000000000","message":"Well. We can do that indeed. But given this file is quite minimalistic and doesn\u0027t contain any unique code I also see no harm having it. While such ternary is quite cumbersome. What if new redhat or debian will move them somewhere - we will be quite locked in. Then we also should think what we can and what can not use from vars.\nSo such minimalistic file is less evil IMO.","commit_id":"cbacebbba8e9872ff0b46b6d4765390b9b9905b5"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"3179861f22ebe3846348413894a654a1a5c1a1b9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ lookup(\u0027first_found\u0027, params) }}\""},{"line_number":18,"context_line":"  vars:"},{"line_number":19,"context_line":"    params:"},{"line_number":20,"context_line":"      files:"},{"line_number":21,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":22,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":23,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":24,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":25,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""},{"line_number":26,"context_line":"      paths:"},{"line_number":27,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- include_tasks: haproxy_service_config.yml"},{"line_number":30,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3751aa2e_dead7a5c","line":27,"range":{"start_line":16,"start_character":0,"end_line":27,"end_character":32},"in_reply_to":"d17f2c3b_56042482","updated":"2023-03-01 13:06:41.000000000","message":"Sure - no problem","commit_id":"cbacebbba8e9872ff0b46b6d4765390b9b9905b5"}],"tasks/haproxy_service_config_temporary.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"4d04ad7d48296f12ff4b2a335a8d7423db3b087d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2023, Cleura AB"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a60de414_1cab346f","line":1,"updated":"2023-03-16 08:45:05.000000000","message":"is this still required - i\u0027m not sure i see why we need to have the temporary service definitions","commit_id":"c85c9f0c8e1a29b3c2c201a4ef83de3537a9d497"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"40cd9de9cd462f9066b627a19e120a1f1845d21e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2023, Cleura AB"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"582c37b8_7d914a23","line":1,"in_reply_to":"a60de414_1cab346f","updated":"2023-03-16 10:51:53.000000000","message":"you\u0027re probably right, fixed.","commit_id":"c85c9f0c8e1a29b3c2c201a4ef83de3537a9d497"}]}