)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"fa1b8cdffcb21ac325ea0b93a33d7342fc0adeb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"621aae7d_43ecdb94","updated":"2023-07-04 09:49:36.000000000","message":"Is there a bunch of reformatting mixed in with the actual change here? The diff view in gerrit looks like many lines are changed but i\u0027m not sure that is real.","commit_id":"1ad860196d9311501ca10d46a6b6ec5ee9612464"}],"vars/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9b8261ec46c06e3ddfbd23a39134477a08cb629a","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_haproxy_pki_certificates: |"},{"line_number":27,"context_line":"  {% set _pki_certs \u003d [] %}"},{"line_number":28,"context_line":"  {% for vip in _haproxy_tls_vip_binds %}"},{"line_number":29,"context_line":"  {%   set _vip_interface \u003d vip[\u0027interface\u0027] | default(\u0027\u0027) %}"},{"line_number":30,"context_line":"  {%   set san \u003d \u0027DNS:\u0027 ~ ansible_facts[\u0027hostname\u0027] ~  \u0027,DNS:\u0027 ~ ansible_facts[\u0027fqdn\u0027] ~ \u0027,\u0027 ~ (vip[\u0027address\u0027] | ansible.utils.ipaddr) | ternary(\u0027IP:\u0027, \u0027DNS:\u0027) ~ vip[\u0027address\u0027] %}"},{"line_number":31,"context_line":"  {%   if vip[\u0027address\u0027] \u003d\u003d haproxy_bind_internal_lb_vip_address %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"71d479a9_ddb955bc","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":38},"updated":"2023-07-04 09:54:51.000000000","message":"oh i now see why this line is changed.\n\nAdding the _ here means that this overriding haproxy_tls_vip_binds from defaults/main.yml no longer has an effect here, is that intended?","commit_id":"1ad860196d9311501ca10d46a6b6ec5ee9612464"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4f66a5c2aa61a135550516d9c56689ed3f304340","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_haproxy_pki_certificates: |"},{"line_number":27,"context_line":"  {% set _pki_certs \u003d [] %}"},{"line_number":28,"context_line":"  {% for vip in _haproxy_tls_vip_binds %}"},{"line_number":29,"context_line":"  {%   set _vip_interface \u003d vip[\u0027interface\u0027] | default(\u0027\u0027) %}"},{"line_number":30,"context_line":"  {%   set san \u003d \u0027DNS:\u0027 ~ ansible_facts[\u0027hostname\u0027] ~  \u0027,DNS:\u0027 ~ ansible_facts[\u0027fqdn\u0027] ~ \u0027,\u0027 ~ (vip[\u0027address\u0027] | ansible.utils.ipaddr) | ternary(\u0027IP:\u0027, \u0027DNS:\u0027) ~ vip[\u0027address\u0027] %}"},{"line_number":31,"context_line":"  {%   if vip[\u0027address\u0027] \u003d\u003d haproxy_bind_internal_lb_vip_address %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f47038ee_059a8f77","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":38},"in_reply_to":"71d479a9_ddb955bc","updated":"2023-07-04 15:05:57.000000000","message":"If it is - you should drop definition from defaults, but I would discourage doing so.","commit_id":"1ad860196d9311501ca10d46a6b6ec5ee9612464"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"c27b10907f1e7523e778c8afa466400088c1a720","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_haproxy_pki_certificates: |"},{"line_number":27,"context_line":"  {% set _pki_certs \u003d [] %}"},{"line_number":28,"context_line":"  {% for vip in _haproxy_tls_vip_binds %}"},{"line_number":29,"context_line":"  {%   set _vip_interface \u003d vip[\u0027interface\u0027] | default(\u0027\u0027) %}"},{"line_number":30,"context_line":"  {%   set san \u003d \u0027DNS:\u0027 ~ ansible_facts[\u0027hostname\u0027] ~  \u0027,DNS:\u0027 ~ ansible_facts[\u0027fqdn\u0027] ~ \u0027,\u0027 ~ (vip[\u0027address\u0027] | ansible.utils.ipaddr) | ternary(\u0027IP:\u0027, \u0027DNS:\u0027) ~ vip[\u0027address\u0027] %}"},{"line_number":31,"context_line":"  {%   if vip[\u0027address\u0027] \u003d\u003d haproxy_bind_internal_lb_vip_address %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"11404443_17886d06","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":38},"in_reply_to":"f47038ee_059a8f77","updated":"2023-07-07 09:42:08.000000000","message":"That was a mistake, thanks for pointing that out.\n\nI\u0027ve removed all formatting changes from this change.","commit_id":"1ad860196d9311501ca10d46a6b6ec5ee9612464"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"92e50897ca04f166ab2440c39741489055a9eee4","unresolved":true,"context_lines":[{"line_number":28,"context_line":"  {% for vip in haproxy_tls_vip_binds %}"},{"line_number":29,"context_line":"  {% set _vip_interface \u003d vip[\u0027interface\u0027] | default(\u0027\u0027) %}"},{"line_number":30,"context_line":"  {% set san \u003d \u0027DNS:\u0027 ~ ansible_facts[\u0027hostname\u0027] ~  \u0027,DNS:\u0027 ~ ansible_facts[\u0027fqdn\u0027] ~ \u0027,\u0027 ~ (vip[\u0027address\u0027] | ansible.utils.ipaddr) | ternary(\u0027IP:\u0027, \u0027DNS:\u0027) ~ vip[\u0027address\u0027] %}"},{"line_number":31,"context_line":"  {% if vip[\u0027address\u0027] \u003d\u003d haproxy_bind_internal_lb_vip_address %}"},{"line_number":32,"context_line":"  {%   set san \u003d san ~ (internal_lb_vip_address | ansible.utils.ipaddr) | ternary(\u0027\u0027, \u0027,DNS:\u0027 ~ internal_lb_vip_address) %}"},{"line_number":33,"context_line":"  {% endif %}"},{"line_number":34,"context_line":"  {% if vip[\u0027address\u0027] \u003d\u003d haproxy_bind_external_lb_vip_address %}"},{"line_number":35,"context_line":"  {%   set san \u003d san ~ (external_lb_vip_address | ansible.utils.ipaddr) | ternary(\u0027\u0027, \u0027,DNS:\u0027 ~ external_lb_vip_address) %}"},{"line_number":36,"context_line":"  {% endif %}"},{"line_number":37,"context_line":"  {% set _ \u003d _pki_certs.append("},{"line_number":38,"context_line":"      {"},{"line_number":39,"context_line":"        \u0027name\u0027: \u0027haproxy_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027-\u0027 ~ (_vip_interface is truthy) | ternary(vip[\u0027address\u0027] ~ \u0027-\u0027 ~ _vip_interface, vip[\u0027address\u0027]),"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fd3a0499_92e99b25","line":36,"range":{"start_line":31,"start_character":0,"end_line":36,"end_character":13},"updated":"2023-07-18 11:40:54.000000000","message":"I\u0027m not sure that `haproxy_bind_internal_lb_vip_address` can be same as `haproxy_bind_external_lb_vip_address`, so elif would be more suitable here, but whatever.","commit_id":"3c5d984f2755583367a2313bd273a0b58683814a"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"9c59d430dc87705e623bffc048fef308605e062a","unresolved":true,"context_lines":[{"line_number":28,"context_line":"  {% for vip in haproxy_tls_vip_binds %}"},{"line_number":29,"context_line":"  {% set _vip_interface \u003d vip[\u0027interface\u0027] | default(\u0027\u0027) %}"},{"line_number":30,"context_line":"  {% set san \u003d \u0027DNS:\u0027 ~ ansible_facts[\u0027hostname\u0027] ~  \u0027,DNS:\u0027 ~ ansible_facts[\u0027fqdn\u0027] ~ \u0027,\u0027 ~ (vip[\u0027address\u0027] | ansible.utils.ipaddr) | ternary(\u0027IP:\u0027, \u0027DNS:\u0027) ~ vip[\u0027address\u0027] %}"},{"line_number":31,"context_line":"  {% if vip[\u0027address\u0027] \u003d\u003d haproxy_bind_internal_lb_vip_address %}"},{"line_number":32,"context_line":"  {%   set san \u003d san ~ (internal_lb_vip_address | ansible.utils.ipaddr) | ternary(\u0027\u0027, \u0027,DNS:\u0027 ~ internal_lb_vip_address) %}"},{"line_number":33,"context_line":"  {% endif %}"},{"line_number":34,"context_line":"  {% if vip[\u0027address\u0027] \u003d\u003d haproxy_bind_external_lb_vip_address %}"},{"line_number":35,"context_line":"  {%   set san \u003d san ~ (external_lb_vip_address | ansible.utils.ipaddr) | ternary(\u0027\u0027, \u0027,DNS:\u0027 ~ external_lb_vip_address) %}"},{"line_number":36,"context_line":"  {% endif %}"},{"line_number":37,"context_line":"  {% set _ \u003d _pki_certs.append("},{"line_number":38,"context_line":"      {"},{"line_number":39,"context_line":"        \u0027name\u0027: \u0027haproxy_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027-\u0027 ~ (_vip_interface is truthy) | ternary(vip[\u0027address\u0027] ~ \u0027-\u0027 ~ _vip_interface, vip[\u0027address\u0027]),"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2ff21403_d49685f2","line":36,"range":{"start_line":31,"start_character":0,"end_line":36,"end_character":13},"in_reply_to":"fd3a0499_92e99b25","updated":"2023-07-18 15:18:20.000000000","message":"There is some support for this, tho: https://opendev.org/openstack/openstack-ansible-haproxy_server/src/branch/master/vars/main.yml#L18.","commit_id":"3c5d984f2755583367a2313bd273a0b58683814a"}]}