)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a8e3a36b0455c170a888a4cc8244385b8b45d024","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37f80bfa_86350eec","updated":"2023-07-06 13:10:42.000000000","message":"recheck rocky erlang issue","commit_id":"848e316ef5066cc0937ec9a91e215382373ae243"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"59b9d8086ff92e56733c68fdd20749f814266991","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc6c5e02_4985244b","updated":"2023-07-10 14:54:01.000000000","message":"recheck rocky tls job - random db failure","commit_id":"848e316ef5066cc0937ec9a91e215382373ae243"}],"handlers/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"68a0347fb013958b5e7193371722a97720962a79","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    cat {{ item_base_path ~ \u0027.crt\u0027 }} $(test -f {{ item_base_path  ~ \u0027-ca.crt\u0027 }} \u0026\u0026 echo {{ item_base_path  ~ \u0027-ca.crt\u0027 }}) {{ item_base_path  ~ \u0027.key\u0027 }} \u003e {{ item_base_path  ~ \u0027.pem\u0027 }}"},{"line_number":19,"context_line":"  notify: Reload haproxy"},{"line_number":20,"context_line":"  vars:"},{"line_number":21,"context_line":"    item_interface: \"{{ item[\u0027interface\u0027] | default(\u0027\u0027) }}\""},{"line_number":22,"context_line":"    item_name: \"{{ (\u0027interface\u0027 in item and item[\u0027interface\u0027] is truthy) | ternary(item[\u0027address\u0027] ~ \u0027-\u0027 ~ item_interface, item[\u0027address\u0027]) }}\""},{"line_number":23,"context_line":"    item_base_path: \"{{ haproxy_ssl_cert_path ~ \u0027/haproxy_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027-\u0027 ~ item_name }}\""},{"line_number":24,"context_line":"  with_items: \"{{ haproxy_tls_vip_binds }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2b7d296a_f338c80f","line":21,"range":{"start_line":21,"start_character":41,"end_line":21,"end_character":55},"updated":"2023-07-04 15:10:27.000000000","message":"wouldn\u0027t it make more sense to apply this default here?\nhttps://opendev.org/openstack/openstack-ansible-haproxy_server/src/commit/c1be49a95c1ce4ad0122c7d97e48d8c143d10d0e/vars/main.yml#L22","commit_id":"848e316ef5066cc0937ec9a91e215382373ae243"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"5718dd82275858c380cea31d4c7af97be69130c9","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    cat {{ item_base_path ~ \u0027.crt\u0027 }} $(test -f {{ item_base_path  ~ \u0027-ca.crt\u0027 }} \u0026\u0026 echo {{ item_base_path  ~ \u0027-ca.crt\u0027 }}) {{ item_base_path  ~ \u0027.key\u0027 }} \u003e {{ item_base_path  ~ \u0027.pem\u0027 }}"},{"line_number":19,"context_line":"  notify: Reload haproxy"},{"line_number":20,"context_line":"  vars:"},{"line_number":21,"context_line":"    item_interface: \"{{ item[\u0027interface\u0027] | default(\u0027\u0027) }}\""},{"line_number":22,"context_line":"    item_name: \"{{ (\u0027interface\u0027 in item and item[\u0027interface\u0027] is truthy) | ternary(item[\u0027address\u0027] ~ \u0027-\u0027 ~ item_interface, item[\u0027address\u0027]) }}\""},{"line_number":23,"context_line":"    item_base_path: \"{{ haproxy_ssl_cert_path ~ \u0027/haproxy_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027-\u0027 ~ item_name }}\""},{"line_number":24,"context_line":"  with_items: \"{{ haproxy_tls_vip_binds }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"af1b699e_9f54a55b","line":21,"range":{"start_line":21,"start_character":41,"end_line":21,"end_character":55},"in_reply_to":"2b7d296a_f338c80f","updated":"2023-07-04 15:24:22.000000000","message":"I wasn\u0027t sure about it. \n\nThere are these things: [1], [2], which use `| default(\u0027\u0027)` syntax, but they are in variables, not in handler, so this fix for `extra_lb_tls_vip_addresses` looks alien for both places to me :)\n\n[1] https://opendev.org/openstack/openstack-ansible-haproxy_server/src/commit/c1be49a95c1ce4ad0122c7d97e48d8c143d10d0e/vars/main.yml#L29\n[2] https://opendev.org/openstack/openstack-ansible-haproxy_server/src/commit/c1be49a95c1ce4ad0122c7d97e48d8c143d10d0e/vars/main.yml#L45","commit_id":"848e316ef5066cc0937ec9a91e215382373ae243"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a8e3a36b0455c170a888a4cc8244385b8b45d024","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    cat {{ item_base_path ~ \u0027.crt\u0027 }} $(test -f {{ item_base_path  ~ \u0027-ca.crt\u0027 }} \u0026\u0026 echo {{ item_base_path  ~ \u0027-ca.crt\u0027 }}) {{ item_base_path  ~ \u0027.key\u0027 }} \u003e {{ item_base_path  ~ \u0027.pem\u0027 }}"},{"line_number":19,"context_line":"  notify: Reload haproxy"},{"line_number":20,"context_line":"  vars:"},{"line_number":21,"context_line":"    item_interface: \"{{ item[\u0027interface\u0027] | default(\u0027\u0027) }}\""},{"line_number":22,"context_line":"    item_name: \"{{ (\u0027interface\u0027 in item and item[\u0027interface\u0027] is truthy) | ternary(item[\u0027address\u0027] ~ \u0027-\u0027 ~ item_interface, item[\u0027address\u0027]) }}\""},{"line_number":23,"context_line":"    item_base_path: \"{{ haproxy_ssl_cert_path ~ \u0027/haproxy_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027-\u0027 ~ item_name }}\""},{"line_number":24,"context_line":"  with_items: \"{{ haproxy_tls_vip_binds }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"590a532d_f342e4c4","line":21,"range":{"start_line":21,"start_character":41,"end_line":21,"end_character":55},"in_reply_to":"af1b699e_9f54a55b","updated":"2023-07-06 13:10:42.000000000","message":"ah, ok, fair enough","commit_id":"848e316ef5066cc0937ec9a91e215382373ae243"}]}