)]}'
{"tasks/container_create.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9c89f202de81d8c5a647195b47a4aaaaca5bd168","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      if [ ! -d \"/etc/network/interfaces.d\" ];then"},{"line_number":106,"context_line":"        mkdir -p /etc/network/interfaces.d"},{"line_number":107,"context_line":"      fi"},{"line_number":108,"context_line":"      configmd5sumpre\u003d`cat /etc/network/interfaces.d/{{ item.value.interface }}.cfg 2\u003e/dev/null | md5sum | cut -d \u0027 \u0027 -f1`"},{"line_number":109,"context_line":"      echo -e \u0027{{ lxc_container_interface }}\u0027 | tee /etc/network/interfaces.d/{{ item.value.interface }}.cfg"},{"line_number":110,"context_line":"      configmd5sumpost\u003d`cat /etc/network/interfaces.d/{{ item.value.interface }}.cfg 2\u003e/dev/null | md5sum | cut -d \u0027 \u0027 -f1`"},{"line_number":111,"context_line":"      if [ \"$configmd5sumpost\" !\u003d \"$configmd5sumpre\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9aed3d3a_8bc29932","line":108,"updated":"2016-02-29 15:01:10.000000000","message":"Can\u0027t you just md5sum \u003cfilename\u003e instead of cat | md5sum | cut ?","commit_id":"8313525a4e070f4ee634ca43917351093999592f"},{"author":{"_account_id":2556,"name":"Evan Callicoat","email":"apsu@propter.net","username":"diopter"},"change_message_id":"4df420c6ddd29cd97b47de7fe5d0661c0324a5bd","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      if [ ! -d \"/etc/network/interfaces.d\" ];then"},{"line_number":106,"context_line":"        mkdir -p /etc/network/interfaces.d"},{"line_number":107,"context_line":"      fi"},{"line_number":108,"context_line":"      configmd5sum\u003d`cat /etc/network/interfaces.d/{{ item.value.interface }}.cfg 2\u003e/dev/null | md5sum | cut -d \u0027 \u0027 -f1`"},{"line_number":109,"context_line":"      echo -e \u0027{{ lxc_container_interface }}\u0027 | tee /etc/network/interfaces.d/{{ item.value.interface }}.cfg"},{"line_number":110,"context_line":"      if ! md5sum -c --status \u003c\u003c\u003c \"$configmd5sum\" 2\u003e/dev/null; then"},{"line_number":111,"context_line":"        ifdown {{ item.value.interface }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aef4532_ea1da067","line":108,"updated":"2016-03-07 15:25:22.000000000","message":"You implemented part of my suggestion but either you missed the changes needed for this line or didn\u0027t realize they were required. You\u0027re still using cat and cut needlessly, and md5sum -c on line 110 needs the full output from md5sum in order to do a --check verification, since it includes the filename. How else will it know which file to verify against?","commit_id":"66ce67081425df352f02a4fb30d7a774e9abd656"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"03918ebc37ad27ad3d75cbccc2de6fae6a56481a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      if [ ! -d \"/etc/network/interfaces.d\" ];then"},{"line_number":106,"context_line":"        mkdir -p /etc/network/interfaces.d"},{"line_number":107,"context_line":"      fi"},{"line_number":108,"context_line":"      configmd5sum\u003d`cat /etc/network/interfaces.d/{{ item.value.interface }}.cfg 2\u003e/dev/null | md5sum | cut -d \u0027 \u0027 -f1`"},{"line_number":109,"context_line":"      echo -e \u0027{{ lxc_container_interface }}\u0027 | tee /etc/network/interfaces.d/{{ item.value.interface }}.cfg"},{"line_number":110,"context_line":"      if ! md5sum -c --status \u003c\u003c\u003c \"$configmd5sum\" 2\u003e/dev/null; then"},{"line_number":111,"context_line":"        ifdown {{ item.value.interface }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aef4532_cac1c430","line":108,"in_reply_to":"5aef4532_ea1da067","updated":"2016-03-07 15:38:56.000000000","message":"Sure Evan, it was a simple oversight - i made the change hastily and didn\u0027t include that fix. thanks.","commit_id":"66ce67081425df352f02a4fb30d7a774e9abd656"}]}
