)]}'
{"tasks/container_create.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"7819f1a940b50eb717e034969cc3b979eadeb431","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"     lxc_container_backing_store: dir"},{"line_number":28,"context_line":"  when: vg_result.rc !\u003d 0"},{"line_number":29,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    - lxc-container-vg-detect"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_379235f7","line":29,"updated":"2016-05-03 14:34:28.000000000","message":"This was removed in https://review.openstack.org/#/c/256784/\nIt broke on earlier versions of Ansible 2 since the fact was delegated to the host and the container would always try to use the default, lvm.\n\nI think delegate_facts is off by default now, but this fact should be set on the container and not the physical host.\nhttp://docs.ansible.com/ansible/playbooks_delegation.html#delegated-facts","commit_id":"6fa867207f0ed935962dd2be3b3d628bb3af159f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"127cab2beda5f8a202d33075dc7900dfc35e62ef","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"     lxc_container_backing_store: dir"},{"line_number":28,"context_line":"  when: vg_result.rc !\u003d 0"},{"line_number":29,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    - lxc-container-vg-detect"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_db832b54","line":29,"in_reply_to":"1a122d0e_379235f7","updated":"2016-05-03 15:08:18.000000000","message":"Done","commit_id":"6fa867207f0ed935962dd2be3b3d628bb3af159f"}],"tests/group_vars/all_containers.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"7819f1a940b50eb717e034969cc3b979eadeb431","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  service_name: \"{{ inventory_hostname }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"global_environment_variables:"},{"line_number":36,"context_line":"  PATH: \"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_d7ab011d","line":36,"updated":"2016-05-03 14:34:28.000000000","message":"Is this needed? The default environment template already includes these paths.","commit_id":"6fa867207f0ed935962dd2be3b3d628bb3af159f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"127cab2beda5f8a202d33075dc7900dfc35e62ef","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  service_name: \"{{ inventory_hostname }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"global_environment_variables:"},{"line_number":36,"context_line":"  PATH: \"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_7b4ad728","line":36,"in_reply_to":"1a122d0e_d7ab011d","updated":"2016-05-03 15:08:18.000000000","message":"its not needed however this was added to exercise the environment variable code path.","commit_id":"6fa867207f0ed935962dd2be3b3d628bb3af159f"}],"tests/test-prepare-host.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"7819f1a940b50eb717e034969cc3b979eadeb431","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - name: Set the files to copy into the container cache for OpenStack-CI instances"},{"line_number":43,"context_line":"      set_fact:"},{"line_number":44,"context_line":"        lxc_container_cache_files:"},{"line_number":45,"context_line":"          - { src: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027, dest: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027 }"},{"line_number":46,"context_line":"      when:"},{"line_number":47,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":48,"context_line":"        - ansible_os_family \u003d\u003d \u0027Debian\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_17a61953","line":45,"updated":"2016-05-03 14:34:28.000000000","message":"This overwrites the same fact in the previous task.\nI tried handling it in another review, there may be a better way.\n\nhttps://review.openstack.org/#/c/286282/24/tests/test-prepare-host.yml","commit_id":"6fa867207f0ed935962dd2be3b3d628bb3af159f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"127cab2beda5f8a202d33075dc7900dfc35e62ef","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - name: Set the files to copy into the container cache for OpenStack-CI instances"},{"line_number":43,"context_line":"      set_fact:"},{"line_number":44,"context_line":"        lxc_container_cache_files:"},{"line_number":45,"context_line":"          - { src: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027, dest: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027 }"},{"line_number":46,"context_line":"      when:"},{"line_number":47,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":48,"context_line":"        - ansible_os_family \u003d\u003d \u0027Debian\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_3b0e9fe5","line":45,"in_reply_to":"1a122d0e_17a61953","updated":"2016-05-03 15:08:18.000000000","message":"good catch. I\u0027ll revise this.","commit_id":"6fa867207f0ed935962dd2be3b3d628bb3af159f"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"d93bc39bd9b4f3a8ec032d2e52906c444c0ecd0e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    - name: Set apt repo facts based on discovered information"},{"line_number":47,"context_line":"      set_fact:"},{"line_number":48,"context_line":"        lxc_container_template_main_apt_repo: \"{{ ubuntu_repo.stdout }}\""},{"line_number":49,"context_line":"        lxc_container_template_security_apt_rep: \"{{ ubuntu_repo.stdout }}\""},{"line_number":50,"context_line":"  roles:"},{"line_number":51,"context_line":"    - role: \"lxc_hosts\""},{"line_number":52,"context_line":"      lxc_net_address: 10.100.100.1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a122d0e_a199e27b","side":"PARENT","line":49,"updated":"2016-05-03 15:32:22.000000000","message":"why was this removed?","commit_id":"f2646d36d89548bd7ed4154aa0ef75a86d94b7b5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7dbc7c70bb636855e2c2d1436fe9f7d81e06a617","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    - name: Set apt repo facts based on discovered information"},{"line_number":47,"context_line":"      set_fact:"},{"line_number":48,"context_line":"        lxc_container_template_main_apt_repo: \"{{ ubuntu_repo.stdout }}\""},{"line_number":49,"context_line":"        lxc_container_template_security_apt_rep: \"{{ ubuntu_repo.stdout }}\""},{"line_number":50,"context_line":"  roles:"},{"line_number":51,"context_line":"    - role: \"lxc_hosts\""},{"line_number":52,"context_line":"      lxc_net_address: 10.100.100.1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a122d0e_648193fb","side":"PARENT","line":49,"in_reply_to":"1a122d0e_4440dc07","updated":"2016-05-03 17:50:50.000000000","message":"ah fair point. We had the vars in this role too which have been removed however for the lxc_hosts role they should be present. This is my mistake.","commit_id":"f2646d36d89548bd7ed4154aa0ef75a86d94b7b5"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"f5fd72872dac5fa7f688211727ee1a8d85a24150","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    - name: Set apt repo facts based on discovered information"},{"line_number":47,"context_line":"      set_fact:"},{"line_number":48,"context_line":"        lxc_container_template_main_apt_repo: \"{{ ubuntu_repo.stdout }}\""},{"line_number":49,"context_line":"        lxc_container_template_security_apt_rep: \"{{ ubuntu_repo.stdout }}\""},{"line_number":50,"context_line":"  roles:"},{"line_number":51,"context_line":"    - role: \"lxc_hosts\""},{"line_number":52,"context_line":"      lxc_net_address: 10.100.100.1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a122d0e_4440dc07","side":"PARENT","line":49,"in_reply_to":"1a122d0e_8153066c","updated":"2016-05-03 15:50:53.000000000","message":"Might be reading this wrong.\nWasn\u0027t it being used for the lxc_hosts role below so that the cache create process uses the same repos as localhost? Or will these vars need to be passed directly to that role?","commit_id":"f2646d36d89548bd7ed4154aa0ef75a86d94b7b5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"28f3beaeee6aad2f8b80777269618d14b38db7dc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    - name: Set apt repo facts based on discovered information"},{"line_number":47,"context_line":"      set_fact:"},{"line_number":48,"context_line":"        lxc_container_template_main_apt_repo: \"{{ ubuntu_repo.stdout }}\""},{"line_number":49,"context_line":"        lxc_container_template_security_apt_rep: \"{{ ubuntu_repo.stdout }}\""},{"line_number":50,"context_line":"  roles:"},{"line_number":51,"context_line":"    - role: \"lxc_hosts\""},{"line_number":52,"context_line":"      lxc_net_address: 10.100.100.1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a122d0e_8153066c","side":"PARENT","line":49,"in_reply_to":"1a122d0e_a199e27b","updated":"2016-05-03 15:38:07.000000000","message":"It\u0027s not used in the container create process. All of that is in the cache create process -- https://github.com/openstack/openstack-ansible-lxc_hosts/blob/master/vars/ubuntu-14.04.yml#L20-L21 -- so there was no need to duplicate that code path. That said I can add it back into the container create process if we think it best.","commit_id":"f2646d36d89548bd7ed4154aa0ef75a86d94b7b5"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"723404f9957791353bedcf2d02f23079bb201044","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    - name: Set apt repo facts based on discovered information"},{"line_number":62,"context_line":"      set_fact:"},{"line_number":63,"context_line":"        lxc_container_template_main_apt_repo: \"{{ ubuntu_repo.stdout }}\""},{"line_number":64,"context_line":"        lxc_container_template_security_apt_rep: \"{{ ubuntu_repo.stdout }}\""},{"line_number":65,"context_line":"  roles:"},{"line_number":66,"context_line":"    - role: \"lxc_hosts\""},{"line_number":67,"context_line":"      lxc_net_address: 10.100.100.1"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_fd753297","line":64,"updated":"2016-05-03 18:58:41.000000000","message":"when clause for Debian/apt and should be good to go","commit_id":"c656d5582a29e14482ea537c9efb6fd1bc3d72e9"}]}