)]}'
{"defaults/main.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"0a80c9ed31908aa4b2ea2aedb09ce0a72694ba89","unresolved":false,"context_lines":[{"line_number":30,"context_line":"lxc_container_fs_type: ext4"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# The container backing store can be set to \u0027overlayfs\u0027 to use overlayfs"},{"line_number":33,"context_line":"# This should only be done for production use with a linux kernel \u003e 3.14"},{"line_number":34,"context_line":"# which is when overlayfs was merged into the mainline kernel."},{"line_number":35,"context_line":"# lxc_container_backing_store: overlayfs"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_f99d7a5a","line":33,"range":{"start_line":33,"start_character":53,"end_line":33,"end_character":72},"updated":"2016-07-04 06:40:25.000000000","message":"The release note says 3.18, which is correct?","commit_id":"0222b141a16262e2c3f15915116b2e558887f0ef"}],"tasks/container_create.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"5594805da2feaa4d9f89101ae4211e58233fd786","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  failed_when: false"},{"line_number":20,"context_line":"  changed_when: vg_result.rc !\u003d 0"},{"line_number":21,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":22,"context_line":"  when: lxc_container_backing_store is not defined"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - lxc-container-vg-detect"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_d4b69787","line":22,"updated":"2016-06-15 06:41:38.000000000","message":"Think this should be\nwhen: lxc_container_backing_store \u003d\u003d \"lvm\"\n\nlxc_container_backing_store defaults to lvm, so it should always be defined and this task is needed to check if lvm is a valid backing store","commit_id":"28ce3aa4b72935811cbba1d9a26851f5ab168263"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"963b8d0ba633521069d35be0e87c26f975c669bd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  failed_when: false"},{"line_number":20,"context_line":"  changed_when: vg_result.rc !\u003d 0"},{"line_number":21,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":22,"context_line":"  when: lxc_container_backing_store is not defined"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - lxc-container-vg-detect"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_fea3a04d","line":22,"in_reply_to":"5a9d85d2_46de1d6e","updated":"2016-07-02 19:00:06.000000000","message":"I\u0027ve applied an auto-detection process which prefers LVM, then dir and only implements overlayfs if it\u0027s specifically set.","commit_id":"28ce3aa4b72935811cbba1d9a26851f5ab168263"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d22c326ffb746d0fb402780cb4208a3a369582e2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  failed_when: false"},{"line_number":20,"context_line":"  changed_when: vg_result.rc !\u003d 0"},{"line_number":21,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":22,"context_line":"  when: lxc_container_backing_store is not defined"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - lxc-container-vg-detect"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a9d85d2_46de1d6e","line":22,"in_reply_to":"7aa08908_d4b69787","updated":"2016-06-21 13:31:00.000000000","message":"+1","commit_id":"28ce3aa4b72935811cbba1d9a26851f5ab168263"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"5594805da2feaa4d9f89101ae4211e58233fd786","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"     lxc_container_backing_store: dir"},{"line_number":29,"context_line":"  when:"},{"line_number":30,"context_line":"    - lxc_container_backing_store is not defined"},{"line_number":31,"context_line":"    - vg_result.rc !\u003d 0"},{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - lxc-container-vg-detect"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_b464ab21","line":30,"updated":"2016-06-15 06:41:38.000000000","message":"when: lxc_container_backing_store \u003d\u003d \"lvm\" here too\nThis task is to fall back to dir if the volume group for lvm wasn\u0027t found","commit_id":"28ce3aa4b72935811cbba1d9a26851f5ab168263"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"963b8d0ba633521069d35be0e87c26f975c669bd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"     lxc_container_backing_store: dir"},{"line_number":29,"context_line":"  when:"},{"line_number":30,"context_line":"    - lxc_container_backing_store is not defined"},{"line_number":31,"context_line":"    - vg_result.rc !\u003d 0"},{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - lxc-container-vg-detect"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_5e8914ca","line":30,"in_reply_to":"5a9d85d2_865645d0","updated":"2016-07-02 19:00:06.000000000","message":"Done","commit_id":"28ce3aa4b72935811cbba1d9a26851f5ab168263"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d22c326ffb746d0fb402780cb4208a3a369582e2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"     lxc_container_backing_store: dir"},{"line_number":29,"context_line":"  when:"},{"line_number":30,"context_line":"    - lxc_container_backing_store is not defined"},{"line_number":31,"context_line":"    - vg_result.rc !\u003d 0"},{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - lxc-container-vg-detect"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a9d85d2_865645d0","line":30,"in_reply_to":"7aa08908_b464ab21","updated":"2016-06-21 13:31:00.000000000","message":"I agree.\n\nOther idea: couldn\u0027t we use a local fact for defining the backing store instead?","commit_id":"28ce3aa4b72935811cbba1d9a26851f5ab168263"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"759af5a640e562beb3c2a2d259628b44ff9ce0c7","unresolved":false,"context_lines":[{"line_number":84,"context_line":"- name: Create container (overlayfs)"},{"line_number":85,"context_line":"  lxc_container:"},{"line_number":86,"context_line":"    name: \"{{ lxc_container_map.distro }}-{{ lxc_container_map.release }}-{{ lxc_container_map.arch }}\""},{"line_number":87,"context_line":"    clone_snapshot: true"},{"line_number":88,"context_line":"    clone_name: \"{{ inventory_hostname }}\""},{"line_number":89,"context_line":"    container_log: \"true\""},{"line_number":90,"context_line":"    config: \"{{ lxc_container_config }}\""},{"line_number":91,"context_line":"    template: \"{{ lxc_container_template }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_f155a2c2","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":42},"updated":"2016-06-15 07:27:48.000000000","message":"These are only available in the ansible 2 lxc_container module.\n1.9 doesn\u0027t seem to notice when the task is skipped, but this would be the first 1.9 breaking change.","commit_id":"28ce3aa4b72935811cbba1d9a26851f5ab168263"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"963b8d0ba633521069d35be0e87c26f975c669bd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"- name: Create container (overlayfs)"},{"line_number":85,"context_line":"  lxc_container:"},{"line_number":86,"context_line":"    name: \"{{ lxc_container_map.distro }}-{{ lxc_container_map.release }}-{{ lxc_container_map.arch }}\""},{"line_number":87,"context_line":"    clone_snapshot: true"},{"line_number":88,"context_line":"    clone_name: \"{{ inventory_hostname }}\""},{"line_number":89,"context_line":"    container_log: \"true\""},{"line_number":90,"context_line":"    config: \"{{ lxc_container_config }}\""},{"line_number":91,"context_line":"    template: \"{{ lxc_container_template }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_9eaa5c18","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":42},"in_reply_to":"7aa08908_f155a2c2","updated":"2016-07-02 19:00:06.000000000","message":"I\u0027ve made a note as a comment. As there\u0027s no way of really detecting the Ansible version used via facts, I figure that this is an experimental feature anyway which would only get traction in Ocata where we\u0027ll be well beyond Ansible 2.0 and this will all work.","commit_id":"28ce3aa4b72935811cbba1d9a26851f5ab168263"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"0a80c9ed31908aa4b2ea2aedb09ce0a72694ba89","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - lxc-container-vg-detect"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Set container backend \"dir\" if \"lvm\" not found"},{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"     lxc_container_backing_store: dir"},{"line_number":29,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_b993f24e","line":26,"updated":"2016-07-04 06:40:25.000000000","message":"Think this might need an intermediate task to set lxc_container_backing_store: lvm if the volume group is found.","commit_id":"0222b141a16262e2c3f15915116b2e558887f0ef"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c7f8334378f6b20d7f4bff2a15f763dc0f62321c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    - lxc-container-create"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# Note (odyssey4me):"},{"line_number":85,"context_line":"# This task will *not* work with Ansible 1.9.x or below"},{"line_number":86,"context_line":"- name: Create container (overlayfs)"},{"line_number":87,"context_line":"  lxc_container:"},{"line_number":88,"context_line":"    name: \"{{ lxc_container_map.distro }}-{{ lxc_container_map.release }}-{{ lxc_container_map.arch }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1aa78d24_b1aea17e","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":55},"updated":"2016-07-13 05:56:23.000000000","message":"maybe a good idea to add a fail notice to the main.yml if overlayfs is set and the ansible version is detected to be \u003c2.1 ?","commit_id":"ce2edbef500a22a1e1cba964ab1bfd5d8b9d541a"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"8ef35fe45025d7e1b824763916b0817bdf4281c5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"- name: Set container backend to \"dir\" or \"lvm\" based on whether the lxc VG was found"},{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"     lxc_container_backing_store: \"{{ (vg_result.rc \u003d\u003d 0) | ternary(\u0027lvm\u0027, \u0027dir\u0027) }}\""},{"line_number":29,"context_line":"  when: vgresult is defined"},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    - lxc-container-vg-detect"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_49ae7699","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":16},"updated":"2016-07-14 04:43:10.000000000","message":"vg_result","commit_id":"42a11c64b9a2ed92e31c85e007e289054ab4a592"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"75570da8b7a58a968cece136d8152b7e258cf435","unresolved":false,"context_lines":[{"line_number":26,"context_line":"- name: Set container backend to \"dir\" or \"lvm\" based on whether the lxc VG was found"},{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"     lxc_container_backing_store: \"{{ (vg_result.rc \u003d\u003d 0) | ternary(\u0027lvm\u0027, \u0027dir\u0027) }}\""},{"line_number":29,"context_line":"  when: vgresult is defined"},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    - lxc-container-vg-detect"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_d54cb5ca","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":16},"in_reply_to":"1aa78d24_49ae7699","updated":"2016-07-14 07:24:19.000000000","message":"Done","commit_id":"42a11c64b9a2ed92e31c85e007e289054ab4a592"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"6dfb30e242b9f3285fe35c507c2fadf4ddb7019f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    clone_snapshot: true"},{"line_number":80,"context_line":"    clone_name: \"{{ inventory_hostname }}\""},{"line_number":81,"context_line":"    container_log: \"true\""},{"line_number":82,"context_line":"    config: \"{{ lxc_container_config }}\""},{"line_number":83,"context_line":"    template: \"{{ lxc_container_template }}\""},{"line_number":84,"context_line":"    state: stopped"},{"line_number":85,"context_line":"    backing_store: \"{{ lxc_container_backing_store }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_673ee9db","line":82,"updated":"2016-07-14 13:10:20.000000000","message":"config doesn\u0027t seem to be applied (along with a few other options) when cloning, so new containers are not configured to autoboot or added to the openstack group.\nhttps://github.com/ansible/ansible-modules-extras/blob/devel/cloud/lxc/lxc_container.py#L473-L479\n\nhttps://github.com/openstack/openstack-ansible-lxc_hosts/blob/master/templates/lxc-openstack.conf.j2","commit_id":"2c6b21611772ef1e24d33adcc0deda449ee23662"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"856f9ba234dc9da888bb55db14fb2fcc4bf0bfa0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    clone_snapshot: true"},{"line_number":80,"context_line":"    clone_name: \"{{ inventory_hostname }}\""},{"line_number":81,"context_line":"    container_log: \"true\""},{"line_number":82,"context_line":"    config: \"{{ lxc_container_config }}\""},{"line_number":83,"context_line":"    template: \"{{ lxc_container_template }}\""},{"line_number":84,"context_line":"    state: stopped"},{"line_number":85,"context_line":"    backing_store: \"{{ lxc_container_backing_store }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_8a92f549","line":82,"in_reply_to":"1aa78d24_673ee9db","updated":"2016-07-14 14:49:52.000000000","message":"Good catch. The reason those aren\u0027t applied is that the clone/copy command doesn\u0027t support them. I\u0027ll have to add another task to apply that config.","commit_id":"2c6b21611772ef1e24d33adcc0deda449ee23662"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"a6417db0158346c59047a140f9e9ccc40803da10","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    name: \"{{ inventory_hostname }}\""},{"line_number":60,"context_line":"    container_log: \"true\""},{"line_number":61,"context_line":"    template: \"{{ lxc_container_template }}\""},{"line_number":62,"context_line":"    state: stopped"},{"line_number":63,"context_line":"    backing_store: \"{{ lxc_container_backing_store }}\""},{"line_number":64,"context_line":"    directory: \"{{ lxc_container_rootfs_directory }}\""},{"line_number":65,"context_line":"    fs_size: \"{{ lxc_container_fs_size }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1aa78d24_1bd75950","line":62,"updated":"2016-07-15 04:30:05.000000000","message":"This is stopping/restarting all containers during each run of the role.","commit_id":"0f8e5bdf27eb7277bd532395644b3ff0a264b5c1"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"a6417db0158346c59047a140f9e9ccc40803da10","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    clone_snapshot: true"},{"line_number":79,"context_line":"    clone_name: \"{{ inventory_hostname }}\""},{"line_number":80,"context_line":"    container_log: \"true\""},{"line_number":81,"context_line":"    state: stopped"},{"line_number":82,"context_line":"    backing_store: \"{{ lxc_container_backing_store }}\""},{"line_number":83,"context_line":"    fs_size: \"{{ lxc_container_fs_size }}\""},{"line_number":84,"context_line":"  delegate_to: \"{{ physical_host }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1aa78d24_1baab91a","line":81,"updated":"2016-07-15 04:30:05.000000000","message":"This seems to be ignored, containers are initially cloned in a stopped state and state is not changed on subsequent runs.","commit_id":"0f8e5bdf27eb7277bd532395644b3ff0a264b5c1"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"a6417db0158346c59047a140f9e9ccc40803da10","unresolved":false,"context_lines":[{"line_number":89,"context_line":"- name: Container base setup"},{"line_number":90,"context_line":"  lxc_container:"},{"line_number":91,"context_line":"    name: \"{{ inventory_hostname }}\""},{"line_number":92,"context_line":"    config: \"{{ lxc_container_config }}\""},{"line_number":93,"context_line":"    container_command: \"{{ lxc_container_map.prep_commands }}\""},{"line_number":94,"context_line":"    container_config:"},{"line_number":95,"context_line":"      - \"lxc.autodev\u003d1\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1aa78d24_3b4a1528","line":92,"updated":"2016-07-15 04:30:05.000000000","message":"Don\u0027t think this is working, these each may need to be defined within container_config.\nhttps://github.com/openstack/openstack-ansible-lxc_hosts/blob/master/templates/lxc-openstack.conf.j2","commit_id":"0f8e5bdf27eb7277bd532395644b3ff0a264b5c1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"28b1ea001979cb29d808ca9646df62e79ccfe049","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  tags:"},{"line_number":113,"context_line":"    - lxc-container-commands"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"- name: Add container config (1)"},{"line_number":116,"context_line":"  lxc_container:"},{"line_number":117,"context_line":"    name: \"{{ inventory_hostname }}\""},{"line_number":118,"context_line":"    config: \"{{ lxc_container_config }}\""},{"line_number":119,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":120,"context_line":"  when: lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":121,"context_line":"  tags:"},{"line_number":122,"context_line":"    - lxc-container-config-1"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"- name: Add container config (2)"},{"line_number":125,"context_line":"  lxc_container:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"fad55976_c66945c0","line":122,"range":{"start_line":115,"start_character":0,"end_line":122,"end_character":28},"updated":"2016-07-16 23:27:32.000000000","message":"For some reason this task seems to have no effect. :(","commit_id":"342f3401e9035cf71a43f02fc484bb995a73a502"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"6c4d3fce2fcb0ffa26e8aa5ba13142dda0ec2d93","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  tags:"},{"line_number":113,"context_line":"    - lxc-container-commands"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"- name: Add container config (1)"},{"line_number":116,"context_line":"  lxc_container:"},{"line_number":117,"context_line":"    name: \"{{ inventory_hostname }}\""},{"line_number":118,"context_line":"    config: \"{{ lxc_container_config }}\""},{"line_number":119,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":120,"context_line":"  when: lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":121,"context_line":"  tags:"},{"line_number":122,"context_line":"    - lxc-container-config-1"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"- name: Add container config (2)"},{"line_number":125,"context_line":"  lxc_container:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"fad55976_46ea7510","line":122,"range":{"start_line":115,"start_character":0,"end_line":122,"end_character":28},"in_reply_to":"fad55976_c66945c0","updated":"2016-07-16 23:45:28.000000000","message":"It looks like the \u0027config\u0027 option is only applied for initial lxc-create commands. Otherwise, \u0027container_config\u0027 needs to be used with a list of key-value pairs, which will edit a container\u0027s config file directly.\n\nThe lxc_hosts role creates the ``lxc_container_config`` file, but doesn\u0027t seem to make use of it.\nMaybe it should be removed and its values managed by this role instead?","commit_id":"342f3401e9035cf71a43f02fc484bb995a73a502"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ebfea2de1a3e9f52531f2e7497e71bcc21ab1fa4","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- name: Create container (overlayfs)"},{"line_number":94,"context_line":"  command: \u003e"},{"line_number":95,"context_line":"    lxc-clone --snapshot --backingstore overlayfs"},{"line_number":96,"context_line":"    --orig {{ lxc_container_map.distro }}-{{ lxc_container_map.release }}-{{ lxc_container_map.arch }}"},{"line_number":97,"context_line":"    --new {{ inventory_hostname }}"},{"line_number":98,"context_line":"    -L {{ lxc_container_fs_size }}"},{"line_number":99,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":100,"context_line":"  when:"},{"line_number":101,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"dada55a8_aced8b90","line":98,"range":{"start_line":95,"start_character":4,"end_line":98,"end_character":34},"updated":"2016-07-17 13:00:17.000000000","message":"This should be using the lxc-copy command if we\u0027re going to shell out to deploy the container.","commit_id":"30af5c385ea30a6f025accbdbdc8e73589f2831c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"80cbbf1c6841a50440caa9bbb3a225108d9b8d4c","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- name: Create container (overlayfs)"},{"line_number":94,"context_line":"  command: \u003e"},{"line_number":95,"context_line":"    lxc-clone --snapshot --backingstore overlayfs"},{"line_number":96,"context_line":"    --orig {{ lxc_container_map.distro }}-{{ lxc_container_map.release }}-{{ lxc_container_map.arch }}"},{"line_number":97,"context_line":"    --new {{ inventory_hostname }}"},{"line_number":98,"context_line":"    -L {{ lxc_container_fs_size }}"},{"line_number":99,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":100,"context_line":"  when:"},{"line_number":101,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"dada55a8_ec3ae3e6","line":98,"range":{"start_line":95,"start_character":4,"end_line":98,"end_character":34},"in_reply_to":"dada55a8_aced8b90","updated":"2016-07-17 13:15:58.000000000","message":"lxc-clone works for LXC v1 and v2 - I thought it best to use the most compatible option for now","commit_id":"30af5c385ea30a6f025accbdbdc8e73589f2831c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ebfea2de1a3e9f52531f2e7497e71bcc21ab1fa4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"- name: Add container config"},{"line_number":121,"context_line":"  lxc_container:"},{"line_number":122,"context_line":"    name: \"{{ inventory_hostname }}\""},{"line_number":123,"context_line":"    container_config:"},{"line_number":124,"context_line":"      - \"lxc.start.auto\u003d1\""},{"line_number":125,"context_line":"      - \"lxc.start.delay\u003d15\""},{"line_number":126,"context_line":"      - \"lxc.group\u003donboot\""},{"line_number":127,"context_line":"      - \"lxc.group\u003dopenstack\""},{"line_number":128,"context_line":"      - \"lxc.autodev\u003d1\""},{"line_number":129,"context_line":"      - \"lxc.pts\u003d1024\""},{"line_number":130,"context_line":"      - \"lxc.kmsg\u003d0\""},{"line_number":131,"context_line":"      - \"lxc.hook.autodev\u003d/var/lib/lxc/{{ inventory_hostname }}/autodev\""},{"line_number":132,"context_line":"      - \"lxc.mount.entry\u003d/openstack/backup/{{ inventory_hostname }} var/backup none defaults,bind,rw 0 0\""},{"line_number":133,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":134,"context_line":"  when: lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":135,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"dada55a8_ece783aa","line":132,"range":{"start_line":123,"start_character":0,"end_line":132,"end_character":105},"updated":"2016-07-17 13:00:17.000000000","message":"These options can be made part of the \"Run container commands\" task.","commit_id":"30af5c385ea30a6f025accbdbdc8e73589f2831c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"80cbbf1c6841a50440caa9bbb3a225108d9b8d4c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"- name: Add container config"},{"line_number":121,"context_line":"  lxc_container:"},{"line_number":122,"context_line":"    name: \"{{ inventory_hostname }}\""},{"line_number":123,"context_line":"    container_config:"},{"line_number":124,"context_line":"      - \"lxc.start.auto\u003d1\""},{"line_number":125,"context_line":"      - \"lxc.start.delay\u003d15\""},{"line_number":126,"context_line":"      - \"lxc.group\u003donboot\""},{"line_number":127,"context_line":"      - \"lxc.group\u003dopenstack\""},{"line_number":128,"context_line":"      - \"lxc.autodev\u003d1\""},{"line_number":129,"context_line":"      - \"lxc.pts\u003d1024\""},{"line_number":130,"context_line":"      - \"lxc.kmsg\u003d0\""},{"line_number":131,"context_line":"      - \"lxc.hook.autodev\u003d/var/lib/lxc/{{ inventory_hostname }}/autodev\""},{"line_number":132,"context_line":"      - \"lxc.mount.entry\u003d/openstack/backup/{{ inventory_hostname }} var/backup none defaults,bind,rw 0 0\""},{"line_number":133,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":134,"context_line":"  when: lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":135,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"dada55a8_cc3f1fd5","line":132,"range":{"start_line":123,"start_character":0,"end_line":132,"end_character":105},"in_reply_to":"dada55a8_ece783aa","updated":"2016-07-17 13:15:58.000000000","message":"Done","commit_id":"30af5c385ea30a6f025accbdbdc8e73589f2831c"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"28c7c27d35a23d7679479b0b3fad0b2f933eace4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    state: started"},{"line_number":64,"context_line":"    backing_store: \"{{ lxc_container_backing_store }}\""},{"line_number":65,"context_line":"    directory: \"{{ lxc_container_rootfs_directory }}\""},{"line_number":66,"context_line":"    fs_size: \"{{ lxc_container_fs_size }}\""},{"line_number":67,"context_line":"    fs_type: \"{{ lxc_container_fs_type }}\""},{"line_number":68,"context_line":"    vg_name: \"{{ lxc_container_vg_name }}\""},{"line_number":69,"context_line":"    template_options: \"{{ lxc_container_download_template_options }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"dada55a8_6f2f05a2","line":66,"range":{"start_line":66,"start_character":17,"end_line":66,"end_character":39},"updated":"2016-07-17 15:14:37.000000000","message":"properties.container_fs_size | default(lxc_container_fs_size)","commit_id":"c89f1ebb955683451cbc4cf184e6d97f4e3411d0"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"28c7c27d35a23d7679479b0b3fad0b2f933eace4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    lxc-copy --snapshot -B overlayfs"},{"line_number":100,"context_line":"    --name {{ lxc_container_map.distro }}-{{ lxc_container_map.release }}-{{ lxc_container_map.arch }}"},{"line_number":101,"context_line":"    --newname {{ inventory_hostname }}"},{"line_number":102,"context_line":"    -L {{ lxc_container_fs_size }}"},{"line_number":103,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":104,"context_line":"  when:"},{"line_number":105,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"dada55a8_0f22c9b9","line":102,"range":{"start_line":102,"start_character":10,"end_line":102,"end_character":31},"updated":"2016-07-17 15:14:37.000000000","message":"properties.container_fs_size | default(lxc_container_fs_size)","commit_id":"c89f1ebb955683451cbc4cf184e6d97f4e3411d0"}],"tasks/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"726de844fb1a8b92a5b5a1675a2d3a74e353ef14","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Ansibel version and lxc backing store check"},{"line_number":17,"context_line":"  fail:"},{"line_number":18,"context_line":"    msg: \"Using overlayfs is not support on Ansible version \u003c 2\""},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - ansible_version.major \u003c 2"},{"line_number":21,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Gather variables for each operating system"},{"line_number":24,"context_line":"  include_vars: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa78d24_27f1d395","line":21,"range":{"start_line":16,"start_character":0,"end_line":21,"end_character":48},"updated":"2016-07-13 07:17:01.000000000","message":"This will fail fast if ansible \u003c2 is used with overlayfs backends.","commit_id":"7c9b86eca4329137b5cc28e78e54447a52aa6aeb"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"5aaa3d69b224ad2ba1a42b79a7b21b12c28b68a6","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Ansible version and lxc backing store check"},{"line_number":17,"context_line":"  fail:"},{"line_number":18,"context_line":"    msg: \"Using overlayfs is not support on Ansible version \u003c 2\""},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - ansible_version.major \u003c 2"},{"line_number":21,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_866a297f","line":18,"updated":"2016-07-13 16:15:17.000000000","message":"\"supported\"","commit_id":"ed156c8aaa20e60e6071f461129bb4c2cda53b61"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"8ef35fe45025d7e1b824763916b0817bdf4281c5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Ansible version and LXC backing store check"},{"line_number":17,"context_line":"  fail:"},{"line_number":18,"context_line":"    msg: \"Using overlayfs is not supported when using Ansible version \u003c 2\""},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":21,"context_line":"    - ansible_version.major \u003c 2"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_c99a666e","line":19,"updated":"2016-07-14 04:43:10.000000000","message":"also\n- lxc_container_backing_store is defined","commit_id":"42a11c64b9a2ed92e31c85e007e289054ab4a592"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"75570da8b7a58a968cece136d8152b7e258cf435","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Ansible version and LXC backing store check"},{"line_number":17,"context_line":"  fail:"},{"line_number":18,"context_line":"    msg: \"Using overlayfs is not supported when using Ansible version \u003c 2\""},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":21,"context_line":"    - ansible_version.major \u003c 2"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_b54929ba","line":19,"in_reply_to":"1aa78d24_c99a666e","updated":"2016-07-14 07:24:19.000000000","message":"Done","commit_id":"42a11c64b9a2ed92e31c85e007e289054ab4a592"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"8ef35fe45025d7e1b824763916b0817bdf4281c5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Kernel version and LXC backing store check"},{"line_number":24,"context_line":"  debug:"},{"line_number":25,"context_line":"    msg: \"Using overlayfs is not recommended when using Kernel version \u003c 3.18\""},{"line_number":26,"context_line":"  when:"},{"line_number":27,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":28,"context_line":"    - ansible_kernel | version_compare(\u00273.18.0-0-generic\u0027, \u0027\u003c\u0027)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_29868a16","line":26,"updated":"2016-07-14 04:43:10.000000000","message":"also\n- lxc_container_backing_store is defined","commit_id":"42a11c64b9a2ed92e31c85e007e289054ab4a592"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"75570da8b7a58a968cece136d8152b7e258cf435","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Kernel version and LXC backing store check"},{"line_number":24,"context_line":"  debug:"},{"line_number":25,"context_line":"    msg: \"Using overlayfs is not recommended when using Kernel version \u003c 3.18\""},{"line_number":26,"context_line":"  when:"},{"line_number":27,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":28,"context_line":"    - ansible_kernel | version_compare(\u00273.18.0-0-generic\u0027, \u0027\u003c\u0027)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_15c59d09","line":26,"in_reply_to":"1aa78d24_29868a16","updated":"2016-07-14 07:24:19.000000000","message":"Done","commit_id":"42a11c64b9a2ed92e31c85e007e289054ab4a592"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"8ef35fe45025d7e1b824763916b0817bdf4281c5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    msg: \"Using overlayfs is not recommended when using Kernel version \u003c 3.18\""},{"line_number":26,"context_line":"  when:"},{"line_number":27,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":28,"context_line":"    - ansible_kernel | version_compare(\u00273.18.0-0-generic\u0027, \u0027\u003c\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Gather variables for each operating system"},{"line_number":31,"context_line":"  include_vars: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_e6567129","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":20},"updated":"2016-07-14 04:43:10.000000000","message":"hostvars[physical_host][\u0027ansible_kernel\u0027]","commit_id":"42a11c64b9a2ed92e31c85e007e289054ab4a592"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"75570da8b7a58a968cece136d8152b7e258cf435","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    msg: \"Using overlayfs is not recommended when using Kernel version \u003c 3.18\""},{"line_number":26,"context_line":"  when:"},{"line_number":27,"context_line":"    - lxc_container_backing_store \u003d\u003d \"overlayfs\""},{"line_number":28,"context_line":"    - ansible_kernel | version_compare(\u00273.18.0-0-generic\u0027, \u0027\u003c\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Gather variables for each operating system"},{"line_number":31,"context_line":"  include_vars: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_f5c9f126","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":20},"in_reply_to":"1aa78d24_e6567129","updated":"2016-07-14 07:24:19.000000000","message":"Done","commit_id":"42a11c64b9a2ed92e31c85e007e289054ab4a592"}],"templates/veth-cleanup.sh.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"726de844fb1a8b92a5b5a1675a2d3a74e353ef14","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% for key, value in container_networks.items() %}"},{"line_number":11,"context_line":"    {% if value.type is not defined or value.type \u003d\u003d \u0027veth\u0027 %}"},{"line_number":12,"context_line":"ip link del {{ inventory_hostname[-8:].replace(\u0027-\u0027, \u0027\u0027).replace(\u0027_\u0027, \u0027\u0027) }}_{{ value.interface }} || true"},{"line_number":13,"context_line":"logger \"LXC container {{ inventory_hostname }} removing veth {{ inventory_hostname[-8:].replace(\u0027-\u0027, \u0027\u0027).replace(\u0027_\u0027, \u0027\u0027) }}_{{ value.interface }}\""},{"line_number":14,"context_line":"    {% endif %}"},{"line_number":15,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1aa78d24_a7fca372","side":"PARENT","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":147},"updated":"2016-07-13 07:17:01.000000000","message":"Note this is being removed because it causes an issue w/ overlayfs type containers because access to \"/dev/log\". It\u0027s worth noting that this a problem on non-onverlayfs containers too however its not a critical issue causing a container not to start.\n\nActual Error: [ http://paste.openstack.org/show/531230 ]","commit_id":"fb3afe597836de352bb66cfbfc8ef8161315cbf6"}]}
