)]}'
{"tasks/container_create.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"076a5d7ed020b05075b668b39e4c36a29b0631fd","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    else"},{"line_number":217,"context_line":"      VETH\u003d\"{{ inventory_hostname[-8:].replace(\u0027-\u0027, \u0027\u0027).replace(\u0027_\u0027, \u0027\u0027) }}_{{ item.value.interface }}\""},{"line_number":218,"context_line":"      PID\u003d\"$(lxc-info -pHn {{ inventory_hostname }})\""},{"line_number":219,"context_line":"      ip link add name \"${VETH}\" type veth peer name \"${VETH}_t\" || true"},{"line_number":220,"context_line":"      ip link set dev \"${VETH}\" up || true"},{"line_number":221,"context_line":"      ip link set dev \"${VETH}_t\" up || true"},{"line_number":222,"context_line":"      brctl addif {{ item.value.bridge }} \"${VETH}\" || true"},{"line_number":223,"context_line":"      ip link set dev \"${VETH}_t\" netns \"${PID}\" name {{ item.value.interface }} || true"},{"line_number":224,"context_line":"      lxc-attach --name {{ inventory_hostname }} -- ifup {{ item.value.interface }}"},{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":"  with_dict: \"{{ container_networks | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_d2f06d93","line":223,"range":{"start_line":219,"start_character":0,"end_line":223,"end_character":88},"updated":"2016-08-07 16:35:35.000000000","message":"Any failure in this part will be gently ignore, where we should probably care.\n\nWouldn\u0027t it be easier to drop a shell script that has `set -e ` flag, which would take as arguments the inventory_hostname and the item.value.interface?\n\nIt seems more readable, would fail on subcommand failures, etc...","commit_id":"c9380122ab7a4ca31654ffe765b648f6ba97476f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6ba491e68acd4b8d1e37c8056596728224125e07","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    else"},{"line_number":217,"context_line":"      VETH\u003d\"{{ inventory_hostname[-8:].replace(\u0027-\u0027, \u0027\u0027).replace(\u0027_\u0027, \u0027\u0027) }}_{{ item.value.interface }}\""},{"line_number":218,"context_line":"      PID\u003d\"$(lxc-info -pHn {{ inventory_hostname }})\""},{"line_number":219,"context_line":"      ip link add name \"${VETH}\" type veth peer name \"${VETH}_t\" || true"},{"line_number":220,"context_line":"      ip link set dev \"${VETH}\" up || true"},{"line_number":221,"context_line":"      ip link set dev \"${VETH}_t\" up || true"},{"line_number":222,"context_line":"      brctl addif {{ item.value.bridge }} \"${VETH}\" || true"},{"line_number":223,"context_line":"      ip link set dev \"${VETH}_t\" netns \"${PID}\" name {{ item.value.interface }} || true"},{"line_number":224,"context_line":"      lxc-attach --name {{ inventory_hostname }} -- ifup {{ item.value.interface }}"},{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":"  with_dict: \"{{ container_networks | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_38e25e04","line":223,"range":{"start_line":219,"start_character":0,"end_line":223,"end_character":88},"in_reply_to":"bacf61ea_d2f06d93","updated":"2016-08-08 16:23:35.000000000","message":"We do not care if any of this fails. These task items were taken from the tasks the LXC runs when creating a container. We could however do some more fencing to test if a bridge exists which would ensure that the wiring on the host level is complete before the veth\u0027s are created.","commit_id":"c9380122ab7a4ca31654ffe765b648f6ba97476f"}]}