)]}'
{"tasks/container_create.yml":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"ddd760524c0952b5b951e60d072ac3477f6a88b8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    state: absent"},{"line_number":107,"context_line":"    backup: True"},{"line_number":108,"context_line":"  when:"},{"line_number":109,"context_line":"    - \"\u0027galera\u0027 in inventory_hostname\""},{"line_number":110,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":111,"context_line":"  tags:"},{"line_number":112,"context_line":"    - lxc-container-service-config"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_28020870","line":109,"updated":"2016-08-24 19:16:13.000000000","message":"Was the previous check (inventory_hostname in groups[\u0027galera_all\u0027]) not safer?","commit_id":"0f4b25a02ec04187a10a4e90f89b3bd6034aef25"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8211e4456fa07f1df9bda0efa8c091017c351b81","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    container_command: |"},{"line_number":116,"context_line":"      mkdir -p /var/backup"},{"line_number":117,"context_line":"      mkdir -p /var/log/{{ properties.log_directory | default(properties.service_name) }}"},{"line_number":118,"context_line":"    container_config:"},{"line_number":119,"context_line":"      - \"lxc.mount.entry\u003d/openstack/backup/{{ inventory_hostname }} var/backup none defaults,bind,rw 0 0\""},{"line_number":120,"context_line":"      - \"lxc.mount.entry\u003d/openstack/log/{{ inventory_hostname }} var/log/{{ properties.log_directory | default(properties.service_name) }} none defaults,bind,rw 0 0\""},{"line_number":121,"context_line":"  when: properties.service_name is defined"},{"line_number":122,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":123,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1ac06dbe_d7900798","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":165},"updated":"2016-08-25 09:50:37.000000000","message":"Having this here will force a rather inconsiderate restart of the container. For the restart to be controlled, this has to be split out to use the lineinfile module instead. The lineinfile change should notify the handler.\n\nThe release note will have to then describe how to go about doing the hotfix upgrade in a way that doesn\u0027t ruin the database (through using the rolling upgrade).","commit_id":"caef23dc2dfbe6835f125e50ed470415dd42fc6d"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"34d84ff898b1bb6b7c61e9e95575d2ee7673ec96","unresolved":false,"context_lines":[{"line_number":117,"context_line":"      mkdir -p /var/log/{{ properties.log_directory | default(properties.service_name) }}"},{"line_number":118,"context_line":"    container_config:"},{"line_number":119,"context_line":"      - \"lxc.mount.entry\u003d/openstack/backup/{{ inventory_hostname }} var/backup none defaults,bind,rw 0 0\""},{"line_number":120,"context_line":"      - \"lxc.mount.entry\u003d/openstack/log/{{ inventory_hostname }} var/log/{{ properties.log_directory | default(properties.service_name) }} none defaults,bind,rw 0 0\""},{"line_number":121,"context_line":"  when: properties.service_name is defined"},{"line_number":122,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":123,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1ac06dbe_43ca9450","line":120,"updated":"2016-08-25 12:04:55.000000000","message":"I\u0027ve tested this, as did Matt, and there were no restarts.  There is no \"notify:\" on this task and the \"Lxc container restart\" handler doesn\u0027t fire. Am I missing something else that would cause a restart?","commit_id":"caef23dc2dfbe6835f125e50ed470415dd42fc6d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dcb5df7c53227f63cb455d5f1cfcef5775414e1f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"      mkdir -p /var/log/{{ properties.log_directory | default(properties.service_name) }}"},{"line_number":118,"context_line":"    container_config:"},{"line_number":119,"context_line":"      - \"lxc.mount.entry\u003d/openstack/backup/{{ inventory_hostname }} var/backup none defaults,bind,rw 0 0\""},{"line_number":120,"context_line":"      - \"lxc.mount.entry\u003d/openstack/log/{{ inventory_hostname }} var/log/{{ properties.log_directory | default(properties.service_name) }} none defaults,bind,rw 0 0\""},{"line_number":121,"context_line":"  when: properties.service_name is defined"},{"line_number":122,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":123,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1ac06dbe_03837ccd","line":120,"in_reply_to":"1ac06dbe_43ca9450","updated":"2016-08-25 12:07:37.000000000","message":"Yes, the lxc_container module makes it restart when a container_config entry is implemented.","commit_id":"caef23dc2dfbe6835f125e50ed470415dd42fc6d"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"9cb3a07884bd97316a67f57bd1aa0f1f4af5e688","unresolved":false,"context_lines":[{"line_number":122,"context_line":"- name: Add correct bind mount to galera container configuration (bug 1609862)"},{"line_number":123,"context_line":"  lineinfile:"},{"line_number":124,"context_line":"    dest: \"/var/lib/lxc/{{ inventory_hostname }}/config\""},{"line_number":125,"context_line":"    regexp: lxc.mount.entry \u003d /openstack/log/{{ inventory_hostname }} var/log/{{ properties.log_directory | default(properties.service_name) }} none defaults,bind,rw 0 0\""},{"line_number":126,"context_line":"    state: present"},{"line_number":127,"context_line":"    backup: True"},{"line_number":128,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1ac06dbe_ec20b6b2","line":125,"range":{"start_line":125,"start_character":169,"end_line":125,"end_character":170},"updated":"2016-08-25 18:45:35.000000000","message":"remove quote marks","commit_id":"02fac479517a8c6f237c141ca16dfeccacd58e0e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"9cb3a07884bd97316a67f57bd1aa0f1f4af5e688","unresolved":false,"context_lines":[{"line_number":122,"context_line":"- name: Add correct bind mount to galera container configuration (bug 1609862)"},{"line_number":123,"context_line":"  lineinfile:"},{"line_number":124,"context_line":"    dest: \"/var/lib/lxc/{{ inventory_hostname }}/config\""},{"line_number":125,"context_line":"    regexp: lxc.mount.entry \u003d /openstack/log/{{ inventory_hostname }} var/log/{{ properties.log_directory | default(properties.service_name) }} none defaults,bind,rw 0 0\""},{"line_number":126,"context_line":"    state: present"},{"line_number":127,"context_line":"    backup: True"},{"line_number":128,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1ac06dbe_cc44da75","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":10},"updated":"2016-08-25 18:45:35.000000000","message":"this should be \u0027line\u0027, it\u0027s failing as is\n\nfailed: [aio1_galera_container-db8f94f1 -\u003e aio1] \u003d\u003e {\"failed\": true}\nmsg: line\u003d is required with state\u003dpresent","commit_id":"02fac479517a8c6f237c141ca16dfeccacd58e0e"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"b122449ec19291761f651cc3305944c8e5ddd54f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"- name: Add correct bind mount to galera container configuration (bug 1609862)"},{"line_number":123,"context_line":"  lineinfile:"},{"line_number":124,"context_line":"    dest: \"/var/lib/lxc/{{ inventory_hostname }}/config\""},{"line_number":125,"context_line":"    regexp: lxc.mount.entry \u003d /openstack/log/{{ inventory_hostname }} var/log/{{ properties.log_directory | default(properties.service_name) }} none defaults,bind,rw 0 0\""},{"line_number":126,"context_line":"    state: present"},{"line_number":127,"context_line":"    backup: True"},{"line_number":128,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fa7ab95a_cbe1bdd2","line":125,"in_reply_to":"1ac06dbe_ec20b6b2","updated":"2016-08-25 20:57:15.000000000","message":"Darn. I missed that.","commit_id":"02fac479517a8c6f237c141ca16dfeccacd58e0e"}]}