)]}'
{"releasenotes/notes/lxc-ssh-wait-deprecation-fe3eda58fc9d318e.yaml":[{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"a8ebf00a831eb88c1fbd5accb3dbb3411077bcb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5ff73747_50176c46","updated":"2017-04-27 12:48:12.000000000","message":"Todo.. refresh reno and replace mentions of ping module","commit_id":"6645507b8311920c4b22e78dd0354d1c5ce8c339"}],"tasks/container_create.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"473e058fd650e78545b13ee4d26368fbe8cf32b8","unresolved":false,"context_lines":[{"line_number":337,"context_line":"# Flush the handlers to ensure the container and networking is online."},{"line_number":338,"context_line":"- meta: flush_handlers"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"- name: Wait for container connectivity"},{"line_number":341,"context_line":"  ping:"},{"line_number":342,"context_line":"  register: container_ping_check"},{"line_number":343,"context_line":"  until: container_ping_check | success"},{"line_number":344,"context_line":"  retries: 10"},{"line_number":345,"context_line":"  tags:"},{"line_number":346,"context_line":"    - lxc-container-networks"},{"line_number":347,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_973f02b3","line":344,"range":{"start_line":340,"start_character":0,"end_line":344,"end_character":13},"updated":"2016-10-16 11:41:36.000000000","message":"You\u0027re asking the container to ping itself, which it obviously can\u0027t. If you delegate this task to the host then this may work.\n\nI do wonder if a ping/ssh check is the definitive way to check that the container is ready for the tasks that follow. Perhaps something better would be to verify the init level, or check that all bind mounts are complete, or something else. But that\u0027s food for thought and not necessarily for this patch.","commit_id":"b59d696c1df312968ddbb66f6d3e261962462790"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"7771498b7a3401dcc9fdfc095a652dae0e96d558","unresolved":false,"context_lines":[{"line_number":409,"context_line":"  register: container_ping_check"},{"line_number":410,"context_line":"  until: container_ping_check | success"},{"line_number":411,"context_line":"  retries: 10"},{"line_number":412,"context_line":"  delegate_to: 127.0.0.1"},{"line_number":413,"context_line":"  tags:"},{"line_number":414,"context_line":"    - lxc_container_create-networks"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ff52f3f_6e3b28d1","line":412,"updated":"2017-04-13 15:20:17.000000000","message":"This task should not be delegated.\n\nReferencing the ping module description:\nhttps://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/ping.py\n\"Try to connect to host, verify a usable python and return C(pong) on success.\"\n\nDelegating this to localhost means we\u0027re effectively testing whether we can run ansible modules against localhost, not the remote container.","commit_id":"00dde41382b0b0b241f9e06af08754606d645369"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f8fe6055ce0fa9f31a423f64fe64cf9ba7165340","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    connect_timeout: \"{{ lxc_container_wait_params.connect_timeout | default(omit) }}\""},{"line_number":410,"context_line":"    delay: \"{{ lxc_container_wait_params.delay | default(omit) }}\""},{"line_number":411,"context_line":"    sleep: \"{{ lxc_container_wait_params.sleep | default(omit) }}\""},{"line_number":412,"context_line":"    timeout: \"{{ lxc_container_wait_params.timeout | default(omit) }}\""},{"line_number":413,"context_line":"  tags:"},{"line_number":414,"context_line":"    - lxc_container_create-networks"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5ff73747_94d4be21","line":412,"updated":"2017-04-27 16:36:46.000000000","message":"The wait_for_connection module uses the ping module, so it tests whether Ansible is able to reach the target through the appropriate connection plugin for the host. This means that delegation is not required.","commit_id":"4f4fca7507a0171b3eb076b2f8e1fc81fe94bf61"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5dbb6651917458a8822ce3f9b6a2bbe9c7fbcaad","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    connect_timeout: \"{{ lxc_container_wait_params.connect_timeout | default(omit) }}\""},{"line_number":410,"context_line":"    delay: \"{{ lxc_container_wait_params.delay | default(omit) }}\""},{"line_number":411,"context_line":"    sleep: \"{{ lxc_container_wait_params.sleep | default(omit) }}\""},{"line_number":412,"context_line":"    timeout: \"{{ lxc_container_wait_params.timeout | default(omit) }}\""},{"line_number":413,"context_line":"  tags:"},{"line_number":414,"context_line":"    - lxc_container_create-networks"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5ff73747_14d1ce23","line":412,"in_reply_to":"5ff73747_94d4be21","updated":"2017-04-27 16:38:03.000000000","message":"Done","commit_id":"4f4fca7507a0171b3eb076b2f8e1fc81fe94bf61"}]}