)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"8732ff8dd5b218fa503e9c6e2457f4ccbe7ad3e2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enhance configurability of LXC net interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enhances the configurability of Debian/Ubuntu style net interfaces"},{"line_number":10,"context_line":"defined in the container_networks dict. The following variables were"},{"line_number":11,"context_line":"added to allow deployers to configure the pre-up, post-up, pre-down,"},{"line_number":12,"context_line":"and post-down scripts defined for the interface."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_dd3d262c","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":33},"updated":"2016-10-15 04:38:32.000000000","message":"It\u0027s probably worth mentioning the file here, too. I believe you\u0027re referencing openstack_user_config.yml","commit_id":"b4b7f13b484951bebee866cec932d01244de7172"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"663b4d39e7b74439c84add4ccddb72e0b80a32aa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enhance configurability of LXC net interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enhances the configurability of Debian/Ubuntu style net interfaces"},{"line_number":10,"context_line":"defined in the container_networks dict. The following variables were"},{"line_number":11,"context_line":"added to allow deployers to configure the pre-up, post-up, pre-down,"},{"line_number":12,"context_line":"and post-down scripts defined for the interface."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_97cc628a","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":33},"in_reply_to":"fa6399be_dd3d262c","updated":"2016-10-16 12:30:25.000000000","message":"Nope - it\u0027s in the role vars file, which is not something typically overridden. This patch is adding the ability to add customisability via defaults which can be overridden.","commit_id":"b4b7f13b484951bebee866cec932d01244de7172"}],"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"663b4d39e7b74439c84add4ccddb72e0b80a32aa","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# Scripts allowing the configuration of pre/post-up/down scripts in Ubuntu"},{"line_number":77,"context_line":"# interface files."},{"line_number":78,"context_line":"lxc_container_default_preup: []"},{"line_number":79,"context_line":"lxc_container_default_postup: []"},{"line_number":80,"context_line":"lxc_container_default_predown: []"},{"line_number":81,"context_line":"lxc_container_default_postdown: []"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_17a772bd","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":32},"updated":"2016-10-16 12:30:25.000000000","message":"Either we should have a comment warning that if the person changes these values then it may break things if they don\u0027t include the existing values in the vars file, or we should ensure that in the implementation that we union the default settings with those provided by the user.","commit_id":"b4b7f13b484951bebee866cec932d01244de7172"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"f837a966aeccf5f20f74004688bf85030e3cc7c2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# Scripts allowing the configuration of pre/post-up/down scripts in Ubuntu"},{"line_number":77,"context_line":"# interface files."},{"line_number":78,"context_line":"lxc_container_default_preup: []"},{"line_number":79,"context_line":"lxc_container_default_postup: []"},{"line_number":80,"context_line":"lxc_container_default_predown: []"},{"line_number":81,"context_line":"lxc_container_default_postdown: []"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a1ced50_0d5dcb14","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":32},"in_reply_to":"fa6399be_17a772bd","updated":"2017-03-22 16:55:20.000000000","message":"Done. They\u0027re unioned now.","commit_id":"b4b7f13b484951bebee866cec932d01244de7172"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"93d39d40acef7e7634b40b0c8049c4f2ddb7d4ad","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# Scripts allowing the configuration of pre/post-up/down scripts in Ubuntu"},{"line_number":77,"context_line":"# interface files."},{"line_number":78,"context_line":"lxc_container_default_preup: []"},{"line_number":79,"context_line":"lxc_container_default_postup: []"},{"line_number":80,"context_line":"lxc_container_default_predown: []"},{"line_number":81,"context_line":"lxc_container_default_postdown: []"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_67a95c7b","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":32},"in_reply_to":"fa6399be_17a772bd","updated":"2016-10-19 14:07:46.000000000","message":"it\u0027s still the \"default\", if the user overrides with its own preup postup... it should be fine.\n\nI think that\u0027s what the deployer would do anyway.","commit_id":"b4b7f13b484951bebee866cec932d01244de7172"}],"releasenotes/notes/lxc-interface-scripts-78e9021cf2ed0c97.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"663b4d39e7b74439c84add4ccddb72e0b80a32aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The keys ``preup``, ``postup``, ``predown``, and ``postdown`` are now"},{"line_number":4,"context_line":"    supported in the ``container_networks`` dict for Ubuntu systems. This will"},{"line_number":5,"context_line":"    allow deployers to configure custom scripts to be run when the interfaces"},{"line_number":6,"context_line":"    are brought up or down by the OS."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_17c0524f","line":3,"updated":"2016-10-16 12:30:25.000000000","message":"This needs to be written in such a way that it can be read outsdie of the context of the role, but instead in the context of OpenStack-Ansible as a whole. This is because this note will be published among all the other notes from all the other roles.\n\nTo do this it should be easy enough to simply start with \u0027In the **lxc_container_create** role...\u0027","commit_id":"b4b7f13b484951bebee866cec932d01244de7172"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"93d39d40acef7e7634b40b0c8049c4f2ddb7d4ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The keys ``preup``, ``postup``, ``predown``, and ``postdown`` are now"},{"line_number":4,"context_line":"    supported in the ``container_networks`` dict for Ubuntu systems. This will"},{"line_number":5,"context_line":"    allow deployers to configure custom scripts to be run when the interfaces"},{"line_number":6,"context_line":"    are brought up or down by the OS."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_a7b9b4cd","line":3,"in_reply_to":"fa6399be_17c0524f","updated":"2016-10-19 14:07:46.000000000","message":"Agreed","commit_id":"b4b7f13b484951bebee866cec932d01244de7172"}],"templates/debian-interface.cfg.j2":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cdb13e4efdc52cf81459a971f4b31d8830995686","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    pre-down {{ item }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"{% for item in item.value.postdown | default([]) | union(lxc_container_default_postdown) %}"},{"line_number":31,"context_line":"    post-down {{ item }}"},{"line_number":32,"context_line":"{% endfor %}"},{"line_number":33,"context_line":"### end generated network for [ {{ item.value.interface }} ] ###"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ffe62b97_15e25404","line":31,"updated":"2017-03-24 19:18:43.000000000","message":"Only for manual interfaces? The static ones have lost their love?","commit_id":"eeabfbc0428a9db4ed8f29afac3f0f4449209587"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"abc16666cdf7aea8ff1f06ef2908b682ac239978","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    pre-down {{ item }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"{% for item in item.value.postdown | default([]) | union(lxc_container_default_postdown) %}"},{"line_number":31,"context_line":"    post-down {{ item }}"},{"line_number":32,"context_line":"{% endfor %}"},{"line_number":33,"context_line":"### end generated network for [ {{ item.value.interface }} ] ###"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ffe62b97_8f999d6f","line":31,"in_reply_to":"ffe62b97_15e25404","updated":"2017-03-25 19:44:45.000000000","message":"both are covered I think?","commit_id":"eeabfbc0428a9db4ed8f29afac3f0f4449209587"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"27b03707ce3b6d61214833a03cb9b28e41cd662f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    pre-down {{ item }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"{% for item in item.value.postdown | default([]) | union(lxc_container_default_postdown) %}"},{"line_number":31,"context_line":"    post-down {{ item }}"},{"line_number":32,"context_line":"{% endfor %}"},{"line_number":33,"context_line":"### end generated network for [ {{ item.value.interface }} ] ###"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ffe62b97_d0798193","line":31,"in_reply_to":"ffe62b97_8f999d6f","updated":"2017-03-26 12:42:14.000000000","message":"Ahah, my brain was tricked by indentation, sorry!","commit_id":"eeabfbc0428a9db4ed8f29afac3f0f4449209587"}]}
