)]}'
{"tasks/lxc_container_config.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9671ce7f45706c20ea31fe3bb64d620deef0d238","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  lineinfile:"},{"line_number":19,"context_line":"    dest: \"/var/lib/lxc/{{ inventory_hostname }}/config\""},{"line_number":20,"context_line":"    line: \"{{ item.split(\u0027\u003d\u0027, 1)[0] }} \u003d {{ item.split(\u0027\u003d\u0027, 1)[1] }}\""},{"line_number":21,"context_line":"    backup: \"true\""},{"line_number":22,"context_line":"  with_items: \"{{ lxc_container_default_config_list | union(lxc_container_config_list) }}\""},{"line_number":23,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":24,"context_line":"  register: default_configuration_container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e83e9260_b809771b","line":21,"updated":"2021-01-29 19:44:15.000000000","message":"maybe we also add\n\nregexp: \"^{{ item.split(\u0027\u003d\u0027, 1)[0] }}\" ?\n\nI think this should not allow to add duplicated records as well.\n\nAnother solution I see is to use blockinfile instead. It will ensure in future that we won\u0027t have issues with duplicated records and will be able to change format if we want without any issues. Moreover it should be more reliable since we will have control over all records we add. \n\nAnd currently in case option is dropped from lxc_container_config_list it won\u0027t be removed from config which might be frustrating","commit_id":"464fa3e544917cba775a6d38416f4ca66bbc9d19"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"74977067e0551105d8b1c33bcc982edf77c7d1af","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  lineinfile:"},{"line_number":19,"context_line":"    dest: \"/var/lib/lxc/{{ inventory_hostname }}/config\""},{"line_number":20,"context_line":"    line: \"{{ item.split(\u0027\u003d\u0027, 1)[0] }} \u003d {{ item.split(\u0027\u003d\u0027, 1)[1] }}\""},{"line_number":21,"context_line":"    backup: \"true\""},{"line_number":22,"context_line":"  with_items: \"{{ lxc_container_default_config_list | union(lxc_container_config_list) }}\""},{"line_number":23,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":24,"context_line":"  register: default_configuration_container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fb12baa8_7341506c","line":21,"in_reply_to":"e83e9260_b809771b","updated":"2021-01-29 19:48:41.000000000","message":"Blockinfile will bring duplicated records for sure though... So we would need to take care to remove all lines we have in list during upgrade before switching to it.\nSo might make sense to do this in follow-up patch and only for master","commit_id":"464fa3e544917cba775a6d38416f4ca66bbc9d19"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2ddd594101fb16a6f21a9b3282471f8e706ac147","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  lineinfile:"},{"line_number":19,"context_line":"    dest: \"/var/lib/lxc/{{ inventory_hostname }}/config\""},{"line_number":20,"context_line":"    line: \"{{ item.split(\u0027\u003d\u0027, 1)[0] }} \u003d {{ item.split(\u0027\u003d\u0027, 1)[1] }}\""},{"line_number":21,"context_line":"    regexp: \"^{{ item.split(\u0027\u003d\u0027, 1)[0] }} *\u003d\""},{"line_number":22,"context_line":"    backup: \"true\""},{"line_number":23,"context_line":"  with_items: \"{{ lxc_container_default_config_list | union(lxc_container_config_list) }}\""},{"line_number":24,"context_line":"  delegate_to: \"{{ physical_host }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9cb43906_98436ea2","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":45},"updated":"2021-02-01 09:21:08.000000000","message":"I\u0027m really sorry I mislead you, as we really can\u0027t use regexp here, since lxc config contains same config keys that are just repeated... So let\u0027s return to patchset 1 and merge it I guess","commit_id":"363f7002a48262f00200df60ed2b030ff60f40b0"}]}