)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e81170fe98d34ae00de86c86fdf6c74c28e8f72c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a314463_59b85d3f","updated":"2025-01-06 09:04:08.000000000","message":"I;m looking at other places where interface is defined, and it\u0027s trimmed in other places:\nhttps://opendev.org/openstack/openstack-ansible-lxc_container_create/src/branch/master/tasks/lxc_container_config.yml#L199\n\nSo yeah, it\u0027s not ovs specific and I think that condition in path is unnecessary.","commit_id":"78d8fb770e97ee5b8f94d15e9ddf687509e9071b"}],"templates/veth-cleanup.sh.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c9abb71ba7226af86a36cf9200b02c89482fdecf","unresolved":true,"context_lines":[{"line_number":5,"context_line":"{% for key, value in lxc_container_networks_combined.items() %}"},{"line_number":6,"context_line":"{%   if value.type is not defined or value.type \u003d\u003d \u0027veth\u0027 %}"},{"line_number":7,"context_line":"{%      set lxc_container_network_port_indexed \u003d lxc_container_network_veth_pair_prefix ~ \"_\" ~ value.interface %}"},{"line_number":8,"context_line":"{%      if \u0027bridge_type\u0027 in value and value.bridge_type \u003d\u003d \"openvswitch\" %}"},{"line_number":9,"context_line":"{%          set lxc_container_network_port_indexed \u003d lxc_container_network_port_indexed[-15:] %}"},{"line_number":10,"context_line":"{%      endif %}"},{"line_number":11,"context_line":"ip link del {{ lxc_container_network_port_indexed }} || true"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8e6a00c3_623ab1e2","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":75},"updated":"2025-01-06 08:48:28.000000000","message":"this issue should actually exist regardless of ovs, as limit of 15 symbols is generic and not ovs-specific.\n\nSo I think this condition is not needed.","commit_id":"78d8fb770e97ee5b8f94d15e9ddf687509e9071b"},{"author":{"_account_id":36565,"name":"Farbod Saghafi","display_name":"itsfarbod","email":"farbodsaghafimail@gmail.com","username":"itsfarbod"},"change_message_id":"2fa5d1ea7b0d81ff59f940a3203a1e759149a9e6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% for key, value in lxc_container_networks_combined.items() %}"},{"line_number":6,"context_line":"{%   if value.type is not defined or value.type \u003d\u003d \u0027veth\u0027 %}"},{"line_number":7,"context_line":"{%      set lxc_container_network_port_indexed \u003d lxc_container_network_veth_pair_prefix ~ \"_\" ~ value.interface %}"},{"line_number":8,"context_line":"{%      if \u0027bridge_type\u0027 in value and value.bridge_type \u003d\u003d \"openvswitch\" %}"},{"line_number":9,"context_line":"{%          set lxc_container_network_port_indexed \u003d lxc_container_network_port_indexed[-15:] %}"},{"line_number":10,"context_line":"{%      endif %}"},{"line_number":11,"context_line":"ip link del {{ lxc_container_network_port_indexed }} || true"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"180364ac_011e0faf","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":75},"in_reply_to":"8e6a00c3_623ab1e2","updated":"2025-01-08 08:46:46.000000000","message":"Done","commit_id":"78d8fb770e97ee5b8f94d15e9ddf687509e9071b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c9abb71ba7226af86a36cf9200b02c89482fdecf","unresolved":true,"context_lines":[{"line_number":8,"context_line":"{%      if \u0027bridge_type\u0027 in value and value.bridge_type \u003d\u003d \"openvswitch\" %}"},{"line_number":9,"context_line":"{%          set lxc_container_network_port_indexed \u003d lxc_container_network_port_indexed[-15:] %}"},{"line_number":10,"context_line":"{%      endif %}"},{"line_number":11,"context_line":"ip link del {{ lxc_container_network_port_indexed }} || true"},{"line_number":12,"context_line":"{%     if \u0027bridge_type\u0027 in value and value.bridge_type \u003d\u003d \"openvswitch\" %}"},{"line_number":13,"context_line":"{%       set lxc_container_network_ovs_port_indexed \u003d lxc_container_network_veth_pair_prefix ~ \"_\" ~ value.interface %}"},{"line_number":14,"context_line":"ovs-vsctl --if-exists del-port {{ lxc_container_network_ovs_port_indexed[-15:] }} || true"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"05273cc0_b8eb6a3a","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":49},"updated":"2025-01-06 08:48:28.000000000","message":"```suggestion\nip link del {{ lxc_container_network_port_indexed[-15:] }} || true\n```","commit_id":"78d8fb770e97ee5b8f94d15e9ddf687509e9071b"},{"author":{"_account_id":36565,"name":"Farbod Saghafi","display_name":"itsfarbod","email":"farbodsaghafimail@gmail.com","username":"itsfarbod"},"change_message_id":"2fa5d1ea7b0d81ff59f940a3203a1e759149a9e6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{%      if \u0027bridge_type\u0027 in value and value.bridge_type \u003d\u003d \"openvswitch\" %}"},{"line_number":9,"context_line":"{%          set lxc_container_network_port_indexed \u003d lxc_container_network_port_indexed[-15:] %}"},{"line_number":10,"context_line":"{%      endif %}"},{"line_number":11,"context_line":"ip link del {{ lxc_container_network_port_indexed }} || true"},{"line_number":12,"context_line":"{%     if \u0027bridge_type\u0027 in value and value.bridge_type \u003d\u003d \"openvswitch\" %}"},{"line_number":13,"context_line":"{%       set lxc_container_network_ovs_port_indexed \u003d lxc_container_network_veth_pair_prefix ~ \"_\" ~ value.interface %}"},{"line_number":14,"context_line":"ovs-vsctl --if-exists del-port {{ lxc_container_network_ovs_port_indexed[-15:] }} || true"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"0f233002_fc9a55d4","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":49},"in_reply_to":"05273cc0_b8eb6a3a","updated":"2025-01-08 08:46:46.000000000","message":"Done","commit_id":"78d8fb770e97ee5b8f94d15e9ddf687509e9071b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c9abb71ba7226af86a36cf9200b02c89482fdecf","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{%      endif %}"},{"line_number":11,"context_line":"ip link del {{ lxc_container_network_port_indexed }} || true"},{"line_number":12,"context_line":"{%     if \u0027bridge_type\u0027 in value and value.bridge_type \u003d\u003d \"openvswitch\" %}"},{"line_number":13,"context_line":"{%       set lxc_container_network_ovs_port_indexed \u003d lxc_container_network_veth_pair_prefix ~ \"_\" ~ value.interface %}"},{"line_number":14,"context_line":"ovs-vsctl --if-exists del-port {{ lxc_container_network_ovs_port_indexed[-15:] }} || true"},{"line_number":15,"context_line":"{%     endif %}"},{"line_number":16,"context_line":"{%   endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"635312fa_41d243bd","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":119},"updated":"2025-01-06 08:48:28.000000000","message":"I guess you should be fine to remove this definition then?","commit_id":"78d8fb770e97ee5b8f94d15e9ddf687509e9071b"},{"author":{"_account_id":36565,"name":"Farbod Saghafi","display_name":"itsfarbod","email":"farbodsaghafimail@gmail.com","username":"itsfarbod"},"change_message_id":"2fa5d1ea7b0d81ff59f940a3203a1e759149a9e6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{%      endif %}"},{"line_number":11,"context_line":"ip link del {{ lxc_container_network_port_indexed }} || true"},{"line_number":12,"context_line":"{%     if \u0027bridge_type\u0027 in value and value.bridge_type \u003d\u003d \"openvswitch\" %}"},{"line_number":13,"context_line":"{%       set lxc_container_network_ovs_port_indexed \u003d lxc_container_network_veth_pair_prefix ~ \"_\" ~ value.interface %}"},{"line_number":14,"context_line":"ovs-vsctl --if-exists del-port {{ lxc_container_network_ovs_port_indexed[-15:] }} || true"},{"line_number":15,"context_line":"{%     endif %}"},{"line_number":16,"context_line":"{%   endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1e8d5ef5_35763312","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":119},"in_reply_to":"635312fa_41d243bd","updated":"2025-01-08 08:46:46.000000000","message":"Done","commit_id":"78d8fb770e97ee5b8f94d15e9ddf687509e9071b"}]}