)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eabd83c21f1837cf4f9affb437a228e222ad6cfb","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# lxc container net network"},{"line_number":58,"context_line":"lxc_net_bridge: lxcbr0"},{"line_number":59,"context_line":"lxc_net_address: 10.0.3.2"},{"line_number":60,"context_line":"lxc_net_netmask: 255.255.255.0"},{"line_number":61,"context_line":"lxc_net_gateway: 10.0.3.1  ## if null, no gateway will be on the LXC bridge. lxc_net_nat must be \"false\" to use a gateway."},{"line_number":62,"context_line":"lxc_net_mtu: 1500  ## setting this variable will add mtu configuration for the lxc config and network bridge"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_28de5c3d","line":59,"updated":"2017-06-28 17:01:19.000000000","message":"A lot of vars are being removed here - best to call that out in a release note.","commit_id":"7dd7d63c2d011dfc68318d9df96548c59326e381"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ee5e814f323b63ea9a8435fb5ae0495a0b3a6018","unresolved":false,"context_lines":[{"line_number":59,"context_line":"lxc_net_address: 10.0.3.1"},{"line_number":60,"context_line":"lxc_net_netmask: 255.255.255.0"},{"line_number":61,"context_line":"lxc_net_gateway: null  ## if null, no gateway will be on the LXC bridge."},{"line_number":62,"context_line":"lxc_net_mtu: 1500  ## setting this variable will add mtu configuration for the lxc config and network bridge"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Enable iptables for lxc network"},{"line_number":65,"context_line":"lxc_net_manage_iptables: true  ## If \"true\" iptables rules will be added when the bridge is up and deleted when bridge is down"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_5dcb8f1d","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":108},"updated":"2017-06-29 07:19:13.000000000","message":"please adapt this comment, as it serves as documentation.","commit_id":"6861ba285a599321d5ff853771e02027876fbbe3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bb934c16a0f0e0ca29a294d0c9cc432148a3afad","unresolved":false,"context_lines":[{"line_number":59,"context_line":"lxc_net_address: 10.0.3.1"},{"line_number":60,"context_line":"lxc_net_netmask: 255.255.255.0"},{"line_number":61,"context_line":"lxc_net_gateway: null  ## if null, no gateway will be on the LXC bridge."},{"line_number":62,"context_line":"lxc_net_mtu: 1500  ## setting this variable will add mtu configuration for the lxc config and network bridge"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Enable iptables for lxc network"},{"line_number":65,"context_line":"lxc_net_manage_iptables: true  ## If \"true\" iptables rules will be added when the bridge is up and deleted when bridge is down"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_a8c5c35d","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":108},"in_reply_to":"3f1d235d_5dcb8f1d","updated":"2017-06-29 07:26:36.000000000","message":"Done","commit_id":"6861ba285a599321d5ff853771e02027876fbbe3"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"db432d8a28b43f4adc5529499c9a49622c127125","unresolved":false,"context_lines":[{"line_number":63,"context_line":"## The MTU option is used both in and outside of the container."},{"line_number":64,"context_line":"lxc_net_mtu: 1500"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# lxc container dhcp settings"},{"line_number":67,"context_line":"lxc_net_dhcp_max: 100"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# lxc network ipv6 settings"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f1d235d_4eff5767","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":29},"updated":"2017-06-29 08:35:58.000000000","message":"You can replace this to be more explicit:\n# DHCP pool size","commit_id":"f2b2c3b2041dd0666b38d711a0994068240b34e5"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"db432d8a28b43f4adc5529499c9a49622c127125","unresolved":false,"context_lines":[{"line_number":81,"context_line":"lxc_network_default_link: {}"},{"line_number":82,"context_line":"## Physical host interface configurations (defaults to a dummy device)"},{"line_number":83,"context_line":"#   See all available overrides here https://www.freedesktop.org/software/systemd/man/systemd.netdev.html"},{"line_number":84,"context_line":"lxc_network_dummy_netdev: {}"},{"line_number":85,"context_line":"#   See all available overrides here https://www.freedesktop.org/software/systemd/man/systemd.network.html"},{"line_number":86,"context_line":"lxc_network_dummy_network: {}"},{"line_number":87,"context_line":"## LXC bridge configurations"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f1d235d_2e12dbb2","line":84,"updated":"2017-06-29 08:35:58.000000000","message":"Where is this used?","commit_id":"f2b2c3b2041dd0666b38d711a0994068240b34e5"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"db432d8a28b43f4adc5529499c9a49622c127125","unresolved":false,"context_lines":[{"line_number":83,"context_line":"#   See all available overrides here https://www.freedesktop.org/software/systemd/man/systemd.netdev.html"},{"line_number":84,"context_line":"lxc_network_dummy_netdev: {}"},{"line_number":85,"context_line":"#   See all available overrides here https://www.freedesktop.org/software/systemd/man/systemd.network.html"},{"line_number":86,"context_line":"lxc_network_dummy_network: {}"},{"line_number":87,"context_line":"## LXC bridge configurations"},{"line_number":88,"context_line":"#   See all available overrides here https://www.freedesktop.org/software/systemd/man/systemd.netdev.html"},{"line_number":89,"context_line":"lxc_network_lxcbr_netdev: {}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f1d235d_0e271f15","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":29},"updated":"2017-06-29 08:35:58.000000000","message":"where is this used? Why? Please document its purpose for deployers.","commit_id":"f2b2c3b2041dd0666b38d711a0994068240b34e5"}],"handlers/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eabd83c21f1837cf4f9affb437a228e222ad6cfb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    name: \"systemd-networkd\""},{"line_number":39,"context_line":"    state: \"restarted\""},{"line_number":40,"context_line":"    enabled: yes"},{"line_number":41,"context_line":"    daemon_reload: yes"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Veth check"},{"line_number":44,"context_line":"  command: \"/usr/local/bin/lxc-veth-check\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_e86624ed","line":41,"updated":"2017-06-28 17:01:19.000000000","message":"Is the veth check no longer required?","commit_id":"7dd7d63c2d011dfc68318d9df96548c59326e381"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0fa49e289912b9a4123d615ea74724180d18c107","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    name: \"systemd-networkd\""},{"line_number":39,"context_line":"    state: \"restarted\""},{"line_number":40,"context_line":"    enabled: yes"},{"line_number":41,"context_line":"    daemon_reload: yes"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Veth check"},{"line_number":44,"context_line":"  command: \"/usr/local/bin/lxc-veth-check\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_28b3fcea","line":41,"in_reply_to":"5f201791_4897583b","updated":"2017-06-28 17:11:51.000000000","message":"Done","commit_id":"7dd7d63c2d011dfc68318d9df96548c59326e381"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1ef456504be4201ea12d8d51c1aa62cfc971635a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    name: \"systemd-networkd\""},{"line_number":39,"context_line":"    state: \"restarted\""},{"line_number":40,"context_line":"    enabled: yes"},{"line_number":41,"context_line":"    daemon_reload: yes"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Veth check"},{"line_number":44,"context_line":"  command: \"/usr/local/bin/lxc-veth-check\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_4897583b","line":41,"in_reply_to":"5f201791_e86624ed","updated":"2017-06-28 17:06:09.000000000","message":"ah yes, the veth check should be added back.","commit_id":"7dd7d63c2d011dfc68318d9df96548c59326e381"}],"releasenotes/notes/networkd-lxcbr0-b7e58166eab04362.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e8622093c9f0391e6aab6981f02fbb98711a0fef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    this has been done to allow us to unify our container"},{"line_number":5,"context_line":"    network capabilities across distributions without carrying"},{"line_number":6,"context_line":"    distro specific configs. This also removes the need to run"},{"line_number":7,"context_line":"    dnsmasq, manage the process and it\u0027s specific user, and"},{"line_number":8,"context_line":"    simplifies the how the lxc network is started and attached"},{"line_number":9,"context_line":"    to across reboots."},{"line_number":10,"context_line":"  - Several variables were removed from the lxc_host role."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_63f46c5c","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":39},"updated":"2017-06-29 08:28:25.000000000","message":"its","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4d5cfa7be79effd7a04ac2e81671a82f53cd604d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    this has been done to allow us to unify our container"},{"line_number":5,"context_line":"    network capabilities across distributions without carrying"},{"line_number":6,"context_line":"    distro specific configs. This also removes the need to run"},{"line_number":7,"context_line":"    dnsmasq, manage the process and it\u0027s specific user, and"},{"line_number":8,"context_line":"    simplifies the how the lxc network is started and attached"},{"line_number":9,"context_line":"    to across reboots."},{"line_number":10,"context_line":"  - Several variables were removed from the lxc_host role."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_099eef62","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":39},"in_reply_to":"3f1d235d_63f46c5c","updated":"2017-06-29 13:58:50.000000000","message":"Done","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"}],"tasks/lxc_cache_preparation.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ee5e814f323b63ea9a8435fb5ae0495a0b3a6018","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"- name: Drop the basic network config"},{"line_number":140,"context_line":"  template:"},{"line_number":141,"context_line":"    src: networkd/contianer-eth0.network"},{"line_number":142,"context_line":"    dest: \"{{ lxc_image_cache_path }}/etc/systemd/network/contianer-eth0.network\""},{"line_number":143,"context_line":"    owner: root"},{"line_number":144,"context_line":"    group: root"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_ddd67fc4","line":141,"range":{"start_line":141,"start_character":22,"end_line":141,"end_character":24},"updated":"2017-06-29 07:19:13.000000000","message":"container","commit_id":"6861ba285a599321d5ff853771e02027876fbbe3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bb934c16a0f0e0ca29a294d0c9cc432148a3afad","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"- name: Drop the basic network config"},{"line_number":140,"context_line":"  template:"},{"line_number":141,"context_line":"    src: networkd/contianer-eth0.network"},{"line_number":142,"context_line":"    dest: \"{{ lxc_image_cache_path }}/etc/systemd/network/contianer-eth0.network\""},{"line_number":143,"context_line":"    owner: root"},{"line_number":144,"context_line":"    group: root"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_e86f3b90","line":141,"range":{"start_line":141,"start_character":22,"end_line":141,"end_character":24},"in_reply_to":"3f1d235d_ddd67fc4","updated":"2017-06-29 07:26:36.000000000","message":"Done","commit_id":"6861ba285a599321d5ff853771e02027876fbbe3"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ee5e814f323b63ea9a8435fb5ae0495a0b3a6018","unresolved":false,"context_lines":[{"line_number":139,"context_line":"- name: Drop the basic network config"},{"line_number":140,"context_line":"  template:"},{"line_number":141,"context_line":"    src: networkd/contianer-eth0.network"},{"line_number":142,"context_line":"    dest: \"{{ lxc_image_cache_path }}/etc/systemd/network/contianer-eth0.network\""},{"line_number":143,"context_line":"    owner: root"},{"line_number":144,"context_line":"    group: root"},{"line_number":145,"context_line":"    mode: \u00270644\u0027"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_3de9f37f","line":142,"range":{"start_line":142,"start_character":62,"end_line":142,"end_character":64},"updated":"2017-06-29 07:19:13.000000000","message":"same","commit_id":"6861ba285a599321d5ff853771e02027876fbbe3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bb934c16a0f0e0ca29a294d0c9cc432148a3afad","unresolved":false,"context_lines":[{"line_number":139,"context_line":"- name: Drop the basic network config"},{"line_number":140,"context_line":"  template:"},{"line_number":141,"context_line":"    src: networkd/contianer-eth0.network"},{"line_number":142,"context_line":"    dest: \"{{ lxc_image_cache_path }}/etc/systemd/network/contianer-eth0.network\""},{"line_number":143,"context_line":"    owner: root"},{"line_number":144,"context_line":"    group: root"},{"line_number":145,"context_line":"    mode: \u00270644\u0027"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_c86c7f9e","line":142,"range":{"start_line":142,"start_character":62,"end_line":142,"end_character":64},"in_reply_to":"3f1d235d_3de9f37f","updated":"2017-06-29 07:26:36.000000000","message":"Done","commit_id":"6861ba285a599321d5ff853771e02027876fbbe3"}],"tasks/lxc_net.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e8622093c9f0391e6aab6981f02fbb98711a0fef","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#                  This task is set to never fail. This is being done so we"},{"line_number":18,"context_line":"#                  can support greenfield deployment where dnsmasq may have"},{"line_number":19,"context_line":"#                  never existed."},{"line_number":20,"context_line":"- name: Ensure dnsmasq stopped"},{"line_number":21,"context_line":"  systemd:"},{"line_number":22,"context_line":"    name: \"dnsmasq\""},{"line_number":23,"context_line":"    state: \"stopped\""},{"line_number":24,"context_line":"    enabled: \"no\""},{"line_number":25,"context_line":"  failed_when: false"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(cloudnull): This is here for upgrade, remove in Q"},{"line_number":28,"context_line":"- name: Remove dnsmasq file(s)"},{"line_number":29,"context_line":"  file:"},{"line_number":30,"context_line":"    path: \"{{ item }}\""},{"line_number":31,"context_line":"    state: \"absent\""},{"line_number":32,"context_line":"  with_items:"},{"line_number":33,"context_line":"    - /var/run/dnsmasq/resolv.conf"},{"line_number":34,"context_line":"    - /etc/dnsmasq.conf"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# NOTE(cloudnull): The use of the lxc-net service should be universally disabled."},{"line_number":37,"context_line":"- name: Disable and stop lxc-net"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_03b13890","line":34,"range":{"start_line":20,"start_character":0,"end_line":34,"end_character":23},"updated":"2017-06-29 08:28:25.000000000","message":"can\u0027t we ensure the package is purged instead?","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8772bde8ff3aa9fae6702818e367bf432a106935","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#                  This task is set to never fail. This is being done so we"},{"line_number":18,"context_line":"#                  can support greenfield deployment where dnsmasq may have"},{"line_number":19,"context_line":"#                  never existed."},{"line_number":20,"context_line":"- name: Ensure dnsmasq stopped"},{"line_number":21,"context_line":"  systemd:"},{"line_number":22,"context_line":"    name: \"dnsmasq\""},{"line_number":23,"context_line":"    state: \"stopped\""},{"line_number":24,"context_line":"    enabled: \"no\""},{"line_number":25,"context_line":"  failed_when: false"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(cloudnull): This is here for upgrade, remove in Q"},{"line_number":28,"context_line":"- name: Remove dnsmasq file(s)"},{"line_number":29,"context_line":"  file:"},{"line_number":30,"context_line":"    path: \"{{ item }}\""},{"line_number":31,"context_line":"    state: \"absent\""},{"line_number":32,"context_line":"  with_items:"},{"line_number":33,"context_line":"    - /var/run/dnsmasq/resolv.conf"},{"line_number":34,"context_line":"    - /etc/dnsmasq.conf"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# NOTE(cloudnull): The use of the lxc-net service should be universally disabled."},{"line_number":37,"context_line":"- name: Disable and stop lxc-net"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_c9c6b717","line":34,"range":{"start_line":20,"start_character":0,"end_line":34,"end_character":23},"in_reply_to":"3f1d235d_03b13890","updated":"2017-06-29 14:05:08.000000000","message":"this package could be used elsewhere or by other services, like neutron-agents. these tasks are only removing the config and stopping the global service, which lxc was responsible for.","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e8622093c9f0391e6aab6981f02fbb98711a0fef","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled: yes"},{"line_number":90,"context_line":"    daemon_reload: yes"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"- name: Drop lxc firewall rules script"},{"line_number":93,"context_line":"  template:"},{"line_number":94,"context_line":"    src: \"lxc-firewall-rules.sh.j2\""},{"line_number":95,"context_line":"    dest: \"/usr/local/bin/lxc-firewall-rules.sh\""},{"line_number":96,"context_line":"    mode: \"0755\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Run lxc firewall rules script"},{"line_number":99,"context_line":"  command: \"/usr/local/bin/lxc-firewall-rules.sh\""},{"line_number":100,"context_line":"  become: yes"},{"line_number":101,"context_line":"  tags:"},{"line_number":102,"context_line":"    - skip_ansible_lint"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# Ensure lxc networks are running as they\u0027re supposed to"},{"line_number":105,"context_line":"- meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_2ea9bbde","line":102,"range":{"start_line":92,"start_character":0,"end_line":102,"end_character":23},"updated":"2017-06-29 08:28:25.000000000","message":"Please use http://docs.ansible.com/ansible/firewalld_module.html","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4d5cfa7be79effd7a04ac2e81671a82f53cd604d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled: yes"},{"line_number":90,"context_line":"    daemon_reload: yes"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"- name: Drop lxc firewall rules script"},{"line_number":93,"context_line":"  template:"},{"line_number":94,"context_line":"    src: \"lxc-firewall-rules.sh.j2\""},{"line_number":95,"context_line":"    dest: \"/usr/local/bin/lxc-firewall-rules.sh\""},{"line_number":96,"context_line":"    mode: \"0755\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Run lxc firewall rules script"},{"line_number":99,"context_line":"  command: \"/usr/local/bin/lxc-firewall-rules.sh\""},{"line_number":100,"context_line":"  become: yes"},{"line_number":101,"context_line":"  tags:"},{"line_number":102,"context_line":"    - skip_ansible_lint"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# Ensure lxc networks are running as they\u0027re supposed to"},{"line_number":105,"context_line":"- meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_291e4b0c","line":102,"range":{"start_line":92,"start_character":0,"end_line":102,"end_character":23},"in_reply_to":"3f1d235d_2ea9bbde","updated":"2017-06-29 13:58:50.000000000","message":"I\u0027d rather not use the module, the cli is already stateful and seems to be fairly neglected and I\u0027m not sure how I\u0027d represent all of the rules we need to create. Additionally the script is creating a specific \"lxc\" firewall zone which will enable us to easily clean up the lxc rules  we\u0027re creating should we ever want to switch to something else.","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"93e51e8fb480a99067f054a06de16adca0a5b919","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    - /var/run/dnsmasq/resolv.conf"},{"line_number":42,"context_line":"    - /etc/dnsmasq.conf"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# NOTE(cloudnull): This task is cleaning up old interface config files, Remote this is R."},{"line_number":45,"context_line":"- name: Remove interface file(s)"},{"line_number":46,"context_line":"  file:"},{"line_number":47,"context_line":"    path: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_83ee5386","line":44,"updated":"2017-06-29 18:59:41.000000000","message":"I think you meant: \"Remove this in the R release\"","commit_id":"a72c01ad6285b62ba4d03872115e51e1891d4f11"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"20ba79f3128b51c0e214b531181ae1135d66825b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    - /var/run/dnsmasq/resolv.conf"},{"line_number":42,"context_line":"    - /etc/dnsmasq.conf"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# NOTE(cloudnull): This task is cleaning up old interface config files, Remote this is R."},{"line_number":45,"context_line":"- name: Remove interface file(s)"},{"line_number":46,"context_line":"  file:"},{"line_number":47,"context_line":"    path: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_7282db51","line":44,"in_reply_to":"3f1d235d_83ee5386","updated":"2017-06-29 21:28:09.000000000","message":"Done","commit_id":"a72c01ad6285b62ba4d03872115e51e1891d4f11"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"93e51e8fb480a99067f054a06de16adca0a5b919","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  notify:"},{"line_number":98,"context_line":"    - Bring bridge up"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- name: Enable firewalld"},{"line_number":101,"context_line":"  systemd:"},{"line_number":102,"context_line":"    name: \"firewalld\""},{"line_number":103,"context_line":"    state: \"started\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f1d235d_435cbb4a","line":100,"updated":"2017-06-29 18:59:41.000000000","message":"This will likely cause issues with hyper-converged deployments, at least on CentOS. Bug: https://bugs.launchpad.net/openstack-ansible/+bug/1657518","commit_id":"a72c01ad6285b62ba4d03872115e51e1891d4f11"}],"templates/lxc-firewall-rules.sh.j2":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e8622093c9f0391e6aab6981f02fbb98711a0fef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3f1d235d_ae8dcb7c","updated":"2017-06-29 08:28:25.000000000","message":"This whole file could probably be removed and replace by default rules using firewalld module.\n\nIf not, we should tell why, and have a TODO item to improve it.","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ecd979232cadb18fa22184bd0af949326e1b64d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3f1d235d_29240b0d","in_reply_to":"3f1d235d_49cf477f","updated":"2017-06-29 14:03:11.000000000","message":"Also the use of firewalld is simply so we can have more unifor code across distros which is persistent. Before we had all of this jammed into the `lxc-system-manage` command which was executed when the bridge was brought up using a post-up shell call. Now we\u0027re being very explicit and ensuring the rules will live through a reboot and will not be impacted by a deployer messing with the lxcbr0 interface.","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4d5cfa7be79effd7a04ac2e81671a82f53cd604d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3f1d235d_49cf477f","in_reply_to":"3f1d235d_ae8dcb7c","updated":"2017-06-29 13:58:50.000000000","message":"I commented in the task file, tl;dr, this is more supportable than the firewalld module at this time. The module seems to lacking options and I\u0027d have to create \"rich\" rules to get everything we need in.","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"}],"vars/redhat-7.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e8622093c9f0391e6aab6981f02fbb98711a0fef","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    ln -s /usr/bin/python2.7 /usr/bin/python"},{"line_number":61,"context_line":"    yum clean all"},{"line_number":62,"context_line":"    mkdir -p /var/backup"},{"line_number":63,"context_line":"    systemctl enable ssh"},{"line_number":64,"context_line":"    systemctl enable systemd-networkd"},{"line_number":65,"context_line":"    chage -I -1 -d -1 -m 0 -M 99999 -E -1 root"},{"line_number":66,"context_line":"    {{ lxc_cache_prep_post_commands }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_aec5cb5d","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":24},"updated":"2017-06-29 08:28:25.000000000","message":"Do we need this?\nI\u0027m afraid that the cache prep will have ssh enabled, and the first container we will build will start ssh and generate keys. Or maybe we don\u0027t start container anymore for cache prep?","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"30a9ae55977339c5cdf3ad9611e4f97379590bcd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    ln -s /usr/bin/python2.7 /usr/bin/python"},{"line_number":61,"context_line":"    yum clean all"},{"line_number":62,"context_line":"    mkdir -p /var/backup"},{"line_number":63,"context_line":"    systemctl enable ssh"},{"line_number":64,"context_line":"    systemctl enable systemd-networkd"},{"line_number":65,"context_line":"    chage -I -1 -d -1 -m 0 -M 99999 -E -1 root"},{"line_number":66,"context_line":"    {{ lxc_cache_prep_post_commands }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_9b2a4ce5","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":24},"in_reply_to":"3f1d235d_aec5cb5d","updated":"2017-06-29 09:28:35.000000000","message":"Cache prep has *never* started the container.","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4d5cfa7be79effd7a04ac2e81671a82f53cd604d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    ln -s /usr/bin/python2.7 /usr/bin/python"},{"line_number":61,"context_line":"    yum clean all"},{"line_number":62,"context_line":"    mkdir -p /var/backup"},{"line_number":63,"context_line":"    systemctl enable ssh"},{"line_number":64,"context_line":"    systemctl enable systemd-networkd"},{"line_number":65,"context_line":"    chage -I -1 -d -1 -m 0 -M 99999 -E -1 root"},{"line_number":66,"context_line":"    {{ lxc_cache_prep_post_commands }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f1d235d_e9c5f35c","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":24},"in_reply_to":"3f1d235d_aec5cb5d","updated":"2017-06-29 13:58:50.000000000","message":"we do this in the other container types, this just makes it uniform.","commit_id":"775b5a2bb2f9746f91e14556734f78a610468d50"}]}
