)]}'
{"defaults/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b0f1ad713b08b4977a21fb0745db70d352f95ece","unresolved":false,"context_lines":[{"line_number":127,"context_line":"lxc_cache_prep_post_commands: \u0027## post command skipped ##\u0027"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"# The DNS name of the LXD server to source the base container cache from"},{"line_number":130,"context_line":"lxc_image_cache_server: images.linuxcontainers.org"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# The protocol to use to fetch from lxc_image_cache_server"},{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_9a5c247f","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":50},"updated":"2017-08-10 09:59:09.000000000","message":"We can definitely keep the url, we are using the url everywhere.\nChanging vars is not something we should do without release notes, etc.\n\nOn top of it, I don\u0027t see the value.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f00aeb2d3f74c2afd68b8cbda973935273c4f0af","unresolved":false,"context_lines":[{"line_number":127,"context_line":"lxc_cache_prep_post_commands: \u0027## post command skipped ##\u0027"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"# The DNS name of the LXD server to source the base container cache from"},{"line_number":130,"context_line":"lxc_image_cache_server: images.linuxcontainers.org"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# The protocol to use to fetch from lxc_image_cache_server"},{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_b5793b94","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":50},"in_reply_to":"9f436f4f_3aad3831","updated":"2017-08-10 10:14:55.000000000","message":"If we want consistency, I\u0027d rather have everything set to a real canonical uri, or even better, a real resource URI, not a dns name.\n\nWe may want to change the rest.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22e6d12217ebfb2cc3835f0a074dcb7af172ad74","unresolved":false,"context_lines":[{"line_number":127,"context_line":"lxc_cache_prep_post_commands: \u0027## post command skipped ##\u0027"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"# The DNS name of the LXD server to source the base container cache from"},{"line_number":130,"context_line":"lxc_image_cache_server: images.linuxcontainers.org"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# The protocol to use to fetch from lxc_image_cache_server"},{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_3aad3831","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":50},"in_reply_to":"9f436f4f_9a5c247f","updated":"2017-08-10 10:04:45.000000000","message":"The value was changes from a dns entry to a URL in the machinectl patch - so your assumption that we\u0027re using the URL everywhere is wrong. Everywhere else, and in the stable branches, we\u0027re using a DNS name only.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"075c465be4ffb64b651b4e8d102e41d5e3cbb6ed","unresolved":false,"context_lines":[{"line_number":127,"context_line":"lxc_cache_prep_post_commands: \u0027## post command skipped ##\u0027"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"# The DNS name of the LXD server to source the base container cache from"},{"line_number":130,"context_line":"lxc_image_cache_server: images.linuxcontainers.org"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# The protocol to use to fetch from lxc_image_cache_server"},{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_15c6c749","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":50},"in_reply_to":"9f436f4f_b5793b94","updated":"2017-08-10 10:35:10.000000000","message":"The URI is not valid for the lxc tooling, that\u0027s why it was set to the DNS name. The LXC tooling expects a DNS name - see https://github.com/lxc/lxc/blob/master/templates/lxc-download.in#L86-L87","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b0f1ad713b08b4977a21fb0745db70d352f95ece","unresolved":false,"context_lines":[{"line_number":130,"context_line":"lxc_image_cache_server: images.linuxcontainers.org"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# The protocol to use to fetch from lxc_image_cache_server"},{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Path to images on server"},{"line_number":136,"context_line":"lxc_image_cache_server_path: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/images/{{ lxc_cache_map.distro }}/{{ lxc_cache_map.release }}/{{ lxc_cache_map.arch }}/{{ lxc_cache_default_variant }}/\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_5a56bc5e","line":133,"range":{"start_line":133,"start_character":30,"end_line":133,"end_character":34},"updated":"2017-08-10 09:59:09.000000000","message":"Why changing the default protocol for everyone?","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22e6d12217ebfb2cc3835f0a074dcb7af172ad74","unresolved":false,"context_lines":[{"line_number":130,"context_line":"lxc_image_cache_server: images.linuxcontainers.org"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# The protocol to use to fetch from lxc_image_cache_server"},{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Path to images on server"},{"line_number":136,"context_line":"lxc_image_cache_server_path: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/images/{{ lxc_cache_map.distro }}/{{ lxc_cache_map.release }}/{{ lxc_cache_map.arch }}/{{ lxc_cache_default_variant }}/\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_da63cc19","line":133,"range":{"start_line":133,"start_character":30,"end_line":133,"end_character":34},"in_reply_to":"9f436f4f_5a56bc5e","updated":"2017-08-10 10:04:45.000000000","message":"This is the default protocol used before. It\u0027s also the default fallback for LXC.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f00aeb2d3f74c2afd68b8cbda973935273c4f0af","unresolved":false,"context_lines":[{"line_number":130,"context_line":"lxc_image_cache_server: images.linuxcontainers.org"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# The protocol to use to fetch from lxc_image_cache_server"},{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Path to images on server"},{"line_number":136,"context_line":"lxc_image_cache_server_path: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/images/{{ lxc_cache_map.distro }}/{{ lxc_cache_map.release }}/{{ lxc_cache_map.arch }}/{{ lxc_cache_default_variant }}/\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_556a0fb3","line":133,"range":{"start_line":133,"start_character":30,"end_line":133,"end_character":34},"in_reply_to":"9f436f4f_da63cc19","updated":"2017-08-10 10:14:55.000000000","message":"OK, good. Let\u0027s use that into the lxc_image_cache_server then, to reduce the amount of variables. There is no need to carry this variable, as I guess no-one will ever override that without overriding the lxc_image_cache_server.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b0f1ad713b08b4977a21fb0745db70d352f95ece","unresolved":false,"context_lines":[{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Path to images on server"},{"line_number":136,"context_line":"lxc_image_cache_server_path: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/images/{{ lxc_cache_map.distro }}/{{ lxc_cache_map.release }}/{{ lxc_cache_map.arch }}/{{ lxc_cache_default_variant }}/\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Local path to cached image"},{"line_number":139,"context_line":"lxc_image_cache_path: \"/var/lib/machines/{{ lxc_container_base_name }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_fa4a10aa","line":136,"range":{"start_line":136,"start_character":30,"end_line":136,"end_character":94},"updated":"2017-08-10 09:59:09.000000000","message":"Why is this necessary?","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"075c465be4ffb64b651b4e8d102e41d5e3cbb6ed","unresolved":false,"context_lines":[{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Path to images on server"},{"line_number":136,"context_line":"lxc_image_cache_server_path: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/images/{{ lxc_cache_map.distro }}/{{ lxc_cache_map.release }}/{{ lxc_cache_map.arch }}/{{ lxc_cache_default_variant }}/\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Local path to cached image"},{"line_number":139,"context_line":"lxc_image_cache_path: \"/var/lib/machines/{{ lxc_container_base_name }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_f5d583e6","line":136,"range":{"start_line":136,"start_character":30,"end_line":136,"end_character":94},"in_reply_to":"9f436f4f_35654be2","updated":"2017-08-10 10:35:10.000000000","message":"How else would you prefer to implement this? Would you prefer the protocol be hard coded into every task which uses lxc_image_cache_server ?","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f00aeb2d3f74c2afd68b8cbda973935273c4f0af","unresolved":false,"context_lines":[{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Path to images on server"},{"line_number":136,"context_line":"lxc_image_cache_server_path: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/images/{{ lxc_cache_map.distro }}/{{ lxc_cache_map.release }}/{{ lxc_cache_map.arch }}/{{ lxc_cache_default_variant }}/\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Local path to cached image"},{"line_number":139,"context_line":"lxc_image_cache_path: \"/var/lib/machines/{{ lxc_container_base_name }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_35654be2","line":136,"range":{"start_line":136,"start_character":30,"end_line":136,"end_character":94},"in_reply_to":"9f436f4f_9a6d4406","updated":"2017-08-10 10:14:55.000000000","message":"It may be for you, it\u0027s not for me. I have yet to understand why creating a variable for this.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c468e89a983c4590e35829e7f27a905998e40b4","unresolved":false,"context_lines":[{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Path to images on server"},{"line_number":136,"context_line":"lxc_image_cache_server_path: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/images/{{ lxc_cache_map.distro }}/{{ lxc_cache_map.release }}/{{ lxc_cache_map.arch }}/{{ lxc_cache_default_variant }}/\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Local path to cached image"},{"line_number":139,"context_line":"lxc_image_cache_path: \"/var/lib/machines/{{ lxc_container_base_name }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_3909c52b","line":136,"range":{"start_line":136,"start_character":30,"end_line":136,"end_character":94},"in_reply_to":"9f436f4f_b565bb47","updated":"2017-08-10 10:52:26.000000000","message":"If we change the format of the value of this var, then we also have to change it in lxc_container_create and make it strip the protocol. That\u0027s unnecessary complexity which adds a knock-on effect to anyone overriding the var.\n\nChanging lxc_image_cache_server_path to include the protocol only helps a single task - there are others which are using lxc_image_cache_server which also require the protocol, so what purpose does it serve to do what you suggest here?\n\nI still believe that my change is the least disruptive for upgrades.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cbc09d180760bbeef1048cf114010d0dd7be9037","unresolved":false,"context_lines":[{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Path to images on server"},{"line_number":136,"context_line":"lxc_image_cache_server_path: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/images/{{ lxc_cache_map.distro }}/{{ lxc_cache_map.release }}/{{ lxc_cache_map.arch }}/{{ lxc_cache_default_variant }}/\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Local path to cached image"},{"line_number":139,"context_line":"lxc_image_cache_path: \"/var/lib/machines/{{ lxc_container_base_name }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_b565bb47","line":136,"range":{"start_line":136,"start_character":30,"end_line":136,"end_character":94},"in_reply_to":"9f436f4f_f5d583e6","updated":"2017-08-10 10:42:52.000000000","message":"no, that sounds awful!\n\nSimply (if we really want to keep dns):\nlxc_image_cache_server_path: \"http://{{lxc_image_cache_server}}/images/ ...\"\n\nIf someone wants to override, he can override the lxc_image_cache_server_path.\n\nOr, in your case, replace the lxc_image_cache_server by:\n${NODEPOOL_MIRROR_HOST}:8080/images.linuxcontainers\n\nthat\u0027s also why I\u0027d prefer having a full url:\nIf we define a full url, we could strip (manually or using a filter), to only get what we need.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22e6d12217ebfb2cc3835f0a074dcb7af172ad74","unresolved":false,"context_lines":[{"line_number":133,"context_line":"lxc_image_cache_server_proto: http"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Path to images on server"},{"line_number":136,"context_line":"lxc_image_cache_server_path: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/images/{{ lxc_cache_map.distro }}/{{ lxc_cache_map.release }}/{{ lxc_cache_map.arch }}/{{ lxc_cache_default_variant }}/\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Local path to cached image"},{"line_number":139,"context_line":"lxc_image_cache_path: \"/var/lib/machines/{{ lxc_container_base_name }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_9a6d4406","line":136,"range":{"start_line":136,"start_character":30,"end_line":136,"end_character":94},"in_reply_to":"9f436f4f_fa4a10aa","updated":"2017-08-10 10:04:45.000000000","message":"As above, I think this is self explanatory.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"}],"tasks/lxc_cache_create.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b0f1ad713b08b4977a21fb0745db70d352f95ece","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Update LXC image meta data"},{"line_number":41,"context_line":"  get_url:"},{"line_number":42,"context_line":"    url: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/{{ item.split(\u0027;\u0027)[-1] }}/meta.tar.xz\""},{"line_number":43,"context_line":"    dest: \"/tmp/meta.tar.xz\""},{"line_number":44,"context_line":"  with_items: \"{{ lxc_images }}\""},{"line_number":45,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_da14eca2","line":42,"updated":"2017-08-10 09:59:09.000000000","message":"Why changing?","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22e6d12217ebfb2cc3835f0a074dcb7af172ad74","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Update LXC image meta data"},{"line_number":41,"context_line":"  get_url:"},{"line_number":42,"context_line":"    url: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/{{ item.split(\u0027;\u0027)[-1] }}/meta.tar.xz\""},{"line_number":43,"context_line":"    dest: \"/tmp/meta.tar.xz\""},{"line_number":44,"context_line":"  with_items: \"{{ lxc_images }}\""},{"line_number":45,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_7a7060dd","line":42,"in_reply_to":"9f436f4f_da14eca2","updated":"2017-08-10 10:04:45.000000000","message":"As explained in defaults, I think it\u0027s self explanatory.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"}],"tasks/lxc_cache_preparation.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b0f1ad713b08b4977a21fb0745db70d352f95ece","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Retrieve Image Index"},{"line_number":22,"context_line":"  uri:"},{"line_number":23,"context_line":"    url: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/meta/1.0/index-system\""},{"line_number":24,"context_line":"    return_content: yes"},{"line_number":25,"context_line":"  register: image_index"},{"line_number":26,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_1a4954cf","line":23,"updated":"2017-08-10 09:59:09.000000000","message":"Why changing?","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22e6d12217ebfb2cc3835f0a074dcb7af172ad74","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Retrieve Image Index"},{"line_number":22,"context_line":"  uri:"},{"line_number":23,"context_line":"    url: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}/meta/1.0/index-system\""},{"line_number":24,"context_line":"    return_content: yes"},{"line_number":25,"context_line":"  register: image_index"},{"line_number":26,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_3a72d8e4","line":23,"in_reply_to":"9f436f4f_1a4954cf","updated":"2017-08-10 10:04:45.000000000","message":"As explained in defaults, I think it\u0027s self explanatory.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"}],"tasks/lxc_cache_preparation_systemd_new.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b0f1ad713b08b4977a21fb0745db70d352f95ece","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    machinectl"},{"line_number":37,"context_line":"    --verify\u003dno"},{"line_number":38,"context_line":"    {{ lxc_image_cache_pull_mode }}"},{"line_number":39,"context_line":"    {{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}{{ item.split(\u0027;\u0027)[-1] }}rootfs.tar.xz"},{"line_number":40,"context_line":"    {{ lxc_container_base_name }}"},{"line_number":41,"context_line":"  register: pull_image"},{"line_number":42,"context_line":"  until: pull_image | success"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_7a38603c","line":39,"updated":"2017-08-10 09:59:09.000000000","message":"Why changing?","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22e6d12217ebfb2cc3835f0a074dcb7af172ad74","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    machinectl"},{"line_number":37,"context_line":"    --verify\u003dno"},{"line_number":38,"context_line":"    {{ lxc_image_cache_pull_mode }}"},{"line_number":39,"context_line":"    {{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}{{ item.split(\u0027;\u0027)[-1] }}rootfs.tar.xz"},{"line_number":40,"context_line":"    {{ lxc_container_base_name }}"},{"line_number":41,"context_line":"  register: pull_image"},{"line_number":42,"context_line":"  until: pull_image | success"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_1a815490","line":39,"in_reply_to":"9f436f4f_7a38603c","updated":"2017-08-10 10:04:45.000000000","message":"As explained in defaults, I think it\u0027s self explanatory.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"}],"tasks/lxc_cache_preparation_systemd_old.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b0f1ad713b08b4977a21fb0745db70d352f95ece","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- name: Retrieve base image"},{"line_number":135,"context_line":"  get_url:"},{"line_number":136,"context_line":"    url: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}{{ item.split(\u0027;\u0027)[-1] }}rootfs.tar.xz\""},{"line_number":137,"context_line":"    dest: \"/tmp/rootfs.tar.xz\""},{"line_number":138,"context_line":"  register: pull_image"},{"line_number":139,"context_line":"  until: pull_image | success"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_ba2ec8f7","line":136,"updated":"2017-08-10 09:59:09.000000000","message":"I don\u0027t see why we need to change this.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22e6d12217ebfb2cc3835f0a074dcb7af172ad74","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- name: Retrieve base image"},{"line_number":135,"context_line":"  get_url:"},{"line_number":136,"context_line":"    url: \"{{ lxc_image_cache_server_proto }}://{{ lxc_image_cache_server }}{{ item.split(\u0027;\u0027)[-1] }}rootfs.tar.xz\""},{"line_number":137,"context_line":"    dest: \"/tmp/rootfs.tar.xz\""},{"line_number":138,"context_line":"  register: pull_image"},{"line_number":139,"context_line":"  until: pull_image | success"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_ba4fe890","line":136,"in_reply_to":"9f436f4f_ba2ec8f7","updated":"2017-08-10 10:04:45.000000000","message":"As explained in defaults, I think it\u0027s self explanatory.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"}],"tests/test.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b0f1ad713b08b4977a21fb0745db70d352f95ece","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      stat:"},{"line_number":55,"context_line":"        path: /etc/nodepool/provider"},{"line_number":56,"context_line":"      register: nodepool"},{"line_number":57,"context_line":"    - name: Discover the lxc_image_cache_server value when in nodepool"},{"line_number":58,"context_line":"      shell:"},{"line_number":59,"context_line":"        source /etc/ci/mirror_info.sh"},{"line_number":60,"context_line":"        echo \"${NODEPOOL_MIRROR_HOST}:8080/images.linuxcontainers\""},{"line_number":61,"context_line":"      args:"},{"line_number":62,"context_line":"        executable: /bin/bash"},{"line_number":63,"context_line":"      register: lxc_reverse_proxy"},{"line_number":64,"context_line":"      when:"},{"line_number":65,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":66,"context_line":"      tags:"},{"line_number":67,"context_line":"        - skip_ansible_lint"},{"line_number":68,"context_line":"    - name: Set a fact to override lxc_image_cache_server value when in nodepool"},{"line_number":69,"context_line":"      set_fact:"},{"line_number":70,"context_line":"        lxc_image_cache_server: \"{{ lxc_reverse_proxy.stdout }}\""},{"line_number":71,"context_line":"      when:"},{"line_number":72,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  roles:"},{"line_number":75,"context_line":"    - role: \"lxc_hosts\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_1af4b485","line":72,"range":{"start_line":57,"start_character":0,"end_line":72,"end_character":37},"updated":"2017-08-10 09:59:09.000000000","message":"Is this exported by default in the runtime environment?\nCan\u0027t we just use\nset_fact:\n  lxc_image_cache_server: http://{{ ansible_env.NODEPOOL_MIRROR_HOST }}:8080/images.linuxcontainers\n\nand be done with it?","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22e6d12217ebfb2cc3835f0a074dcb7af172ad74","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      stat:"},{"line_number":55,"context_line":"        path: /etc/nodepool/provider"},{"line_number":56,"context_line":"      register: nodepool"},{"line_number":57,"context_line":"    - name: Discover the lxc_image_cache_server value when in nodepool"},{"line_number":58,"context_line":"      shell:"},{"line_number":59,"context_line":"        source /etc/ci/mirror_info.sh"},{"line_number":60,"context_line":"        echo \"${NODEPOOL_MIRROR_HOST}:8080/images.linuxcontainers\""},{"line_number":61,"context_line":"      args:"},{"line_number":62,"context_line":"        executable: /bin/bash"},{"line_number":63,"context_line":"      register: lxc_reverse_proxy"},{"line_number":64,"context_line":"      when:"},{"line_number":65,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":66,"context_line":"      tags:"},{"line_number":67,"context_line":"        - skip_ansible_lint"},{"line_number":68,"context_line":"    - name: Set a fact to override lxc_image_cache_server value when in nodepool"},{"line_number":69,"context_line":"      set_fact:"},{"line_number":70,"context_line":"        lxc_image_cache_server: \"{{ lxc_reverse_proxy.stdout }}\""},{"line_number":71,"context_line":"      when:"},{"line_number":72,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  roles:"},{"line_number":75,"context_line":"    - role: \"lxc_hosts\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_9a46647c","line":72,"range":{"start_line":57,"start_character":0,"end_line":72,"end_character":37},"in_reply_to":"9f436f4f_1af4b485","updated":"2017-08-10 10:04:45.000000000","message":"Because it\u0027s not exported in the runtime environment.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f00aeb2d3f74c2afd68b8cbda973935273c4f0af","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      stat:"},{"line_number":55,"context_line":"        path: /etc/nodepool/provider"},{"line_number":56,"context_line":"      register: nodepool"},{"line_number":57,"context_line":"    - name: Discover the lxc_image_cache_server value when in nodepool"},{"line_number":58,"context_line":"      shell:"},{"line_number":59,"context_line":"        source /etc/ci/mirror_info.sh"},{"line_number":60,"context_line":"        echo \"${NODEPOOL_MIRROR_HOST}:8080/images.linuxcontainers\""},{"line_number":61,"context_line":"      args:"},{"line_number":62,"context_line":"        executable: /bin/bash"},{"line_number":63,"context_line":"      register: lxc_reverse_proxy"},{"line_number":64,"context_line":"      when:"},{"line_number":65,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":66,"context_line":"      tags:"},{"line_number":67,"context_line":"        - skip_ansible_lint"},{"line_number":68,"context_line":"    - name: Set a fact to override lxc_image_cache_server value when in nodepool"},{"line_number":69,"context_line":"      set_fact:"},{"line_number":70,"context_line":"        lxc_image_cache_server: \"{{ lxc_reverse_proxy.stdout }}\""},{"line_number":71,"context_line":"      when:"},{"line_number":72,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  roles:"},{"line_number":75,"context_line":"    - role: \"lxc_hosts\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_1a08342a","line":72,"range":{"start_line":57,"start_character":0,"end_line":72,"end_character":37},"in_reply_to":"9f436f4f_9a46647c","updated":"2017-08-10 10:14:55.000000000","message":"OK.","commit_id":"94d968ff102de8b5bb7e249ef785c08f65647a9b"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"3bf8d8a9e32b70d80b75962e572b9ec196f57f41","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      with_items:"},{"line_number":48,"context_line":"        - \"91.189.91.21 images.linuxcontainers.org us.images.linuxcontainers.org\""},{"line_number":49,"context_line":"        - \"91.189.88.37 images.linuxcontainers.org uk.images.linuxcontainers.org\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    # This is a temporary hack to override the LXC image source to"},{"line_number":52,"context_line":"    # the reverse proxy if the test is run in OpenStack-Infra."},{"line_number":53,"context_line":"    - name: Check if this is an OpenStack-CI nodepool instance"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f436f4f_a2e1fe2c","line":50,"updated":"2017-08-10 12:48:53.000000000","message":"Couldn\u0027t you leverage https://review.openstack.org/#/c/492465 here instead?","commit_id":"93c2d32d0c5648491e3c9cceb55489dd6ad726dd"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"d0ddac5f319dff9321fbc3b2fad2344a04eab57c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      with_items:"},{"line_number":48,"context_line":"        - \"91.189.91.21 images.linuxcontainers.org us.images.linuxcontainers.org\""},{"line_number":49,"context_line":"        - \"91.189.88.37 images.linuxcontainers.org uk.images.linuxcontainers.org\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    # This is a temporary hack to override the LXC image source to"},{"line_number":52,"context_line":"    # the reverse proxy if the test is run in OpenStack-Infra."},{"line_number":53,"context_line":"    - name: Check if this is an OpenStack-CI nodepool instance"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f436f4f_c2ac028e","line":50,"in_reply_to":"9f436f4f_82bcbadc","updated":"2017-08-10 12:57:44.000000000","message":"Got it. Thanks","commit_id":"93c2d32d0c5648491e3c9cceb55489dd6ad726dd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"af25de865d641cca67aa3230f866c9acba12f65c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      with_items:"},{"line_number":48,"context_line":"        - \"91.189.91.21 images.linuxcontainers.org us.images.linuxcontainers.org\""},{"line_number":49,"context_line":"        - \"91.189.88.37 images.linuxcontainers.org uk.images.linuxcontainers.org\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    # This is a temporary hack to override the LXC image source to"},{"line_number":52,"context_line":"    # the reverse proxy if the test is run in OpenStack-Infra."},{"line_number":53,"context_line":"    - name: Check if this is an OpenStack-CI nodepool instance"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f436f4f_82bcbadc","line":50,"in_reply_to":"9f436f4f_a2e1fe2c","updated":"2017-08-10 12:53:49.000000000","message":"There would then be a circular dependency.\n\nWe can revise how these tests are done after it all stabilises, but right now this test does not make use of any vars or plays in the tests repo.","commit_id":"93c2d32d0c5648491e3c9cceb55489dd6ad726dd"}]}