)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"4f35d793833a909b7e2ac09917509f670d5b5d2c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove dnsmasq from package list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The dnsmasq package is a dependent package for"},{"line_number":10,"context_line":"LXC and therefore does not need to be in our"},{"line_number":11,"context_line":"package lists."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In Ubuntu the \u0027dnsmasq\u0027 package actually includes"},{"line_number":14,"context_line":"init scripts and service configuration which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_673ef6c1","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":14},"updated":"2017-08-16 13:56:08.000000000","message":"This is not true on openSUSE\n\nhttps://build.opensuse.org/package/view_file/openSUSE:Leap:42.3:Update/lxc/lxc.spec?expand\u003d1\n\ninstalling lxc will not pull dnsmasq in","commit_id":"2f348c4f39aff607965e575db69d36e0ac82c7cc"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"63e952e1f6245ae6fefd988e3f1d152211f07b3b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"package lists."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In Ubuntu the \u0027dnsmasq\u0027 package actually includes"},{"line_number":14,"context_line":"init scripts and service configuration which"},{"line_number":15,"context_line":"conflict with LXC and are best not included. The"},{"line_number":16,"context_line":"actual dependent package is \u0027dnsmasq-base\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Instead of trying to keep track of the right"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_fc527934","line":15,"range":{"start_line":14,"start_character":39,"end_line":15,"end_character":43},"updated":"2017-08-16 13:53:15.000000000","message":"If this is breaking current builds should we do more to purge it out than just stop installing it for greenfields? Do we need to state\u003dabsent it from existing builds? Or will the package skew (present on old builds, missing on new builds) not affect anything?","commit_id":"2f348c4f39aff607965e575db69d36e0ac82c7cc"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"8cd8cf2b23c3ae945d4e57d92bfba3ac7d0c2ab3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"package lists."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In Ubuntu the \u0027dnsmasq\u0027 package actually includes"},{"line_number":14,"context_line":"init scripts and service configuration which"},{"line_number":15,"context_line":"conflict with LXC and are best not included. The"},{"line_number":16,"context_line":"actual dependent package is \u0027dnsmasq-base\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Instead of trying to keep track of the right"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_67b15647","line":15,"range":{"start_line":14,"start_character":39,"end_line":15,"end_character":43},"in_reply_to":"9f436f4f_27346edd","updated":"2017-08-16 13:59:02.000000000","message":"Also ideally would like to see a bug referenced for further reading about what brokenness necessitated this","commit_id":"2f348c4f39aff607965e575db69d36e0ac82c7cc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ddab6ead61ab5443df25d3b2a5bacba5bc64f699","unresolved":false,"context_lines":[{"line_number":11,"context_line":"package lists."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In Ubuntu the \u0027dnsmasq\u0027 package actually includes"},{"line_number":14,"context_line":"init scripts and service configuration which"},{"line_number":15,"context_line":"conflict with LXC and are best not included. The"},{"line_number":16,"context_line":"actual dependent package is \u0027dnsmasq-base\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Instead of trying to keep track of the right"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_27346edd","line":15,"range":{"start_line":14,"start_character":39,"end_line":15,"end_character":43},"in_reply_to":"9f436f4f_fc527934","updated":"2017-08-16 13:56:22.000000000","message":"Yeah, I was thinking about this exact question when I noticed your comment.","commit_id":"2f348c4f39aff607965e575db69d36e0ac82c7cc"}],"tasks/lxc_dnsmasq_cleanup.yml":[{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"d44b38bd1e5da47f221732c666535386d8c3cd90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f436f4f_edbe45d3","side":"PARENT","updated":"2017-08-16 15:04:22.000000000","message":"Is this still needed on centos or suse?","commit_id":"de1b45553e856ac618562476095e4023c8f627be"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4ce7cba8c8343a148118027886a2393e2c9839bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f436f4f_08c3b758","side":"PARENT","in_reply_to":"9f436f4f_edbe45d3","updated":"2017-08-16 15:37:04.000000000","message":"CentOS and SUSE have just passed gates in testing, so I guess not. :)","commit_id":"de1b45553e856ac618562476095e4023c8f627be"}]}
