)]}'
{"tasks/lxc_cache_preparation_systemd_new.yml":[{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"f869d83cdce493a5800aa95502ebc9c4d4bac671","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  retries: 60"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Find real image name"},{"line_number":34,"context_line":"  shell: tail -n1 \"/var/log/aria2c-image-prestage.log\" | awk \u0027{print $3}\u0027"},{"line_number":35,"context_line":"  register: real_image_name"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Ensure systemd-importd is enabled"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_3e0bec8e","line":34,"updated":"2019-04-23 20:44:55.000000000","message":"This is potentially slightly hackish :) I couldn\u0027t find an Ansible way of doing this.","commit_id":"6221397665d47277dc66a6c1ffa666be3bc04396"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"038eae18de703aca4abc08a9c960a22693400a9d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  retries: 60"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Find real image name"},{"line_number":34,"context_line":"  shell: tail -n1 \"/var/log/aria2c-image-prestage.log\" | awk \u0027{print $3}\u0027"},{"line_number":35,"context_line":"  register: real_image_name"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Ensure systemd-importd is enabled"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_601a087e","line":34,"in_reply_to":"ffb9cba7_20cc10bb","updated":"2019-04-24 17:07:36.000000000","message":"I have concerns about how static aria output is, as it may change one day, which will break all of the distros and corresponding tags, as we install aria from packages and don\u0027t have any version lock. I don\u0027t have anything against tail and awk:)","commit_id":"6221397665d47277dc66a6c1ffa666be3bc04396"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"7400440e0a1e305369d37f2ffd1c8c04fc77c7f9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  retries: 60"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Find real image name"},{"line_number":34,"context_line":"  shell: tail -n1 \"/var/log/aria2c-image-prestage.log\" | awk \u0027{print $3}\u0027"},{"line_number":35,"context_line":"  register: real_image_name"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Ensure systemd-importd is enabled"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_20cc10bb","line":34,"in_reply_to":"ffb9cba7_26faf674","updated":"2019-04-24 16:36:46.000000000","message":"Could you elaborate on why you don\u0027t like this change? Is it because it affects all distros? Or do you think it might break in some other way? Or the way I used tail and awk since they are external dependencies?","commit_id":"6221397665d47277dc66a6c1ffa666be3bc04396"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6d354e88f3c01b0f07b68561bfb829cfe0eeadac","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  retries: 60"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Find real image name"},{"line_number":34,"context_line":"  shell: tail -n1 \"/var/log/aria2c-image-prestage.log\" | awk \u0027{print $3}\u0027"},{"line_number":35,"context_line":"  register: real_image_name"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Ensure systemd-importd is enabled"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_26faf674","line":34,"in_reply_to":"ffb9cba7_3e0bec8e","updated":"2019-04-24 08:49:23.000000000","message":"I don\u0027t really like, that we replace unreliable way to determine suse image name with pretty arguable reliable way of determining all images names. On the other side other images also may become metalinks one day, and we\u0027ll be ready for this.","commit_id":"6221397665d47277dc66a6c1ffa666be3bc04396"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"5c94b44957cb23cd8af6e0a4477239cbe2ba8dcf","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  retries: 60"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Find real image name"},{"line_number":34,"context_line":"  shell: tail -n1 \"/var/log/aria2c-image-prestage.log\" | awk \u0027{print $3}\u0027"},{"line_number":35,"context_line":"  register: real_image_name"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Ensure systemd-importd is enabled"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_a9c54b3e","line":34,"in_reply_to":"ffb9cba7_601a087e","updated":"2019-04-24 19:01:21.000000000","message":"Ah ok, good point. On the other hand, what if openSUSE decides to keep more than one build on their download server? Then the parsing we had before would have to become more intelligent. In any case, the fact that we need to jump through hoops just to download the latest and greatest is definitely not ideal.","commit_id":"6221397665d47277dc66a6c1ffa666be3bc04396"}],"tasks/lxc_cache_prestage.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8eb10a976fcc2c0a8295a11426fc7f1a5e7076e9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    aria2c"},{"line_number":51,"context_line":"    --max-connection-per-server\u003d4"},{"line_number":52,"context_line":"    --allow-overwrite\u003dtrue"},{"line_number":53,"context_line":"    --dir\u003d/tmp"},{"line_number":54,"context_line":"    --out\u003d{{ cache_basename }}"},{"line_number":55,"context_line":"    --check-certificate\u003d{{ (lxc_hosts_validate_certs | bool) | lower }}"},{"line_number":56,"context_line":"    --on-download-complete\u003decho"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_bb6d8a99","line":53,"updated":"2019-04-25 06:56:15.000000000","message":"I\u0027d add --follow-metalink\u003dmem here anyway","commit_id":"6221397665d47277dc66a6c1ffa666be3bc04396"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"4bd2872702f7a733a47ec4c876f958504dd511fa","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    aria2c"},{"line_number":51,"context_line":"    --max-connection-per-server\u003d4"},{"line_number":52,"context_line":"    --allow-overwrite\u003dtrue"},{"line_number":53,"context_line":"    --dir\u003d/tmp"},{"line_number":54,"context_line":"    --out\u003d{{ cache_basename }}"},{"line_number":55,"context_line":"    --check-certificate\u003d{{ (lxc_hosts_validate_certs | bool) | lower }}"},{"line_number":56,"context_line":"    --on-download-complete\u003decho"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_b156065c","line":53,"in_reply_to":"ffb9cba7_bb6d8a99","updated":"2019-04-25 13:01:00.000000000","message":"Done","commit_id":"6221397665d47277dc66a6c1ffa666be3bc04396"}],"templates/aria2c-download-helper.sh.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"93a4bd897e6311b0b58cf4cfa83f5d11995d8daa","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -x -e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"real_name\u003d\"$3\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ln --symbolic \"${real_name}\" \"/tmp/{{ cache_basename }}\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ffb9cba7_f146be7c","line":6,"updated":"2019-04-25 13:09:42.000000000","message":"I\u0027d check that real_name and symlink destination are not the same.","commit_id":"581befd95174daf8fc868e266beb97b5bc562f7b"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"775cd1881379f71101bb6bd24064d827e3c1f593","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -x -e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"real_name\u003d\"$3\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ln --symbolic \"${real_name}\" \"/tmp/{{ cache_basename }}\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ffb9cba7_b125a6c4","line":6,"in_reply_to":"ffb9cba7_f146be7c","updated":"2019-04-25 13:12:11.000000000","message":"Done","commit_id":"581befd95174daf8fc868e266beb97b5bc562f7b"}]}