)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d784ff5c5e9f1e226638927df1d3fb77cb886b27","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jonathan Rosser \u003cjonathan.rosser@rd.bbc.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-02-18 08:39:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - Build centos 8 container image with dnf rather than download"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change uses dnf to build the container image with dnf locally"},{"line_number":10,"context_line":"rather than rely on an external image that is downloaded and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2595f5c3_5823028e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2021-02-23 10:42:32.000000000","message":"Should we remove WIP now considering CI is passing?","commit_id":"f76a593b899c0565a7729e957ed23b4ba8e53d2c"}],"tasks/lxc_cache_preparation_simple.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7177a7e1eca80cdf3c732fc4270fb780a3b90ec2","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Tasks for image download"},{"line_number":68,"context_line":"  when:"},{"line_number":69,"context_line":"    - (_lxc_hosts_container_image_url is defined) or (_lxc_hosts_container_image_url_base is defined)"},{"line_number":70,"context_line":"  block:"},{"line_number":71,"context_line":"    - name: Wait for base image download"},{"line_number":72,"context_line":"      async_status:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"2616eb90_38344011","line":69,"range":{"start_line":69,"start_character":6,"end_line":69,"end_character":101},"updated":"2021-04-18 07:47:06.000000000","message":"we can also just check for lxc_hosts_container_image_url here?","commit_id":"2de86a014c7386714d0442ce75b79b06f90ff0e6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f1eedb3c4cf301b903d8320d3880340ea3660734","unresolved":true,"context_lines":[{"line_number":67,"context_line":"- name: Tasks for image download"},{"line_number":68,"context_line":"  when:"},{"line_number":69,"context_line":"    - lxc_hosts_container_image_url | length \u003e 0"},{"line_number":70,"context_line":"    - lxc_hosts_container_build_command | length \u003d 0"},{"line_number":71,"context_line":"  block:"},{"line_number":72,"context_line":"    - name: Wait for base image download"},{"line_number":73,"context_line":"      async_status:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c3b16f46_1cf88e5c","line":70,"range":{"start_line":70,"start_character":49,"end_line":70,"end_character":50},"updated":"2021-04-18 16:38:30.000000000","message":"shouldn\u0027t it be `\u003d\u003d`?","commit_id":"7ecf7ba5a82771cc8becba86431e18c12cbe0949"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"40105520af4ee5198fd621c5ea5a1847443910db","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Tasks for image download"},{"line_number":68,"context_line":"  when:"},{"line_number":69,"context_line":"    - lxc_hosts_container_image_url | length \u003e 0"},{"line_number":70,"context_line":"    - lxc_hosts_container_build_command | length \u003d\u003d 0"},{"line_number":71,"context_line":"  block:"},{"line_number":72,"context_line":"    - name: Wait for base image download"},{"line_number":73,"context_line":"      async_status:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9e240a6a_caefd7b6","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":53},"updated":"2021-04-19 07:23:17.000000000","message":"should we apply same logic as for lxc_cache_prestage.yml where we just left `lxc_hosts_container_build_command | length \u003d\u003d 0`?","commit_id":"ccec617bbd87fed31c2d07797c1e7d2282f20264"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"e3a01bffe0f35f31806b02f2dc6300a2047cf609","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Tasks for image download"},{"line_number":68,"context_line":"  when:"},{"line_number":69,"context_line":"    - lxc_hosts_container_image_url | length \u003e 0"},{"line_number":70,"context_line":"    - lxc_hosts_container_build_command | length \u003d\u003d 0"},{"line_number":71,"context_line":"  block:"},{"line_number":72,"context_line":"    - name: Wait for base image download"},{"line_number":73,"context_line":"      async_status:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"4c5d6244_5f7275f7","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":53},"in_reply_to":"9e240a6a_caefd7b6","updated":"2021-04-19 07:37:51.000000000","message":"Done","commit_id":"ccec617bbd87fed31c2d07797c1e7d2282f20264"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"c9bc29cd5cf84ee5724de73d7e6144477f3cacd5","unresolved":true,"context_lines":[{"line_number":84,"context_line":"      when: create_new_dir is changed"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- name: Build the base image using a CLI tool"},{"line_number":87,"context_line":"  command: \"{{ _lxc_hosts_container_build_command }}\""},{"line_number":88,"context_line":"  when: lxc_hosts_container_build_command | length \u003e 0"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"953d3bc2_5a209cf7","line":87,"updated":"2021-04-20 08:51:39.000000000","message":"Can the underscore be removed here? Otherwise overriding the var won\u0027t work","commit_id":"13742f908f4dce99bded79399928891773f3ea4b"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"5d532bfeb8a0941eab3c485816d1d222a52c718f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      when: create_new_dir is changed"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- name: Build the base image using a CLI tool"},{"line_number":87,"context_line":"  command: \"{{ _lxc_hosts_container_build_command }}\""},{"line_number":88,"context_line":"  when: lxc_hosts_container_build_command | length \u003e 0"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"b906eb58_55e897e7","line":87,"in_reply_to":"953d3bc2_5a209cf7","updated":"2021-04-20 08:56:44.000000000","message":"Done","commit_id":"13742f908f4dce99bded79399928891773f3ea4b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"48a89a8308346ccd47f02b074437fe4a3f5f9189","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      when: create_new_dir is changed"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- name: Build the base image using a CLI tool"},{"line_number":87,"context_line":"  command: \"{{ _lxc_hosts_container_build_command }}\""},{"line_number":88,"context_line":"  when: lxc_hosts_container_build_command | length \u003e 0"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"c6230dd1_0d7e6034","line":87,"in_reply_to":"b906eb58_55e897e7","updated":"2021-04-20 08:59:43.000000000","message":"nice catch","commit_id":"13742f908f4dce99bded79399928891773f3ea4b"}],"tasks/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7177a7e1eca80cdf3c732fc4270fb780a3b90ec2","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- include_tasks: lxc_cache_prestage.yml"},{"line_number":66,"context_line":"  when:"},{"line_number":67,"context_line":"    - (_lxc_hosts_container_image_url is defined) or (_lxc_hosts_container_image_url_base is defined)"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - always"},{"line_number":70,"context_line":"    - lxc_hosts-config"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"2ab588cd_4f7bce1d","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":37},"updated":"2021-04-18 07:47:06.000000000","message":"I think we should check for lxc_hosts_container_image_url length instead, as thing might be overriden.\n\nAnd the I think it would be enough and _lxc_hosts_container_image_url_base check won\u0027t be needed? Not sure though.","commit_id":"2de86a014c7386714d0442ce75b79b06f90ff0e6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f1eedb3c4cf301b903d8320d3880340ea3660734","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- include_tasks: lxc_cache_prestage.yml"},{"line_number":66,"context_line":"  when:"},{"line_number":67,"context_line":"    - (_lxc_hosts_container_image_url is defined) or (_lxc_hosts_container_image_url_base is defined)"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - always"},{"line_number":70,"context_line":"    - lxc_hosts-config"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"391a50f5_888cf125","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":37},"updated":"2021-04-18 16:38:30.000000000","message":"lxc_hosts_container_image_url | length \u003e 0 ? Not sure 100% sure because of https://opendev.org/openstack/openstack-ansible-lxc_hosts/src/branch/master/tasks/lxc_cache_prestage.yml#L39-L50","commit_id":"7ecf7ba5a82771cc8becba86431e18c12cbe0949"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d1f117f69de01b69195481529c56270b0d311bfe","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- include_tasks: lxc_cache_prestage.yml"},{"line_number":66,"context_line":"  when:"},{"line_number":67,"context_line":"    - (_lxc_hosts_container_image_url is defined) or (_lxc_hosts_container_image_url_base is defined)"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - always"},{"line_number":70,"context_line":"    - lxc_hosts-config"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"a999d5d0_2f640445","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":37},"in_reply_to":"1545512b_05edc84c","updated":"2021-04-18 17:12:00.000000000","message":"Yes, you\u0027re right. Except the case where there might have no _lxc_hosts_container_image_url, but lxc_hosts_container_image_url is inside user_variables? But lxc_hosts_container_image_url will be defined anyway in case _lxc_hosts_container_image_url is also set?","commit_id":"7ecf7ba5a82771cc8becba86431e18c12cbe0949"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"20ed021be38d7a3507b88370925e88df49d1eea8","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- include_tasks: lxc_cache_prestage.yml"},{"line_number":66,"context_line":"  when:"},{"line_number":67,"context_line":"    - (_lxc_hosts_container_image_url is defined) or (_lxc_hosts_container_image_url_base is defined)"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - always"},{"line_number":70,"context_line":"    - lxc_hosts-config"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1545512b_05edc84c","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":37},"in_reply_to":"391a50f5_888cf125","updated":"2021-04-18 16:58:56.000000000","message":"Doesn\u0027t it come from either _lxc_hosts_container_image_url via a vars file and defaults (old way for centos for example with a url direct to the imag) or via the ...url_base method and this set fact (where we have to find the right version for ubuntu on the fly), either way isn\u0027t lxc_hosts_container_image_url the var that finally gets used? I may have missed something of course, only briefly looking at this over the weekend!","commit_id":"7ecf7ba5a82771cc8becba86431e18c12cbe0949"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"21280f4f0dc55b74ba9c23a513334b9604a52357","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- include_tasks: lxc_cache_prestage.yml"},{"line_number":66,"context_line":"  when:"},{"line_number":67,"context_line":"    - (_lxc_hosts_container_image_url is defined) or (_lxc_hosts_container_image_url_base is defined)"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - always"},{"line_number":70,"context_line":"    - lxc_hosts-config"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"74f2b036_bff215f7","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":37},"in_reply_to":"889ca195_2cae4c8b","updated":"2021-04-18 20:28:16.000000000","message":"oh, yes, great idea!","commit_id":"7ecf7ba5a82771cc8becba86431e18c12cbe0949"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"ca74941a7daf7397f8096f56f78c5f7f9c2c90ee","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- include_tasks: lxc_cache_prestage.yml"},{"line_number":66,"context_line":"  when:"},{"line_number":67,"context_line":"    - (_lxc_hosts_container_image_url is defined) or (_lxc_hosts_container_image_url_base is defined)"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - always"},{"line_number":70,"context_line":"    - lxc_hosts-config"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"889ca195_2cae4c8b","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":37},"in_reply_to":"a999d5d0_2f640445","updated":"2021-04-18 19:26:08.000000000","message":"ah, well maybe it\u0027s simpler to swap it round and use when: lxc_hosts_container_build_command | length \u003d\u003d 0 instead, as thats an easy boolean rather than the complex combination of the possible download methods? i.e don\u0027t prestage the image ever when using a build command, otherwise do.","commit_id":"7ecf7ba5a82771cc8becba86431e18c12cbe0949"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f1eedb3c4cf301b903d8320d3880340ea3660734","unresolved":true,"context_lines":[{"line_number":65,"context_line":"- include_tasks: lxc_cache_prestage.yml"},{"line_number":66,"context_line":"  when:"},{"line_number":67,"context_line":"    - (_lxc_hosts_container_image_url is defined) or (_lxc_hosts_container_image_url_base is defined)"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - always"},{"line_number":70,"context_line":"    - lxc_hosts-config"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"110d2480_f346894c","line":68,"updated":"2021-04-18 16:38:30.000000000","message":"- lxc_hosts_container_build_command | length \u003d\u003d 0","commit_id":"7ecf7ba5a82771cc8becba86431e18c12cbe0949"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"20ed021be38d7a3507b88370925e88df49d1eea8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"- include_tasks: lxc_cache_prestage.yml"},{"line_number":66,"context_line":"  when:"},{"line_number":67,"context_line":"    - (_lxc_hosts_container_image_url is defined) or (_lxc_hosts_container_image_url_base is defined)"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    - always"},{"line_number":70,"context_line":"    - lxc_hosts-config"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"8f90e7ad_d1ad9b43","line":68,"in_reply_to":"110d2480_f346894c","updated":"2021-04-18 16:58:56.000000000","message":"Done","commit_id":"7ecf7ba5a82771cc8becba86431e18c12cbe0949"}],"vars/redhat.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"11199f3a3a6cad0a5b5d05b414ca35273bbe4e98","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"_lxc_hosts_container_build_command: \"dnf --assumeyes --installroot\u003d/var/lib/machines/{{ lxc_container_base_name }} install --setopt\u003dinstall_weak_deps\u003dFalse --nodocs rootfiles coreutils dnf centos-stream-release centos-stream-repos --releasever\u003d8\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"_lxc_cache_map:"},{"line_number":19,"context_line":"  distro: centos"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"da3084b0_404224aa","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":34},"updated":"2021-04-18 14:48:44.000000000","message":"I think we should add lxc_hosts_container_build_command to role defaults as well, to allow users to easily override command.\n\nSorry for not spotting that at once.","commit_id":"3b4194892945f2ee2f8fe93beb81dd806cb636d6"}]}