)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d232e16bc57ea41bf019b4fa41cb9432b8515be3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5831b80e_35142d25","updated":"2022-01-14 11:39:02.000000000","message":"recheck","commit_id":"ddbe02a01527377b4629038807dfb3c85843dae3"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5ed59d5ef326662909371d4afdbfff7846ad126a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6bd06803_2b17afd9","updated":"2022-01-24 12:58:01.000000000","message":"recheck","commit_id":"ddbe02a01527377b4629038807dfb3c85843dae3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"34f2632f11247dea5f41ee424b26e86b5c603957","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c19394df_ff2d1fa7","updated":"2022-02-01 15:28:10.000000000","message":"recheck","commit_id":"b9cccb3a8b589c229d920672a4a6af96fc5532bd"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"dc26320f7c75bf15de15aaeab41507377d0daec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e390b817_51021870","updated":"2022-01-30 09:30:01.000000000","message":"recheck","commit_id":"b9cccb3a8b589c229d920672a4a6af96fc5532bd"}],"tasks/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"547d0f1e58901b585424c995c5fea5819f178dd0","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":47,"context_line":"  tags:"},{"line_number":48,"context_line":"    - always"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Gather container variables"},{"line_number":51,"context_line":"  include_vars: \"{{ lookup(\u0027first_found\u0027, params) }}\""},{"line_number":52,"context_line":"  vars:"},{"line_number":53,"context_line":"    params:"},{"line_number":54,"context_line":"      files:"},{"line_number":55,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":56,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":57,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":58,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":59,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027].split(\u0027.\u0027)[0] }}.yml\""},{"line_number":60,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""},{"line_number":61,"context_line":"      paths:"},{"line_number":62,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":63,"context_line":"  tags:"},{"line_number":64,"context_line":"    - always"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- include_tasks: lxc_pre_install.yml"},{"line_number":67,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"016505ff_a4750b4e","line":64,"range":{"start_line":49,"start_character":0,"end_line":64,"end_character":12},"updated":"2022-01-12 11:27:09.000000000","message":"Hm I though we had some \"isolation\" between host/container vars, but seems it more like ordering thing...\n\nI wonder if it\u0027s worth moving container vars to https://opendev.org/openstack/openstack-ansible-lxc_hosts/src/branch/master/tasks/lxc_cache.yml#L15 as they shouldn\u0027t be used anywhere else and thus their include might be skipped at all?\n\nWe don\u0027t have logic to omit skipping lxc_cache include though (except tags which are not going to work)...","commit_id":"ddbe02a01527377b4629038807dfb3c85843dae3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"8d80c539b121ae8ccaa43a87e1112b97a29bc836","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":47,"context_line":"  tags:"},{"line_number":48,"context_line":"    - always"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Gather container variables"},{"line_number":51,"context_line":"  include_vars: \"{{ lookup(\u0027first_found\u0027, params) }}\""},{"line_number":52,"context_line":"  vars:"},{"line_number":53,"context_line":"    params:"},{"line_number":54,"context_line":"      files:"},{"line_number":55,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":56,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":57,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":58,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":59,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027].split(\u0027.\u0027)[0] }}.yml\""},{"line_number":60,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""},{"line_number":61,"context_line":"      paths:"},{"line_number":62,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":63,"context_line":"  tags:"},{"line_number":64,"context_line":"    - always"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- include_tasks: lxc_pre_install.yml"},{"line_number":67,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8a7fb638_2024d0e3","line":64,"range":{"start_line":49,"start_character":0,"end_line":64,"end_character":12},"in_reply_to":"016505ff_a4750b4e","updated":"2022-01-12 11:39:16.000000000","message":"host vars are all \u003cfoo\u003e-host.yml? or do you mean some other sort of isolation?","commit_id":"ddbe02a01527377b4629038807dfb3c85843dae3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"e2a9f0d02f648354da55852c6c55bc4270cf3289","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":47,"context_line":"  tags:"},{"line_number":48,"context_line":"    - always"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Gather container variables"},{"line_number":51,"context_line":"  include_vars: \"{{ lookup(\u0027first_found\u0027, params) }}\""},{"line_number":52,"context_line":"  vars:"},{"line_number":53,"context_line":"    params:"},{"line_number":54,"context_line":"      files:"},{"line_number":55,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":56,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":57,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":58,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":59,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027].split(\u0027.\u0027)[0] }}.yml\""},{"line_number":60,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""},{"line_number":61,"context_line":"      paths:"},{"line_number":62,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":63,"context_line":"  tags:"},{"line_number":64,"context_line":"    - always"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- include_tasks: lxc_pre_install.yml"},{"line_number":67,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"be4d4465_dd36e85c","line":64,"range":{"start_line":49,"start_character":0,"end_line":64,"end_character":12},"in_reply_to":"188d5d01_bcf99867","updated":"2022-01-13 11:23:48.000000000","message":"I wonder if this is something historical from code which would allow different OS containers to run on the same host?","commit_id":"ddbe02a01527377b4629038807dfb3c85843dae3"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0e4005fea210d7d00c01143a0bd24208c2902b44","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":47,"context_line":"  tags:"},{"line_number":48,"context_line":"    - always"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Gather container variables"},{"line_number":51,"context_line":"  include_vars: \"{{ lookup(\u0027first_found\u0027, params) }}\""},{"line_number":52,"context_line":"  vars:"},{"line_number":53,"context_line":"    params:"},{"line_number":54,"context_line":"      files:"},{"line_number":55,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":56,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":57,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":58,"context_line":"        - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":59,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027].split(\u0027.\u0027)[0] }}.yml\""},{"line_number":60,"context_line":"        - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""},{"line_number":61,"context_line":"      paths:"},{"line_number":62,"context_line":"        - \"{{ role_path }}/vars\""},{"line_number":63,"context_line":"  tags:"},{"line_number":64,"context_line":"    - always"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- include_tasks: lxc_pre_install.yml"},{"line_number":67,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"188d5d01_bcf99867","line":64,"range":{"start_line":49,"start_character":0,"end_line":64,"end_character":12},"in_reply_to":"8a7fb638_2024d0e3","updated":"2022-01-13 11:18:07.000000000","message":"well I meant they\u0027re all included and valid variables for same hosts (so basically they\u0027re all host variables), only their purpose differs. While for some reason I thought it\u0027s different somehow.","commit_id":"ddbe02a01527377b4629038807dfb3c85843dae3"}]}