)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"53e50aa4bfb73762635c909124ed51cfbade45d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"84fbe69a_a65f3686","updated":"2022-02-07 14:45:16.000000000","message":"We also need to replace ifdown-post somehow for rhel","commit_id":"83af9d96f35a5d65a916e0acc3b19b6a7f278f36"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b0445f9cfa54aae6cff6305f7a36ea049b3785cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e88b4675_78567602","in_reply_to":"84fbe69a_a65f3686","updated":"2022-10-18 23:57:45.000000000","message":"`nmcli conn $name up/down`?","commit_id":"83af9d96f35a5d65a916e0acc3b19b6a7f278f36"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c89f024594782dd0741604b4ec902e6b65fb6c48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a1bb3750_445434fc","in_reply_to":"e88b4675_78567602","updated":"2022-11-02 12:02:28.000000000","message":"Ah, I think the \"proper\" way is to have systemd-service that will run pre-start post-stop tasks. It\u0027s already been implemented here.","commit_id":"83af9d96f35a5d65a916e0acc3b19b6a7f278f36"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0257e2d7ee5458ef47fef0c39ed46d908ccce565","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d995a8e9_002453fb","updated":"2022-10-18 23:53:57.000000000","message":"love it! ","commit_id":"0cc0dc613054f915dae79c8f9f90fc5c10a13a3b"}],"handlers/main.yml":[{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"59b8feeae1891d9bb2e841bfa8b00f139cf9960a","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    daemon_reload: yes"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- name: Restart bridge"},{"line_number":64,"context_line":"  shell: \"ifdown {{ lxc_net_bridge }} || true\""},{"line_number":65,"context_line":"  notify:"},{"line_number":66,"context_line":"    - Bring bridge up"},{"line_number":67,"context_line":"    - Veth check"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ef1b0d53_a1559407","line":64,"updated":"2022-02-07 13:41:11.000000000","message":"should we replace this one also ?","commit_id":"b929e677617247ac5eea42126ee11c7f76909c0d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b064a827ac295aa1cc01e9512e395be9528b737f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    daemon_reload: yes"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- name: Restart bridge"},{"line_number":64,"context_line":"  shell: \"ifdown {{ lxc_net_bridge }} || true\""},{"line_number":65,"context_line":"  notify:"},{"line_number":66,"context_line":"    - Bring bridge up"},{"line_number":67,"context_line":"    - Veth check"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ed2a1898_f47b1c77","line":64,"in_reply_to":"ef1b0d53_a1559407","updated":"2022-10-18 08:33:08.000000000","message":"Done","commit_id":"b929e677617247ac5eea42126ee11c7f76909c0d"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"8cce6ab8f1e553ce4ba377e58e37d8f2087c99d8","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  command: \"ifup {{ lxc_net_bridge }}\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Veth check"},{"line_number":52,"context_line":"  command: \"/usr/local/bin/lxc-veth-check\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Reload systemd units"},{"line_number":55,"context_line":"  systemd:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"605a22bc_b22f23aa","side":"PARENT","line":52,"updated":"2022-10-18 10:56:26.000000000","message":"why we don\u0027t need that anymore?\n\nPS. If we really don\u0027t need that, we should also remove files/lxc-veth-check.sh and references in tasks/lxc_post_install.yml.","commit_id":"a09612c1fbc4f2c93047ecea77c51b2ebb326496"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"50c3a49972170ae9e48c49175e3be9a40d29a65c","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  command: \"ifup {{ lxc_net_bridge }}\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Veth check"},{"line_number":52,"context_line":"  command: \"/usr/local/bin/lxc-veth-check\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Reload systemd units"},{"line_number":55,"context_line":"  systemd:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba19888f_8349629c","side":"PARENT","line":52,"in_reply_to":"605a22bc_b22f23aa","updated":"2022-10-18 23:56:26.000000000","message":"+1","commit_id":"a09612c1fbc4f2c93047ecea77c51b2ebb326496"}],"tasks/lxc_net.yml":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"76147738affa612afc828d65daa89ff84961c0e5","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    enabled: yes"},{"line_number":33,"context_line":"  when: networkmanager_check.rc \u003d\u003d 0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# NOTE(mhayden): There are ifup hooks that handle the customized LXC container"},{"line_number":36,"context_line":"# networking. Starting lxc-net will trample over these hooks and cause"},{"line_number":37,"context_line":"# networking issues for containers."},{"line_number":38,"context_line":"- name: Disable and stop lxc-net"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a573595b_a61b7314","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":78},"updated":"2022-10-17 16:56:38.000000000","message":"it\u0027s rather a minor thing, but technically we don\u0027t have \u0027ifup\u0027 hooks anymore","commit_id":"de38595061cd846dd7dcf5c7d54293d6a3c99907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"23cfa32df6dac616b21e9304d1919a3ddd7660da","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    enabled: yes"},{"line_number":33,"context_line":"  when: networkmanager_check.rc \u003d\u003d 0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# NOTE(mhayden): There are ifup hooks that handle the customized LXC container"},{"line_number":36,"context_line":"# networking. Starting lxc-net will trample over these hooks and cause"},{"line_number":37,"context_line":"# networking issues for containers."},{"line_number":38,"context_line":"- name: Disable and stop lxc-net"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4b97f4ba_e720838e","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":78},"in_reply_to":"a573595b_a61b7314","updated":"2022-10-18 08:32:36.000000000","message":"Done","commit_id":"de38595061cd846dd7dcf5c7d54293d6a3c99907"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"397af7be8d770ae014acaad732630196d2f62718","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  tags:"},{"line_number":45,"context_line":"    - lxc-net"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Run the systemd-networkd role"},{"line_number":48,"context_line":"  include_role:"},{"line_number":49,"context_line":"    name: systemd_networkd"},{"line_number":50,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"86afeede_81c01fc3","line":47,"updated":"2022-10-18 23:55:58.000000000","message":"can we add a way to omit all of this? I have my deployment with the lxc-net bridge provisioned as part of the host kick and would like a way to disable this interface.\n\nre: https://review.opendev.org/c/openstack/openstack-ansible-lxc_hosts/+/861676","commit_id":"0cc0dc613054f915dae79c8f9f90fc5c10a13a3b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c89f024594782dd0741604b4ec902e6b65fb6c48","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  tags:"},{"line_number":45,"context_line":"    - lxc-net"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Run the systemd-networkd role"},{"line_number":48,"context_line":"  include_role:"},{"line_number":49,"context_line":"    name: systemd_networkd"},{"line_number":50,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"260dbaba_4a02d6b9","line":47,"in_reply_to":"86afeede_81c01fc3","updated":"2022-11-02 12:02:28.000000000","message":"Yeah, sure, but likely worth doing with separate patch anyway.","commit_id":"0cc0dc613054f915dae79c8f9f90fc5c10a13a3b"}]}