)]}'
{"id":"openstack%2Fopenstack-ansible-openstack_hosts~266021","triplet_id":"openstack%2Fopenstack-ansible-openstack_hosts~master~I76bfd447e0f9747679362775c44c9f84793a78f5","project":"openstack/openstack-ansible-openstack_hosts","branch":"master","topic":"bug/1532917","hashtags":[],"change_id":"I76bfd447e0f9747679362775c44c9f84793a78f5","subject":"Add missing kernel module br_netfilter to openstack_hosts role","status":"MERGED","created":"2016-01-11 20:15:05.000000000","updated":"2016-01-12 17:27:51.000000000","submitted":"2016-01-12 17:27:51.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"46d4e8e094369089d43d635893c0d68422bc7e53","_number":266021,"virtual_id_number":266021,"owner":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2016-01-12 17:27:51.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":2,"date":"2016-01-12 17:21:42.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-12 17:19:53.000000000","_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":1,"date":"2016-01-12 17:21:42.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-12 17:19:53.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2016-01-12 17:21:42.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2016-01-12 17:27:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"73c3522cb1d527f34742d1046ee977e59b709b10","author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"date":"2016-01-11 20:15:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d2deb71a158ee4c545999b55ca6a4337b6948437","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-11 20:20:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-openstack_hosts-docs http://docs-draft.openstack.org/21/266021/1/check/gate-openstack-ansible-openstack_hosts-docs/6b57dfd//doc/build/html/ : SUCCESS in 43s\n- gate-openstack-ansible-openstack_hosts-pep8 http://logs.openstack.org/21/266021/1/check/gate-openstack-ansible-openstack_hosts-pep8/e0beafb/ : SUCCESS in 24s\n- gate-openstack-ansible-openstack_hosts-tox-ansible-lint http://logs.openstack.org/21/266021/1/check/gate-openstack-ansible-openstack_hosts-tox-ansible-lint/17d3232/ : SUCCESS in 54s\n- gate-openstack-ansible-openstack_hosts-dsvm-ansible-functional-trusty http://logs.openstack.org/21/266021/1/check/gate-openstack-ansible-openstack_hosts-dsvm-ansible-functional-trusty/cf3b3e7/ : SUCCESS in 1m 20s","accounts_in_message":[],"_revision_number":1},{"id":"0765c5cdd06d91ef49c43b0bc663747cdf72986d","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2016-01-12 17:19:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9b62b2d97c571d2772c774a82372becb7f718d8f","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-01-12 17:21:42.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"fb5f580ddd9835a5ae096acc2937ffb7727bb9ff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-12 17:22:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"9238e64e5f0db93461f3bf47b11274f1a9e5e0a3","date":"2016-01-12 17:27:51.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"24bebbfac867380e31ddeec2e9b7b7ae1351c781","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-12 17:27:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-openstack_hosts-docs http://docs-draft.openstack.org/21/266021/1/gate/gate-openstack-ansible-openstack_hosts-docs/4fb839d//doc/build/html/ : SUCCESS in 31s\n- gate-openstack-ansible-openstack_hosts-pep8 http://logs.openstack.org/21/266021/1/gate/gate-openstack-ansible-openstack_hosts-pep8/331602c/ : SUCCESS in 19s\n- gate-openstack-ansible-openstack_hosts-tox-ansible-lint http://logs.openstack.org/21/266021/1/gate/gate-openstack-ansible-openstack_hosts-tox-ansible-lint/157f4e9/ : SUCCESS in 52s\n- gate-openstack-ansible-openstack_hosts-dsvm-ansible-functional-trusty http://logs.openstack.org/21/266021/1/gate/gate-openstack-ansible-openstack_hosts-dsvm-ansible-functional-trusty/540906d/ : SUCCESS in 1m 09s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"45d89c2bb9fbc478eb4223516f572cf34ca1ca40","revisions":{"45d89c2bb9fbc478eb4223516f572cf34ca1ca40":{"kind":"REWORK","_number":1,"created":"2016-01-11 20:15:05.000000000","uploader":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"ref":"refs/changes/21/266021/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-openstack_hosts","ref":"refs/changes/21/266021/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/21/266021/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/21/266021/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/21/266021/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/21/266021/1"}}},"commit":{"parents":[{"commit":"cd1a8c02454dc2346aa35532444a2260954eefb0","subject":"Switch to testenv:functional","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/cd1a8c02454dc2346aa35532444a2260954eefb0"}]}],"author":{"name":"Michael Gugino","email":"michael.gugino@walmart.com","date":"2016-01-11 19:59:00.000000000","tz":-300},"committer":{"name":"Michael Gugino","email":"michael.gugino@walmart.com","date":"2016-01-11 20:14:51.000000000","tz":-300},"subject":"Add missing kernel module br_netfilter to openstack_hosts role","message":"Add missing kernel module br_netfilter to openstack_hosts role\n\nThe openstack_hosts role contains a list of several kernel\nmodules which are necessary for the successful deployment of lxc\ncontainers.  The role also applies certain kernel parameters via\nsysctl, including 3 parameters related to to the kernel module\nbr_netfilter.  These parameters are:\n\n- { key: \u0027net.bridge.bridge-nf-call-ip6tables\u0027, value: 0 }\n- { key: \u0027net.bridge.bridge-nf-call-iptables\u0027, value: 0 }\n- { key: \u0027net.bridge.bridge-nf-call-arptables\u0027, value: 0 }\n\nThe list of modules and parameters can be found in the file\nopenstack-ansible-openstack_hosts/defaults/main.yml\n\nA kernel change committed in version 3.17 disabled the module\nbr_netfilter from being loaded automatically.  The most recent release\nof Ubuntu 14.04 LTS utilizes kernel version 3.19.  This results in\nthe aforementioned parameters failing to apply successfully, as well\nas sysctl failing to properly parse /etc/sysctl.conf.\n\nAs a result, the task \u0027Adding new system tuning\u0027 fails.\n\nThis change adds br_netfilter to the variable\nopenstack_host_kernel_modules in\nopenstack-ansible-openstack_hosts/defaults/main.yml to correct the bug\nintroduced by a change in kernel behavior upstream.\n\nThis change will allow the module br_netfilter to be loaded via\nmodprobe, as well as inserted into /etc/modules.  This will allow the\naforementioned parameters to be applied correctly.\n\nChange-Id: I76bfd447e0f9747679362775c44c9f84793a78f5\nCloses-Bug: #1532917\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/45d89c2bb9fbc478eb4223516f572cf34ca1ca40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/45d89c2bb9fbc478eb4223516f572cf34ca1ca40"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
