)]}'
{"id":"openstack%2Fopenstack-ansible-openstack_hosts~312206","triplet_id":"openstack%2Fopenstack-ansible-openstack_hosts~master~Idca583deb403fce2b15a3dbc6255bb3bf92d9446","project":"openstack/openstack-ansible-openstack_hosts","branch":"master","topic":"speed-improvement","hashtags":[],"change_id":"Idca583deb403fce2b15a3dbc6255bb3bf92d9446","subject":"Improve deployment performance on large clusters","status":"MERGED","created":"2016-05-03 18:55:49.000000000","updated":"2016-05-06 14:39:51.000000000","submitted":"2016-05-06 14:36:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f4a708c6c63bba67aaa75c7c38b150bfe636fb18","_number":312206,"virtual_id_number":312206,"owner":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2016-05-06 14:36:50.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},{"value":0,"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":2,"date":"2016-05-04 16:56:45.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-06 14:01:14.000000000","_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},{"value":1,"date":"2016-05-06 14:28:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},{"value":1,"date":"2016-05-03 19:05:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-05-06 14:01:14.000000000","_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},{"value":0,"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},{"value":0,"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-03 19:05:16.000000000","updated_by":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"reviewer":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"state":"REVIEWER"},{"updated":"2016-05-04 16:56:45.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2016-05-06 14:01:14.000000000","updated_by":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"reviewer":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"state":"REVIEWER"},{"updated":"2016-05-06 14:28:42.000000000","updated_by":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"reviewer":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"state":"REVIEWER"},{"updated":"2016-05-06 14:36:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f380e92b6311ea402433ca698401acfcb5feafb9","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2016-05-03 18:55:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c0be76e457cfc576ea24cda09d6d8d7d7e2570af","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2016-05-03 18:56:25.000000000","message":"Topic set to speed-improvement","accounts_in_message":[],"_revision_number":1},{"id":"d3a2f8890fb3ce1a0fededecfca503a45cce8ce5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-03 18:59:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-openstack_hosts-docs http://docs-draft.openstack.org/06/312206/1/check/gate-openstack-ansible-openstack_hosts-docs/ec65133//doc/build/html/ : SUCCESS in 48s\n- gate-openstack-ansible-openstack_hosts-linters http://logs.openstack.org/06/312206/1/check/gate-openstack-ansible-openstack_hosts-linters/59521ff/ : SUCCESS in 36s\n- gate-openstack-ansible-openstack_hosts-ansible-func-ubuntu-trusty http://logs.openstack.org/06/312206/1/check/gate-openstack-ansible-openstack_hosts-ansible-func-ubuntu-trusty/7379c80/ : SUCCESS in 1m 11s","accounts_in_message":[],"_revision_number":1},{"id":"f0fac0273c383d562e9fde1c6e3f7ee0423dd20b","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2016-05-03 19:05:16.000000000","message":"Patch Set 1: Code-Review+1\n\nThis seems like it would be much quicker on bigger deployments.","accounts_in_message":[],"_revision_number":1},{"id":"263a3282a51a316df2f52980f84d769490951233","author":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"date":"2016-05-03 19:17:05.000000000","message":"Patch Set 1:\n\nHow about this:\n\nSave stock /etc/hosts to /etc/hosts.dist, write all ansible hosts into  /etc/hosts.osa and then copy the file onto all hosts and merge them ?","accounts_in_message":[],"_revision_number":1},{"id":"93d3b9fc50fb1736008eff4cb5a28ac4dfe2b8b3","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-05-03 19:47:39.000000000","message":"Patch Set 1: Code-Review+1\n\nI\u0027m not against this, but I think we can also resolve this in many other ways.\n\nFor example, we already have dnsmasq setup on the LXC hosts (for LXC to use), so why not make use of it to serve DNS for all the other hosts and containers and limit the number of hosts that this needs to run against. All we\u0027ll have to configure on all the other hosts are the resolvers.","accounts_in_message":[],"_revision_number":1},{"id":"5621b90848063328a61da3cdae96669b8f2ec443","author":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"date":"2016-05-03 19:49:59.000000000","message":"Patch Set 1:\n\nAgreed, but dnsmasq forces us to remove the _ from the container names in order to be compliant, which causes havoc on the neutron server side, where all agents go offline etc. I would not expect that we can get the dnsmasq back ported into Kilo since it\u0027s more complex","accounts_in_message":[],"_revision_number":1},{"id":"9189b6055f0ddad14a41528baefda5558a276287","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2016-05-03 20:05:47.000000000","message":"Patch Set 1:\n\nI\u0027m all in favor adding proper DNS support however this PR resolves a long standing issue with the speed of how the host files are generated. If we go the route of proper DNS support I think all of these tasks should be removed however until then I think we need to refactor this to make it more performant. Example performance impact: http://cdn.pasteraw.com/iziyyumue8cc9z41tb4fj9j1f5t703p","accounts_in_message":[],"_revision_number":1},{"id":"7b83df3efd7c61a3b87f5f5795c302b6eff250fd","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2016-05-04 15:02:00.000000000","message":"Patch Set 1:\n\nPerhaps the DNS changes could be tossed into a spec and worked on as a future improvement? Kevin\u0027s patch seems like it could alleviate quite a bit of short term pain.","accounts_in_message":[],"_revision_number":1},{"id":"58b5bc70ff77ff8ee61c90ec03042a4b36fcf860","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-05-04 16:56:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e95d35b1136681c58300a9a4e34d9609b99fc512","author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"date":"2016-05-06 14:01:14.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"04d8d1320bbca5cfb26f40977afbb9bc4f60c9b5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-06 14:12:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"dd27776255ac51ca01d81779f28f3f2bcfb6aadd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-06 14:28:24.000000000","message":"Patch Set 1:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2a47491ea65e751166983744d8c0ec124c5dd215","author":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"date":"2016-05-06 14:28:42.000000000","message":"Patch Set 1: Code-Review+1\n\nI will be able to test the performance implications next week if you want so can see if the how much it improves","accounts_in_message":[],"_revision_number":1},{"id":"02f1f2b7c109baff2359ed12a0be7d2f1ba0c4e9","date":"2016-05-06 14:36:50.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"898863d99ff0dec432f504eb08bdb0f76695e5f5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-06 14:36:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-openstack_hosts-docs http://docs-draft.openstack.org/06/312206/1/gate/gate-openstack-ansible-openstack_hosts-docs/3ea2515//doc/build/html/ : SUCCESS in 1m 19s\n- gate-openstack-ansible-openstack_hosts-linters http://logs.openstack.org/06/312206/1/gate/gate-openstack-ansible-openstack_hosts-linters/811a5fc/ : SUCCESS in 38s\n- gate-openstack-ansible-openstack_hosts-ansible-func-ubuntu-trusty http://logs.openstack.org/06/312206/1/gate/gate-openstack-ansible-openstack_hosts-ansible-func-ubuntu-trusty/f4561c6/ : SUCCESS in 1m 19s","accounts_in_message":[],"_revision_number":1},{"id":"f4a708c6c63bba67aaa75c7c38b150bfe636fb18","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2016-05-06 14:39:51.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/mitaka as commit 625b737613bfb58d8434502f54b49b0cfe86dfc0","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1f1ed79bb43aa6309e05bd7e9707a3d152b1314d","revisions":{"1f1ed79bb43aa6309e05bd7e9707a3d152b1314d":{"kind":"REWORK","_number":1,"created":"2016-05-03 18:55:49.000000000","uploader":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"ref":"refs/changes/06/312206/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-openstack_hosts","ref":"refs/changes/06/312206/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/06/312206/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/06/312206/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/06/312206/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/06/312206/1"}}},"commit":{"parents":[{"commit":"606612211688cff4b1003b8442643d8ae2bac2f7","subject":"Add dependencies for paramiko 2.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/606612211688cff4b1003b8442643d8ae2bac2f7"}]}],"author":{"name":"Kevin Carter","email":"kevin.carter@rackspace.com","date":"2016-05-03 18:52:12.000000000","tz":-300},"committer":{"name":"Kevin Carter","email":"kevin.carter@rackspace.com","date":"2016-05-03 18:55:24.000000000","tz":-300},"subject":"Improve deployment performance on large clusters","message":"Improve deployment performance on large clusters\n\nThis change makes the host file prep and setup a lot faster\nespecially when deploying against very large clusters. The\nchange moves away from the lineinfile module and instead generates\na script with the same capabilities and then executes the script.\nThe generated script is stored in locally on the remote host\nat \"/usr/local/bin/openstack-host-hostfile-setup.sh\" and can be\nexecuted at any time to fix and or clean up host file problems.\n\nChange-Id: Idca583deb403fce2b15a3dbc6255bb3bf92d9446\nSigned-off-by: Kevin Carter \u003ckevin.carter@rackspace.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/1f1ed79bb43aa6309e05bd7e9707a3d152b1314d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/1f1ed79bb43aa6309e05bd7e9707a3d152b1314d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}