)]}'
{"tasks/openstack_host_install_apt.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ecb82afdb2eb361875fba645b956f048c5dcd883","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  until: install_packages|success"},{"line_number":40,"context_line":"  retries: 5"},{"line_number":41,"context_line":"  delay: 2"},{"line_number":42,"context_line":"  with_items: \"{{ openstack_host_apt_packages | default([]) }}\""},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - openstack-apt-packages"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_b6c65a66","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":45},"updated":"2016-06-15 14:06:23.000000000","message":"As per the multi-distro template [1] we should be naming this \u0027openstack_host_packages\u0027, then the default here will not be required.\n\n[1] https://github.com/openstack/openstack-ansible-rsyslog_server/blob/master/vars/debian.yml","commit_id":"5b52fca510cea131acd2098789fb900ae832e3d4"}],"tasks/openstack_host_install_yum.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ecb82afdb2eb361875fba645b956f048c5dcd883","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  until: install_packages|success"},{"line_number":22,"context_line":"  retries: 5"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  with_items: \"{{ openstack_host_yum_packages | default([]) }}\""},{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - openstack-yum-packages"},{"line_number":27,"context_line":"    - openstack-packages"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_5690d64e","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":45},"updated":"2016-06-15 14:06:23.000000000","message":"As per the multi-distro template [1] we should be naming this \u0027openstack_host_packages\u0027, then the default here will not be required.\n\n[1] https://github.com/openstack/openstack-ansible-rsyslog_server/blob/master/vars/debian.yml","commit_id":"5b52fca510cea131acd2098789fb900ae832e3d4"}],"tasks/openstack_kernel_modules.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cc662509f9b1358db61e54387f65f87732aae8a0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: \"Ensure kernel module(s)\""},{"line_number":17,"context_line":"  modprobe:"},{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"  with_items: \"{{ openstack_host_kernel_modules }}\""},{"line_number":20,"context_line":"  when: openstack_host_kernel_modules is defined and item !\u003d \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: \"Ensure kernel module(s) loaded at boot\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_2bcfa32a","line":19,"updated":"2016-06-15 13:58:47.000000000","message":"| default([])\nis exactly what you need.","commit_id":"5b52fca510cea131acd2098789fb900ae832e3d4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d44bdeea9ace1dcf2b4434e28188b41d60bd8c12","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: \"Ensure kernel module(s)\""},{"line_number":17,"context_line":"  modprobe:"},{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"  with_items: \"{{ openstack_host_kernel_modules }}\""},{"line_number":20,"context_line":"  when: openstack_host_kernel_modules is defined and item !\u003d \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: \"Ensure kernel module(s) loaded at boot\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_165beef7","line":19,"in_reply_to":"7aa08908_2bcfa32a","updated":"2016-06-15 14:03:10.000000000","message":"I don\u0027t think this is necessary as this var is always defined:\nhttps://github.com/openstack/openstack-ansible-openstack_hosts/blob/master/vars/redhat-7.yml#L20\nhttps://github.com/openstack/openstack-ansible-openstack_hosts/blob/master/vars/ubuntu-14.04.yml\nhttps://github.com/openstack/openstack-ansible-openstack_hosts/blob/master/vars/ubuntu-16.04.yml#L23","commit_id":"5b52fca510cea131acd2098789fb900ae832e3d4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cc662509f9b1358db61e54387f65f87732aae8a0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  lineinfile:"},{"line_number":24,"context_line":"    dest: /etc/modules"},{"line_number":25,"context_line":"    line: \"{{ item }}\""},{"line_number":26,"context_line":"  with_items: \"{{ openstack_host_kernel_modules }}\""},{"line_number":27,"context_line":"  when: openstack_host_kernel_modules is defined and item !\u003d \u0027\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: get kernel release"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_cbf09f69","line":26,"updated":"2016-06-15 13:58:47.000000000","message":"same","commit_id":"5b52fca510cea131acd2098789fb900ae832e3d4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cc662509f9b1358db61e54387f65f87732aae8a0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"- name: check how kernel modules are implemented (statically builtin, dynamic, not set)"},{"line_number":34,"context_line":"  shell: grep {{ item.pattern }} /boot/config-{{ uname.stdout}}"},{"line_number":35,"context_line":"  register: modules"},{"line_number":36,"context_line":"  with_items: \"{{ openstack_host_specific_kernel_modules }}\""},{"line_number":37,"context_line":"  when:"},{"line_number":38,"context_line":"    - openstack_host_specific_kernel_modules is defined"},{"line_number":39,"context_line":"    - inventory_hostname in groups[\"{{ item.group }}\"]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_8bf7b758","line":36,"updated":"2016-06-15 13:58:47.000000000","message":"same, but keep the other when condition here.","commit_id":"5b52fca510cea131acd2098789fb900ae832e3d4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"07dd41df0ec5696ca20bbd6cb0b000158134e885","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  modprobe:"},{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"  with_items: \"{{ openstack_host_kernel_modules }}\""},{"line_number":20,"context_line":"  when: openstack_host_kernel_modules is defined and item !\u003d \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: \"Ensure kernel module(s) loaded at boot\""},{"line_number":23,"context_line":"  lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_fc01e005","line":20,"updated":"2016-06-15 15:13:38.000000000","message":"nit: openstack_host_kernel_modules | length \u003e 0","commit_id":"1abea88b90bb76b8f537e1f9fd464dfc0e74c3b9"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"07dd41df0ec5696ca20bbd6cb0b000158134e885","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    dest: /etc/modules"},{"line_number":25,"context_line":"    line: \"{{ item }}\""},{"line_number":26,"context_line":"  with_items: \"{{ openstack_host_kernel_modules }}\""},{"line_number":27,"context_line":"  when: openstack_host_kernel_modules is defined and item !\u003d \u0027\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: get kernel release"},{"line_number":30,"context_line":"  command: \"uname -r\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_fc28c087","line":27,"updated":"2016-06-15 15:13:38.000000000","message":"Nit: openstack_host_kernel_modules | length \u003e 0","commit_id":"1abea88b90bb76b8f537e1f9fd464dfc0e74c3b9"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"07dd41df0ec5696ca20bbd6cb0b000158134e885","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  register: modules"},{"line_number":36,"context_line":"  with_items: \"{{ openstack_host_specific_kernel_modules | default([]) }}\""},{"line_number":37,"context_line":"  when:"},{"line_number":38,"context_line":"    - openstack_host_specific_kernel_modules is defined"},{"line_number":39,"context_line":"    - inventory_hostname in groups[\"{{ item.group }}\"]"},{"line_number":40,"context_line":"  ignore_errors: yes"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_19167e58","line":38,"updated":"2016-06-15 15:13:38.000000000","message":"Nit: This line becomes irrelevant","commit_id":"1abea88b90bb76b8f537e1f9fd464dfc0e74c3b9"}],"tasks/openstack_kernel_tuning.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cc662509f9b1358db61e54387f65f87732aae8a0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    sysctl_set: \"{{ item.set|default(\u0027yes\u0027) }}\""},{"line_number":21,"context_line":"    state: \"{{ item.state|default(\u0027present\u0027) }}\""},{"line_number":22,"context_line":"    reload: \"{{ item.reload|default(\u0027yes\u0027) }}\""},{"line_number":23,"context_line":"  with_items: \"{{ openstack_kernel_options }}\""},{"line_number":24,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_ab7f13aa","line":23,"updated":"2016-06-15 13:58:47.000000000","message":"Are we sure kernel options is always defined (or their definition is never skipped?)","commit_id":"5b52fca510cea131acd2098789fb900ae832e3d4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d44bdeea9ace1dcf2b4434e28188b41d60bd8c12","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    sysctl_set: \"{{ item.set|default(\u0027yes\u0027) }}\""},{"line_number":21,"context_line":"    state: \"{{ item.state|default(\u0027present\u0027) }}\""},{"line_number":22,"context_line":"    reload: \"{{ item.reload|default(\u0027yes\u0027) }}\""},{"line_number":23,"context_line":"  with_items: \"{{ openstack_kernel_options }}\""},{"line_number":24,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_b68e5a77","line":23,"in_reply_to":"7aa08908_ab7f13aa","updated":"2016-06-15 14:03:10.000000000","message":"Yes it\u0027s a default var: https://github.com/openstack/openstack-ansible-openstack_hosts/blob/master/defaults/main.yml#L45","commit_id":"5b52fca510cea131acd2098789fb900ae832e3d4"}]}
