)]}'
{"id":"openstack%2Fopenstack-ansible-openstack_hosts~451303","triplet_id":"openstack%2Fopenstack-ansible-openstack_hosts~master~Ida3897f2553491913a3183e67b6503bed5281d5e","project":"openstack/openstack-ansible-openstack_hosts","branch":"master","topic":"be-kind-to-the-environment","hashtags":[],"change_id":"Ida3897f2553491913a3183e67b6503bed5281d5e","subject":"Update instead of replacing the environment file","status":"MERGED","created":"2017-03-29 10:01:20.000000000","updated":"2017-04-06 01:29:08.000000000","submitted":"2017-04-06 01:29:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a28390c3eb7de65dad44d24bf11ef6f02ae52119","_number":451303,"virtual_id_number":451303,"owner":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-04-06 01:29:08.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-04-06 01:25:52.000000000","_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":2,"date":"2017-04-05 13:25:50.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-04-06 01:25:52.000000000","_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-05 13:25:50.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2017-04-06 01:25:52.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2017-04-06 01:29:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ff0ebe0ad752d95cb5b1251a682ab1fcecd1dd47","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-29 10:01:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"463839fe6d7162231f3128b164094bdb407e91c9","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-29 10:02:52.000000000","message":"Topic set to be-kind-to-the-environment","accounts_in_message":[],"_revision_number":1},{"id":"5d468de3dcd3835fba239a344fee11a628934a8c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-29 10:04:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-openstack_hosts-docs-ubuntu-xenial http://docs-draft.openstack.org/03/451303/1/check/gate-openstack-ansible-openstack_hosts-docs-ubuntu-xenial/d49c8f1//doc/build/html/ : SUCCESS in 1m 37s\n- gate-openstack-ansible-openstack_hosts-linters-ubuntu-xenial http://logs.openstack.org/03/451303/1/check/gate-openstack-ansible-openstack_hosts-linters-ubuntu-xenial/ea0c9ca/ : SUCCESS in 2m 08s\n- gate-openstack-ansible-openstack_hosts-ansible-func-centos-7 http://logs.openstack.org/03/451303/1/check/gate-openstack-ansible-openstack_hosts-ansible-func-centos-7/7252915/ : SUCCESS in 2m 16s\n- gate-openstack-ansible-openstack_hosts-ansible-func-ubuntu-xenial http://logs.openstack.org/03/451303/1/check/gate-openstack-ansible-openstack_hosts-ansible-func-ubuntu-xenial/3595185/ : SUCCESS in 2m 40s","accounts_in_message":[],"_revision_number":1},{"id":"f0078817216f02cd1c17dc8f3494313b30ea32e6","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2017-03-30 07:59:07.000000000","message":"Patch Set 1:\n\nFor an AIO build where http_proxy is already set in /etc/environment on the AIO host, this adds a duplicate set of proxy settings which may not be what you intended.\n\nThe /etc/environment file inside the containers is however correct.","accounts_in_message":[],"_revision_number":1},{"id":"a31fe74f66a089ee8804b86b7705c465b2d72c2a","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-30 09:22:11.000000000","message":"Patch Set 1:\n\n@Jonathan I expect that there would be duplicates if the proxy vars were set in global_environment_variables, but if none were set then it should not have duplication unless I\u0027m missing something somewhere?","accounts_in_message":[],"_revision_number":1},{"id":"1dffb1052c5cbaf1ef13c16f4c978146666430d1","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2017-03-30 15:03:47.000000000","message":"Patch Set 1:\n\nLGTM if the duplication is ok.","accounts_in_message":[],"_revision_number":1},{"id":"7832c71b5b0133c0230186805426f087f6909c16","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-04-05 13:25:50.000000000","message":"Patch Set 1: Code-Review+2\n\nI don\u0027t see a problem of ensuring just a block presence vs the full file at first sight.\n\nStill it brings a question:\nWhat are the risks for a deploy to fail if variables inside the environment file are set to a value incompatible with our deployment (because we don\u0027t manage the whole file we could have incompatible issue, and the testing matrix increases)? \n\nShould we take care of these when the issue will occur? Because they will be harder to troubleshoot.","accounts_in_message":[],"_revision_number":1},{"id":"3827b35df4c0c49ec06a92cb95b899e409e69e55","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-04-06 01:25:52.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ce733ae472390451afff026d9919f0ff06898bb7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-06 01:26:03.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b236ec3a83233a405b42c4555edf0d1ba93b2399","date":"2017-04-06 01:29:08.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"a28390c3eb7de65dad44d24bf11ef6f02ae52119","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-06 01:29:08.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-openstack_hosts-docs-ubuntu-xenial http://docs-draft.openstack.org/03/451303/1/gate/gate-openstack-ansible-openstack_hosts-docs-ubuntu-xenial/9799a81//doc/build/html/ : SUCCESS in 42s\n- gate-openstack-ansible-openstack_hosts-linters-ubuntu-xenial http://logs.openstack.org/03/451303/1/gate/gate-openstack-ansible-openstack_hosts-linters-ubuntu-xenial/2063f60/ : SUCCESS in 1m 15s\n- gate-openstack-ansible-openstack_hosts-ansible-func-centos-7 http://logs.openstack.org/03/451303/1/gate/gate-openstack-ansible-openstack_hosts-ansible-func-centos-7/749770b/ : SUCCESS in 3m 00s\n- gate-openstack-ansible-openstack_hosts-ansible-func-ubuntu-xenial http://logs.openstack.org/03/451303/1/gate/gate-openstack-ansible-openstack_hosts-ansible-func-ubuntu-xenial/2d78466/ : SUCCESS in 1m 32s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4af53825b15a3da4e40cf86e9d1ec8b287aee552","revisions":{"4af53825b15a3da4e40cf86e9d1ec8b287aee552":{"kind":"REWORK","_number":1,"created":"2017-03-29 10:01:20.000000000","uploader":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"ref":"refs/changes/03/451303/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-openstack_hosts","ref":"refs/changes/03/451303/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/03/451303/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/03/451303/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/03/451303/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/03/451303/1"}}},"commit":{"parents":[{"commit":"67c35f0f89784d7ba1f961b242c7a20e8d7d17b9","subject":"Install RDO release RPM without GPG checks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/67c35f0f89784d7ba1f961b242c7a20e8d7d17b9"}]}],"author":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2017-03-29 09:58:53.000000000","tz":60},"committer":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2017-03-29 09:58:53.000000000","tz":60},"subject":"Update instead of replacing the environment file","message":"Update instead of replacing the environment file\n\nCurrently the entire environment file is replaced,\nwhich may remove any existing configuration on the\nhosts including any pre-existing proxy configurations\nand anything else the deployer may have put there.\n\nThis method replaces it with an additive process which\nrespects pre-existing content, but still allows the\nglobal_environment_variables variable changes to be\nfully reflected in the resulting environment file.\n\nChange-Id: Ida3897f2553491913a3183e67b6503bed5281d5e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/4af53825b15a3da4e40cf86e9d1ec8b287aee552"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/4af53825b15a3da4e40cf86e9d1ec8b287aee552"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
